@brightspace-ui/core 3.222.0 → 3.224.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -32,15 +32,15 @@ The `d2l-dialog` element is a generic dialog that provides a slot for arbitrary
|
|
|
32
32
|
* Label primary actions with clear and predictable language. Use verbs like, “Add” or “Save” that indicate the outcome of a dialog rather than, “OK” or “Close”
|
|
33
33
|
* Keep dialog titles concise
|
|
34
34
|
* Maintain a language relationship between the action that triggered the dialog, dialog title, and dialog primary button.
|
|
35
|
-
* When it is necessary to
|
|
35
|
+
* When it is necessary to nest multiple dialogs, ensure the nested dialog is within the DOM of the dialog containing the opener
|
|
36
36
|
<!-- docs: end dos -->
|
|
37
37
|
|
|
38
38
|
<!-- docs: start donts -->
|
|
39
39
|
* Don’t use a dialog when you could reasonably use an alternative that preserves user context, like expanding options inline
|
|
40
40
|
* Don’t use a dialog to show error, success, or warning messages. Use an inline or toast alert instead.
|
|
41
|
-
* Avoid
|
|
42
|
-
*
|
|
43
|
-
* Avoid
|
|
41
|
+
* Avoid opening a dialog from another dialog (nesting) since this can increase cognitive load and disorient users
|
|
42
|
+
* Exception: confirmation dialogs that protect users from losing unsaved work
|
|
43
|
+
* Avoid titles that are long enough to wrap onto multiple lines
|
|
44
44
|
<!-- docs: end donts -->
|
|
45
45
|
<!-- docs: end best practices -->
|
|
46
46
|
|
|
@@ -9,9 +9,6 @@ import { ifDefined } from 'lit/directives/if-defined.js';
|
|
|
9
9
|
import { isPopoverSupported } from '../popover/popover-mixin.js';
|
|
10
10
|
import { PageableMixin } from '../paging/pageable-mixin.js';
|
|
11
11
|
import { SelectionMixin } from '../selection/selection-mixin.js';
|
|
12
|
-
import { usePopoverMixin as useTooltipPopover } from '../tooltip/tooltip.js';
|
|
13
|
-
|
|
14
|
-
export const isUsingNativePopover = isPopoverSupported && useTooltipPopover;
|
|
15
12
|
|
|
16
13
|
export const tableStyles = css`
|
|
17
14
|
.d2l-table {
|
|
@@ -750,7 +747,7 @@ export class TableWrapper extends PageableMixin(SelectionMixin(LitElement)) {
|
|
|
750
747
|
}
|
|
751
748
|
|
|
752
749
|
_updateStickyAncestor(node, popoverOpened) {
|
|
753
|
-
if (!this.stickyHeaders ||
|
|
750
|
+
if (!this.stickyHeaders || isPopoverSupported) return;
|
|
754
751
|
|
|
755
752
|
node = getComposedParent(node);
|
|
756
753
|
while (node) {
|