@brightspace-ui/core 3.204.4 → 3.204.6

package/components/popover/popover-mixin.js

@@ -351,7 +351,7 @@ export const PopoverMixin = superclass => class extends superclass {
 		this._opened = true;
 
 		await this.updateComplete; // wait for popover attribute before managing top-layer
-		if (this._useNativePopover) this.showPopover();
+		if (this.isConnected && this._useNativePopover) this.showPopover();
 
 		this._previousFocusableAncestor = getPreviousFocusableAncestor(this, false, false);
 

package/components/scroll-wrapper/scroll-wrapper.js

@@ -2,19 +2,13 @@ import '../colors/colors.js';
 import '../icons/icon.js';
 import { css, html, LitElement } from 'lit';
 import { classMap } from 'lit/directives/class-map.js';
-import { getFlag } from '../../helpers/flags.js';
 import { getFocusRingStyles } from '../../helpers/focus.js';
 import { LocalizeCoreElement } from '../../helpers/localize-core-element.js';
 import ResizeObserver from 'resize-observer-polyfill/dist/ResizeObserver.es.js';
 
-export const printMediaQueryOnlyFlag = getFlag('GAUD-8263-scroll-wrapper-media-print', true);
-
 const RTL_MULTIPLIER = navigator.userAgent.indexOf('Edge/') > 0 ? 1 : -1; /* legacy-Edge doesn't reverse scrolling in RTL */
 const SCROLL_AMOUNT = 0.8;
 
-// remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-const PRINT_MEDIA_QUERY_LIST = matchMedia('print');
-
 let focusStyleSheet;
 function getFocusStyleSheet() {
 	if (!focusStyleSheet) {
@@ -69,7 +63,6 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 				reflect: true,
 				type: Boolean
 			},
-			_printMode: { state: true },
 			_scrollbarLeft: {
 				attribute: 'scrollbar-left',
 				reflect: true,
@@ -148,18 +141,15 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 			}
 
 			@media print {
-				/* remove .print-media-query-only when cleaning up GAUD-8263-scroll-wrapper-media-print */
-				.d2l-scroll-wrapper-actions.print-media-query-only {
+				.d2l-scroll-wrapper-actions {
 					display: none;
 				}
-				/* remove .print-media-query-only when cleaning up GAUD-8263-scroll-wrapper-media-print */
-				.d2l-scroll-wrapper-container.print-media-query-only {
+				.d2l-scroll-wrapper-container {
 					border: none !important;
 					box-sizing: content-box !important;
 					overflow: visible !important;
 				}
 			}
-
 		`;
 	}
 
@@ -172,9 +162,6 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 		this._container = null;
 		this._hScrollbar = true;
 
-		// remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-		this._printMode = PRINT_MEDIA_QUERY_LIST.matches;
-
 		this._resizeObserver = new ResizeObserver(() => requestAnimationFrame(() => this.checkScrollbar()));
 		this._scrollbarLeft = false;
 		this._scrollbarRight = false;
@@ -182,29 +169,12 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 		this._syncDriverTimeout = null;
 		this._checkScrollThresholds = this._checkScrollThresholds.bind(this);
 
-		// remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-		this._handlePrintChange = this._handlePrintChange.bind(this);
-
 		this._synchronizeScroll = this._synchronizeScroll.bind(this);
 	}
 
-	connectedCallback() {
-		super.connectedCallback();
-
-		// remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-		if (!printMediaQueryOnlyFlag) {
-			PRINT_MEDIA_QUERY_LIST.addEventListener?.('change', this._handlePrintChange);
-		}
-	}
-
 	disconnectedCallback() {
 		super.disconnectedCallback();
 		this._disconnectAll();
-
-		// remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-		if (!printMediaQueryOnlyFlag) {
-			PRINT_MEDIA_QUERY_LIST.removeEventListener?.('change', this._handlePrintChange);
-		}
 	}
 
 	firstUpdated(changedProperties) {
@@ -213,17 +183,11 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 	}
 
 	render() {
-
-		// when printing, just get scroll-wrapper out of the way; remove when cleaning up GAUD-8263-scroll-wrapper-media-print
-		if (this._printMode && !printMediaQueryOnlyFlag) return html`<slot></slot>`;
-
 		const containerClasses = {
-			'd2l-scroll-wrapper-container': true,
-			'print-media-query-only': printMediaQueryOnlyFlag // remove when cleaning up GAUD-8263-scroll-wrapper-media-print
+			'd2l-scroll-wrapper-container': true
 		};
 		const actionsClasses = {
-			'd2l-scroll-wrapper-actions': true,
-			'print-media-query-only': printMediaQueryOnlyFlag // remove when cleaning up GAUD-8263-scroll-wrapper-media-print
+			'd2l-scroll-wrapper-actions': true
 		};
 		const isRtl = document.documentElement.getAttribute('dir') === 'rtl';
 		const leftScrollLabel = this.localize('components.scroll-wrapper.scroll-left');
@@ -296,18 +260,6 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 		}
 	}
 
-	// remove this handler when cleaning up GAUD-8263-scroll-wrapper-media-print
-	async _handlePrintChange() {
-		if (!this._printMode) {
-			this._disconnectAll();
-		}
-		this._printMode = PRINT_MEDIA_QUERY_LIST.matches;
-		if (!this._printMode) {
-			await this.updateComplete;
-			this._updateScrollTargets();
-		}
-	}
-
 	_scrollLeft() {
 		if (!this._container) return;
 		const scrollDistance = this._container.clientWidth * SCROLL_AMOUNT * -1;
@@ -334,8 +286,6 @@ class ScrollWrapper extends LocalizeCoreElement(LitElement) {
 	_updateScrollTargets() {
 		this._disconnectAll();
 
-		if (this._printMode) return;
-
 		this._baseContainer = this.shadowRoot.querySelector('.d2l-scroll-wrapper-container');
 		this._container = this.customScrollers?.primary || this._baseContainer;
 		this._secondaryScrollers = this.customScrollers?.secondary || [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.204.4",
+  "version": "3.204.6",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",