@brightspace-ui/core 3.180.0 → 3.182.0

package/components/menu/menu-item-link.js

@@ -8,8 +8,6 @@ import { menuItemStyles } from './menu-item-styles.js';
 
 const newWindowIconEnabled = getFlag('GAUD-8295-menu-item-link-new-window-icon', true);
 
-const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-changes', true);
-
 /**
  * A menu item component used for navigating.
  * @fires click - Dispatched when the link is clicked
@@ -105,7 +103,6 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 
 	firstUpdated() {
 		super.firstUpdated();
-		if (!menuItemClickChangesEnabled) this.addEventListener('click', this._onClick); // remove when cleaning up GAUD-8369-menu-item-link-click-changes
 		this.addEventListener('keydown', this._onKeyDown);
 	}
 
@@ -142,41 +139,9 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 		return label && this.target === '_blank' ? this.localize('components.link.open-in-new-window') : undefined;
 	}
 
-	// remove this function when cleaning up GAUD-8369-menu-item-link-click-changes
-	_getTarget() {
-		if (this.target && this.target !== '') {
-			return this.target;
-		}
-		let base = document.getElementsByTagName('base');
-		if (base && base.length > 0) {
-			base = base[0];
-			return base.getAttribute('target');
-		}
-		return null;
-	}
-
-	// remove this function when cleaning up GAUD-8369-menu-item-link-click-changes
-	_onClick() {
-		if (this.shadowRoot) this.shadowRoot.querySelector('a').dispatchEvent(new CustomEvent('click'));
-	}
-
 	_onKeyDown(e) {
-		if (menuItemClickChangesEnabled) {
-			if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
-				this.shadowRoot.querySelector('a').click();
-			}
-		} else { // remove this block when cleaning up GAUD-8369-menu-item-link-click-changes
-			super._onKeyDown(e);
-			if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
-				const target = this._getTarget();
-				if (target === '_parent') {
-					window.parent.location.assign(this.href);
-				} else if (target === '_top') {
-					window.top.location.assign(this.href);
-				} else {
-					window.location.assign(this.href);
-				}
-			}
+		if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
+			this.shadowRoot.querySelector('a').click();
 		}
 	}
 }

package/components/menu/menu-item-mixin.js

@@ -1,8 +1,6 @@
-import { getFlag } from '../../helpers/flags.js';
 import { PropertyRequiredMixin } from '../../mixins/property-required/property-required-mixin.js';
 
 const defaultLines = 2;
-const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-changes', true);
 
 export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(superclass) {
 
@@ -156,11 +154,7 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 	}
 
 	__onClick(e) {
-		if (menuItemClickChangesEnabled) {
-			if (!this._letClickPropagate) e.stopPropagation();
-		} else { // remove this block when cleaning up GAUD-8369-menu-item-link-click-changes
-			e.stopPropagation();
-		}
+		if (!this._letClickPropagate) e.stopPropagation();
 
 		this.__action();
 	}

package/helpers/focus.js

@@ -1,6 +1,5 @@
 import { css, unsafeCSS } from 'lit';
 import { getComposedChildren, getComposedParent, getFirstVisibleAncestor, getNextAncestorSibling, getPreviousAncestorSibling, isVisible } from './dom.js';
-import { getFlag } from './flags.js';
 
 const focusableElements = {
 	a: true,
@@ -15,9 +14,6 @@ const focusableElements = {
 	textarea: true
 };
 
-// The default here cannot be changed, as BSI relies on it being true. Do not change the default without adding a way for BSI to override it.
-const focusVisibleSupportChangesEnabled = getFlag('focus-visible-support-changes-for-focus-rings', true);
-
 export function getComposedActiveElement() {
 	let node = document.activeElement;
 
@@ -80,22 +76,6 @@ export function getFocusPseudoClass() {
 	return isFocusVisibleSupported() ? 'focus-visible' : 'focus';
 }
 export function getFocusRingStyles(selector, { extraStyles = null } = {}) {
-	// Remove when cleaning up focus-visible-support-changes-for-focus-rings
-	if (!focusVisibleSupportChangesEnabled) {
-		const selectorDelegate = typeof selector === 'string' ? pseudoClass => `${selector}:${pseudoClass}` : selector;
-		const cssSelector = unsafeCSS(selectorDelegate(getFocusPseudoClass()));
-		return css`${cssSelector} {
-			${extraStyles ?? css``}
-			outline: 2px solid var(--d2l-focus-ring-color, var(--d2l-color-celestine));
-			outline-offset: var(--d2l-focus-ring-offset, 2px);
-		}
-		@media (prefers-contrast: more) {
-			${cssSelector} {
-				outline-color: Highlight;
-			}
-		}`;
-	}
-
 	const stylesDelegate = selector => css`
 		${selector} {
 			${extraStyles ?? css``}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.180.0",
+  "version": "3.182.0",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",