@brightspace-ui/core 3.176.2 → 3.176.4

package/components/sorting/README.md

@@ -9,9 +9,9 @@ The sort menu allows the user to adjust the sort order of data in a list.
   import '@brightspace-ui/core/components/sorting/sort-item.js';
 </script>
 <d2l-sort>
-	<d2l-sort-item text="Most Relevant" selected></d2l-sort-item>
-	<d2l-sort-item text="Recently Updated"></d2l-sort-item>
-	<d2l-sort-item text="Highest Rated"></d2l-sort-item>
+	<d2l-sort-item text="Most Relevant" value="relevant" selected></d2l-sort-item>
+	<d2l-sort-item text="Recently Updated" value="updated"></d2l-sort-item>
+	<d2l-sort-item text="Highest Rated" value="rating"></d2l-sort-item>
 </d2l-sort>
 ```
 

package/components/sorting/sort.js

@@ -78,7 +78,7 @@ class Sort extends FocusMixin(LocalizeCoreElement(LitElement)) {
 		if (this._selectedItemValue === e.target.value) return;
 
 		this._selectedItemText = e.target.text;
-		this._selectedItemValue = e.target;
+		this._selectedItemValue = e.target.value;
 		this.dispatchEvent(new CustomEvent(
 			'd2l-sort-change', {
 				detail: { value: e.detail.value }

package/helpers/framed.js

@@ -1,30 +1,29 @@
-let framed;
+let framedPromise;
 
-export async function isFramed() {
-	if (framed !== undefined) return framed;
+export function isFramed() {
+	if (framedPromise !== undefined) return framedPromise;
 
 	if (window.D2L && window.D2L.IsNotAnIframedApp) {
-		framed = false;
-		return framed;
+		framedPromise = Promise.resolve(false);
+		return framedPromise;
 	}
 
 	try {
 		if (window === window.parent) {
-			framed = false;
-			return framed;
+			framedPromise = Promise.resolve(false);
+			return framedPromise;
 		}
 	} catch {
-		framed = false;
-		return framed;
+		framedPromise = Promise.resolve(false);
+		return framedPromise;
 	}
 
-	framed = await Promise.race([
+	framedPromise = Promise.race([
 		new Promise(resolve => {
 			const handleIsFramedResponse = evt => {
 				if (!evt || !evt.data || evt.data.isFramed === undefined) return;
 				window.removeEventListener('message', handleIsFramedResponse, false);
-				framed = evt.data.isFramed;
-				resolve(framed);
+				resolve(evt.data.isFramed);
 			};
 
 			window.addEventListener('message', handleIsFramedResponse, false);
@@ -33,9 +32,9 @@ export async function isFramed() {
 		new Promise(resolve => {
 			setTimeout(() => {
 				resolve(false);
-			}, 75);
+			}, 150);
 		})
 	]);
 
-	return framed;
+	return framedPromise;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.176.2",
+  "version": "3.176.4",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",