@brightspace-ui/core 3.157.0 → 3.158.1

package/components/link/link-mixin.js

@@ -21,11 +21,6 @@ export const LinkMixin = superclass => class extends LocalizeCoreElement(supercl
 			 * @type {string}
 			 */
 			href: { type: String },
-			/**
-			 * Label for the link
-			 * @type {string}
-			 */
-			ariaLabel: { type: String, attribute: 'aria-label' },
 			/**
 			 * Where to display the linked URL
 			 * @type {string}
@@ -57,14 +52,19 @@ export const LinkMixin = superclass => class extends LocalizeCoreElement(supercl
 		`];
 	}
 
-	_render(inner, { rel = undefined, linkClasses = {}, tabindex = undefined } = {}) {
+	getNewWindowDescription(label) {
+		return label && this.target === '_blank' ? this.localize('components.link.open-in-new-window') : undefined;
+	}
+
+	_render(inner, { ariaLabel = undefined, rel = undefined, linkClasses = {}, tabindex = undefined } = {}) {
 		/*
 		* NOTICE:
 		* All html template whitespace within this component is critical to proper rendering and wrapping.
 		* Do not modify for readability!
 		*/
 		return html`<a
-			aria-label="${ifDefined(this.ariaLabel)}"
+			aria-label="${ifDefined(ariaLabel)}"
+			aria-description="${ifDefined(this.getNewWindowDescription(ariaLabel))}"
 			class="${classMap(linkClasses)}"
 			download="${ifDefined(this.download)}"
 			href="${ifDefined(this.href)}"

package/components/menu/menu-item-link.js

@@ -2,10 +2,12 @@ import { css, html, LitElement } from 'lit';
 import { getFlag } from '../../helpers/flags.js';
 import { ifDefined } from 'lit/directives/if-defined.js';
 import { LinkMixin } from '../link/link-mixin.js';
+import { LocalizeCoreElement } from '../../helpers/localize-core-element.js';
 import { MenuItemMixin } from './menu-item-mixin.js';
 import { menuItemStyles } from './menu-item-styles.js';
 
 const newWindowIconEnabled = getFlag('GAUD-8295-menu-item-link-new-window-icon', true);
+
 const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-changes', true);
 
 /**
@@ -13,11 +15,11 @@ const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-chan
  * @fires click - Dispatched when the link is clicked
  * @slot supporting - Allows supporting information to be displayed on the right-most side of the menu item
  */
-class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitElement)) : MenuItemMixin(LitElement)) {
+class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitElement)) : LocalizeCoreElement(MenuItemMixin(LitElement))) {
 
 	static get properties() {
-		if (newWindowIconEnabled) return {};
-		return {
+		// remove this block when cleaning up GAUD-8295-menu-item-link-new-window-icon
+		if (!newWindowIconEnabled) return {
 			/**
 			 * Prompts the user to save the linked URL instead of navigating to it.
 			 * Must be to a resource on the same origin.
@@ -34,7 +36,12 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 			 * Where to display the linked URL
 			 * @type {string}
 			 */
-			target: { type: String }
+			target: { type: String },
+			_ariaDescription: { type: String, attribute: 'aria-description', reflect: true },
+		};
+
+		return {
+			_ariaDescription: { type: String, attribute: 'aria-description', reflect: true },
 		};
 	}
 
@@ -119,8 +126,20 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 			${this._renderNewWindowIcon()}
 			<div class="d2l-menu-item-supporting"><slot name="supporting"></slot></div>
 		`;
-		return this._render(inner, { rel: this.target ? 'noreferrer noopener' : undefined, tabindex: -1 });
+		return this._render(inner, { ariaLabel: this._ariaLabel, rel: this.target ? 'noreferrer noopener' : undefined, tabindex: -1 });
+
+	}
+
+	willUpdate(changedProperties) {
+		super.willUpdate(changedProperties);
+		if (newWindowIconEnabled && changedProperties.has('_ariaLabel') || changedProperties.has('target')) {
+			this._ariaDescription = this.getNewWindowDescription(this._ariaLabel);
+		}
+	}
 
+	// remove this function when cleaning up GAUD-8295-menu-item-link-new-window-icon
+	getNewWindowDescription(label) {
+		return label && this.target === '_blank' ? this.localize('components.link.open-in-new-window') : undefined;
 	}
 
 	// remove this function when cleaning up GAUD-8369-menu-item-link-click-changes

package/custom-elements.json

@@ -10540,43 +10540,6 @@
       "name": "d2l-menu-item-link",
       "path": "./components/menu/menu-item-link.js",
       "description": "A menu item component used for navigating.",
-      "attributes": [
-        {
-          "name": "download",
-          "description": "Prompts the user to save the linked URL instead of navigating to it.\nMust be to a resource on the same origin.\nCan be used with or without a value, when set the value becomes the filename.",
-          "type": "string"
-        },
-        {
-          "name": "href",
-          "description": "REQUIRED: The url the menu item link navigates to",
-          "type": "string"
-        },
-        {
-          "name": "target",
-          "description": "Where to display the linked URL",
-          "type": "string"
-        }
-      ],
-      "properties": [
-        {
-          "name": "download",
-          "attribute": "download",
-          "description": "Prompts the user to save the linked URL instead of navigating to it.\nMust be to a resource on the same origin.\nCan be used with or without a value, when set the value becomes the filename.",
-          "type": "string"
-        },
-        {
-          "name": "href",
-          "attribute": "href",
-          "description": "REQUIRED: The url the menu item link navigates to",
-          "type": "string"
-        },
-        {
-          "name": "target",
-          "attribute": "target",
-          "description": "Where to display the linked URL",
-          "type": "string"
-        }
-      ],
       "events": [
         {
           "name": "click",

package/lang/haw.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} hou aku",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count}i mea}
-			other {Tag List with {count}a ʻē aʻe}
+			=0 {Papa inoa me 0 mau mea}
+			one {Papa inoa me {count} mau mea}
+			other {Papa inoa me {count} mau mea}
 		}`,
 	"components.tag-list.show-less": "Hōʻike liʻiliʻi",
 	"components.tag-list.show-more-description": "E koho e hōʻike i nā mea papa inoa inoa huna",

package/lang/mi.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} anō",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count}ahi te mea}
-			other {Tag List with {count}ētahi atu tūemi}
+			=0 {Rarangi Tohu me nga mea 0}
+			one {Rarangi Tohu me nga mea {count}}
+			other {Rarangi Tohu me nga mea {count}}
 		}`,
 	"components.tag-list.show-less": "Whakaaturia mai kia iti iho",
 	"components.tag-list.show-more-description": "Tīpakohia hei whakaatu i ngā tūemi rārangi tūtohu hunahuna",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.157.0",
+  "version": "3.158.1",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",