@brightspace-ui/core 3.156.3 → 3.157.0

package/components/menu/demo/menu.html

@@ -4,6 +4,12 @@
 		<meta name="viewport" content="width=device-width, initial-scale=1.0">
 		<meta charset="UTF-8">
 		<link rel="stylesheet" href="../../demo/styles.css" type="text/css">
+		<script type="module">
+			import { mockFlag } from '../../../helpers/flags.js';
+			const urlParams = new URLSearchParams(window.location.search);
+			mockFlag('GAUD-8295-menu-item-link-new-window-icon', urlParams.get('link-new-window-icon') === 'true');
+			mockFlag('GAUD-8369-menu-item-link-click-changes', urlParams.get('link-click-changes') === 'true');
+		</script>
 		<script type="module">
 			import '../../demo/demo-page.js';
 			import './custom-menu-item.js';
@@ -200,5 +206,12 @@
 				</template>
 			</d2l-demo-snippet>
 		</d2l-demo-page>
+
+		<script>
+			document.addEventListener('click', e => {
+				if (e.target.tagName !== 'D2L-MENU-ITEM-LINK') return;
+				console.log('Click event propagated up for router!', e.target);
+			});
+		</script>
 	</body>
 </html>

package/components/menu/menu-item-link.js

@@ -6,6 +6,7 @@ import { MenuItemMixin } from './menu-item-mixin.js';
 import { menuItemStyles } from './menu-item-styles.js';
 
 const newWindowIconEnabled = getFlag('GAUD-8295-menu-item-link-new-window-icon', true);
+const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-changes', true);
 
 /**
  * A menu item component used for navigating.
@@ -90,9 +91,14 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 		];
 	}
 
+	constructor() {
+		super();
+		this._letClickPropagate = true;
+	}
+
 	firstUpdated() {
 		super.firstUpdated();
-		this.addEventListener('click', this._onClick);
+		if (!menuItemClickChangesEnabled) this.addEventListener('click', this._onClick); // remove when cleaning up GAUD-8369-menu-item-link-click-changes
 		this.addEventListener('keydown', this._onKeyDown);
 	}
 
@@ -117,6 +123,7 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 
 	}
 
+	// remove this function when cleaning up GAUD-8369-menu-item-link-click-changes
 	_getTarget() {
 		if (this.target && this.target !== '') {
 			return this.target;
@@ -129,19 +136,27 @@ class MenuItemLink extends (newWindowIconEnabled ? LinkMixin(MenuItemMixin(LitEl
 		return null;
 	}
 
+	// remove this function when cleaning up GAUD-8369-menu-item-link-click-changes
 	_onClick() {
 		if (this.shadowRoot) this.shadowRoot.querySelector('a').dispatchEvent(new CustomEvent('click'));
 	}
 
 	_onKeyDown(e) {
-		if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
-			const target = this._getTarget();
-			if (target === '_parent') {
-				window.parent.location.assign(this.href);
-			} else if (target === '_top') {
-				window.top.location.assign(this.href);
-			} else {
-				window.location.assign(this.href);
+		if (menuItemClickChangesEnabled) {
+			if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
+				this.shadowRoot.querySelector('a').click();
+			}
+		} else { // remove this block when cleaning up GAUD-8369-menu-item-link-click-changes
+			super._onKeyDown(e);
+			if (e.keyCode === this.__keyCodes.ENTER || e.keyCode === this.__keyCodes.SPACE) {
+				const target = this._getTarget();
+				if (target === '_parent') {
+					window.parent.location.assign(this.href);
+				} else if (target === '_top') {
+					window.top.location.assign(this.href);
+				} else {
+					window.location.assign(this.href);
+				}
 			}
 		}
 	}

package/components/menu/menu-item-mixin.js

@@ -1,6 +1,8 @@
+import { getFlag } from '../../helpers/flags.js';
 import { PropertyRequiredMixin } from '../../mixins/property-required/property-required-mixin.js';
 
 const defaultLines = 2;
+const menuItemClickChangesEnabled = getFlag('GAUD-8369-menu-item-link-click-changes', true);
 
 export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(superclass) {
 
@@ -54,7 +56,8 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 			 */
 			description: { type: String },
 			_ariaDisabled: { type: String, attribute: 'aria-disabled', reflect: true },
-			_ariaLabel: { type: String, attribute: 'aria-label', reflect: true }
+			_ariaLabel: { type: String, attribute: 'aria-label', reflect: true },
+			_letClickPropagate: { state: true }
 		};
 	}
 
@@ -74,6 +77,7 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 		this.role = 'menuitem';
 		/** @ignore */
 		this.tabindex = -1;
+		this._letClickPropagate = false;
 	}
 
 	firstUpdated(changedProperties) {
@@ -82,7 +86,7 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 		this.addEventListener('click', this.__onClick);
 		this.addEventListener('d2l-hierarchical-view-hide-complete', this.__onHideComplete);
 		this.addEventListener('dom-change', this.__onDomChange);
-		this.addEventListener('keydown', this.__onKeyDown);
+		this.addEventListener('keydown', this._onKeyDown);
 
 		this.__initializeItem();
 
@@ -152,7 +156,12 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 	}
 
 	__onClick(e) {
-		e.stopPropagation();
+		if (menuItemClickChangesEnabled) {
+			if (!this._letClickPropagate) e.stopPropagation();
+		} else { // remove this block when cleaning up GAUD-8369-menu-item-link-click-changes
+			e.stopPropagation();
+		}
+
 		this.__action();
 	}
 
@@ -171,7 +180,12 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 		this.setAttribute('tabindex', '0');
 	}
 
-	__onKeyDown(e) {
+	_onHidden() {
+		/** Dispatched when the visibility of the menu item changes */
+		this.dispatchEvent(new CustomEvent('d2l-menu-item-visibility-change', { bubbles: true, composed: true }));
+	}
+
+	_onKeyDown(e) {
 		if (e.target !== this) {
 			return;
 		}
@@ -188,9 +202,4 @@ export const MenuItemMixin = superclass => class extends PropertyRequiredMixin(s
 		}
 	}
 
-	_onHidden() {
-		/** Dispatched when the visibility of the menu item changes */
-		this.dispatchEvent(new CustomEvent('d2l-menu-item-visibility-change', { bubbles: true, composed: true }));
-	}
-
 };

package/lang/ar.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "زيادة {count} إضافي",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {قائمة العلامات بها 0 عناصر}
+			one {قائمة العلامات بها {count} عنصر}
+			other {قائمة العلامات بها {count} من العناصر}
 		}`,
 	"components.tag-list.show-less": "إظهار أقل",
 	"components.tag-list.show-more-description": "حدد لإظهار عناصر قائمة العلامات المخفية",

package/lang/cy.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} yn rhagor",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Rhestr Tagiau gyda 0 eitem}
+			one {Rhestr Tagiau gyda {count} eitem}
+			other {Rhestr Tagiau gyda {count} eitem}
 		}`,
 	"components.tag-list.show-less": "Dangos Llai",
 	"components.tag-list.show-more-description": "Dewis i ddangos eitemau rhestr tag cudd",

package/lang/da.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} mere",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Tagliste med 0 elementer}
+			one {Tagliste med {count} element}
+			other {Tagliste med {count} elementer}
 		}`,
 	"components.tag-list.show-less": "Vis færre",
 	"components.tag-list.show-more-description": "Vælg for at få vist skjulte taglisteelementer",

package/lang/de.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} weitere",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Tag-Liste mit 0 Elementen}
+			one {Tag-Liste mit {count} Element}
+			other {Tag-Liste mit {count} Elementen}
 		}`,
 	"components.tag-list.show-less": "Weniger anzeigen",
 	"components.tag-list.show-more-description": "Wählen Sie diese Option, um ausgeblendete Elemente der Tag-Liste anzuzeigen",

package/lang/es-es.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} más",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Lista de etiquetas con 0 elementos}
+			one {Lista de etiquetas con {count} elemento}
+			other {Lista de etiquetas con {count} elementos}
 		}`,
 	"components.tag-list.show-less": "Mostrar menos",
 	"components.tag-list.show-more-description": "Seleccione esta opción para mostrar los elementos ocultos de la lista de etiquetas",

package/lang/es.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} más",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Lista de etiquetas con 0 elementos}
+			one {Lista de etiquetas con {count} elemento}
+			other {Lista de etiquetas con {count} elementos}
 		}`,
 	"components.tag-list.show-less": "Mostrar menos",
 	"components.tag-list.show-more-description": "Seleccione para mostrar los elementos ocultos de la lista de etiquetas",

package/lang/fr-fr.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "{count} de plus",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Liste d’étiquettes comportant 0 élément}
+			one {Liste d’étiquettes comportant {count} élément}
+			other {Liste d’étiquettes comportant {count} éléments}
 		}`,
 	"components.tag-list.show-less": "Afficher moins",
 	"components.tag-list.show-more-description": "Sélectionnez cette option pour afficher les éléments de la liste d’étiquettes masquées",

package/lang/fr.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} de plus",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Liste de balises avec 0 élément}
+			one {Liste de balises avec {count} élément}
+			other {Liste de balises avec {count} éléments}
 		}`,
 	"components.tag-list.show-less": "Afficher moins",
 	"components.tag-list.show-more-description": "Sélectionnez cette option pour afficher les éléments de la liste des balises cachées",

package/lang/haw.js

@@ -212,8 +212,8 @@ export default {
 	"components.tag-list.role-description":
 		`{count, plural,
 			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			one {Tag List with {count}i mea}
+			other {Tag List with {count}a ʻē aʻe}
 		}`,
 	"components.tag-list.show-less": "Hōʻike liʻiliʻi",
 	"components.tag-list.show-more-description": "E koho e hōʻike i nā mea papa inoa inoa huna",

package/lang/hi.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} और",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {0 आइटम के साथ सूची टैग करें}
+			one {{count} आइटम के साथ सूची टैग करें}
+			other {{count} आइटम के साथ सूची टैग करें}
 		}`,
 	"components.tag-list.show-less": "कम दिखाएँ",
 	"components.tag-list.show-more-description": "छिपे हुए टैग लिस्ट आइटम दिखाने के लिए चुनें",

package/lang/ja.js

@@ -203,8 +203,8 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} 件追加",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			other {Tag List with {count} items}
+			=0 {0 項目のタグリスト}
+			other {{count} 項目のタグリスト}
 		}`,
 	"components.tag-list.show-less": "少なく表示",
 	"components.tag-list.show-more-description": "選択すると、非表示のタグリスト項目が表示されます",

package/lang/ko.js

@@ -203,8 +203,8 @@ export default {
 	"components.tag-list.num-hidden": "{count}개 더",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			other {Tag List with {count} items}
+			=0 {0개의 항목이 있는 태그 목록}
+			other {{count}개의 항목이 있는 태그 목록}
 		}`,
 	"components.tag-list.show-less": "간단히 표시",
 	"components.tag-list.show-more-description": "숨겨진 태그 목록 항목을 표시하려면 선택합니다",

package/lang/mi.js

@@ -212,8 +212,8 @@ export default {
 	"components.tag-list.role-description":
 		`{count, plural,
 			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			one {Tag List with {count}ahi te mea}
+			other {Tag List with {count}ētahi atu tūemi}
 		}`,
 	"components.tag-list.show-less": "Whakaaturia mai kia iti iho",
 	"components.tag-list.show-more-description": "Tīpakohia hei whakaatu i ngā tūemi rārangi tūtohu hunahuna",

package/lang/nl.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} extra",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Taglijst met 0 items}
+			one {Taglijst met {count} item}
+			other {Taglijst met {count} items}
 		}`,
 	"components.tag-list.show-less": "Minder weergeven",
 	"components.tag-list.show-more-description": "Selecteer deze optie om verborgen items op labellijsten weer te geven",

package/lang/pt.js

@@ -173,7 +173,7 @@ export default {
 	"components.selection.selected-plus": "Mais de {count} selecionados",
 	"components.selection-controls.label": "Ações para seleção",
 	"components.sort.label": "Classificar",
-	"components.sort.text": "Classificação: {selectedItemText}",
+	"components.sort.text": "Classificar: {selectedItemText}",
 	"components.switch.conditions": "As condições devem ser atendidas",
 	"components.switch.hidden": "Oculto",
 	"components.switch.visible": "Visível",
@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} mais",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Lista de etiquetas com 0 item}
+			one {Lista de etiquetas com {count} item}
+			other {Lista de etiquetas com {count} itens}
 		}`,
 	"components.tag-list.show-less": "Mostrar menos",
 	"components.tag-list.show-more-description": "Selecione para mostrar itens ocultos da lista de etiquetas",

package/lang/sv.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} till",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {Tagglista med 0 objekt}
+			one {Tagglista med {count} objekt}
+			other {Tagglista med {count} objekt}
 		}`,
 	"components.tag-list.show-less": "Visa färre",
 	"components.tag-list.show-more-description": "Välj för att visa dolda tagglistobjekt",

package/lang/tr.js

@@ -211,9 +211,9 @@ export default {
 	"components.tag-list.num-hidden": "+{count} tane daha",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			one {Tag List with {count} item}
-			other {Tag List with {count} items}
+			=0 {0 öğeli Etiket Listesi}
+			one {{count} öğeli Etiket Listesi}
+			other {{count} öğeli Etiket Listesi}
 		}`,
 	"components.tag-list.show-less": "Daha Azını Göster",
 	"components.tag-list.show-more-description": "Gizli etiket listesi öğelerini göstermek için seçin",

package/lang/zh-cn.js

@@ -203,8 +203,8 @@ export default {
 	"components.tag-list.num-hidden": "+ {count} 个",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			other {Tag List with {count} items}
+			=0 {包含 0 个项目的标签列表}
+			other {包含 {count} 个项目的标签列表}
 		}`,
 	"components.tag-list.show-less": "显示更少",
 	"components.tag-list.show-more-description": "选择以显示隐藏的标签列表项目",

package/lang/zh-tw.js

@@ -204,8 +204,8 @@ export default {
 	"components.tag-list.num-hidden": "還有 {count} 個",
 	"components.tag-list.role-description":
 		`{count, plural,
-			=0 {Tag List with 0 items}
-			other {Tag List with {count} items}
+			=0 {標記列表包含 0 個項目}
+			other {標記列表包含 {count} 個項目}
 		}`,
 	"components.tag-list.show-less": "顯示更少",
 	"components.tag-list.show-more-description": "選取以顯示隱藏的標記清單項目",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.156.3",
+  "version": "3.157.0",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",