@brightspace-ui/core 3.135.4 → 3.135.6

package/components/description-list/description-list-wrapper.js

@@ -19,6 +19,9 @@ export const descriptionListStyles = [
 			grid-auto-flow: row;
 			grid-template-columns: minmax(var(--d2l-dl-wrapper-dt-min-width), auto) minmax(var(--d2l-dl-wrapper-dd-min-width), 1fr);
 		}
+		d2l-dl-wrapper > dl[hidden] {
+			display: none;
+		}
 		d2l-dl-wrapper > dl > dt {
 			margin: var(--d2l-dl-wrapper-dt-margin, 0);
 			max-width: var(--d2l-dl-wrapper-dt-max-width);
@@ -107,6 +110,7 @@ class DescriptionListWrapper extends LitElement {
 	_onResize(entries) {
 		if (!entries || entries.length === 0) return;
 		const entry = entries[0];
+		if (entry.contentRect.width === 0) return; // ignore if we're hidden
 
 		requestAnimationFrame(() => this._stacked = entry.contentRect.width < this.breakpoint);
 	}

package/components/dialog/dialog-mixin.js

@@ -270,7 +270,7 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 		const availableHeight = this._ifrauContextInfo
 			? this._ifrauContextInfo.availableHeight - this._margin.top - this._margin.bottom
 			: window.innerHeight - this._margin.top - this._margin.bottom;
-		let preferredHeight = 2;
+		let preferredHeight = 3; // content height is off by 2px and we need an extra 1px to account for rounding when zoomed
 
 		if (this.fullHeight) {
 			preferredHeight = 2 * this._width;
@@ -550,8 +550,10 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 	_updateOverflow() {
 		if (!this.shadowRoot) return;
 		const content = this.shadowRoot.querySelector('.d2l-dialog-content');
+		// On Windows, browser zoom can cause scrollTop to be a fraction
+		const bottomOverflow = content.scrollHeight - (Math.ceil(content.scrollTop) + content.clientHeight);
 		this._overflowTop = (content.scrollTop > 0);
-		this._overflowBottom = (content.scrollHeight > content.scrollTop + content.clientHeight);
+		this._overflowBottom = (bottomOverflow > 0);
 	}
 
 	async _updateSize() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.135.4",
+  "version": "3.135.6",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",