@brightspace-ui/core 2.18.4 → 2.18.7

package/components/dropdown/dropdown-content-mixin.js

@@ -683,7 +683,7 @@ export const DropdownContentMixin = superclass => class extends LocalizeCoreElem
 
 			const centerDelta = contentRect.width - targetRect.width;
 			const position = this._getPosition(spaceAround, centerDelta);
-			if (position) {
+			if (position !== null) {
 				this._position = position;
 			}
 

package/components/switch/switch-visibility.js

@@ -8,6 +8,10 @@ import { SwitchMixin } from './switch-mixin.js';
  */
 class VisibilitySwitch extends LocalizeCoreElement(SwitchMixin(LitElement)) {
 
+	/**
+	 * The text that is displayed for the switch label.
+	 * @default "Visibility"
+	 */
 	get text() {
 		return (this._text ? this._text : this.localize('components.switch.visibility'));
 	}

package/custom-elements.json

@@ -9354,8 +9354,9 @@
       "attributes": [
         {
           "name": "text",
-          "description": "REQUIRED: The text that is displayed for the switch label.",
-          "type": "string"
+          "description": "The text that is displayed for the switch label.",
+          "type": "string",
+          "default": "\"\\\"Visibility\\\"\""
         },
         {
           "name": "tooltip",
@@ -9393,8 +9394,9 @@
         {
           "name": "text",
           "attribute": "text",
-          "description": "REQUIRED: The text that is displayed for the switch label.",
-          "type": "string"
+          "description": "The text that is displayed for the switch label.",
+          "type": "string",
+          "default": "\"\\\"Visibility\\\"\""
         },
         {
           "name": "tooltip",

package/mixins/demo/localize-test.js

@@ -1,7 +1,7 @@
 import { html, LitElement } from 'lit';
-import { LocalizeMixin } from '../../mixins/localize-mixin.js';
+import { LocalizeDynamicMixin } from '../../mixins/localize-dynamic-mixin.js';
 
-class LocalizeTest extends LocalizeMixin(LitElement) {
+class LocalizeTest extends LocalizeDynamicMixin(LitElement) {
 
 	static get properties() {
 		return {
@@ -11,7 +11,7 @@ class LocalizeTest extends LocalizeMixin(LitElement) {
 		};
 	}
 
-	static async getLocalizeResources(langs) {
+	static get localizeConfig() {
 		const langResources = {
 			'ar': { 'hello': 'مرحبا {name}' },
 			'de': { 'hello': 'Hallo {name}' },
@@ -29,17 +29,15 @@ class LocalizeTest extends LocalizeMixin(LitElement) {
 			'zh-cn': { 'hello': '你好 {name}' },
 			'zh-tw': { 'hello': '你好 {name}' }
 		};
-
-		for (let i = 0; i < langs.length; i++) {
-			if (langResources[langs[i]]) {
-				return {
-					language: langs[i],
-					resources: langResources[langs[i]]
-				};
+		return {
+			importFunc: async lang => {
+				return new Promise((resolve) => {
+					setTimeout(() => {
+						resolve(langResources[lang]);
+					}, 50);
+				});
 			}
-		}
-
-		return null;
+		};
 	}
 
 	render() {

package/mixins/localize-mixin.js

@@ -163,12 +163,13 @@ export const LocalizeMixin = dedupeMixin(superclass => class extends superclass
 	}
 
 	static _getAllLocalizeResources(possibleLanguages, config = this.localizeConfig) {
-		let resourcesLoadedPromises;
+		let resourcesLoadedPromises = [];
 		const superCtor = Object.getPrototypeOf(this);
+		// get imported terms for each config, head up the chain to get them all
 		if ('_getAllLocalizeResources' in superCtor) {
-			resourcesLoadedPromises = superCtor._getAllLocalizeResources(possibleLanguages, config);
-		} else {
-			resourcesLoadedPromises = [];
+			// eslint-disable-next-line no-prototype-builtins
+			const superConfig = superCtor.hasOwnProperty('localizeConfig') && superCtor.localizeConfig.importFunc ? superCtor.localizeConfig : config;
+			resourcesLoadedPromises = superCtor._getAllLocalizeResources(possibleLanguages, superConfig);
 		}
 		// eslint-disable-next-line no-prototype-builtins
 		if (this.hasOwnProperty('getLocalizeResources') || this.hasOwnProperty('resources')) {

package/mixins/localize-mixin.md

@@ -103,6 +103,17 @@ static get localizeConfig() {
 }
 ```
 
+**Note:** If using `LocalizeCoreElement` or a mixin that utilizes `LocalizeCoreElement` as well as `LocalizeDynamicMixin` or a mixin that uses `LocalizeDynamicMixin`, `LocalizeDynamicMixin` **must** appear before `LocalizeCoreElement` in the chain. For example:
+
+```javascript
+import { LocalizeCoreElement } from '@brightspace-ui/core/helpers/localize-core-element.js';
+import { LocalizeDynamicMixin } from '@brightspace-ui/core/mixins/localize-dynamic-mixin.js';
+
+class MyComponent extends LocalizeDynamicMixin(LocalizeCoreElement(LitElement)) {
+  ...
+}
+```
+
 ## `localize()`
 
 Once your localization resources are available, the `localize()` method is used to localize a piece of text in your `render()` method.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "2.18.4",
+  "version": "2.18.7",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",