@brightspace-ui/core 2.1.0 → 2.1.3

package/components/dialog/dialog-mixin.js

@@ -124,7 +124,12 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 	}
 
 	resize() {
-		return this._updateSize();
+		return new Promise(resolve => {
+			setTimeout(async() => {
+				await this._updateSize();
+				resolve();
+			}, 0);
+		});
 	}
 
 	_addHandlers() {
@@ -330,7 +335,7 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 		// focus first focusable child prior to auto resize (fixes screen reader hiccups)
 		this._focusInitial();
 
-		requestAnimationFrame(async() => {
+		setTimeout(async() => {
 
 			this.shadowRoot.querySelector('.d2l-dialog-content').scrollTop = 0;
 			// scrollbar is kept hidden while we update the scroll position to avoid scrollbar flash
@@ -340,6 +345,7 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 
 			await this._updateSize();
 			this._state = 'showing';
+			await this._updateComplete;
 
 			// edge case: no children were focused, try again after one redraw
 			const activeElement = getComposedActiveElement();
@@ -354,7 +360,7 @@ export const DialogMixin = superclass => class extends RtlMixin(superclass) {
 			this.dispatchEvent(new CustomEvent(
 				'd2l-dialog-open', { bubbles: true, composed: true }
 			));
-		});
+		}, 0);
 
 	}
 

package/components/dialog/dialog-styles.js

@@ -11,6 +11,15 @@ export const dialogStyles = css`
 		display: block;
 	}
 
+	:host([opened]:not([_state="showing"])) {
+		visibility: hidden;
+	}
+
+	:host([opened][_state="showing"]),
+	:host([opened][_state="hiding"]) {
+		visibility: visible;
+	}
+
 	.d2l-dialog-outer {
 		background-color: white;
 		border: 1px solid var(--d2l-color-mica);

package/components/filter/filter.js

@@ -506,7 +506,7 @@ class Filter extends FocusMixin(LocalizeCoreElement(RtlMixin(LitElement))) {
 		const changes = e.detail.changes;
 		const dimension = this._dimensions.find(dimension => dimension.key === e.detail.dimensionKey);
 		const value = e.detail.valueKey && dimension.values.find(value => value.key === e.detail.valueKey);
-		const toUpdate = value ? value : dimension;
+		const toUpdate = e.detail.valueKey ? value : dimension;
 
 		if (!toUpdate) return;
 

package/components/tabs/tab-panel-mixin.js

@@ -71,6 +71,7 @@ export const TabPanelMixin = superclass => class extends superclass {
 				}
 			} else if (prop === 'text') {
 				this.setAttribute('aria-label', this.text);
+				/** Dispatched when the text attribute is changed */
 				this.dispatchEvent(new CustomEvent(
 					'd2l-tab-panel-text-changed', { bubbles: true, composed: true, detail: { text: this.text } }
 				));

package/custom-elements.json

@@ -9707,7 +9707,8 @@
           "description": "Dispatched when a tab is selected"
         },
         {
-          "name": "d2l-tab-panel-text-changed"
+          "name": "d2l-tab-panel-text-changed",
+          "description": "Dispatched when the text attribute is changed"
         }
       ],
       "slots": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "2.1.0",
+  "version": "2.1.3",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",