@brightspace-ui-labs/facet-filter-sort 6.7.5 → 6.8.0

package/components/filter-dropdown/filter-dropdown-category.js

@@ -37,7 +37,8 @@ class LabsFilterDropdownCategory extends FilterLocalizeMixin(TabPanelMixin(LitEl
 			/**
 			 * The number of selected filter options for that filter category.  When options are selected and de-selected, the consumer is responsible for updating this number after updating its own data store.
 			 */
-			selectedOptionCount: { type: Number, attribute: 'selected-option-count' }
+			selectedOptionCount: { type: Number, attribute: 'selected-option-count' },
+			_text: { type: String, attribute: '_text', reflect: true }
 		};
 	}
 
@@ -96,14 +97,6 @@ class LabsFilterDropdownCategory extends FilterLocalizeMixin(TabPanelMixin(LitEl
 		}
 	}
 
-	firstUpdated(changedProperties) {
-		super.firstUpdated(changedProperties);
-		this.addEventListener('d2l-menu-item-select', (e) => {
-			this.selected = !this.selected;
-			this.__onSelect(e);
-		});
-	}
-
 	render() {
 		return html`
 			<div class="d2l-labs-filter-dropdown-page-search" ?hidden="${this.disableSearch}">
@@ -113,7 +106,7 @@ class LabsFilterDropdownCategory extends FilterLocalizeMixin(TabPanelMixin(LitEl
 					value="${ifDefined(this.searchValue)}">
 				</d2l-input-search>
 			</div>
-			<d2l-menu @d2l-menu-item-change="${this._handleMenuItemChange}" label="${this.getAttribute('text')}">
+			<d2l-menu @d2l-menu-item-change="${this._handleMenuItemChange}" label="${this._text}">
 				<slot @slotchange="${this._onSlotChange}"></slot>
 			</d2l-menu>
 		`;
@@ -152,11 +145,10 @@ class LabsFilterDropdownCategory extends FilterLocalizeMixin(TabPanelMixin(LitEl
 
 	_updateTabText(categoryText, selectedOptionCount) {
 		if (selectedOptionCount === 0) {
-			this.setAttribute('text', categoryText);
+			this._text = categoryText;
 		} else {
-			this.setAttribute('text', this.localize('categoryTitleMultiple', 'title', categoryText, 'numSelected', selectedOptionCount));
+			this._text = this.localize('categoryTitleMultiple', 'title', categoryText, 'numSelected', selectedOptionCount);
 		}
-		this.requestUpdate();
 	}
 
 }

package/components/filter-dropdown/filter-dropdown.js

@@ -133,7 +133,7 @@ class D2LLabsFilterDropdown extends mixinBehaviors([LocalizeBehavior], PolymerEl
 					</div>
 					<d2l-tabs>
 						<template is="dom-repeat" items="[[_tabInfos]]" as="tab">
-							<d2l-tab id="[[tab.key]]" text="[[tab.text]]" slot="tabs" selected$="[[tab.selected]]" on-d2l-tab-selected="_dispatchSelected"></d2l-tab>
+							<d2l-tab id="[[tab.key]]" text="[[tab.text]]" slot="tabs" on-d2l-tab-selected="_dispatchSelected"></d2l-tab>
 						</template>
 						<slot on-slotchange="_handleCategoriesSlotChange" slot="panels"></slot>
 					</d2l-tabs>
@@ -215,24 +215,22 @@ class D2LLabsFilterDropdown extends mixinBehaviors([LocalizeBehavior], PolymerEl
 		const tabInfos = [];
 		categories.forEach((category, index) => {
 			const key = category.getAttribute('key') || `category-${index}`;
-			const text = category.getAttribute('text');
-			const isSelected = category._selected;
+			const text = category._text;
 
 			category.setAttribute('labelled-by', key);
-			tabInfos.push({ key, text, selected: isSelected });
+			tabInfos.push({ key, text });
 
 			if (!category.__tabInfoObserver) {
 				category.__tabInfoObserver = new MutationObserver(() => {
-					const newText = category.getAttribute('text');
-					const newSelected = category._selected;
+					const newText = category._text;
 
 					this._tabInfos = this._tabInfos.map(info => {
 						return info.key === key
-							? { ...info, text: newText, selected: newSelected }
+							? { ...info, text: newText }
 							: info;
 					});
 				});
-				category.__tabInfoObserver.observe(category, { attributes: true, attributeFilter: ['text', 'selected'] });
+				category.__tabInfoObserver.observe(category, { attributes: true, attributeFilter: ['_text'] });
 			}
 		});
 

package/package.json

@@ -35,7 +35,7 @@
     "eslint-config-brightspace": "^0.25",
     "stylelint": "^15"
   },
-  "version": "6.7.5",
+  "version": "6.8.0",
   "dependencies": {
     "@brightspace-ui/core": "^3",
     "@brightspace-ui/localize-behavior": "^2",