@bridge_gpt/mcp-server 0.2.68 → 0.2.69

package/build/doctor.js

@@ -36,6 +36,9 @@ import { modelRoutingPreferencesPath, readModelRoutingPreference } from "./model
 import { inspectExecutorAgentAdapter, inspectionForFailedResolution, } from "./agent-launchers/executor-adapter-inspection.js";
 import { resolveExecutorAgentAdapter } from "./agent-launchers/executor-adapter-registry.js";
 import { parseDefaultOnEnvFlag } from "./env-flags.js";
+import { checkForUpdate, isPlainReleaseVersion } from "./update-check.js";
+import { getNoticeDecision, isUnattendedSession, UPDATE_CHECK_ENABLED_ENV, } from "./session-upgrade-notice.js";
+import { formatUpdateAdvice } from "./upgrade-advice.js";
 import { createBridgeApiUrls } from "./bridge-api-urls.js";
 import { probeToolSurface } from "./tool-surface-gating.js";
 import { readStoredBindingState, resolveBapiCredentials } from "./credential-store.js";
@@ -45,7 +48,7 @@ import { validateHttpBaseUrl } from "./base-url.js";
 import { getLiveRepositoryConductors, getParseDispatcherHealth, } from "./epic-shared/bridge-client.js";
 import { resolveRequiredStartTicketsRepoName } from "./start-tickets-repo.js";
 import { collectWorkerContainmentDiagnostic, formatWorkerContainmentDiagnosticReport, } from "./worker-containment-diagnostic.js";
-import { BRIDGE_PACKAGE_NAME, describeLauncherReason, DUPLICATE_REGISTRATION_GUIDANCE, inspectLauncherConfigs, parseLauncherPin as parseSharedLauncherPin, } from "./launcher-config-inspection.js";
+import { BRIDGE_PACKAGE_NAME, describeLauncherReason, DUPLICATE_REGISTRATION_GUIDANCE, inspectLauncherConfigs, isExactVersion, isPrerequisiteFailure, parseLauncherPin as parseSharedLauncherPin, } from "./launcher-config-inspection.js";
 import { MCP_SERVER_NAME, MCP_PACKAGE_NAME, } from "./mcp-identity.js";
 import { DEFAULT_AGENT_NAME, resolveAgentSpec, isAgentName, formatValidAgentNames, } from "./agent-registry.js";
 import { getDoctorPrereqDescriptors, probePrerequisite, } from "./start-tickets-prereqs.js";
@@ -166,7 +169,8 @@ export function getDoctorUsage() {
         "",
         "It also includes an advisory '/drive-epic-run permission rules' section",
         "(BAPI-1398): whether the project permissions.allow rules and the optional user",
-        "autoMode entries that install writes are PRESENT, MISSING, or DRIFTED (for",
+        "autoMode entries (added through /drive-epic-run or the bridge-permissions",
+        "subcommand, never by install) are PRESENT, MISSING, or DRIFTED (for",
         "example after the BAPI_MCP_CLI launcher changed). It reads .claude/settings.local.json,",
         "~/.claude/settings.json, and .bridge/bridge-permissions.json, writes nothing,",
         "and never changes the exit code.",
@@ -386,6 +390,82 @@ export async function collectDoctorResults(deps, agentName) {
     }
     return { ok: true, results };
 }
+/** The production checker, bound so it can neither read nor populate the cache. */
+export function createDoctorVersionChecker(env) {
+    return () => checkForUpdate({ env, readCache: false, writeCache: false });
+}
+/**
+ * Collect the version diagnostic. Never throws. The lookup is skipped when update
+ * checks are disabled or the session is unattended; a null, rejected, or malformed
+ * result is `unavailable`. Only a reliable fresh (or override) result reaches the
+ * shared notice decision, and only then are project pins evaluated.
+ */
+export async function collectVersionDiagnostic(deps) {
+    try {
+        if (!parseDefaultOnEnvFlag(deps.env[UPDATE_CHECK_ENABLED_ENV]) || isUnattendedSession(deps.env)) {
+            return { status: "not-checked" };
+        }
+        let result = null;
+        try {
+            result = await deps.checkLatest();
+        }
+        catch {
+            result = null;
+        }
+        if (!result || typeof result !== "object" || !isPlainReleaseVersion(result.latestVersion)) {
+            return { status: "unavailable" };
+        }
+        const latest = result.latestVersion;
+        const authoritative = { known: true, latest };
+        const upgrade = getNoticeDecision(deps.env, VERSION, authoritative).show;
+        const stalePins = [];
+        try {
+            const shared = await inspectLauncherConfigs({
+                cwd: deps.cwd,
+                targetVersion: VERSION,
+                readFile: deps.readFile,
+            });
+            for (const found of shared) {
+                if (!found.filePresent || !found.bridgeEntryPresent)
+                    continue;
+                if (found.shape !== "standard" || isPrerequisiteFailure(found))
+                    continue;
+                if (!isExactVersion(found.currentVersion))
+                    continue;
+                const pin = found.currentVersion;
+                if (getNoticeDecision(deps.env, pin, authoritative).show) {
+                    stalePins.push({ relPath: found.relPath, pin });
+                }
+            }
+        }
+        catch {
+            // Pin diagnostics are advisory; the installed-runtime line still renders.
+        }
+        return { status: "known", latest, upgrade, stalePins };
+    }
+    catch {
+        return { status: "unavailable" };
+    }
+}
+/** The `Bridge MCP version` lines, or none when no diagnostic was collected. */
+export function formatDoctorVersionLines(diagnostic) {
+    if (!diagnostic)
+        return [];
+    if (diagnostic.status === "not-checked") {
+        return [`Bridge MCP version: installed ${VERSION}, latest: not checked`];
+    }
+    if (diagnostic.status === "unavailable") {
+        return [`Bridge MCP version: installed ${VERSION}, latest: unavailable`];
+    }
+    const lines = [`Bridge MCP version: installed ${VERSION}, latest ${diagnostic.latest}`];
+    if (diagnostic.upgrade)
+        lines.push(`  ${formatUpdateAdvice(VERSION, diagnostic.latest)}`);
+    // Stale project pins are subordinate to the runtime line above.
+    for (const { relPath, pin } of diagnostic.stalePins) {
+        lines.push(`  ${relPath} pin: ${formatUpdateAdvice(pin, diagnostic.latest)}`);
+    }
+    return lines;
+}
 /**
  * The BROAD report header: title plus the run's platform / agent / profile
  * metadata (BAPI-669, U9b). Split out from the prerequisite body so `runDoctorCli`
@@ -393,7 +473,10 @@ export async function collectDoctorResults(deps, agentName) {
  * ordering change is the whole point, and it must not require rewriting the
  * prerequisite formatting below.
  */
-export function buildDoctorReportHeader(platform, agent) {
+export function buildDoctorReportHeader(platform, agent, 
+// A DEFAULT value, not a plain optional marker, so the function's declared arity
+// stays two: the header takes no dependency seam and does no I/O.
+versionDiagnostic = undefined) {
     const activeGroups = Array.from(resolveProfiles(process.env.BRIDGE_MCP_PROFILE)).join(", ");
     return [
         DOCTOR_REPORT_TITLE,
@@ -404,6 +487,7 @@ export function buildDoctorReportHeader(platform, agent) {
         // never blank and never omitted. Neither line feeds launcher-pin drift,
         // which stays a `VERSION`-only comparison.
         `Package version: ${VERSION}`,
+        ...formatDoctorVersionLines(versionDiagnostic),
         `Build commit: ${BUILD_COMMIT}`,
         `Platform: ${platform}`,
         `Selected agent: ${agent.name} (command: ${agent.command})`,
@@ -1736,10 +1820,10 @@ export function formatBridgePermissionsDiagnosticReport(inspection) {
     else {
         lines.push(...formatPermissionScope("project permissions.allow", inspection.project));
     }
-    lines.push(...formatPermissionScope("user autoMode entries", inspection.user, "Optional: install adds them only after you say yes."));
+    lines.push(...formatPermissionScope("user autoMode entries", inspection.user, `Optional: /drive-epic-run offers to add them, or run \`npx -y ${MCP_PACKAGE_NAME} bridge-permissions\`.`));
     const healthy = inspection.project.state === "present" && inspection.user.state === "present";
     if (!healthy) {
-        lines.push(`  To repair: re-run \`npx -y ${MCP_PACKAGE_NAME} install\` in a terminal (it lists every rule it writes).`);
+        lines.push(`  To repair the project rules: re-run \`npx -y ${MCP_PACKAGE_NAME} install\` in a terminal (it lists every rule it writes).`);
         lines.push(`  To remove Bridge's entries: \`npx -y ${MCP_PACKAGE_NAME} install --remove-bridge-permissions\`.`);
     }
     lines.push(`  Bridge's ownership record: ${BRIDGE_PERMISSIONS_MANIFEST_RELPATH}. Advisory only; never changes the exit code.`);
@@ -1885,7 +1969,26 @@ export async function runDoctorCli(argv, overrides = {}) {
     // always-first is both simpler and equivalent. The `installStatus: false` override
     // remains a dependency-injection-only seam for hermetic tests; a normal CLI
     // invocation never takes it.
-    log(buildDoctorReportHeader(deps.platform, agent).join("\n"));
+    // BAPI-1446: the version diagnostic is advisory and read-only (fresh lookup, no
+    // cache read or write, no spawn). A failure leaves the header exactly as it was.
+    let versionDiagnostic;
+    if (overrides.version !== false && (overrides.deps === undefined || overrides.version?.checkLatest)) {
+        try {
+            const versionEnv = overrides.version?.env ?? deps.env;
+            versionDiagnostic = await collectVersionDiagnostic({
+                env: versionEnv,
+                cwd: overrides.version?.cwd ?? overrides.launcherProbe?.cwd ?? deps.cwd,
+                readFile: overrides.version?.readFile ??
+                    overrides.launcherProbe?.readFile ??
+                    ((p) => readFile(p, "utf-8")),
+                checkLatest: overrides.version?.checkLatest ?? createDoctorVersionChecker(versionEnv),
+            });
+        }
+        catch {
+            versionDiagnostic = undefined;
+        }
+    }
+    log(buildDoctorReportHeader(deps.platform, agent, versionDiagnostic).join("\n"));
     // Advisory install-status section (easy-install done criteria). Read-only GETs
     // only; any failure degrades to WARN/SKIP lines inside the section, and any
     // unexpected throw renders the sanitized fallback rather than dropping the