@bridge_gpt/mcp-server 0.2.67 → 0.2.68

package/build/conductor/install-doctor.js

@@ -36,7 +36,7 @@ import { buildConductorDoctorReport, formatConductorDoctorReport, } from "./doct
 import { inspectBridgeApiProfileToken, } from "../mcp-host-config.js";
 import { collectExecutorServiceDiagnostics, formatExecutorServiceDiagnosticsReport, } from "../doctor.js";
 import { collectInstallStatusChecks, formatInstallStatusReport, } from "../install-doctor.js";
-import { bringUpSafetySections, conductorHookTargetsSection, conductorLedgerLoadabilitySection, gitHubActionsMergeObservabilitySections, conductorProfileTokenSection, EPIC_IMPLEMENTER_PROFILE_TOKEN, detectConductorContext, executorObservationSection, executorProvisioningSection, executorServiceStateSection, githubActionsSection, mergeExecutionSections, githubCredentialsSection, inspectWorkflowPresence, reconcilerSection, supervisorSection, workflowSection, } from "./readiness-sections.js";
+import { bringUpSafetySections, conductorHookTargetsSection, conductorLedgerLoadabilitySection, gitHubActionsMergeObservabilitySections, conductorProfileTokenSection, effectiveReviewModeIsRepositoryPolicy, epicBranchCiSections, EPIC_IMPLEMENTER_PROFILE_TOKEN, detectConductorContext, executorObservationSection, executorProvisioningSection, executorServiceStateSection, githubActionsSection, mergeExecutionSections, githubCredentialsSection, inspectWorkflowPresence, reconcilerSection, supervisorSection, workflowSection, } from "./readiness-sections.js";
 import { ConductorBridgeApiError, fetchConductorReadiness, } from "./bridge-api-client.js";
 /**
  * Run one optional collector, containing any throw.
@@ -155,6 +155,11 @@ export async function runConductorInstallDoctor(deps) {
     }
     if (readiness) {
         sections.push(...supervisorSection(readiness));
+        // BAPI-1405 — the three warn-only epic-branch CI rows, beside the gate
+        // profile they qualify. Never fatal, so they cannot change the exit code or
+        // the installer's pre-write abort. An older server renders them as
+        // "Unreported — upgrade the server", never as "no warning".
+        sections.push(...epicBranchCiSections(readiness.epic_branch_ci));
         sections.push(githubCredentialsSection(readiness));
         sections.push(githubActionsSection(readiness));
         // BAPI-1135 — the shared "Merge execution eligibility" section, immediately
@@ -166,7 +171,12 @@ export async function runConductorInstallDoctor(deps) {
         sections.push(...mergeExecutionSections(readiness));
     }
     const workflow = await inspectWorkflowPresence(deps.readWorkflowFile, deps.classifyWorkflowDrift);
-    sections.push(workflowSection(workflow.presence, deps.reviewPolicySource, workflow.driftDetail));
+    // BAPI-1405 — when the server says the effective review mode is
+    // `repository_policy`, no review verdict is consumed, so the workflow row
+    // reports not-applicable instead of nagging. An older server keeps the
+    // caller's source exactly as before.
+    const effectiveReviewPolicySource = effectiveReviewModeIsRepositoryPolicy(readiness) ? "repository_policy" : deps.reviewPolicySource;
+    sections.push(workflowSection(workflow.presence, effectiveReviewPolicySource, workflow.driftDetail));
     if (readiness) {
         // BAPI-1153 — the "Bring-up safety" group, ahead of the repository-scoped
         // reconciler/executor story: these three decide whether a plane can drive a
@@ -357,6 +367,8 @@ mergeExecutionSections, databaseMigrationCurrentSection, singleTransitionAuthori
 // BAPI-1135 — both new section builders join the compatibility surface like
 // every other one, so an existing importer of this module does not learn a
 // second import path for them.
-gitHubActionsMergeObservabilitySections, } from "./readiness-sections.js";
+gitHubActionsMergeObservabilitySections, 
+// BAPI-1405 — the epic-branch CI rows and their shared copy.
+epicBranchCiSections, EPIC_BRANCH_CI_RERUN_INSTALL_ADVICE, EPIC_BRANCH_CI_SECTION_IDS, EPIC_BRANCH_CI_SECTION_LABELS, EPIC_BRANCH_CI_UNREPORTED_DETAIL, } from "./readiness-sections.js";
 // BAPI-1153 — the bring-up remediations the three sections above render.
 export { BRING_UP_RUNBOOK, BRING_UP_UNREPORTED_REMEDIATION, DATABASE_MIGRATION_BEHIND_REMEDIATION, DATABASE_MIGRATION_UNREADABLE_REMEDIATION, SECOND_RECONCILER_REMEDIATION, WORKER_HEARTBEAT_UNREADABLE_REMEDIATION, WORKER_NOT_PRESENT_REMEDIATION, } from "./bring-up-facts.js";

package/build/conductor/json-output.js

@@ -0,0 +1,63 @@
+/**
+ * Complete `--json` output for CLI commands (BAPI-1397, F3).
+ *
+ * The CLI ends through `process.exit(cliExitCode)` in `index.ts` as soon as a
+ * command returns its exit code. On macOS a piped stdout is asynchronous, so a
+ * large document written with `console.log` could still be queued when the
+ * process exited — a 72 KB `epic-status --json` reached its reader truncated.
+ *
+ * {@link writeJsonDocument} prints the already-serialized document through the
+ * same sink as before (so its bytes and the tests that capture `console.log` are
+ * unchanged) and then waits until stdout has handed every queued byte to the
+ * operating system before the command returns. It never changes a payload.
+ */
+/**
+ * Wait until `stream` has flushed everything written to it so far.
+ *
+ * A writable stream completes writes in order, so the callback of a zero-length
+ * write runs only after every earlier write has completed. Resolves `true` once
+ * flushed and `false` when the stream reports an error (for example a reader
+ * that closed the pipe). Never throws and never leaves an `error` listener
+ * behind, so a closed pipe cannot become an uncaught exception.
+ */
+export function flushOutputStream(stream) {
+    return new Promise((resolve) => {
+        let settled = false;
+        const finish = (ok) => {
+            if (settled)
+                return;
+            settled = true;
+            stream.removeListener("error", onError);
+            resolve(ok);
+        };
+        const onError = () => finish(false);
+        stream.once("error", onError);
+        try {
+            stream.write("", (error) => finish(!error));
+        }
+        catch {
+            finish(false);
+        }
+    });
+}
+/** Flush the real process stdout. */
+export function flushProcessStdout() {
+    return flushOutputStream(process.stdout);
+}
+/**
+ * Print one already-serialized JSON document and wait for stdout to drain.
+ *
+ * Resolves `true` when the whole document was handed to the operating system,
+ * `false` when the output could not complete. The text is printed exactly as
+ * given, so no command's JSON shape changes.
+ */
+export async function writeJsonDocument(serialized, deps = {}) {
+    const log = deps.log ?? ((line) => console.log(line));
+    try {
+        log(serialized);
+    }
+    catch {
+        return false;
+    }
+    return (deps.flush ?? flushProcessStdout)();
+}

package/build/conductor/readiness-cli.js

@@ -35,7 +35,9 @@
 import os from "node:os";
 import { readFile as fsReadFile, stat as fsStat } from "node:fs/promises";
 import { collectConductorReadinessGate, formatConductorReadinessGateReport, } from "./readiness.js";
-import { readinessEndpointEnvironments, resolveConductorBridgeApiAccess, resolveEpicLaunchBridgeApiAccess } from "./bridge-api-client.js";
+import { fetchEffectiveSupervisorSetup, readinessEndpointEnvironments, resolveConductorBridgeApiAccess, resolveEpicLaunchBridgeApiAccess, } from "./bridge-api-client.js";
+import { createCommandDriftInspector } from "./command-drift-production.js";
+import { flushProcessStdout, writeJsonDocument } from "./json-output.js";
 import { validateHttpBaseUrl } from "../base-url.js";
 import { claudeReviewWorkflowPath } from "../claude-review-workflow.js";
 import { runDefaultPlanePreflight } from "../plane/cli.js";
@@ -46,13 +48,18 @@ export const READINESS_COLLECTION_NOTICE = "one or more readiness sources could
 /** Usage text for `epic-implementer readiness`. */
 export function getReadinessUsage() {
     return [
-        "Usage: epic-implementer readiness [--json] [--no-deny-probe] [--base-url <url>]",
+        "Usage: epic-implementer readiness [--json] [--no-deny-probe] [--base-url <url>] [--epic-run-id <id>]",
         "",
         "Read-only ADVISORY report of every conductor prerequisite, consolidated from the",
         "Bridge install checklist, the epic-implementer doctor, the plane preflight, and the",
         "server conductor-readiness collector. Each prerequisite reports pass/warn/fail/skip",
         "and, on a failure, exactly ONE named remediation.",
         "",
+        "The claude-review workflow row is assessed for a NEW feature-branch run's first",
+        "approval: it is not applicable only when the server confirms no repository review",
+        "default is set. If that cannot be confirmed the row stays required. This report is",
+        "not a prediction or an authorization of any particular run.",
+        "",
         "Remediations are NOT run automatically. This command changes nothing: it starts no",
         "plane, approves no run, writes no file, and always exits 0 — `drive-epic` remains",
         "the only route-selection gate and the server-side admission the only hard refusal.",
@@ -63,6 +70,9 @@ export function getReadinessUsage() {
         "                    this command never spawns the deny-enforcement probe",
         "  --base-url <url>  Select a read-only Bridge API endpoint for this report;",
         "                    this does not authorize or supply a credential",
+        "  --epic-run-id <id>",
+        "                    The epic run being attached. When the live plane is bound to",
+        "                    this run, its port and manifest rows pass with reason own_plane",
         "  --help            Print this usage message",
     ].join("\n");
 }
@@ -86,11 +96,64 @@ export function parseReadinessArgs(argv) {
                 return { error: "--base-url requires a valid HTTP(S) URL." };
             parsed.baseUrl = valid.baseUrl;
         }
+        else if (token === "--epic-run-id") {
+            const raw = argv[++index];
+            if (!raw || raw.startsWith("--") || raw.trim() === "") {
+                return { error: "--epic-run-id requires an epic run id." };
+            }
+            parsed.epicRunId = raw.trim();
+        }
         else
             return { error: `Unknown argument "${token}". Run "epic-implementer readiness --help" for usage.` };
     }
     return parsed;
 }
+const KNOWN_REVIEW_POLICY_SOURCES = [
+    "verdict_protocol",
+    "native_review_decision",
+    "none",
+    "repository_policy",
+];
+/**
+ * Choose the review-policy source the workflow row is judged under (BAPI-1406).
+ *
+ * `repository_policy` is selected ONLY when a successful, parseable response
+ * explicitly confirms the repository's effective review default is unset: the
+ * `review_policy` key is present and `null`. A stored default is respected, and
+ * an unknown or missing source falls back to `verdict_protocol`. Every other
+ * outcome — no access, a read failure, a malformed body, a missing key (an older
+ * server), an unrecognised value — returns `verdict_protocol`, so the workflow
+ * row stays required rather than falsely healthy.
+ *
+ * Read-only: one GET through the existing supervisor-setup client. This answers
+ * "what would a new feature-branch run's first approval resolve to", which is a
+ * prospective assessment and not a prediction or authorization of any run.
+ */
+export async function resolveReadinessReviewPolicySource(access, fetchImpl) {
+    if (access === null)
+        return "verdict_protocol";
+    try {
+        const setup = await fetchEffectiveSupervisorSetup(access, undefined, fetchImpl);
+        if (typeof setup !== "object" || setup === null || Array.isArray(setup)) {
+            return "verdict_protocol";
+        }
+        const record = setup;
+        if (!Object.prototype.hasOwnProperty.call(record, "review_policy")) {
+            return "verdict_protocol";
+        }
+        const reviewPolicy = record.review_policy;
+        if (reviewPolicy === null)
+            return "repository_policy";
+        if (typeof reviewPolicy !== "object" || Array.isArray(reviewPolicy)) {
+            return "verdict_protocol";
+        }
+        const source = reviewPolicy.source;
+        return KNOWN_REVIEW_POLICY_SOURCES.find((known) => known === source) ?? "verdict_protocol";
+    }
+    catch {
+        return "verdict_protocol";
+    }
+}
 /**
  * Build the production report for `repoRoot`.
  *
@@ -98,7 +161,7 @@ export function parseReadinessArgs(argv) {
  * epic-implementer doctor's local inspections, and the same plane preflight
  * `plane up` and `drive-epic` run. Nothing is re-implemented here.
  */
-async function collectProductionReport(repoRoot, env, baseUrl) {
+async function collectProductionReport(repoRoot, env, baseUrl, epicRunId) {
     const { reportEnv, resolverEnv } = readinessEndpointEnvironments(env, baseUrl);
     const accessResult = baseUrl === undefined
         ? await resolveConductorBridgeApiAccess({ env: reportEnv, cwd: repoRoot })
@@ -117,6 +180,7 @@ async function collectProductionReport(repoRoot, env, baseUrl) {
         });
     }
     const access = accessResult.ok ? accessResult.access : null;
+    const reviewPolicySource = await resolveReadinessReviewPolicySource(access);
     return collectConductorReadinessGate({
         // Never guessed: an unresolved identity is reported as such rather than
         // invented, and the repository ROOT is never placed in the report at all.
@@ -125,10 +189,11 @@ async function collectProductionReport(repoRoot, env, baseUrl) {
             access,
             accessError: accessResult.ok ? undefined : accessResult.error,
             fetch: (...args) => fetch(...args),
-            // The consolidated gate reports workflow presence as a fact; it selects no
-            // per-run review policy, so applicability is evaluated under the policy
-            // that always consumes the workflow's verdict.
-            reviewPolicySource: "verdict_protocol",
+            // BAPI-1406: the workflow row is judged under the review default the
+            // server CONFIRMS for a new feature-branch run's first approval, and under
+            // `verdict_protocol` whenever that cannot be established. This is a
+            // prospective assessment, not a prediction or authorization of any run.
+            reviewPolicySource,
             readWorkflowFile: () => fsReadFile(claudeReviewWorkflowPath(repoRoot), "utf-8"),
             projectRoot: repoRoot,
             installDoctorDeps: {
@@ -143,12 +208,19 @@ async function collectProductionReport(repoRoot, env, baseUrl) {
         },
         // The deny-enforcement probe is never spawned from this command; the check
         // is reported as an explicit skip naming `epic-implementer doctor` instead.
-        conductorDoctorDeps: { env: reportEnv, skipDenyProbe: true },
+        conductorDoctorDeps: {
+            env: reportEnv,
+            skipDenyProbe: true,
+            // BAPI-1392: read-only, warn-only committed-command drift row.
+            inspectCommandDrift: createCommandDriftInspector({ env: reportEnv, cwd: repoRoot }),
+        },
         // Provided ONLY for a target that names the local plane; otherwise the rows
         // are skipped without any probe.
         ...(planeNotApplicable === null
             ? {
                 runPlanePreflight: () => runDefaultPlanePreflight(repoRoot, reportEnv),
+                // BAPI-1397 (F4): only for an applicable local plane.
+                ...(epicRunId !== undefined ? { epicRunId } : {}),
             }
             : { planeNotApplicable }),
     });
@@ -175,7 +247,8 @@ export async function runConductorReadinessCommand(argv, deps = {}) {
     }
     const cwd = deps.cwd ?? process.cwd();
     const env = deps.env ?? process.env;
-    const collect = deps.collect ?? ((repoRoot) => collectProductionReport(repoRoot, env, parsed.baseUrl));
+    const collect = deps.collect ??
+        ((repoRoot) => collectProductionReport(repoRoot, env, parsed.baseUrl, parsed.epicRunId));
     const report = await collect(cwd);
     // Fixed, sanitized, and stderr-only: never a credential, exception, header,
     // body, subprocess output, or absolute path. It fires on a COLLECTION gap,
@@ -183,7 +256,19 @@ export async function runConductorReadinessCommand(argv, deps = {}) {
     // every time an ordinary check fails teaches operators to ignore it.
     if (report.unavailableSources.length > 0)
         sinks.stderr(READINESS_COLLECTION_NOTICE);
-    sinks.stdout(parsed.json ? JSON.stringify(report) : formatConductorReadinessGateReport(report));
+    if (parsed.json) {
+        // BAPI-1397 (F3): the document goes through the shared CLI writer, which waits
+        // for a piped stdout to drain. An injected sink is the caller's own boundary,
+        // so only the production stdout is flushed. Output completion never becomes a
+        // readiness verdict and never changes the advisory exit code.
+        await writeJsonDocument(JSON.stringify(report), {
+            log: sinks.stdout,
+            flush: deps.sinks ? async () => true : flushProcessStdout,
+        });
+    }
+    else {
+        sinks.stdout(formatConductorReadinessGateReport(report));
+    }
     // Advisory: the exit code is a constant, never derived from a check status.
     return 0;
 }