@bridge_gpt/mcp-server 0.2.62 → 0.2.66

package/build/doctor.js

@@ -24,8 +24,9 @@ import { spawn } from "child_process";
 import os from "os";
 import path from "path";
 import { createDefaultStartTicketsDeps } from "./start-tickets.js";
+import { defaultNpmEntryFileExists, resolveNpmEntry } from "./windows-npm-entry.js";
 import { VERSION, BUILD_COMMIT } from "./version.generated.js";
-import { collectInstallStatusChecks, formatInstallStatusReport, formatInstallStatusFallbackReport, resolveInstallDoctorTarget, } from "./install-doctor.js";
+import { collectInstallStatusChecks, collectProjectIdentityAndRoot, formatInstallStatusReport, formatInstallStatusFallbackReport, formatProjectIdentityAndRootFallbackReport, formatProjectIdentityAndRootReport, resolveInstallDoctorTarget, } from "./install-doctor.js";
 import { codexHome, inspectBridgeCodexProfile } from "./codex-bridge-profile.js";
 import { resolveRoutingHost } from "./model-routing-host.js";
 import { modelRoutingPreferencesPath, readModelRoutingPreference } from "./model-routing-preferences.js";
@@ -34,9 +35,10 @@ import { resolveExecutorAgentAdapter } from "./agent-launchers/executor-adapter-
 import { parseDefaultOnEnvFlag } from "./env-flags.js";
 import { createBridgeApiUrls } from "./bridge-api-urls.js";
 import { probeToolSurface } from "./tool-surface-gating.js";
-import { readStoredBinding, resolveBapiCredentials } from "./credential-store.js";
-import { listEpicLaunchProfiles } from "./epic-launch-profile.js";
-import { resolveConductorBridgeApiAccess } from "./conductor/bridge-api-client.js";
+import { readStoredBindingState, resolveBapiCredentials } from "./credential-store.js";
+import { EPIC_LAUNCH_PROFILE_NAME_PATTERN, listEpicLaunchProfiles } from "./epic-launch-profile.js";
+import { CONDUCTOR_DEFAULT_BASE_URL, resolveConductorBridgeApiAccess } from "./conductor/bridge-api-client.js";
+import { validateHttpBaseUrl } from "./base-url.js";
 import { getLiveRepositoryConductors, getParseDispatcherHealth, } from "./epic-shared/bridge-client.js";
 import { resolveRequiredStartTicketsRepoName } from "./start-tickets-repo.js";
 import { collectWorkerContainmentDiagnostic, formatWorkerContainmentDiagnosticReport, } from "./worker-containment-diagnostic.js";
@@ -87,6 +89,12 @@ export function getDoctorUsage() {
         "bootstrap-field completeness, integration credentials, and repository-indexing",
         "state. It performs read-only GETs only and never affects the exit code.",
         "",
+        "Next comes an advisory 'Project identity and root' section (BAPI-1318): whether",
+        "each BAPI_PROJECT_ROOT (from the environment and the project MCP configs) names",
+        "a real project folder the server will use, and whether .bridge/config's",
+        "repo_name matches each project MCP config's BAPI_REPO_NAME. It only reads",
+        "files and never affects the exit code.",
+        "",
         "After that come the start-tickets prerequisite checks (for the current OS):",
         "the start-tickets preflight prerequisites plus",
         "uv, the selected agent's command, Bridge API credential resolution, and",
@@ -540,10 +548,25 @@ export function parseLauncherPin(args) {
  * spawn error, or timeout is classified `indeterminate` (never silently "warm").
  * `--no-install` guarantees the probe never downloads/warms the bucket.
  */
-function probeNpxNoInstallDefault(spec) {
+export function probeNpxNoInstallDefault(spec, options = {}) {
+    const doSpawn = options.spawn ?? spawn;
     return new Promise((resolve) => {
+        // WINDOWS (BAPI-1319): a bare `npx` is ENOENT without a shell, so the probe
+        // always read "indeterminate". Map it to npm's `npx-cli.js` through Node;
+        // `--no-install` is kept, so doctor still can never warm the cache. Other
+        // platforms pass through unchanged.
+        const resolved = resolveNpmEntry("npx", ["--no-install", spec, "--version"], {
+            platform: options.platform ?? process.platform,
+            env: options.env ?? process.env,
+            execPath: options.execPath ?? process.execPath,
+            fileExists: options.fileExists ?? defaultNpmEntryFileExists,
+        });
+        if (resolved.status !== "resolved") {
+            resolve({ warmed: false, indeterminate: true });
+            return;
+        }
         try {
-            const child = spawn("npx", ["--no-install", spec, "--version"], {
+            const child = doSpawn(resolved.command, resolved.args, {
                 shell: false,
                 stdio: "ignore",
                 timeout: 30_000,
@@ -1559,6 +1582,47 @@ export async function collectOperationalAdvisories(deps) {
         legacyDriveHelpers,
     };
 }
+/**
+ * BAPI-1299 — the "Automation queue" advisory line, from the `automation_queue`
+ * block of the same health GET. Queued reviews, plans, and docs wait for the
+ * background worker; this line says whether they are being drained.
+ *
+ * Only an `undrained` verdict WARNs. An old queue with a fresh running-job
+ * heartbeat is a busy worker, reported OK with its backlog. Anything the server
+ * did not positively observe — no credential, a failed read, an older server
+ * with no block, an unreadable block — is SKIP, never OK. Advisory only.
+ */
+export function formatAutomationQueueAdvisory(dispatcher) {
+    if (dispatcher === null) {
+        return "  SKIP     Automation queue: not checked (no Bridge credential resolved).";
+    }
+    const queue = dispatcher.automationQueue ?? null;
+    if (queue === null) {
+        return ("  SKIP     Automation queue: unavailable — the health read carried no queue block\n" +
+            "           (the read failed, or the server predates this check).");
+    }
+    if (queue.status === "unreadable" || queue.verdict === "unknown") {
+        return ("  SKIP     Automation queue: unreadable — the server could not read the queue.\n" +
+            "           This is not evidence that the queue is stuck.");
+    }
+    const count = queue.queuedCount ?? 0;
+    const age = queue.oldestQueuedAgeSeconds;
+    const backlog = age === null ? `${count} queued` : `${count} queued, oldest waiting ${age}s`;
+    if (queue.verdict === "undrained") {
+        return (`  WARN     Automation queue: ${backlog}, and no running job shows a fresh heartbeat.\n` +
+            "           Queued reviews, plans, and docs wait for the background worker. Check that\n" +
+            "           `python worker.py` (the `worker:` dyno) is running and DISABLE_SCHEDULER is\n" +
+            "           not true on it. The jobs have not failed; they will run once it drains.");
+    }
+    if (queue.verdict === "working_backlog") {
+        return (`  OK       Automation queue: ${backlog} — the worker is busy (running jobs are\n` +
+            "           heartbeating), so this is a working backlog, not a stopped worker.");
+    }
+    if (count === 0) {
+        return "  OK       Automation queue: nothing queued.";
+    }
+    return `  OK       Automation queue: ${backlog} — within the normal wait.`;
+}
 /** Render the operational-advisories section. Advisory: never changes the exit code. */
 export function formatOperationalAdvisoryReport(diagnostic) {
     const lines = ["", "operational advisories (advisory)"];
@@ -1577,6 +1641,7 @@ export function formatOperationalAdvisoryReport(diagnostic) {
         lines.push("  SKIP     Parse dispatcher: unavailable — the liveness read produced no verdict.\n" +
             "           This is not evidence that no dispatcher is running.");
     }
+    lines.push(formatAutomationQueueAdvisory(dispatcher));
     if (diagnostic.conductorObservation === "unavailable") {
         lines.push("  SKIP     Concurrent conductors: unavailable — the repository-scoped read produced\n" +
             "           no verdict.");
@@ -1620,12 +1685,20 @@ export function formatOperationalAdvisoryReport(diagnostic) {
  * migrates anything.
  */
 export async function collectEpicLaunchProfileDiagnostic(deps) {
+    const selectedName = deps.env.BAPI_EPIC_LAUNCH_PROFILE?.trim();
+    const selected = selectedName
+        ? EPIC_LAUNCH_PROFILE_NAME_PATTERN.test(selectedName)
+            ? { name: selectedName, status: "missing" }
+            : { name: "<invalid>", status: "invalid" }
+        : undefined;
     const listing = await listEpicLaunchProfiles(deps);
     if (!listing.ok)
-        return { store: "unreadable", message: listing.message };
+        return { store: "unreadable", message: listing.message, ...(selected ? { selected } : {}) };
     if (!listing.present)
-        return { store: "absent" };
+        return { store: "absent", ...(selected ? { selected: { ...selected, status: selected.status === "invalid" ? "invalid" : "missing" } } : {}) };
     const host = deps.hostname();
+    const production = validateHttpBaseUrl(CONDUCTOR_DEFAULT_BASE_URL);
+    const productionBaseUrl = production.ok ? production.baseUrl : null;
     const profiles = [];
     for (const entry of listing.entries) {
         if (!entry.validation.ok) {
@@ -1633,22 +1706,32 @@ export async function collectEpicLaunchProfileDiagnostic(deps) {
             continue;
         }
         const p = entry.validation.profile;
-        const bound = await readStoredBinding(p.credentialRef.target, {
+        const binding = await readStoredBindingState(p.credentialRef.target, {
             env: deps.env,
             homedir: deps.homedir,
             platform: process.platform,
             readFile: deps.readFile,
-            // Presence probe via read: the binding reader treats any failure as unbound.
+            // Presence probe via read: an unreadable store is reported as unbound.
             stat: async (filePath) => {
                 await deps.readFile(filePath);
                 return { mode: 0o600 };
             },
         });
         const hostMatches = p.host === host;
-        const credentialBinding = bound === null ? "unbound" : bound === p.baseUrl ? "matches" : "different";
+        // Only a genuinely ABSENT binding field is accepted at production; a
+        // present-but-empty field is a broken binding, reported as different.
+        const credentialBinding = binding.state === "bound"
+            ? binding.baseUrl === p.baseUrl
+                ? "matches"
+                : "different"
+            : binding.state === "invalid"
+                ? "different"
+                : binding.state === "absent" && productionBaseUrl !== null && p.baseUrl === productionBaseUrl
+                    ? "production-default"
+                    : "unbound";
         profiles.push({
             name: p.name,
-            usable: hostMatches && credentialBinding === "matches",
+            usable: hostMatches && (credentialBinding === "matches" || credentialBinding === "production-default"),
             target: p.baseUrl,
             repo: p.repoName,
             mode: p.executionMode,
@@ -1656,13 +1739,33 @@ export async function collectEpicLaunchProfileDiagnostic(deps) {
             credentialBinding,
         });
     }
-    return { store: "present", profiles };
+    const selectedProfile = selected?.status !== "invalid" ? profiles.find((p) => p.name === selected?.name) : undefined;
+    return {
+        store: "present",
+        profiles,
+        ...(selected ? { selected: { name: selected.name, status: selected.status === "invalid" ? "invalid" : !selectedProfile ? "missing" : selectedProfile.usable ? "usable" : "unusable" } } : {}),
+    };
 }
-/** Render the section, or `null` when this host has no profile store. */
+/**
+ * BAPI-1272 — a target-selection fact, shown whether or not a profile store
+ * exists. It says nothing about credentials or readiness.
+ */
+export const EPIC_LAUNCH_DEFAULT_TARGET_LINE = `  [info] drive-epic with no profile, --base-url, or BAPI_BASE_URL targets production ` +
+    `(${CONDUCTOR_DEFAULT_BASE_URL}); production needs no profile.`;
+/**
+ * Render the section. With no profile store it holds only the default-target
+ * line (BAPI-1272) — the common production case.
+ */
 export function formatEpicLaunchProfileDiagnosticReport(diagnostic) {
+    const lines = ["", "Epic launch profiles (read-only)", "", EPIC_LAUNCH_DEFAULT_TARGET_LINE];
+    if (diagnostic.selected) {
+        const { name, status } = diagnostic.selected;
+        lines.push(`  [${status === "usable" ? "ok" : "fail"}] BAPI_EPIC_LAUNCH_PROFILE selects ${name}: ${status}.`);
+        if (status !== "usable")
+            lines.push("         Epic launch will refuse this selection; inspect the local profile and credential binding.");
+    }
     if (diagnostic.store === "absent")
-        return null;
-    const lines = ["", "Epic launch profiles (read-only)", ""];
+        return lines.join("\n");
     if (diagnostic.store === "unreadable") {
         lines.push(`  [warn] ${diagnostic.message}`);
         return lines.join("\n");
@@ -1684,6 +1787,9 @@ export function formatEpicLaunchProfileDiagnosticReport(diagnostic) {
         else if (p.credentialBinding === "different") {
             lines.push("         stored credential is approved for a DIFFERENT target — a launch will refuse to send it.");
         }
+        else if (p.credentialBinding === "production-default") {
+            lines.push("         stored credential is unbound, which production accepts — no binding is needed.");
+        }
     }
     return lines.join("\n");
 }
@@ -1705,8 +1811,8 @@ export async function runDoctorCli(argv, overrides = {}) {
     const agent = resolveAgentSpec(parsed.options.agentName) ?? resolveAgentSpec(DEFAULT_AGENT_NAME);
     const collection = await collectDoctorResults(deps, parsed.options.agentName);
     // ---- Section order (BAPI-669, U9c) ----
-    // Broad header → Install status → start-tickets prerequisites → launcher cache →
-    // MCP tool surface. Install status renders FIRST and UNCONDITIONALLY: it answers
+    // Broad header → Install status → Project identity and root (BAPI-1318) →
+    // start-tickets prerequisites → launcher cache → MCP tool surface. Install status renders FIRST and UNCONDITIONALLY: it answers
     // "is this project actually set up?", which is what someone running `doctor` after
     // an install is asking. There is deliberately no "invocation context" flag to gate
     // the ordering on — the report has a single caller and carries no context, so
@@ -1742,6 +1848,27 @@ export async function runDoctorCli(argv, overrides = {}) {
             log(formatInstallStatusFallbackReport());
         }
     }
+    // Advisory "Project identity and root" section (BAPI-1318). Read-only: it
+    // validates each explicit BAPI_PROJECT_ROOT the way the server does and
+    // compares .bridge/config's repo_name with each project MCP config. Placed
+    // right after Install status without reordering any existing section; a throw
+    // renders a sanitized line, and the exit code is never affected.
+    if (overrides.projectIdentity !== false) {
+        try {
+            const injectedFs = deps;
+            const identityDeps = {
+                env: overrides.projectIdentity?.env ?? deps.env,
+                cwd: overrides.projectIdentity?.cwd ?? deps.cwd,
+                readFile: overrides.projectIdentity?.readFile ?? injectedFs.readFile ?? ((p) => readFile(p, "utf-8")),
+                statDir: overrides.projectIdentity?.statDir ?? ((p) => stat(p)),
+            };
+            const collect = overrides.projectIdentity?.collect ?? collectProjectIdentityAndRoot;
+            log(formatProjectIdentityAndRootReport(await collect(identityDeps)));
+        }
+        catch {
+            log(formatProjectIdentityAndRootFallbackReport());
+        }
+    }
     if (parsed.options.agentName === "codex") {
         const readCodexFile = deps.readFile ?? ((p) => readFile(p, "utf-8"));
         const profile = await inspectBridgeCodexProfile(codexHome(deps.env), readCodexFile);
@@ -1816,7 +1943,7 @@ export async function runDoctorCli(argv, overrides = {}) {
         const launcherDeps = {
             cwd: overrides.launcherProbe?.cwd ?? deps.cwd,
             readFile: overrides.launcherProbe?.readFile ?? ((p) => readFile(p, "utf-8")),
-            probeNpxNoInstall: overrides.launcherProbe?.probeNpxNoInstall ?? probeNpxNoInstallDefault,
+            probeNpxNoInstall: overrides.launcherProbe?.probeNpxNoInstall ?? ((spec) => probeNpxNoInstallDefault(spec)),
         };
         const launcherInspections = await inspectLauncherCache(launcherDeps);
         log(formatLauncherCacheReport(launcherInspections));
@@ -2000,8 +2127,7 @@ export async function runDoctorCli(argv, overrides = {}) {
                     ((p) => readFile(p, "utf-8")),
                 hostname: overrides.launchProfiles?.hostname ?? os.hostname,
             }));
-            if (report !== null)
-                log(report);
+            log(report);
         }
         catch {
             /* advisory only: an unexpected failure drops the section, never the doctor */

package/build/drive-epic-key.js

@@ -0,0 +1,12 @@
+/**
+ * BAPI-1285: the one epic-key pattern `drive-epic` and plan discovery share.
+ *
+ * It lives in its own module so `plan-discovery.ts` can import it without
+ * importing `drive-epic.ts`, which imports discovery — a cycle.
+ *
+ * This is deliberately the narrower CLI grammar. Bundle finalization accepts some
+ * underscore or digit project prefixes, but `drive-epic` already rejects them, so
+ * metadata naming such a key can never be discovered through this CLI.
+ */
+/** Jira epic key shape. Matches the epic-key positional rule exactly. */
+export const EPIC_KEY_PATTERN = /^[A-Z]+-[0-9]+$/;