@bridge_gpt/mcp-server 0.2.62 → 0.2.65

package/build/conductor/hook-runtime-qualification.js

@@ -0,0 +1,340 @@
+/**
+ * Read-only qualification of the runtime a managed conductor Git hook launches
+ * (BAPI-1290).
+ *
+ * BAPI-772 made the hook installer refuse a binary that does not EXIST. That is
+ * not enough for a hook's lifetime: a hook embeds one absolute path and runs it on
+ * every commit for as long as the hook file lives. When that path sits inside the
+ * `npx` cache (`~/.npm/_npx/<hash>/…`), ordinary cache cleanup deletes it and every
+ * later commit silently delivers nothing — the hook body is detached, discards its
+ * output, and ends in `|| true` by design.
+ *
+ * This module answers one question for both installation and diagnostics, so the
+ * two can never disagree: "is this entry a stable, package-owned invocation that
+ * the hook's `node` can actually run, including the native ledger binding?" The
+ * answer is evidence-based:
+ *
+ *   1. the canonical entry is a regular `build/epic-implementer-bin.js`;
+ *   2. it is not inside a prunable `_npx` cache directory;
+ *   3. it lives in the supported persistent npm layout
+ *      (`<prefix>/node_modules/@bridge_gpt/mcp-server/build/…`);
+ *   4. the adjacent `package.json` names this package, maps the
+ *      `epic-implementer` bin to that entry, and carries a compatible version;
+ *   5. the platform is a qualified one (macOS or Linux);
+ *   6. a bounded subprocess — `node` from PATH, exactly what the hook runs —
+ *      executes the entry's private runtime probe and reports a qualified Node
+ *      line and a loadable `better-sqlite3`.
+ *
+ * Anything missing, malformed, or inconclusive is UNAVAILABLE, never healthy. The
+ * failure carries only a fixed classification and a fixed action sentence: no
+ * probed path, no subprocess stderr, no caught exception text.
+ *
+ * Deliberately NOT here: running npm, downloading or installing anything, opening
+ * or migrating the ledger, or starting a service. The one subprocess is the
+ * bounded runtime probe, which only imports the native binding.
+ */
+import { spawnSync } from "node:child_process";
+import { readFileSync, realpathSync, statSync } from "node:fs";
+import { basename, dirname, join } from "node:path";
+import { MCP_PACKAGE_NAME } from "../mcp-identity.js";
+import { isTransientNpxEntryPath } from "../mcp-server-invocation.js";
+/** The bin name the package maps to the hook entry. */
+export const HOOK_RUNTIME_BIN_NAME = "epic-implementer";
+/** The entry file every managed hook invokes. */
+export const HOOK_RUNTIME_ENTRY_FILENAME = "epic-implementer-bin.js";
+/** The private CLI action the bounded runtime probe runs. Never advertised. */
+export const HOOK_RUNTIME_PROBE_ACTION = "__hook-runtime-probe";
+/** Marker the probe prints so a stray line on stdout can never be mistaken for evidence. */
+export const HOOK_RUNTIME_PROBE_MARKER = "bapi-hook-runtime-probe/1";
+/**
+ * Platforms whose hook shell grammar and persistent npm layout are qualified.
+ * Windows Git hooks run under a different shell/runtime and are unqualified.
+ */
+export const HOOK_RUNTIME_QUALIFIED_PLATFORMS = ["darwin", "linux"];
+/**
+ * The lowest Node major line accepted for durable hooks. Only even (LTS) majors
+ * at or above it qualify; odd "current" lines are unqualified because they have a
+ * short support window and a native ABI that changes under the operator.
+ */
+export const HOOK_RUNTIME_MIN_NODE_MAJOR = 20;
+/**
+ * Compatible package versions: the `0.x` line from `0.2.0` onward. Every such
+ * release ships the renamed `epic-implementer-bin.js` entry and the
+ * `git-hook post-commit` / `git-hook reference-transaction` grammar the managed
+ * hook invokes, so an in-place upgrade inside this range keeps the hook valid
+ * without rewriting it. A `1.x` release must be requalified before it is added.
+ */
+export const HOOK_RUNTIME_COMPATIBLE_RANGE = ">=0.2.0 <1.0.0";
+/** Bounded wall-clock for the runtime probe subprocess. */
+export const HOOK_RUNTIME_PROBE_TIMEOUT_MS = 15_000;
+/** Upper bound on probe output read back; anything larger is malformed. */
+const HOOK_RUNTIME_PROBE_MAX_BUFFER = 16 * 1024;
+/** Every classification, for exhaustive rendering and tests. */
+export const HOOK_RUNTIME_CLASSIFICATIONS = [
+    "ephemeral-cache",
+    "missing",
+    "legacy-name",
+    "unqualified-runtime",
+    "node-unavailable",
+    "native-unavailable",
+    "unknown",
+];
+/** Fixed, path-free operator action for each classification. */
+export const HOOK_RUNTIME_ACTIONS = {
+    "ephemeral-cache": "the hook runtime is inside the npx cache, which cleanup can delete. Install the CLI " +
+        `persistently (\`npm i -g ${MCP_PACKAGE_NAME}\`) and re-run \`epic-implementer install-git-hooks\`.`,
+    missing: "the hook runtime entry is not present. Reinstall the CLI persistently " +
+        `(\`npm i -g ${MCP_PACKAGE_NAME}\`) and re-run \`epic-implementer install-git-hooks\`.`,
+    "legacy-name": "the hook invokes the retired conductor-bin.js entry. Re-run `epic-implementer install-git-hooks` " +
+        "from a persistent install.",
+    "unqualified-runtime": "the hook runtime is not a qualified persistent installation (supported: a persistent npm " +
+        `install of ${MCP_PACKAGE_NAME} ${HOOK_RUNTIME_COMPATIBLE_RANGE} on macOS or Linux with an even ` +
+        `Node LTS line >= ${HOOK_RUNTIME_MIN_NODE_MAJOR}). See mcp_server/docs/CONDUCTOR.md.`,
+    "node-unavailable": "`node` could not be launched from PATH, so the hook cannot run. Put a qualified Node on PATH " +
+        "and re-run `epic-implementer doctor`.",
+    "native-unavailable": "better-sqlite3 does not load for the hook's Node, so no event can be recorded. Reinstall the " +
+        `CLI (\`npm i -g ${MCP_PACKAGE_NAME}\`) with the Node on PATH and re-run \`epic-implementer doctor\`.`,
+    unknown: "the hook runtime could not be verified (a persistent install that predates the runtime probe " +
+        `also lands here). Upgrade it with \`npm i -g ${MCP_PACKAGE_NAME}@latest\`, then re-run ` +
+        "`epic-implementer doctor`.",
+};
+/** One sentence naming a classification and its action. Path-free by construction. */
+export function describeHookRuntimeClassification(classification) {
+    return `${classification}: ${HOOK_RUNTIME_ACTIONS[classification]}`;
+}
+function unavailable(classification) {
+    return { usable: false, classification, reason: describeHookRuntimeClassification(classification) };
+}
+function defaultRealpath(filePath) {
+    try {
+        return realpathSync(filePath);
+    }
+    catch {
+        return null;
+    }
+}
+function defaultIsFile(filePath) {
+    try {
+        return statSync(filePath).isFile();
+    }
+    catch {
+        return false;
+    }
+}
+function defaultReadText(filePath) {
+    try {
+        return readFileSync(filePath, "utf-8");
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * Run `node <stableEntry> __hook-runtime-probe` with a short timeout and a small
+ * output cap. `node` is resolved from PATH on purpose: that is the exact runtime
+ * the hook body invokes, so the probe measures what a commit will actually run.
+ * stderr is discarded unread.
+ */
+export function runHookRuntimeProbe(stableEntry) {
+    const result = spawnSync("node", [stableEntry, HOOK_RUNTIME_PROBE_ACTION], {
+        encoding: "utf-8",
+        timeout: HOOK_RUNTIME_PROBE_TIMEOUT_MS,
+        maxBuffer: HOOK_RUNTIME_PROBE_MAX_BUFFER,
+        stdio: ["ignore", "pipe", "ignore"],
+        windowsHide: true,
+    });
+    if (result.error) {
+        const code = result.error.code ?? null;
+        if (code === "ETIMEDOUT")
+            return { kind: "timeout" };
+        return { kind: "spawn-failed", code };
+    }
+    if (result.signal !== null)
+        return { kind: "timeout" };
+    if (result.status !== 0)
+        return { kind: "exit-nonzero" };
+    return { kind: "ok", stdout: result.stdout ?? "" };
+}
+/** Parse `major.minor.patch` (pre-release suffix ignored), or `null`. */
+export function parseSemver(version) {
+    const match = /^v?(\d+)\.(\d+)\.(\d+)(?:[-+].*)?$/.exec(version.trim());
+    if (match === null)
+        return null;
+    return [Number(match[1]), Number(match[2]), Number(match[3])];
+}
+/** True when `version` is inside {@link HOOK_RUNTIME_COMPATIBLE_RANGE}. */
+export function isCompatibleHookPackageVersion(version) {
+    const parsed = parseSemver(version);
+    if (parsed === null)
+        return false;
+    const [major, minor] = parsed;
+    return major === 0 && minor >= 2;
+}
+/** True when `nodeVersion` is an even LTS major at or above the minimum. */
+export function isQualifiedHookNodeVersion(nodeVersion) {
+    const parsed = parseSemver(nodeVersion);
+    if (parsed === null)
+        return false;
+    const [major] = parsed;
+    return major >= HOOK_RUNTIME_MIN_NODE_MAJOR && major % 2 === 0;
+}
+/**
+ * Locate the persistent package root for a canonical entry: the entry must be
+ * `<root>/build/epic-implementer-bin.js` and `<root>` must be
+ * `…/node_modules/@bridge_gpt/mcp-server`. Returns `null` for any other layout.
+ */
+export function persistentPackageRootOf(canonicalEntry) {
+    if (basename(canonicalEntry) !== HOOK_RUNTIME_ENTRY_FILENAME)
+        return null;
+    const buildDir = dirname(canonicalEntry);
+    if (basename(buildDir) !== "build")
+        return null;
+    const packageRoot = dirname(buildDir);
+    const segments = packageRoot.split(/[\\/]/).filter((s) => s.length > 0);
+    const [scope, name] = MCP_PACKAGE_NAME.split("/");
+    const n = segments.length;
+    if (n < 3)
+        return null;
+    if (segments[n - 1] !== name || segments[n - 2] !== scope || segments[n - 3] !== "node_modules") {
+        return null;
+    }
+    // A `.bin` shim is never a package root, and neither is anything nested in one.
+    if (segments.includes(".bin"))
+        return null;
+    return packageRoot;
+}
+/** Parse and validate the probe's single JSON line, or `null` when malformed. */
+export function parseHookRuntimeProbeOutput(stdout) {
+    const lines = stdout.split(/\r?\n/).filter((l) => l.trim().length > 0);
+    if (lines.length !== 1)
+        return null;
+    let parsed;
+    try {
+        parsed = JSON.parse(lines[0]);
+    }
+    catch {
+        return null;
+    }
+    if (parsed === null || typeof parsed !== "object")
+        return null;
+    const p = parsed;
+    if (p.probe !== HOOK_RUNTIME_PROBE_MARKER)
+        return null;
+    const str = (v) => typeof v === "string" && v.length > 0 && v.length <= 64;
+    if (!str(p.node_version) || !str(p.node_modules_abi) || !str(p.native_module) || !str(p.failure_kind)) {
+        return null;
+    }
+    if (typeof p.native_loads !== "boolean")
+        return null;
+    const nativeVersion = p.native_module_version === null || p.native_module_version === undefined
+        ? null
+        : str(p.native_module_version) ? p.native_module_version : null;
+    const packageVersion = str(p.package_version) ? p.package_version : null;
+    return {
+        node_version: p.node_version,
+        node_modules_abi: p.node_modules_abi,
+        native_module: p.native_module,
+        native_module_version: nativeVersion,
+        native_loads: p.native_loads,
+        failure_kind: p.failure_kind,
+        package_version: packageVersion,
+    };
+}
+/**
+ * Qualify a candidate hook entry. Read-only and never throws: every boundary
+ * failure maps to a fixed classification.
+ */
+export function qualifyHookRuntime(candidateEntry, deps = {}) {
+    try {
+        return qualifyHookRuntimeUnsafe(candidateEntry, deps);
+    }
+    catch {
+        return unavailable("unknown");
+    }
+}
+function qualifyHookRuntimeUnsafe(candidateEntry, deps) {
+    const realpath = deps.realpath ?? defaultRealpath;
+    const isFile = deps.isFile ?? defaultIsFile;
+    const readText = deps.readText ?? defaultReadText;
+    const platform = deps.platform ?? process.platform;
+    const runProbe = deps.runProbe ?? runHookRuntimeProbe;
+    if (typeof candidateEntry !== "string" || candidateEntry.length === 0)
+        return unavailable("missing");
+    if (basename(candidateEntry) === "conductor-bin.js")
+        return unavailable("legacy-name");
+    if (isTransientNpxEntryPath(candidateEntry))
+        return unavailable("ephemeral-cache");
+    const canonical = realpath(candidateEntry);
+    if (canonical === null || !isFile(canonical))
+        return unavailable("missing");
+    // A symlink into the cache is still the cache.
+    if (isTransientNpxEntryPath(canonical))
+        return unavailable("ephemeral-cache");
+    if (basename(canonical) !== HOOK_RUNTIME_ENTRY_FILENAME)
+        return unavailable("unqualified-runtime");
+    const packageRoot = persistentPackageRootOf(canonical);
+    if (packageRoot === null)
+        return unavailable("unqualified-runtime");
+    const pkgText = readText(join(packageRoot, "package.json"));
+    if (pkgText === null)
+        return unavailable("missing");
+    let pkg;
+    try {
+        pkg = JSON.parse(pkgText);
+    }
+    catch {
+        return unavailable("unqualified-runtime");
+    }
+    if (pkg.name !== MCP_PACKAGE_NAME)
+        return unavailable("unqualified-runtime");
+    if (typeof pkg.version !== "string" || !isCompatibleHookPackageVersion(pkg.version)) {
+        return unavailable("unqualified-runtime");
+    }
+    const binMap = pkg.bin !== null && typeof pkg.bin === "object" ? pkg.bin : null;
+    const mapped = binMap?.[HOOK_RUNTIME_BIN_NAME];
+    if (typeof mapped !== "string")
+        return unavailable("unqualified-runtime");
+    const normalizedMapped = mapped.replace(/^\.\//, "").replace(/\\/g, "/");
+    if (normalizedMapped !== `build/${HOOK_RUNTIME_ENTRY_FILENAME}`)
+        return unavailable("unqualified-runtime");
+    if (!HOOK_RUNTIME_QUALIFIED_PLATFORMS.includes(platform))
+        return unavailable("unqualified-runtime");
+    // The stable launch path is the package-owned entry under the persistent
+    // prefix. An in-place `npm i -g` upgrade replaces the files beneath it, so a
+    // hook that embeds this path keeps working across supported upgrades.
+    const stableEntry = join(packageRoot, "build", HOOK_RUNTIME_ENTRY_FILENAME);
+    const outcome = runProbe(stableEntry);
+    if (outcome.kind === "spawn-failed") {
+        return unavailable(outcome.code === "ENOENT" ? "node-unavailable" : "unknown");
+    }
+    if (outcome.kind !== "ok")
+        return unavailable("unknown");
+    const evidence = parseHookRuntimeProbeOutput(outcome.stdout);
+    if (evidence === null)
+        return unavailable("unknown");
+    if (!evidence.native_loads)
+        return unavailable("native-unavailable");
+    if (!isQualifiedHookNodeVersion(evidence.node_version))
+        return unavailable("unqualified-runtime");
+    // The probe must be answering for the package we just read, not some other
+    // build the entry happens to import.
+    if (evidence.package_version !== null && evidence.package_version !== pkg.version) {
+        return unavailable("unknown");
+    }
+    return {
+        usable: true,
+        stable_entry: stableEntry,
+        canonical_entry: canonical,
+        package_name: MCP_PACKAGE_NAME,
+        package_version: pkg.version,
+        platform,
+        runtime: {
+            node_version: evidence.node_version,
+            node_modules_abi: evidence.node_modules_abi,
+            native_module: evidence.native_module,
+            native_module_version: evidence.native_module_version,
+            native_loads: evidence.native_loads,
+            failure_kind: evidence.failure_kind,
+        },
+    };
+}

package/build/conductor/readiness-sections.js

@@ -771,12 +771,13 @@ export function conductorHookTargetsSection(legacyConductor, conductorContext) {
             detail: "advisory — not a git worktree, so no managed conductor hooks apply",
         };
     }
+    // BAPI-1290: the shared per-hook `usable` verdict — a recognized command, an
+    // executable hook, and a qualified persistent runtime whose Node and native
+    // binding load. A file that merely exists is not delivery, and a hook without
+    // that verdict (an older or partial report) is unknown, never usable.
     const usable = (name) => {
         const hook = (hooks.hooks ?? []).find((h) => h.name === name);
-        return (hook !== undefined &&
-            hook.exists &&
-            hook.managed_block_present &&
-            hook.embedded_bin_is_file);
+        return hook !== undefined && hook.usable === true;
     };
     const rendered = MANAGED_HOOK_NAMES.map((name) => `${name}=${usable(name)}`).join(", ");
     const allUsable = MANAGED_HOOK_NAMES.every((name) => usable(name));

package/build/conductor/readiness.js

@@ -141,7 +141,7 @@ export const SERVER_READINESS_DESCRIPTORS = [
     { id: "executor-readiness", label: "Executor server observation" },
     { id: "review-workflow", label: "Review workflow protocol" },
     { id: "conductor-ci-workflow", label: "Conductor CI migration guard" },
-    // BAPI-1102 — the two ONE-TIME unattended prerequisites plus the aggregate the
+    // BAPI-1102 — the two unattended repository prerequisites plus the aggregate the
     // third unattended refusal reads. Noun phrases, like every row above: these
     // render as list items under a source heading, not as sentences.
     { id: "unattended-consent", label: "Repository unattended consent" },
@@ -189,8 +189,10 @@ const SERVER_REMEDIATIONS = {
     olderServer: "upgrade the Bridge API deploy so it reports this fact; its state is unknown here, not healthy.",
     // BAPI-1102. Each names the ONE action that clears it, and none of them
     // mentions a webhook URL, a destination, or any configuration value.
-    unattendedConsent: "set `unattended_epic_implementer_allowed` for this repository (docs/claude/account-settings-operator-runbook.md), or run setup with --attended.",
-    unattendedNotifyDefault: "supply a --policy-file declaring notify.webhook_url, or run setup with --attended; an unattended run must have a working escalation channel, and notify.local_sink is not one.",
+    // BAPI-1273: consent defaults ON; the repository owner switches it on the
+    // admin panel's Setup page. No MCP or CLI surface ever writes it.
+    unattendedConsent: "turn on 'Allow unattended Epic Implementer runs' on the repository's Setup page in the Bridge admin panel, or run setup with --attended. If it is already on, contact Bridge support.",
+    unattendedNotifyDefault: "supply a --policy-file declaring notify.webhook_url, or add an email address to the account so escalation alerts can be emailed, or run setup with --attended; an unattended run must have a working escalation channel, and notify.local_sink is not one.",
     repositoryWorkflowReadiness: "run `install-bridge conductor` so the review and conductor-CI workflows are confirmed on the default branch, or run setup with --attended.",
     // BAPI-1135. Both are IMPORTED from the shared classifier rather than written
     // out here, so the remedy command has exactly one spelling across the refusal,
@@ -351,7 +353,7 @@ const ADMISSION_EVIDENCE_LABELS = {
 /** Who acts, in fixed prose. Never a value from the payload. */
 const ADMISSION_OWNER_REMEDIATION = {
     operator: "the operator re-runs guided setup (`install conductor --launch-profile <name>`) and re-observes.",
-    repository_admin: "a repository administrator resolves it through the account-settings runbook; setup never grants it.",
+    repository_admin: "a repository administrator resolves it (unattended consent is the 'Allow unattended Epic Implementer runs' toggle on the repository's Setup page in the Bridge admin panel); setup never grants it.",
     bridge_operations: "escalate to Bridge operations; this is not something an operator command can change.",
 };
 /**
@@ -485,7 +487,7 @@ function unattendedOutcomes(readiness) {
             : {
                 id: "unattended-consent",
                 status: "warn",
-                detail: "unattended_epic_implementer_allowed is NOT set — an unattended run will be refused before it is created",
+                detail: "unattended runs are off for this repository — an unattended run will be refused before it is created",
                 remediation: SERVER_REMEDIATIONS.unattendedConsent,
             },
         u.notify_webhook_default_declared
@@ -498,12 +500,21 @@ function unattendedOutcomes(readiness) {
                     ? "a notify webhook default is declared and verified"
                     : "a notify webhook default is declared (verified at approval, not here)",
             }
-            : {
-                id: "unattended-notify-default",
-                status: "warn",
-                detail: "no repository notify webhook default is declared — an unattended run needs an escalation channel, and no column supplies a repository default today, so the run must declare notify.webhook_url itself",
-                remediation: SERVER_REMEDIATIONS.unattendedNotifyDefault,
-            },
+            : u.escalation_email_available === true
+                ? {
+                    // BAPI-1274 — with no webhook declared, escalation alerts go to the
+                    // account's email address. Presence only: the address is never
+                    // reported by the server and is never rendered here.
+                    id: "unattended-notify-default",
+                    status: "pass",
+                    detail: "No webhook declared; escalation alerts will be emailed to the account's email address",
+                }
+                : {
+                    id: "unattended-notify-default",
+                    status: "warn",
+                    detail: "no repository notify webhook default is declared — an unattended run needs an escalation channel, and no column supplies a repository default today, so the run must declare notify.webhook_url itself or the account needs an email address for escalation alerts",
+                    remediation: SERVER_REMEDIATIONS.unattendedNotifyDefault,
+                },
         u.repository_readiness_confirmed
             ? {
                 id: "repository-workflow-readiness",