@bridge_gpt/mcp-server 0.2.58 → 0.2.60

package/build/drive-epic.js

@@ -1,32 +1,29 @@
 /**
  * `drive-epic` — the one universal conductor entry point (BAPI-887).
  *
- * Bridge has two conductors and a standing rule that they must never operate on
- * the same epic: two transition authorities on one epic wedge it permanently.
- *
- *   - **v2 engine** — bootstrapped by `setup-epic`, which creates a durable
- *     `epic_run` row, stores a plan DAG, and approves it.
- *   - **LLM-conductor pilot** — `/loop 5m /conduct-epic <EPIC>`, which creates no
- *     run row and keeps its whole memory in a local checkpoint plus GitHub.
+ * Bridge has one conductor — the **v2 engine**, bootstrapped by `setup-epic`,
+ * which creates a durable `epic_run` row, stores a plan DAG, and approves it. The
+ * standing rule is that exactly one transition authority ever operates on an
+ * epic: two authorities on one epic wedge it permanently.
  *
  * Asking a prompt to pick correctly every time is not a control. This subcommand
  * makes the choice STRUCTURAL: it reads server-side conductor readiness and
- * routes to exactly one path, so no prompt names either underlying conductor and
- * no prompt can present both. Every ticket-authoring surface hands off to
- * `drive-epic` and to nothing else.
+ * routes to exactly one path, so no prompt names the underlying conductor. Every
+ * ticket-authoring surface hands off to `drive-epic` and to nothing else.
  *
  * ## The output invariant
  *
  * Every branch — including every error path — emits **at most one** conductor
- * invocation. An escalation carries NO alternative conductor command: "v2 failed,
- * try the pilot instead" is precisely the dual-authority hazard this subcommand
- * exists to remove. {@link assertSingleConductorInvocation} enforces this on the
- * way out rather than trusting each branch to have got it right.
+ * invocation. A not-ready result or an escalation carries NO alternative
+ * conductor command: "v2 failed, try something else instead" is precisely the
+ * dual-authority hazard this subcommand exists to remove.
+ * {@link assertSingleConductorInvocation} enforces this on the way out rather than
+ * trusting each branch to have got it right.
  *
  * ## Three-state routing, fail-closed
  *
  *   - readiness green            -> delegate to the `setup-epic` (v2) flow
- *   - readiness read, not green  -> print the pilot instruction
+ *   - readiness read, not green  -> report v2 not-ready, offer no alternative
  *   - readiness UNKNOWN          -> escalate to the operator, print no conductor
  *
  * Unknown is never treated as not-ready, and selection never happens by
@@ -72,17 +69,16 @@ import { validateBranchName } from "./base-ref.js";
 // BAPI-806: mcp-identity.ts is the SOLE source of the package-name literal, so
 // the printed invocation interpolates it rather than repeating it.
 import { MCP_PACKAGE_NAME } from "./mcp-identity.js";
-/** Jira epic key shape. Matches `implement-epic`'s positional rule exactly. */
+/** Jira epic key shape. Matches the epic-key positional rule exactly. */
 const EPIC_KEY_PATTERN = /^[A-Z]+-[0-9]+$/;
-/** The two conductor paths. Derived types below come from this constant. */
-export const DRIVE_EPIC_CONDUCTORS = ["v2", "pilot"];
+/** The conductor paths. Derived types below come from this constant. */
+export const DRIVE_EPIC_CONDUCTORS = ["v2"];
 /**
- * THE consolidation-day edit point.
+ * The preferred conductor.
  *
- * When readiness is green, v2 is preferred and the pilot is the fallback for
- * projects that cannot run it. This is expressed as one named constant rather
- * than as branching scattered through the routing logic precisely so that
- * eliminating a conductor is a one-line change plus one deleted branch.
+ * v2 is the only conductor: when readiness is green it drives the epic, and when
+ * it is not the command reports v2 not-ready with no alternative. Expressed as
+ * one named constant rather than branching scattered through the routing logic.
  */
 export const DRIVE_EPIC_PREFERRED_CONDUCTOR = "v2";
 /**
@@ -165,6 +161,29 @@ export const V2_READINESS_REQUIREMENTS = [
         remedy: "Run `install-bridge conductor` to install them, or pass --attended.",
         satisfied: (r) => r.unattended?.repository_readiness_confirmed === true,
     },
+    // BAPI-1135 — merge-execution eligibility is deliberately NOT a requirement here.
+    //
+    // It was one, and it made `drive-epic` refuse EVERY repository the moment it
+    // shipped. The requirement could only be keyed on repository facts, because
+    // this layer keeps the composed run policy opaque to itself — and no
+    // repository carries the merge workflow until epic child 4 lands it. So both
+    // states resolved the same way: an upgraded server reported
+    // `merge_workflow_present: false` (`not_eligible`), an older one reported no
+    // block at all (`could_not_verify`), and either made `selectConductor` return
+    // `not_ready` and `classifyV2Readiness` return `operator_blocked` — for
+    // `--attended`, `--into-base` and `local`-mode runs alike, with a remedy
+    // naming a flag that does not exist yet.
+    //
+    // That is exactly the failure `selectConductor`'s own docstring warns about,
+    // and it contradicts the compatibility guarantee the rest of this slice keeps:
+    // nothing changes for a run that does not declare `github_actions`.
+    //
+    // Eligibility is still enforced, at the three layers that can actually see the
+    // declared mode: `setup-epic`'s pre-create refusal (which reads the composed
+    // policy), the approval route's server-side gate, and — authoritatively — the
+    // before-merge preflight. Readiness still REPORTS the facts as diagnostic
+    // rows, which inform without blocking. Reinstating a requirement here belongs
+    // with child 4, once a repository can actually satisfy it.
 ];
 /**
  * The readiness facts a `plane up` can actually repair (BAPI-1054).
@@ -482,10 +501,10 @@ export function parseDriveEpicArgs(argv) {
  * v2 engine drive an epic at all?", and the answer does not depend on whether
  * the repository has consented to UNATTENDED operation: an attended v2 run on a
  * non-consenting repository is a perfectly ordinary, fully supported run.
- * Including them would route every such repository to the pilot conductor the
- * moment this ticket deployed — a silent, repository-wide change of conductor for
- * a reason that has nothing to do with the choice, and the exact opposite of
- * AC-3's "nothing changes for an existing run".
+ * Including them would report v2 not-ready for every such repository the moment
+ * this ticket deployed — a silent, repository-wide refusal for a reason that has
+ * nothing to do with readiness, and the exact opposite of AC-3's "nothing
+ * changes for an existing run".
  *
  * They still gate the COMPOSED bring-up, through
  * {@link classifyV2Readiness}, which is where an unattended run is actually
@@ -501,8 +520,7 @@ export function selectConductor(readiness) {
         };
     }
     return {
-        kind: "selected",
-        conductor: "pilot",
+        kind: "not_ready",
         reason: `the engine path still needs ${missing.map((m) => m.describe).join("; ")}`,
     };
 }
@@ -536,51 +554,35 @@ export function buildSetupEpicArgv(options) {
     ];
 }
 /**
- * Render the selected path and only the selected path.
- *
- * Precondition: the caller has already ruled out delegation. The `v2` branch
- * reads as "green, but no plan file was supplied", which is only true once
- * {@link runDriveEpicCli} has declined to delegate — so route first, render
- * second.
+ * Render the selected v2 path and only that path.
  *
- * CONSOLIDATION DAY: delete the branch of the conductor being eliminated and
- * point {@link DRIVE_EPIC_PREFERRED_CONDUCTOR} at the survivor. Nothing outside
- * this file moves.
+ * Precondition: the caller has already ruled out delegation and a not-ready
+ * result. The `v2` branch reads as "green, but no plan file was supplied", which
+ * is only true once {@link runDriveEpicCli} has declined to delegate — so route
+ * first, render second.
  */
 export function renderConductorHandoff(selection, epicKey) {
-    if (selection.conductor === "v2") {
-        const invocation = `npx -y ${MCP_PACKAGE_NAME} drive-epic ${epicKey} --plan-file <path>`;
-        return {
-            conductor: "v2",
-            invocation,
-            lines: [
-                `${epicKey}: ${selection.reason}, but no plan file was supplied.`,
-                "",
-                "The engine path needs a plan DAG, and nothing derives one from an epic key:",
-                "the dependency edges and per-ticket touched_files it carries do not exist",
-                "anywhere else. Produce one, then re-run this command with it.",
-                "",
-                `  1. Run /plan-epic ${epicKey} in an interactive session. It writes the`,
-                "     sidecar to {docs_dir}/epic-plans/{epic_slug}/epic-plan.dag.json.",
-                "     If the epic's tickets already exist, run emit-epic-implementer-bundle",
-                "     finalize instead — it resolves the placeholder keys in an existing",
-                "     sidecar and attaches touched_files.",
-                "",
-                `  2. ${invocation}`,
-                "",
-                `That second command bootstraps the run for you; ${SETUP_EPIC_SUBCOMMAND} is not`,
-                "something you invoke directly.",
-            ],
-        };
-    }
-    const invocation = `/loop 5m /conduct-epic ${epicKey}`;
+    const invocation = `npx -y ${MCP_PACKAGE_NAME} drive-epic ${epicKey} --plan-file <path>`;
     return {
-        conductor: "pilot",
+        conductor: "v2",
         invocation,
         lines: [
-            `${epicKey}: ${selection.reason}. Drive it from an interactive session with:`,
+            `${epicKey}: ${selection.reason}, but no plan file was supplied.`,
+            "",
+            "The engine path needs a plan DAG, and nothing derives one from an epic key:",
+            "the dependency edges and per-ticket touched_files it carries do not exist",
+            "anywhere else. Produce one, then re-run this command with it.",
             "",
-            `  ${invocation}`,
+            `  1. Run /plan-epic ${epicKey} in an interactive session. It writes the`,
+            "     sidecar to {docs_dir}/epic-plans/{epic_slug}/epic-plan.dag.json.",
+            "     If the epic's tickets already exist, run emit-epic-implementer-bundle",
+            "     finalize instead — it resolves the placeholder keys in an existing",
+            "     sidecar and attaches touched_files.",
+            "",
+            `  2. ${invocation}`,
+            "",
+            `That second command bootstraps the run for you; ${SETUP_EPIC_SUBCOMMAND} is not`,
+            "something you invoke directly.",
         ],
     };
 }
@@ -589,7 +591,7 @@ export function renderConductorHandoff(selection, epicKey) {
  * output guard and by its test — one list, so a new spelling cannot be added to
  * the renderer without the guard seeing it.
  */
-export const CONDUCTOR_INVOCATION_TOKENS = ["setup-epic", "conduct-epic"];
+export const CONDUCTOR_INVOCATION_TOKENS = ["setup-epic"];
 /** The v2 token, named once so prose and the guard cannot drift apart. */
 const SETUP_EPIC_SUBCOMMAND = CONDUCTOR_INVOCATION_TOKENS[0];
 /**
@@ -935,9 +937,9 @@ export async function runDriveEpicCli(argv, overrides = {}) {
         //
         // BAPI-1054: a supplied plan file is what makes this a BRING-UP decision
         // rather than a routing one. Everything below runs before `selectConductor`'s
-        // pilot fallback can be rendered, because a report that is non-green only on
-        // the runtime facts is not a "use the other conductor" situation — it is a
-        // plane that has not been started yet.
+        // not-ready result can be rendered, because a report that is non-green only on
+        // the runtime facts is not a "v2 cannot run" situation — it is a plane that
+        // has not been started yet.
         if (planFile) {
             // BAPI-1102 — the explicit `--attended` opt-out makes the unattended
             // prerequisites inapplicable. Both inputs are FLAG checks, not policy
@@ -1061,6 +1063,21 @@ export async function runDriveEpicCli(argv, overrides = {}) {
                 awaitPlaneReady: controlPlane.awaitPlaneReady,
             });
         }
+        // No plan file, and readiness is not green: v2 is not ready and there is no
+        // second conductor to offer. Report it as a not-ready refusal on stderr with
+        // exactly one — actually zero — conductor invocation, and a non-zero exit.
+        if (selection.kind === "not_ready") {
+            const refusal = [
+                `${epicKey}: ${selection.reason}.`,
+                "",
+                "The v2 engine is not ready to drive this epic, and there is no alternative",
+                "conductor to fall back to. Resolve conductor readiness (`install-bridge",
+                "conductor`, then `doctor`) and run drive-epic again.",
+            ].join("\n");
+            assertSingleConductorInvocation(refusal);
+            deps.errorLog(refusal);
+            return 1;
+        }
         const handoff = renderConductorHandoff(selection, epicKey);
         const text = handoff.lines.join("\n");
         assertSingleConductorInvocation(text);