@bridge_gpt/mcp-server 0.2.29 → 0.2.31

package/build/install-bridge.js

@@ -150,18 +150,27 @@ export function buildPrewarmCommandPreview() {
  * (`maybe_auto_parse_if_ready`), with no prompt on any path.
  */
 export const INSTALL_BRIDGE_AGENT_PROMPT = "Execute the /install-bridge command in the install-spawn context (tell the command it is running " +
-    "in the install-spawn context so it SKIPS its Stage 8, Stage 9, and Stage 10 offers — this " +
-    "session's only closing interaction is the concise capability report and learn recommendation " +
-    "below). " +
-    "Complete the command's read-after-write concise capability report first: the single 'What Bridge " +
+    "in the install-spawn context so it SKIPS its Stage 8, Stage 9, and Stage 10 offers). " +
+    "The command chooses its own mode from the install manifest's `configured` flag — do NOT force a " +
+    "mode: when `configured` is false it runs its fresh-configuration flow, and when `configured` is " +
+    "true it runs JOIN MODE. In JOIN MODE the command must NOT derive, approve, apply, or offer any " +
+    "configuration and applies zero fields for any caller; a joining member's only closing interaction " +
+    "is the welcome plus the concise capability report (no /learn-repository prompt for a member). " +
+    "Complete the command's concise capability report: the single 'What Bridge " +
     "can help with' section, rendered exactly as the server's concise_tool_capabilities field gives it " +
     "(Regularly useful, then Occasionally useful, each tool's display_name only, plus each tier's " +
     "server-computed '+N more' where non-zero). Do not render the obsolete five-section report, and do " +
     "not locally filter, count, or fall back to the complete tool_capabilities catalog. " +
+    "The install-spawn skip set is exactly Stage 8, Stage 9, and Stage 10. The command-owned Stage 11 " +
+    "(invite teammates) is NOT in that skip set: it is independently gated and may run only when the " +
+    "caller's role is admin AND customer_type is b2b AND an interactive response is available; " +
+    "otherwise it is skipped silently. If Stage 11 mints a teammate key, show that plaintext key " +
+    "exactly once and never repeat it in any summary, retry, or diagnostic. " +
     "Do NOT ask any indexing question, call parse_repository, mention /parse-repository, or claim " +
     "indexing has started or is pending — indexing is decided entirely by the server-side readiness " +
     "funnel with no visibility from this session, so say nothing about it at all. " +
-    "After the capability report, recommend /learn-repository as the next step: explain briefly that it " +
+    "After the capability report on the fresh-configuration path, recommend /learn-repository as the " +
+    "next step: explain briefly that it " +
     "learns repository-specific architecture, review, testing, correctness, and validation-manual " +
     "configuration by researching the actual codebase. Do NOT run /learn-repository yourself — only " +
     "recommend it; running it is the human's next explicit invocation. " +
@@ -169,9 +178,11 @@ export const INSTALL_BRIDGE_AGENT_PROMPT = "Execute the /install-bridge command
     "integration's own configure_in pointer, verbatim. The pointer is per-integration and is NOT " +
     "always the setup UI: GitHub's is a terminal command (connect-github), while Jira, SFCC, and " +
     "Bitbucket point at the setup UI. Follow whatever the report says rather than assuming. " +
-    "End with an explicit summary line stating how many config fields the apply_install_manifest call " +
+    "On the fresh-configuration path, end with an explicit summary line stating how many config fields " +
+    "the apply_install_manifest call " +
     "applied (e.g. 'Applied 8 of 9 derived fields') — if 0 fields were applied, say so loudly and " +
-    "explain what is still pending.";
+    "explain what is still pending. In JOIN MODE there is no apply — state instead that the project " +
+    "was already configured and zero changes were made, without a fabricated applied count.";
 /** Default base URL when `BAPI_BASE_URL` is unset (mirrors index.ts). */
 export const DEFAULT_BAPI_BASE_URL = "https://bridgegpt-api.com";
 /** Default docs dir when `BAPI_DOCS_DIR` is unset (mirrors index.ts). */
@@ -185,10 +196,13 @@ export function getInstallBridgeUsage() {
         "One-command Bridge API project bootstrap. Scaffolds the project, writes the",
         "per-host MCP config with your credentials, verifies connectivity, persists the",
         "routing credential, then — on a TTY, only after a Y/N consent prompt — opens a",
-        "fresh session in your selected tool to derive the remaining config, present a",
-        "concise capability report, and recommend /learn-repository. Indexing is never",
-        "asked about — it starts automatically once the repository reaches full parse",
-        "readiness.",
+        "fresh session in your selected tool. If the project is not yet configured it",
+        "derives the remaining config, presents a concise capability report, and",
+        "recommends /learn-repository. If the project is already configured it instead",
+        "joins you to it without proposing or applying any changes and just shows the",
+        "concise capability report (a b2b admin is additionally offered a teammate-invite",
+        "step). So not every run applies config fields. Indexing is never asked about —",
+        "it starts automatically once the repository reaches full parse readiness.",
         "",
         "Run it bare — `install-bridge` with no flags — in a terminal and it asks",
         `\`${INSTALL_BRIDGE_KEY_SELECTOR_PROMPT.trim()}\` first. Answer yes (or press Enter) for the`,
@@ -261,10 +275,12 @@ export function getInstallBridgeUsage() {
         `                                ${HOST_PLATFORM_ORDER.join(", ")}.`,
         "                                Both --tools=claude-code,codex and",
         "                                --tools claude-code,codex are accepted. On an",
-        "                                interactive terminal WITHOUT this flag the",
-        "                                checklist starts EMPTY — no tool is pre-selected",
-        "                                (not even Claude Code) and you must select at",
-        "                                least one. A non-interactive (non-TTY) run without",
+        "                                interactive terminal WITHOUT this flag you get a",
+        "                                numbered picker: enter one or more tool numbers,",
+        "                                comma-separated (e.g. 1,3), and press Enter once —",
+        "                                no tool is pre-selected (not even Claude Code) and",
+        "                                you must select at least one. A non-interactive",
+        "                                (non-TTY) run without",
         "                                --tools writes the legacy automatic set (Claude",
         "                                Code plus any detected Cursor / Copilot VS Code)",
         "                                and never opens an agent terminal (it prints",
@@ -284,12 +300,15 @@ export function getInstallBridgeUsage() {
         "  --agent claude|cursor-agent   Explicit launch override for the post-install",
         "                                session — it always wins, and there is NO Claude",
         "                                default. Without it the launch tool is derived",
-        "                                from your selection: Claude Code opens `claude`,",
-        "                                Cursor opens `cursor-agent`; if several launchable",
-        "                                tools are selected the wizard asks which single one",
-        "                                to open; and a selection whose tools have no",
-        "                                agentic CLI (e.g. Copilot) opens nothing and prints",
-        "                                how to finish configuring later.",
+        "                                from your selection: Claude Code opens `claude`.",
+        "                                Cursor is NOT auto-opened (its cursor-agent CLI",
+        "                                first-run workspace-trust prompt collapses a spawned",
+        "                                session); selecting Cursor writes .cursor/mcp.json",
+        "                                and prints how to finish by running /install-bridge",
+        "                                in a new Cursor session. A selection whose tools have",
+        "                                no agentic CLI (e.g. Copilot) likewise opens nothing",
+        "                                and prints how to finish configuring later. Passing",
+        "                                --agent cursor-agent still force-spawns it.",
         "  -h, --help                    Show this help.",
         "",
         "Environment: BAPI_BASE_URL (default https://bridgegpt-api.com) and BAPI_DOCS_DIR",
@@ -1009,88 +1028,78 @@ export async function resolveRepoName(options, deps, mode = "existing-registrati
 /** A per-host MCP config target (mirrors runInit's configTargets shape). */
 /** Stable wording of the interactive tool-selection prompt (BAPI-635). */
 export const INSTALL_BRIDGE_TOOL_SELECTOR_PROMPT = "Which AI coding tools do you use on this project?";
+/** A one-based selection token is exactly one or more digits, no sign/decimal/leading-zero. */
+const SELECTION_TOKEN_PATTERN = /^[1-9][0-9]*$/;
 /**
- * Interactive numbered multi-select prompt on stderr (TTY only). Displays a
- * legend and usage line plus each option with a checked/unchecked marker seeded
- * from `defaults`, accepts a comma-separated list of numbers that TOGGLE the rows
- * and RE-PROMPT (acceptance is a separate bare Enter), and accepts only a NON-EMPTY
- * selection on a bare Enter — an empty one prints "Select at least one tool." and
- * re-prompts (AC-1/AC-3). Reprints on an invalid token rather than corrupting
- * state. Resolves safely (to the current set, including an empty one) on EOF /
- * synchronous close so a readline regression can never hang or discard the answer.
+ * Interactive single-shot numbered picker on stderr (TTY only). Renders the
+ * heading and each option exactly once, then accepts ONE strict
+ * comma-separated line of one-based numbers and resolves immediately — there
+ * is no preselected/toggle state and no separate confirmation step (BAPI-663).
+ *
+ * A blank line or a line containing any invalid token (non-numeric, zero,
+ * signed, leading-zero, decimal, out-of-range) is rejected atomically — the
+ * whole line is discarded, one error line is printed, and the picker
+ * re-prompts without re-rendering the option list. A valid line is
+ * deduplicated and returned in `options` order regardless of entry order.
+ *
+ * Resolves to `[]` on EOF / synchronous close before any line has been
+ * committed, so a readline regression can never hang. Returns `[]`
+ * immediately, without creating a readline interface, when `options` is
+ * empty.
  */
-export function promptMultiSelectViaReadline(promptText, options, defaults, input = process.stdin, output = process.stderr) {
+export function promptMultiSelectViaReadline(promptText, options, input = process.stdin, output = process.stderr) {
+    if (options.length === 0)
+        return Promise.resolve([]);
     return new Promise((resolve) => {
-        const selected = new Set(defaults);
-        const render = () => {
-            output.write(`\n${promptText}\n`);
-            output.write("[x] = selected · [ ] = not selected\n");
-            options.forEach((opt, idx) => {
-                const mark = selected.has(opt.id) ? "[x]" : "[ ]";
-                output.write(`  ${idx + 1}. ${mark} ${opt.label}\n`);
-            });
-            output.write("Type numbers to toggle, e.g. 1,3 — then Enter.\n");
-            output.write("Press Enter on an empty line to confirm — re-typing a number un-selects it.\n");
-            output.write("Enter numbers to toggle (comma-separated), or press Enter to accept: ");
-        };
         const rl = readline.createInterface({ input, output });
-        let answered = false;
-        const finish = () => {
-            answered = true;
+        let settled = false;
+        const finish = (result) => {
+            if (settled)
+                return;
+            settled = true;
             rl.close();
-            resolve(options.filter((o) => selected.has(o.id)).map((o) => o.id));
+            resolve(result);
         };
         // EOF / synchronous close must resolve rather than deadlock the top-level
-        // await; `answered` guards the synchronous close from discarding a real answer.
-        rl.on("close", () => {
-            if (!answered)
-                resolve(options.filter((o) => selected.has(o.id)).map((o) => o.id));
+        // await; the `settled` guard stops a synchronous `close` (fired by `rl.close()`
+        // above) from replacing an already-committed answer with the EOF fallback.
+        rl.on("close", () => finish([]));
+        output.write(`\n${promptText}\n`);
+        options.forEach((opt, idx) => {
+            output.write(`  ${idx + 1}. ${opt.label}\n`);
         });
-        const ask = () => {
-            render();
-            rl.question("", (answer) => {
+        output.write("Enter the number(s) of the tools you use (e.g. 1,3), then Enter.\n");
+        const prompt = () => {
+            rl.question("> ", (answer) => {
                 const trimmed = answer.trim();
                 if (trimmed.length === 0) {
-                    // AC-3: a bare Enter accepts ONLY a non-empty selection; an empty one
-                    // re-prompts rather than resolving to nothing. EOF/close (handled above)
-                    // still resolves the current — possibly empty — set so input can never hang.
-                    if (selected.size === 0) {
-                        output.write("Select at least one tool.\n");
-                        ask();
-                        return;
-                    }
-                    finish();
+                    output.write("Select at least one tool.\n");
+                    prompt();
                     return;
                 }
                 const tokens = trimmed.split(",").map((t) => t.trim());
-                const nums = [];
-                let bad = false;
+                const indices = [];
                 for (const tok of tokens) {
+                    if (!SELECTION_TOKEN_PATTERN.test(tok)) {
+                        output.write(`Invalid selection. Enter numbers between 1 and ${options.length}.\n`);
+                        prompt();
+                        return;
+                    }
                     const n = Number(tok);
-                    if (!Number.isInteger(n) || n < 1 || n > options.length) {
-                        bad = true;
-                        break;
+                    if (n < 1 || n > options.length) {
+                        output.write(`Invalid selection. Enter numbers between 1 and ${options.length}.\n`);
+                        prompt();
+                        return;
                     }
-                    nums.push(n);
-                }
-                if (bad) {
-                    output.write(`Invalid selection. Enter numbers between 1 and ${options.length}.\n`);
-                    ask();
-                    return;
+                    indices.push(n);
                 }
-                for (const n of nums) {
-                    const opt = options[n - 1];
-                    if (selected.has(opt.id))
-                        selected.delete(opt.id);
-                    else
-                        selected.add(opt.id);
-                }
-                // Toggling re-renders the updated checklist and re-prompts; acceptance is a
-                // separate, deliberate bare Enter (AC-1/AC-3) rather than an implicit accept.
-                ask();
+                const chosen = new Set(indices);
+                finish(options
+                    .filter((_, idx) => chosen.has(idx + 1))
+                    .map((o) => o.id));
             });
         };
-        ask();
+        prompt();
     });
 }
 /**
@@ -1110,13 +1119,11 @@ export async function resolveSelectedHostPlatforms(deps, options) {
     }
     const ctx = await buildDetectionContext(deps);
     const detected = new Set(detectDefaultPlatforms(ctx));
-    // 2. Interactive multi-select on a TTY. AC-2: no row is pre-selected — the
-    // picker seeds an EMPTY default set (dropping the former forced Claude Code
-    // inclusion and detected-platform seeding) and requires an explicit selection.
+    // 2. Interactive single-shot numbered picker on a TTY. No row is pre-selected
+    // — the picker has no default state and requires an explicit selection.
     if (deps.isTTY && deps.promptMultiSelect) {
         const optionList = allHostTargets().map((t) => ({ id: t.id, label: t.label }));
-        const defaults = [];
-        const chosen = await deps.promptMultiSelect(INSTALL_BRIDGE_TOOL_SELECTOR_PROMPT, optionList, defaults);
+        const chosen = await deps.promptMultiSelect(INSTALL_BRIDGE_TOOL_SELECTOR_PROMPT, optionList);
         return HOST_PLATFORM_ORDER.filter((id) => chosen.includes(id));
     }
     // 3. Legacy non-TTY automatic set: Claude + detected Cursor / Copilot VS Code.
@@ -1127,18 +1134,37 @@ export async function resolveSelectedHostPlatforms(deps, options) {
         legacy.push("copilot-vscode");
     return HOST_PLATFORM_ORDER.filter((id) => legacy.includes(id));
 }
+/**
+ * Launch agents install-bridge will NEVER auto-spawn from a host SELECTION, even
+ * though their CLI exists and the host's MCP config is still written normally.
+ *
+ * `cursor-agent` is excluded: its FIRST-RUN workspace-trust handshake collapses
+ * under our osascript-spawned launch — the "Workspace Trust Required" dialog
+ * renders, then the process exits before a selection registers, so configuration
+ * never runs (reproduced on a pristine, never-trusted workspace; the identical
+ * command works only where Cursor already trusts the directory). The trust gate is
+ * cursor-agent's own behavior on an untrusted workspace and is not something our
+ * launch can drive, so we treat Cursor as a no-auto-launch host: selecting it
+ * still writes `.cursor/mcp.json`, then prints the manual `/install-bridge`
+ * continuation (same path as Copilot/Codex/Windsurf, which have no agentic CLI).
+ * An explicit `--agent cursor-agent` override still spawns it — a deliberate,
+ * documented power-user opt-in that bypasses this selection guard.
+ */
+const SELECTION_NON_LAUNCHABLE_AGENTS = new Set(["cursor-agent"]);
 /**
  * Resolve the post-install launch decision from the selected host platforms and an
  * OPTIONAL explicit `--agent` override (BAPI-657). Pure and total:
  *
  *  - An explicit `--agent` is an ABSOLUTE override (ratified AC-4): a valid explicit
  *    agent always returns `spawn(agent)`, regardless of which tools were selected —
- *    the flag is honored even for a host outside the selection.
+ *    the flag is honored even for a host outside the selection, and it bypasses the
+ *    {@link SELECTION_NON_LAUNCHABLE_AGENTS} guard below.
  *  - Otherwise the selection drives it: map each selected host through
- *    {@link agentForPlatform}, drop non-launchable hosts, dedup in registry order,
- *    then return `manual("empty-selection")` for an empty selection,
- *    `manual("no-launchable-agent")` for zero launchable agents, `spawn` for one, or
- *    `choose-one` for more than one.
+ *    {@link agentForPlatform}, drop hosts that are non-launchable OR excluded from
+ *    selection auto-spawn ({@link SELECTION_NON_LAUNCHABLE_AGENTS}, e.g. Cursor),
+ *    dedup in registry order, then return `manual("empty-selection")` for an empty
+ *    selection, `manual("no-launchable-agent")` for zero launchable agents, `spawn`
+ *    for one, or `choose-one` for more than one.
  *
  * Never prompts, logs, resolves an {@link AgentSpec}, or touches the filesystem.
  */
@@ -1154,8 +1180,9 @@ export function resolveInstallBridgeLaunchDecision(selectedPlatforms, explicitAg
         if (!selectedPlatforms.includes(id))
             continue;
         const agent = agentForPlatform(id);
-        if (agent && !agents.includes(agent))
+        if (agent && !SELECTION_NON_LAUNCHABLE_AGENTS.has(agent) && !agents.includes(agent)) {
             agents.push(agent);
+        }
     }
     if (agents.length === 0)
         return { kind: "manual", reason: "no-launchable-agent" };
@@ -1242,7 +1269,7 @@ export function buildManualInstallBridgeContinuation(kind, toolLabels) {
     const toolPhrase = formatToolLabelPhrase(toolLabels);
     return [
         `To finish configuring this project, open it in ${toolPhrase} that has the`,
-        "Bridge MCP server configured and run /install-bridge.",
+        "Bridge MCP server configured, start a new session, and run /install-bridge.",
         "Until the project is configured, your Bridge MCP tools stay limited.",
     ].join("\n");
 }