@bridge_gpt/mcp-server 0.2.2 → 0.2.3

package/build/pipeline-orchestrator.js

@@ -222,7 +222,9 @@ export async function runPipeline(deps, input) {
     }
     let recipe;
     try {
-        recipe = resolveRecipe(pipelineDef, deps.instructions, mergedVariables, undefined, autoApprove);
+        recipe = resolveRecipe(pipelineDef, deps.instructions, mergedVariables, undefined, autoApprove, {
+            includeUpgradeAdviceSurfacing: deps.includeUpgradeAdviceSurfacing !== false,
+        });
     }
     catch (err) {
         return failedEnvelope("VALIDATION", err instanceof Error ? err.message : String(err), { pipeline: input.pipeline });
@@ -487,6 +489,7 @@ async function continuePipelineExecution(deps, persistence, row, recipe, autoApp
                 step_description: step.description,
                 instruction: approvalInstruction,
                 results,
+                preamble: recipe.agent_instructions,
             };
         }
         if (step.type === "agent_task") {
@@ -514,6 +517,7 @@ async function continuePipelineExecution(deps, persistence, row, recipe, autoApp
                 step_description: step.description,
                 instruction: step.instruction ?? "",
                 results,
+                preamble: recipe.agent_instructions,
             };
         }
         // mcp_call branch (executing now)

package/build/pipeline-utils.js

@@ -53,6 +53,11 @@ export function validatePipelineSchema(json) {
         if (s.requires_approval !== undefined && typeof s.requires_approval !== "boolean") {
             errors.push(`${prefix}: "requires_approval" must be a boolean if provided.`);
         }
+        if (s.id !== undefined) {
+            if (typeof s.id !== "string" || s.id.trim().length === 0) {
+                errors.push(`${prefix}."id" must be a non-empty string when provided`);
+            }
+        }
         if (s.type === "mcp_call") {
             if (typeof s.tool !== "string" || s.tool.trim() === "") {
                 errors.push(`${prefix}: mcp_call step requires "tool" (string).`);
@@ -145,7 +150,23 @@ function substituteInParams(params, variables) {
 // ---------------------------------------------------------------------------
 // Recipe Resolution
 // ---------------------------------------------------------------------------
-export function resolveRecipe(pipeline, instructions, variables, skipSteps, autoApprove) {
+/**
+ * Shared convention (BAPI-375) appended to the recipe preamble so every
+ * ping-bearing pipeline proactively surfaces the server's upgrade advice. The
+ * advice STRING is owned by the backend `compute_upgrade()` and emitted by the
+ * `ping` tool as a second text content item; this text only tells the agent to
+ * relay it. It deliberately contains NO advice wording (no "Your bridge-api MCP
+ * is…" sentence) so there is no second source of truth to drift from the server.
+ */
+export const UPGRADE_ADVICE_SURFACING_INSTRUCTIONS = " Upgrade advice: when any `ping` MCP call in this run returns a non-empty" +
+    " second text content item, relay that server-provided text to the user" +
+    " verbatim — do not invent, prefix, suffix, summarize, or paraphrase it." +
+    " Surface it at most once per pipeline run or session, including any" +
+    " chained sub-pipelines. Stay completely silent when the second content" +
+    " item is absent or empty. A ping failure, a non-OK ping response, missing" +
+    " advice, or empty advice is fail-open: it must never block, pause, or" +
+    " crash the run, and you must never synthesize advice of your own.";
+export function resolveRecipe(pipeline, instructions, variables, skipSteps, autoApprove, options) {
     // Validate required variables are provided
     const declared = pipeline.variables ?? [];
     const missing = declared.filter((v) => !(v in variables));
@@ -158,22 +179,36 @@ export function resolveRecipe(pipeline, instructions, variables, skipSteps, auto
     const resolvedSteps = [];
     let stepIndex = 1;
     for (const step of pipeline.steps) {
-        // Determine skip key: tool name for mcp_call, description for agent_task
-        const skipKey = step.type === "mcp_call" ? step.tool : step.description;
+        // Prefer a meaningful step `id` as the skip key; fall back to tool name
+        // (mcp_call) or raw description (agent_task) for untagged steps.
+        const stepId = typeof step.id === "string" && step.id.trim().length > 0
+            ? step.id
+            : undefined;
+        const skipKey = stepId ??
+            (step.type === "mcp_call" ? step.tool : step.description);
         if (skip.has(skipKey))
             continue;
         const declaredApproval = step.requires_approval ?? false;
         const effectiveApproval = declaredApproval && !autoApprove;
+        // `ping` is the best-effort connectivity / upgrade-advice probe (BAPI-375):
+        // it must never halt a pipeline when degraded, so its effective on_error is
+        // always warn_and_continue regardless of any declared value. Non-ping steps
+        // keep their declared on_error, defaulting to halt.
+        const isPingStep = step.type === "mcp_call" && step.tool === "ping";
         const base = {
             step: stepIndex++,
             type: step.type,
             description: substituteVariables(step.description, variables),
-            on_error: step.on_error ?? "halt",
+            on_error: isPingStep ? "warn_and_continue" : (step.on_error ?? "halt"),
             requires_approval: effectiveApproval,
         };
         if (declaredApproval !== effectiveApproval) {
             base.requires_approval_declared = declaredApproval;
         }
+        // Emit the stable step id only when meaningful — never substitute variables.
+        if (stepId !== undefined) {
+            base.id = stepId;
+        }
         if (step.type === "mcp_call") {
             base.tool = step.tool;
             base.params = substituteInParams(step.params, variables);
@@ -202,6 +237,11 @@ export function resolveRecipe(pipeline, instructions, variables, skipSteps, auto
         'For on_error "halt", stop the pipeline immediately on failure. ' +
         'For on_error "warn_and_continue", log a warning and proceed. ' +
         "Do not skip steps, reorder them, or substitute your own tool calls.";
+    // Default-on: include the upgrade-advice surfacing convention unless the
+    // caller explicitly opts out (BAPI_MCP_UPGRADE_ADVICE_ENABLED=false).
+    const upgradeAdviceConvention = options?.includeUpgradeAdviceSurfacing !== false
+        ? UPGRADE_ADVICE_SURFACING_INSTRUCTIONS
+        : "";
     const autoApproveSuffix = autoApprove
         ? " Auto-approve mode is ACTIVE: every approval gate has been pre-approved by the user via the auto_approve flag — proceed without pausing for confirmation, applying the default branching, file-staging, and recommendation choices documented in each instruction file's auto-approve branch."
         : "";
@@ -209,7 +249,7 @@ export function resolveRecipe(pipeline, instructions, variables, skipSteps, auto
         pipeline: pipeline.name,
         description: pipeline.description ?? "",
         total_steps: resolvedSteps.length,
-        agent_instructions: baseInstructions + autoApproveSuffix,
+        agent_instructions: baseInstructions + upgradeAdviceConvention + autoApproveSuffix,
         auto_approve: !!autoApprove,
         steps: resolvedSteps,
     };