@brickhouse-tech/sync-agents 0.1.9 → 0.1.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brickhouse-tech/sync-agents",
-  "version": "0.1.9",
+  "version": "0.1.11",
   "description": "Simple scripts to DRY up common agent interactions across multiple LLM providers.",
   "keywords": [
     "agents",
@@ -25,6 +25,10 @@
   "files": [
     "src/**/*"
   ],
+  "overrides": {
+    "file-type": ">=22",
+    "picomatch": ">=4.0.4"
+  },
   "scripts": {
     "lint": "shellcheck src/sh/*.sh",
     "test": "npx bats test/"
@@ -34,6 +38,6 @@
     "@commitlint/config-conventional": "^20",
     "commitlint": "20",
     "shellcheck": "^4.1.0",
-    "sort-package-json": "3.6"
+    "sort-package-json": ">=3"
   }
 }

package/src/sh/sync-agents.sh

@@ -75,6 +75,9 @@ ${BOLD}COMMANDS${RESET}
   watch                         Watch .agents/ for changes and auto-regenerate index
   import <url>                  Import a rule/skill/workflow from a URL
   hook                          Install a pre-commit git hook for auto-sync
+  fix [type]                    Migrate legacy dirs + repair broken symlinks
+                                  type: skills, rules, workflows, or all
+                                  --no-clobber: skip items that already exist in .agents/
   inherit <label> <path>        Add an inheritance link to AGENTS.md (convention-based)
   inherit --list                List current inheritance links
   inherit --remove <label>      Remove an inheritance link by label
@@ -249,7 +252,14 @@ cmd_add() {
 
   ensure_agents_dir
 
-  local filepath="$PROJECT_ROOT/$AGENTS_DIR/$type/$name.md"
+  # Skills use directory layout: skills/name/SKILL.md
+  # Rules and workflows use flat files: rules/name.md, workflows/name.md
+  local filepath
+  if [[ "$type" == "skills" ]]; then
+    filepath="$PROJECT_ROOT/$AGENTS_DIR/$type/$name/SKILL.md"
+  else
+    filepath="$PROJECT_ROOT/$AGENTS_DIR/$type/$name.md"
+  fi
 
   if [[ -f "$filepath" ]] && [[ "$FORCE" != "true" ]]; then
     error "File already exists: $filepath (use --force to overwrite)"
@@ -265,6 +275,9 @@ cmd_add() {
     *)         template_name="RULE_TEMPLATE.md" ;;
   esac
 
+  # Create parent directory for skills
+  mkdir -p "$(dirname "$filepath")"
+
   if [[ -f "$TEMPLATES_DIR/$template_name" ]]; then
     sed "s/\${NAME}/$name/g" "$TEMPLATES_DIR/$template_name" > "$filepath"
   elif [[ -f "$TEMPLATES_DIR/RULE_TEMPLATE.md" ]]; then
@@ -287,6 +300,308 @@ TMPL_EOF
   info "Updated $AGENTS_MD index"
 }
 
+cmd_fix() {
+  ensure_agents_dir
+
+  # Parse fix-specific flags
+  local no_clobber="false"
+  local fix_args=()
+  for arg in "$@"; do
+    case "$arg" in
+      --no-clobber) no_clobber="true" ;;
+      *)            fix_args+=("$arg") ;;
+    esac
+  done
+
+  local fix_type="${fix_args[0]:-all}"
+  local subdirs=()
+
+  case "$fix_type" in
+    skills|rules|workflows)
+      subdirs=("$fix_type")
+      ;;
+    all)
+      subdirs=(skills rules workflows)
+      ;;
+    *)
+      error "Unknown type: $fix_type (expected: skills, rules, workflows, or all)"
+      exit 1
+      ;;
+  esac
+
+  local agents_abs
+  agents_abs="$(cd "$PROJECT_ROOT/$AGENTS_DIR" && pwd)"
+  local fixed=0
+  local skipped=0
+  local merged=0
+
+  # Helper: compare inodes of two directories (portable across macOS/Linux)
+  same_inode() {
+    local inode_a inode_b
+    if stat --version >/dev/null 2>&1; then
+      # GNU stat (Linux)
+      inode_a="$(stat -c '%i' "$1" 2>/dev/null)"
+      inode_b="$(stat -c '%i' "$2" 2>/dev/null)"
+    else
+      # BSD stat (macOS)
+      inode_a="$(stat -f '%i' "$1" 2>/dev/null)"
+      inode_b="$(stat -f '%i' "$2" 2>/dev/null)"
+    fi
+    [[ -n "$inode_a" ]] && [[ "$inode_a" == "$inode_b" ]]
+  }
+
+  for subdir in "${subdirs[@]}"; do
+    local legacy_dir="$PROJECT_ROOT/$subdir"
+    local agents_subdir="$agents_abs/$subdir"
+
+    # Skip if legacy dir doesn't exist or is already a symlink
+    if [[ ! -d "$legacy_dir" ]]; then
+      continue
+    fi
+    if [[ -L "$legacy_dir" ]]; then
+      info "$subdir/ is already a symlink — nothing to do."
+      continue
+    fi
+
+    # Detect same-inode (legacy dir IS .agents/subdir — e.g. hardlink or bind mount)
+    if [[ -d "$agents_subdir" ]] && same_inode "$legacy_dir" "$agents_subdir"; then
+      warn "$subdir/ and $AGENTS_DIR/$subdir/ are the same directory (same inode)."
+      warn "Replacing $subdir/ with a symlink to $AGENTS_DIR/$subdir/."
+      if [[ "$DRY_RUN" == "true" ]]; then
+        echo "  would remove $subdir/ (same inode as $AGENTS_DIR/$subdir/)"
+        echo "  would create symlink $subdir/ -> $AGENTS_DIR/$subdir"
+      else
+        rm -rf "$legacy_dir"
+        ln -s "$AGENTS_DIR/$subdir" "$legacy_dir"
+        info "Replaced $subdir/ with symlink -> $AGENTS_DIR/$subdir"
+      fi
+      fixed=$((fixed + 1))
+      continue
+    fi
+
+    info "Found legacy directory: $subdir/"
+    mkdir -p "$agents_subdir"
+
+    # Move each item from legacy dir into .agents/subdir
+    for item in "$legacy_dir"/*/; do
+      [[ -d "$item" ]] || continue
+      local name
+      name="$(basename "$item")"
+
+      if [[ -d "$agents_subdir/$name" ]]; then
+        if [[ "$no_clobber" == "true" ]]; then
+          warn "Skipping $subdir/$name — already exists in $AGENTS_DIR/$subdir/ (--no-clobber)"
+          skipped=$((skipped + 1))
+          continue
+        fi
+        # Merge: legacy content wins (overwrite into .agents/)
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would merge: $subdir/$name -> $AGENTS_DIR/$subdir/$name (overwrite)"
+        else
+          rm -rf "${agents_subdir:?}/${name:?}"
+          mv "$item" "$agents_subdir/$name"
+          info "Merged: $subdir/$name -> $AGENTS_DIR/$subdir/$name (overwrote existing)"
+        fi
+        merged=$((merged + 1))
+        fixed=$((fixed + 1))
+        continue
+      fi
+
+      if [[ "$DRY_RUN" == "true" ]]; then
+        echo "  would move: $subdir/$name -> $AGENTS_DIR/$subdir/$name"
+      else
+        mv "$item" "$agents_subdir/$name"
+        info "Moved: $subdir/$name -> $AGENTS_DIR/$subdir/$name"
+      fi
+      fixed=$((fixed + 1))
+    done
+
+    # Also move any top-level files (e.g. loose .md rules)
+    for item in "$legacy_dir"/*; do
+      [[ -f "$item" ]] || continue
+      local name
+      name="$(basename "$item")"
+
+      if [[ -f "$agents_subdir/$name" ]]; then
+        if [[ "$no_clobber" == "true" ]]; then
+          warn "Skipping $subdir/$name — already exists in $AGENTS_DIR/$subdir/ (--no-clobber)"
+          skipped=$((skipped + 1))
+          continue
+        fi
+        # Merge: legacy content wins
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would merge: $subdir/$name -> $AGENTS_DIR/$subdir/$name (overwrite)"
+        else
+          mv "$item" "$agents_subdir/$name"
+          info "Merged: $subdir/$name -> $AGENTS_DIR/$subdir/$name (overwrote existing)"
+        fi
+        merged=$((merged + 1))
+        fixed=$((fixed + 1))
+        continue
+      fi
+
+      if [[ "$DRY_RUN" == "true" ]]; then
+        echo "  would move: $subdir/$name -> $AGENTS_DIR/$subdir/$name"
+      else
+        mv "$item" "$agents_subdir/$name"
+        info "Moved: $subdir/$name -> $AGENTS_DIR/$subdir/$name"
+      fi
+      fixed=$((fixed + 1))
+    done
+
+    # Remove the now-empty legacy dir and replace with symlink
+    if [[ "$DRY_RUN" == "true" ]]; then
+      echo "  would replace $subdir/ with symlink -> $AGENTS_DIR/$subdir"
+    else
+      # Check if dir is empty (only . and .. remain)
+      if [[ -z "$(ls -A "$legacy_dir" 2>/dev/null)" ]]; then
+        rmdir "$legacy_dir"
+        ln -s "$AGENTS_DIR/$subdir" "$legacy_dir"
+        info "Replaced $subdir/ with symlink -> $AGENTS_DIR/$subdir"
+      else
+        warn "$subdir/ is not empty after migration — skipping symlink replacement"
+        warn "Remaining items:"
+        find "$legacy_dir" -mindepth 1 -maxdepth 1 -exec basename {} \; | sed 's/^/    /'
+      fi
+    fi
+  done
+
+  # --- Phase 1b: Convert flat skill files to directory layout ---
+  # e.g. .agents/skills/foo.md -> .agents/skills/foo/SKILL.md
+  for subdir in "${subdirs[@]}"; do
+    [[ "$subdir" == "skills" ]] || continue
+    local skills_dir="$agents_abs/skills"
+    [[ -d "$skills_dir" ]] || continue
+
+    for flat_file in "$skills_dir"/*.md; do
+      [[ -f "$flat_file" ]] || continue
+      local name
+      name="$(basename "$flat_file" .md)"
+      local target_dir="$skills_dir/$name"
+      local target_file="$target_dir/SKILL.md"
+
+      if [[ -d "$target_dir" ]] && [[ -f "$target_file" ]]; then
+        if [[ "$no_clobber" == "true" ]]; then
+          warn "Skipping flat skill $name.md — $name/SKILL.md already exists (--no-clobber)"
+          skipped=$((skipped + 1))
+          continue
+        fi
+        # Flat file wins (same merge behavior as legacy migration)
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would convert: skills/$name.md -> skills/$name/SKILL.md (overwrite)"
+        else
+          mv "$flat_file" "$target_file"
+          info "Converted: skills/$name.md -> skills/$name/SKILL.md (overwrote existing)"
+        fi
+        merged=$((merged + 1))
+        fixed=$((fixed + 1))
+        continue
+      fi
+
+      if [[ "$DRY_RUN" == "true" ]]; then
+        echo "  would convert: skills/$name.md -> skills/$name/SKILL.md"
+      else
+        mkdir -p "$target_dir"
+        mv "$flat_file" "$target_file"
+        info "Converted: skills/$name.md -> skills/$name/SKILL.md"
+      fi
+      fixed=$((fixed + 1))
+    done
+  done
+
+  # --- Phase 2: Repair broken/missing symlinks ---
+  local repaired=0
+
+  for target in "${ACTIVE_TARGETS[@]}"; do
+    local target_dir
+    target_dir="$(resolve_target_dir "$target" "$PROJECT_ROOT")"
+    local agents_rel
+    agents_rel="$(resolve_agents_rel "$target")"
+
+    for subdir in "${subdirs[@]}"; do
+      if [[ ! -d "$agents_abs/$subdir" ]]; then
+        continue
+      fi
+      local expected_link="$target_dir/$subdir"
+      local expected_source="$agents_rel/$subdir"
+
+      if [[ -L "$expected_link" ]]; then
+        local current_target
+        current_target="$(readlink "$expected_link")"
+        if [[ "$current_target" == "$expected_source" ]]; then
+          continue  # Already correct
+        fi
+        # Symlink exists but points to wrong target
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would relink: $expected_link -> $expected_source (was $current_target)"
+        else
+          rm "$expected_link"
+          create_symlink "$expected_source" "$expected_link" "false"
+          info "Repaired: $expected_link -> $expected_source (was $current_target)"
+        fi
+        repaired=$((repaired + 1))
+      elif [[ -e "$expected_link" ]]; then
+        # Something exists but isn't a symlink — skip unless --force
+        if [[ "$FORCE" == "true" ]]; then
+          if [[ "$DRY_RUN" == "true" ]]; then
+            echo "  would replace: $expected_link with symlink -> $expected_source"
+          else
+            rm -rf "$expected_link"
+            create_symlink "$expected_source" "$expected_link" "false"
+            info "Repaired: replaced $expected_link with symlink -> $expected_source"
+          fi
+          repaired=$((repaired + 1))
+        else
+          warn "$expected_link exists but is not a symlink (use --force to replace)"
+        fi
+      else
+        # Missing entirely
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would create: $expected_link -> $expected_source"
+        else
+          create_symlink "$expected_source" "$expected_link" "false"
+        fi
+        repaired=$((repaired + 1))
+      fi
+    done
+  done
+
+  # Repair CLAUDE.md symlink
+  if [[ -f "$PROJECT_ROOT/$AGENTS_MD" ]]; then
+    if [[ -L "$PROJECT_ROOT/CLAUDE.md" ]]; then
+      local current_target
+      current_target="$(readlink "$PROJECT_ROOT/CLAUDE.md")"
+      if [[ "$current_target" != "$AGENTS_MD" ]]; then
+        if [[ "$DRY_RUN" == "true" ]]; then
+          echo "  would relink: CLAUDE.md -> $AGENTS_MD (was $current_target)"
+        else
+          rm "$PROJECT_ROOT/CLAUDE.md"
+          create_symlink "$AGENTS_MD" "$PROJECT_ROOT/CLAUDE.md" "false"
+        fi
+        repaired=$((repaired + 1))
+      fi
+    elif [[ ! -e "$PROJECT_ROOT/CLAUDE.md" ]]; then
+      if [[ "$DRY_RUN" == "true" ]]; then
+        echo "  would create: CLAUDE.md -> $AGENTS_MD"
+      else
+        create_symlink "$AGENTS_MD" "$PROJECT_ROOT/CLAUDE.md" "false"
+      fi
+      repaired=$((repaired + 1))
+    fi
+  fi
+
+  # Summary
+  if [[ "$fixed" -eq 0 ]] && [[ "$skipped" -eq 0 ]] && [[ "$repaired" -eq 0 ]]; then
+    info "Nothing to fix — all directories and symlinks are correct."
+  else
+    if [[ "$fixed" -gt 0 ]]; then info "Fixed $fixed item(s)."; fi
+    if [[ "$merged" -gt 0 ]]; then info "Merged $merged item(s) (legacy overwrote existing)."; fi
+    if [[ "$skipped" -gt 0 ]]; then warn "Skipped $skipped item(s) (use without --no-clobber to merge)."; fi
+    if [[ "$repaired" -gt 0 ]]; then info "Repaired $repaired symlink(s)."; fi
+    if [[ "$fixed" -gt 0 ]]; then info "Run 'sync-agents sync' to update agent target symlinks."; fi
+  fi
+}
+
 cmd_sync() {
   ensure_agents_dir
 
@@ -936,16 +1251,30 @@ HEADER
     fi
     echo ""
 
-    # Skills
+    # Skills (directory layout: skills/name/SKILL.md, or legacy flat: skills/name.md)
     echo "## Skills"
     echo ""
+    local has_skills="false"
+    # Directory skills: skills/name/SKILL.md
+    for d in "$agents_dir/skills/"*/; do
+      [[ -d "$d" ]] || continue
+      local name
+      name="$(basename "$d")"
+      if [[ -f "$d/SKILL.md" ]]; then
+        echo "- [$name](.agents/skills/$name/SKILL.md)"
+        has_skills="true"
+      fi
+    done
+    # Legacy flat skills: skills/name.md
     if compgen -G "$agents_dir/skills/*.md" > /dev/null 2>&1; then
       for f in "$agents_dir/skills/"*.md; do
         local name
         name="$(basename "$f" .md)"
         echo "- [$name](.agents/skills/$name.md)"
+        has_skills="true"
       done
-    else
+    fi
+    if [[ "$has_skills" == "false" ]]; then
       echo "_No skills defined yet. Add one with \`sync-agents add skill <name>\`._"
     fi
     echo ""
@@ -1124,6 +1453,9 @@ main() {
     import)
       cmd_import "$@"
       ;;
+    fix)
+      cmd_fix "$@"
+      ;;
     hook)
       cmd_hook
       ;;