@bravemobile/react-native-code-push 12.0.1 → 12.0.2

package/AGENTS.md

@@ -0,0 +1,32 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+- `CodePush.js` and `package-mixins.js` expose the JavaScript API, with supporting utilities in `logging.js` and `AlertAdapter.js`.
+- Native bridges live in `android/` and `ios/`; keep platform-specific assets scoped there.
+- The Expo sample and reference implementations sit in `Examples/`, while CLI logic and packaging helpers live in `cli/` and `code-push-plugin-testing-framework/`.
+- Automated tests are authored in TypeScript under `test/` and emitted into `bin/test` after build; documentation and release notes remain in `docs/` and `Recipes/`.
+
+## Build, Test, and Development Commands
+- `npm install` installs dependencies (Node >=18 is required).
+- `npm run build:tests` transpiles the TypeScript test harness into `bin/test`.
+- `npm run test` runs the full Mocha suite across Android and iOS adapters; use `npm run test:android` or `npm run test:ios` when iterating on a single platform.
+- `npm run test:fast` skips environment setup for quicker feedback once devices are ready.
+- `npm run eslint` checks JavaScript/TypeScript style; `npm run tslint` targets the legacy TypeScript specs; `npm run jest` covers the semver logic in `versioning/`.
+- `npm run clean` clears generated artifacts before rebuilding.
+
+## Coding Style & Naming Conventions
+- Use 2-space indentation and double quotes in TypeScript tests (see `tslint.json`); match surrounding style elsewhere and let ESLint guide fixes.
+- Components and HOCs use PascalCase (`CodePush`), utilities camelCase, and CLI binaries kebab-case.
+- Keep platform guards explicit (`Platform.OS`) and annotate non-obvious flows with concise comments.
+
+## Testing Guidelines
+- Place new specs alongside `test/test.ts`; share fixtures via `test/template/` or the helper utilities in `code-push-plugin-testing-framework/`.
+- Always run `npm run build:tests` before executing tests locally or in CI.
+- Document which device targets were used when running `npm run test`, and prefer `:android`/`:ios` variants during platform-specific debugging.
+- Extend `versioning/` tests when changing release or rollback logic and verify with `npm run jest`.
+
+## Commit & Pull Request Guidelines
+- Follow conventional commits (`type(scope): summary`), mirroring history such as `chore(Example): update the example app to v12`.
+- Reference related issues in the body, summarize behavioral changes, and attach screenshots/logs for Example app updates.
+- Ensure lint, Mocha, and Jest suites pass before requesting review; include the commands executed in the PR description.
+- Rebase instead of merging from main when tidying feature branches to keep history linear.

package/expo/plugin/withCodePush.js

@@ -1,10 +1,9 @@
 const { createRunOncePlugin } = require('expo/config-plugins');
-const { withAndroidBuildScriptDependency, withAndroidMainApplicationDependency } = require('./withCodePushAndroid');
+const { withAndroidMainApplicationDependency } = require('./withCodePushAndroid');
 const { withIosBridgingHeader, withIosAppDelegateDependency } = require('./withCodePushIos');
 const pkg = require('../../package.json');
 
 const withCodePush = (config) => {
-  config = withAndroidBuildScriptDependency(config);
   config = withAndroidMainApplicationDependency(config);
   config = withIosBridgingHeader(config);
   config = withIosAppDelegateDependency(config);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bravemobile/react-native-code-push",
-  "version": "12.0.1",
+  "version": "12.0.2",
   "description": "React Native plugin for the CodePush service",
   "main": "CodePush.js",
   "typings": "typings/react-native-code-push.d.ts",

package/android/app/src/debug/AndroidManifest.xml

@@ -1,9 +0,0 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <uses-permission android:name="android.permission.INTERNET" />
-
-    <application>
-        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
-    </application>
-
-</manifest>

package/cli/commands/initCommand/test/initAndroid.test.js

@@ -1,85 +0,0 @@
-const fs = require('fs');
-const path = require('path');
-const { initAndroid, modifyMainApplicationKt } = require('../initAndroid');
-
-const tempDir = path.join(__dirname, 'temp');
-
-// https://github.com/react-native-community/template/blob/0.80.2/template/android/app/src/main/java/com/helloworld/MainApplication.kt
-const ktTemplate = `
-package com.helloworld
-
-import android.app.Application
-import com.facebook.react.PackageList
-import com.facebook.react.ReactApplication
-import com.facebook.react.ReactHost
-import com.facebook.react.ReactNativeApplicationEntryPoint.loadReactNative
-import com.facebook.react.ReactNativeHost
-import com.facebook.react.ReactPackage
-import com.facebook.react.defaults.DefaultReactHost.getDefaultReactHost
-import com.facebook.react.defaults.DefaultReactNativeHost
-
-class MainApplication : Application(), ReactApplication {
-
-  override val reactNativeHost: ReactNativeHost =
-      object : DefaultReactNativeHost(this) {
-        override fun getPackages(): List<ReactPackage> =
-            PackageList(this).packages.apply {
-              // Packages that cannot be autolinked yet can be added manually here, for example:
-              // add(MyReactNativePackage())
-            }
-
-        override fun getJSMainModuleName(): String = "index"
-
-        override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG
-
-        override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
-        override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED
-      }
-
-  override val reactHost: ReactHost
-    get() = getDefaultReactHost(applicationContext, reactNativeHost)
-
-  override fun onCreate() {
-    super.onCreate()
-    loadReactNative(this)
-  }
-}
-`;
-
-describe('Android init command', () => {
-    it('should correctly modify Kotlin MainApplication content', () => {
-        const modifiedContent = modifyMainApplicationKt(ktTemplate);
-        expect(modifiedContent).toContain('import com.microsoft.codepush.react.CodePush');
-        expect(modifiedContent).toContain('override fun getJSBundleFile(): String = CodePush.getJSBundleFile()');
-    });
-
-    it('should log a message and exit if MainApplication.java is found', async () => {
-        const originalCwd = process.cwd();
-
-        fs.mkdirSync(tempDir, { recursive: true });
-        process.chdir(tempDir);
-
-        // Arrange
-        const javaAppDir = path.join(tempDir, 'android', 'app', 'src', 'main', 'java', 'com', 'helloworld');
-        fs.mkdirSync(javaAppDir, { recursive: true });
-        const javaFilePath = path.join(javaAppDir, 'MainApplication.java');
-        const originalContent = '// Java file content';
-        fs.writeFileSync(javaFilePath, originalContent);
-
-        const consoleSpy = jest.spyOn(console, 'log').mockImplementation(() => {
-        });
-
-        // Act
-        await initAndroid();
-
-        // Assert
-        expect(consoleSpy).toHaveBeenCalledWith('MainApplication.java is not supported. Please migrate to MainApplication.kt.');
-        const finalContent = fs.readFileSync(javaFilePath, 'utf-8');
-        expect(finalContent).toBe(originalContent); // Ensure file is not modified
-
-        consoleSpy.mockRestore();
-
-        process.chdir(originalCwd);
-        fs.rmSync(tempDir, { recursive: true, force: true });
-    });
-});

package/cli/commands/initCommand/test/initIos.test.js

@@ -1,98 +0,0 @@
-const { modifyObjectiveCAppDelegate, modifySwiftAppDelegate } = require('../initIos');
-
-// https://github.com/react-native-community/template/blob/0.80.2/template/ios/HelloWorld/AppDelegate.swift
-const swiftTemplate = `
-import UIKit
-import React
-import React_RCTAppDelegate
-import ReactAppDependencyProvider
-
-@main
-class AppDelegate: UIResponder, UIApplicationDelegate {
-  var window: UIWindow?
-  var reactNativeDelegate: ReactNativeDelegate?
-  var reactNativeFactory: RCTReactNativeFactory?
-
-  func application(
-    _ application: UIApplication,
-    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil
-  ) -> Bool {
-    let delegate = ReactNativeDelegate()
-    let factory = RCTReactNativeFactory(delegate: delegate)
-    delegate.dependencyProvider = RCTAppDependencyProvider()
-    reactNativeDelegate = delegate
-    reactNativeFactory = factory
-    window = UIWindow(frame: UIScreen.main.bounds)
-    factory.startReactNative(
-      withModuleName: "HelloWorld",
-      in: window,
-      launchOptions: launchOptions
-    )
-    return true
-  }
-}
-
-class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate {
-  override func sourceURL(for bridge: RCTBridge) -> URL? {
-    self.bundleURL()
-  }
-
-  override func bundleURL() -> URL? {
-    #if DEBUG
-    RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
-    #else
-    Bundle.main.url(forResource: "main", withExtension: "jsbundle")
-    #endif
-  }
-}
-`;
-
-// https://github.com/react-native-community/template/blob/0.76.9/template/ios/HelloWorld/AppDelegate.mm
-const objcTemplate = `
-#import "AppDelegate.h"
-
-#import <React/RCTBundleURLProvider.h>
-
-@implementation AppDelegate
-
-- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
-{
-  self.moduleName = @"HelloWorld";
-  // You can add your custom initial props in the dictionary below.
-  // They will be passed down to the ViewController used by React Native.
-  self.initialProps = @{};
-
-  return [super application:application didFinishLaunchingWithOptions:launchOptions];
-}
-
-- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
-{
-  return [self bundleURL];
-}
-
-- (NSURL *)bundleURL
-{
-#if DEBUG
-  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
-#else
-  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
-#endif
-}
-
-@end
-`;
-
-describe('iOS init command - pure functions', () => {
-    it('should correctly modify Swift AppDelegate content', () => {
-        const modifiedContent = modifySwiftAppDelegate(swiftTemplate);
-        expect(modifiedContent).toContain('CodePush.bundleURL()');
-        expect(modifiedContent).not.toContain('Bundle.main.url(forResource: "main", withExtension: "jsbundle")');
-    });
-
-    it('should correctly modify Objective-C AppDelegate content', () => {
-        const modifiedContent = modifyObjectiveCAppDelegate(objcTemplate);
-        expect(modifiedContent).toContain('#import <CodePush/CodePush.h>');
-        expect(modifiedContent).toContain('[CodePush bundleURL]');
-        expect(modifiedContent).not.toContain('[[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];');
-    });
-});