@brandocms/jupiter 3.46.0 → 3.46.1

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+#### 3.46.1
+
+- Lazyload: Fix loading loop for Chrome. Only reset `sizes` on load for firefox browsers,
+  and when the image has not been loaded before.
+
+
 #### 3.46.0
 
 - **BREAKING** Marquee: Drop `paddingLeft` -- add `startProgress`. This sets where in the 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@brandocms/jupiter",
-    "version": "3.46.0",
+    "version": "3.46.1",
     "description": "Frontend helpers.",
     "author": "Univers/Twined",
     "license": "UNLICENSED",

package/src/modules/Lazyload/index.js

@@ -187,18 +187,23 @@ export default class Lazyload {
     const img = picture.querySelector('img')
 
     const onload = () => {
+      if (!img.getAttribute('data-ll-loaded') && this.app.browser === 'firefox') {
+        // set sizes attribute on load again, 
+        // since firefox sometimes is a bit slow to 
+        // get the actual image width
+        const width = this.getWidth(img)
+
+        img.setAttribute('sizes', `${width}px`)
+        if (img.parentNode) {
+          Array.from(Dom.all(img.parentNode, 'source'))
+            .forEach(source => source.setAttribute('sizes', `${width}px`))
+        }
+      }
+      
       img.removeAttribute('data-ll-placeholder')
       img.removeAttribute('data-ll-blurred')
       img.removeAttribute('data-ll-loading')
       img.setAttribute('data-ll-loaded', '')
-
-      // set sizes attribute on load again, since firefox sometimes is a bit slow to 
-      // get the actual image width
-      const width = this.getWidth(img)
-      img.setAttribute('sizes', `${width}px`)
-      if (img.parentNode) {
-        Array.from(Dom.all(img.parentNode, 'source')).forEach(source => source.setAttribute('sizes', `${width}px`))
-      }
     }
 
     img.addEventListener('load', onload, false)

package/src/modules/Moonwalk/index.js

@@ -249,7 +249,7 @@ export default class Moonwalk {
     }
 
     const timeline = gsap.timeline({
-      // autoRemoveChildren: true
+      autoRemoveChildren: true,
       smoothChildTiming: true
     })
 
@@ -562,9 +562,13 @@ export default class Moonwalk {
       for (let i = 0; i < entries.length; i += 1) {
         const entry = entries[i]
 
-        if (entry.isIntersecting) {
+        if (entry.isIntersecting || entry.intersectionRatio > 0) {
           section.running = true
 
+          if (entry.target.dataset.moonwalkId) {
+            console.debug('-- intersecting', entry.target.dataset.moonwalkId)
+          }
+
           const walkName = entry.target.getAttribute('data-moonwalk')
           const cfg = !walkName.length ? opts.walks.default : opts.walks[walkName]