@brainervirus/workit-core 8.28.1 → 8.29.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brainervirus/workit-core",
-  "version": "8.28.1",
+  "version": "8.29.0",
   "private": false,
   "description": "Workit shared core — task, policy, evidence, review, decision, worker, and writer state for agentic coding workflows",
   "keywords": [

package/src/check-config.ts

@@ -10,6 +10,10 @@
 //    self-ignoring `.workit/`, never at the repo root. A legacy root
 //    `workit.checks.json` is still read when `.workit/checks.json` is absent,
 //    with a note that it moved.
+//    In a linked worktree (a fanout slice's, an agent's) that has neither
+//    file, the main checkout's is read: `.workit/` is git-ignored, so a new
+//    worktree never has one, and it shares the main checkout's checks
+//    (#426). Configured commands still run from the worktree's own top.
 // 2. Built-in ecosystem defaults detected from the repo: package.json scripts
 //    `test`, `lint`, `typecheck`, `check` (`<pm> run <script>`, pm from the
 //    lockfile); go.mod → `go test ./...`; Cargo.toml → `cargo test`;
@@ -216,10 +220,25 @@ function detectedChecks(root: string): NamedCheck[] {
 
 const GATES = ["testing", "verification"] as const;
 
+/**
+ * The checks config file for `root`: its own, else (in a linked worktree
+ * without one) the main checkout's, else the path a new config belongs at.
+ */
+function configFileFor(root: string): string {
+  const own = checksConfigFile(root);
+  if (fs.existsSync(own)) return own;
+  const common = git(root, ["rev-parse", "--path-format=absolute", "--git-common-dir"]);
+  if (!common || path.basename(common) !== ".git") return own;
+  const main = path.dirname(common);
+  if (path.resolve(main) === path.resolve(root)) return own;
+  const shared = checksConfigFile(main);
+  return fs.existsSync(shared) ? shared : own;
+}
+
 /** The named checks for the repository containing `cwd` (see the header). */
 export function loadCheckConfig(cwd: string): CheckConfig {
   const root = checkRoot(cwd);
-  const file = checksConfigFile(root);
+  const file = configFileFor(root);
   const legacy = path.basename(file) === LEGACY_CHECKS_FILE;
   const label = legacy ? LEGACY_CHECKS_FILE : CHECKS_FILE;
   const note = legacy

package/src/fanout-worktree.ts

@@ -255,9 +255,56 @@ export type CreateOutcome = {
   created: boolean;
   /** node_modules linked from the main checkout (worktree-deps.ts); null when none were. */
   dependencies: LinkedDependencies | null;
+  /** The install command to run in the worktree when its lockfile differs from the main checkout's. */
+  install: string | null;
   notes: string[];
 };
 
+/** Lockfiles in the order a package manager is picked, with its frozen install for a directory. */
+const LOCKFILES: ReadonlyArray<[string, (dir: string) => string]> = [
+  ["bun.lock", (dir) => `bun install --frozen-lockfile --cwd ${dir}`],
+  ["bun.lockb", (dir) => `bun install --frozen-lockfile --cwd ${dir}`],
+  ["pnpm-lock.yaml", (dir) => `pnpm install --frozen-lockfile --dir ${dir}`],
+  ["yarn.lock", (dir) => `yarn install --frozen-lockfile --cwd ${dir}`],
+  ["package-lock.json", (dir) => `npm ci --prefix ${dir}`],
+];
+
+const readBytes = (file: string): Buffer | null => {
+  try {
+    return fs.readFileSync(file);
+  } catch {
+    return null;
+  }
+};
+
+/**
+ * Link the main checkout's node_modules into `worktree` only when every
+ * lockfile is byte-identical in both: a stale main checkout would otherwise
+ * hand the worktree the wrong dependency versions (#426). When one differs,
+ * nothing is linked and `install` is the command the worker runs instead.
+ */
+function worktreeDependencies(
+  main: string,
+  worktree: string,
+): { linked: LinkedDependencies | null; install: string | null; notes: string[] } {
+  for (const [name, install] of LOCKFILES) {
+    const ours = readBytes(path.join(main, name));
+    const theirs = readBytes(path.join(worktree, name));
+    if (ours === null && theirs === null) continue;
+    if (ours !== null && theirs !== null && ours.equals(theirs)) continue;
+    if (fs.existsSync(path.join(worktree, "node_modules"))) break;
+    const command = install(worktree);
+    return {
+      linked: null,
+      install: command,
+      notes: [
+        `${name} differs from the main checkout's (${main}), so its node_modules was not linked; install dependencies first: ${command}`,
+      ],
+    };
+  }
+  return { ...linkWorktreeDependencies(main, worktree), install: null };
+}
+
 function ensureScratch(worktree: string): string {
   const scratch = path.join(worktree, SCRATCH_DIR);
   fs.mkdirSync(scratch, { recursive: true });
@@ -303,7 +350,7 @@ export function createSliceWorktree(
         `remove it yourself (git worktree remove ${target}) once you know what it holds`,
       );
     excludeScratch(cwd);
-    const deps = linkWorktreeDependencies(mainCheckout(cwd), target);
+    const deps = worktreeDependencies(mainCheckout(cwd), target);
     return {
       ok: true,
       data: {
@@ -313,6 +360,7 @@ export function createSliceWorktree(
         mode: resolveRef(cwd, localRef) ? "resume" : "new",
         created: false,
         dependencies: deps.linked,
+        install: deps.install,
         notes: [
           deps.linked
             ? "the worktree already exists; only its missing dependencies were linked"
@@ -392,7 +440,7 @@ export function createSliceWorktree(
   }
   excludeScratch(cwd);
   const scratch = ensureScratch(target);
-  const deps = linkWorktreeDependencies(mainCheckout(cwd), target);
+  const deps = worktreeDependencies(mainCheckout(cwd), target);
   notes.push(...deps.notes);
   const head = gitRun(target, ["rev-parse", "HEAD"]).stdout.trim();
   const baseSha = mode === "new" ? head : null;
@@ -415,7 +463,16 @@ export function createSliceWorktree(
   });
   return {
     ok: true,
-    data: { ...base, scratch, head, mode, created: true, dependencies: deps.linked, notes },
+    data: {
+      ...base,
+      scratch,
+      head,
+      mode,
+      created: true,
+      dependencies: deps.linked,
+      install: deps.install,
+      notes,
+    },
   };
 }