@brainervirus/workit-core 2.1.4 → 2.1.5

package/src/core/task-evaluation.ts

@@ -94,7 +94,7 @@ const gitPaths = (root: string): Inventory => {
     return {
       paths: [],
       uncertain: !/not a git repository/i.test(stderr),
-      git: /not a git repository/i.test(stderr) ? false : true,
+      git: !/not a git repository/i.test(stderr),
     };
   }
   const paths = result.stdout
@@ -219,7 +219,7 @@ export function captureCandidate(
 
   const files: Candidate["files"] = [];
   let completeness: Candidate["completeness"] = uncertain ? "uncertain" : "known";
-  for (const item of [...names].sort()) {
+  for (const item of [...names].toSorted()) {
     if (!scopeMatches(item, normalizedScope)) continue;
     const target = path.join(checkout, item);
     try {
@@ -264,7 +264,7 @@ export function captureCandidate(
   )
     return failure("invalid_input", "candidate environment names must be unique and non-empty");
   const values = supplied
-    .sort((left, right) => compareCodeUnits(left.name, right.name))
+    .toSorted((left, right) => compareCodeUnits(left.name, right.name))
     .map(({ name, value }) => ({ name, value, refs: [] }));
   if (values.some(({ value }) => value === null)) completeness = "uncertain";
   const headResult = spawnSync("git", ["rev-parse", "HEAD"], { cwd: checkout, encoding: "utf8" });

package/src/core/task-store.ts

@@ -208,10 +208,10 @@ const isNewerVersion = (candidate: string, current: string): boolean => {
       .split("-")[0]
       .split(".")
       .map((item) => Number.parseInt(item, 10) || 0);
-  const [next, now] = [parts(candidate), parts(current)];
+  const [candidateParts, currentParts] = [parts(candidate), parts(current)];
   for (let index = 0; index < 3; index += 1) {
-    const left = next[index] ?? 0;
-    const right = now[index] ?? 0;
+    const left = candidateParts[index] ?? 0;
+    const right = currentParts[index] ?? 0;
     if (left !== right) return left > right;
   }
   return false;
@@ -288,7 +288,7 @@ export class TaskStore {
       return failure("recovery_required", "task filename and record ID differ", { taskId });
     if (result.result.ok) {
       const workspace = this.readWorkspace();
-      if (!workspace.ok) return workspace as Result<never>;
+      if (!workspace.ok) return workspace;
       if (!workspace.data || result.result.data.workspaceId !== workspace.data.id)
         return failure("recovery_required", "task workspace binding is invalid", { taskId });
     }
@@ -306,13 +306,13 @@ export class TaskStore {
       });
     }
     const workspace = this.readWorkspace();
-    if (!workspace.ok) return workspace as Result<never>;
+    if (!workspace.ok) return workspace;
     if (!workspace.data)
       return failure("recovery_required", "task workspace binding is invalid", {
         path: this.workspacePath,
       });
     const tasks: TaskRecord[] = [];
-    for (const name of names.sort()) {
+    for (const name of names.toSorted()) {
       const item = this.readRecord<TaskRecord>(path.join(this.tasksDir, name), taskRecordSchema);
       if (!item.exists) continue;
       if (!item.result.ok) return item.result;
@@ -342,7 +342,7 @@ export class TaskStore {
       });
     }
     const workspace = this.readWorkspace();
-    if (!workspace.ok) return workspace as Result<never>;
+    if (!workspace.ok) return workspace;
     if (!workspace.data)
       return failure("recovery_required", "task workspace binding is invalid", {
         path: this.workspacePath,
@@ -350,7 +350,7 @@ export class TaskStore {
     const stored = this.readIndex(workspace.data.id);
     const entries: TaskIndexEntry[] = [];
     let changed = Object.keys(stored).length !== names.length;
-    for (const name of names.sort()) {
+    for (const name of names.toSorted()) {
       const file = path.join(this.tasksDir, name);
       const signature = fileSignature(file);
       if (signature === null) {
@@ -364,7 +364,7 @@ export class TaskStore {
       }
       const item = this.readRecord<TaskRecord>(file, taskRecordSchema);
       if (!item.exists) continue;
-      if (!item.result.ok) return item.result as Result<never>;
+      if (!item.result.ok) return item.result;
       if (!validId(name.slice(0, -5)) || item.result.data.id !== name.slice(0, -5))
         return failure("recovery_required", "task filename and record ID differ", { path: name });
       if (item.result.data.workspaceId !== workspace.data.id)
@@ -514,11 +514,11 @@ export class TaskStore {
         if (origin.workspaceId === current.data.id) {
           const source = this.readTask(origin.taskId);
           if (source.ok) return success(source.data.revision, current.data.revision, source.data);
-          if (source.code !== "not_found") return source as Result<never>;
+          if (source.code !== "not_found") return source;
           return failure("not_found", "source task is not present in this shared workspace");
         }
         const tasks = this.listTasks();
-        if (!tasks.ok) return tasks as Result<never>;
+        if (!tasks.ok) return tasks;
         const prior = tasks.data.filter(
           (task) =>
             task.origin?.workspaceId === origin.workspaceId &&
@@ -530,7 +530,7 @@ export class TaskStore {
             `source task has multiple imported mappings: ${prior.map((task) => task.id).join(", ")}`,
           );
         if (prior.length === 1) {
-          const existing = prior[0]!;
+          const existing = prior[0];
           if (existing.origin!.exportDigest !== origin.exportDigest)
             return failure(
               "revision_conflict",

package/src/core/tracker-issues.ts

@@ -55,7 +55,7 @@ const defaultCli = (bin: string, available: boolean): TrackerCli | null => {
     return Promise.resolve({
       status: out.status ?? 1,
       stdout: out.stdout ?? "",
-      stderr: (out.error as Error | undefined)?.message ?? out.stderr ?? "",
+      stderr: out.error?.message ?? out.stderr ?? "",
     });
   };
 };

package/src/core/uninstall.ts

@@ -125,7 +125,7 @@ function cleanCursorSettings(
   const next = { ...settings };
   let changed = false;
   if (isRecord(next.enabled_plugins)) {
-    const enabled = { ...(next.enabled_plugins as Record<string, unknown>) };
+    const enabled = { ...next.enabled_plugins };
     for (const identity of ["workit", ...CURSOR_LEGACY_IDENTITIES]) {
       if (identity in enabled) {
         delete enabled[identity];
@@ -177,7 +177,7 @@ function cleanCursorMcp(mcp: Record<string, unknown>): {
   const next = { ...mcp };
   let changed = false;
   if (isRecord(next.mcpServers)) {
-    const servers = { ...(next.mcpServers as Record<string, unknown>) };
+    const servers = { ...next.mcpServers };
     for (const name of ["workit", "workflow-toolkit"]) {
       if (name in servers) {
         delete servers[name];
@@ -211,7 +211,7 @@ function cleanPiConfig(config: Record<string, unknown>): {
       changed = true;
     }
   }
-  const pi = isRecord(next.pi) ? { ...(next.pi as Record<string, unknown>) } : null;
+  const pi = isRecord(next.pi) ? { ...next.pi } : null;
   if (pi && Array.isArray(pi.extensions)) {
     const kept = pi.extensions.filter((entry) => !String(entry).includes("workit"));
     if (kept.length !== pi.extensions.length) {

package/src/core/workers.ts

@@ -117,7 +117,7 @@ const callerSession = (caller: CallerContext): HostSession =>
 const validPath = (value: unknown): value is string =>
   typeof value === "string" &&
   value.length > 0 &&
-  ![...value].some((char) => {
+  !Array.from(value).some((char) => {
     const code = char.charCodeAt(0);
     return code < 32 || code === 127;
   }) &&
@@ -157,9 +157,9 @@ export function assertProductWriteAllowed(input: ProductWriteInput): Result<Owne
     return failure("invalid_input", "invalid product write path");
   if (!input.store) return failure("permission_denied", "write authorization requires core state");
   const task = input.store.readTask(input.task.id);
-  if (!task.ok) return task as Result<never>;
+  if (!task.ok) return task;
   const workspace = input.store.readWorkspace();
-  if (!workspace.ok) return workspace as Result<never>;
+  if (!workspace.ok) return workspace;
   if (!workspace.data) return failure("not_found", "workspace not found");
   const workspaceRecord = workspace.data;
   if (task.data.status !== "active")

package/src/core/workspaces.ts

@@ -552,6 +552,7 @@ const resolveRuntimeWorkspaceCandidate = (
     if ((error as NodeJS.ErrnoException).code === "ENOENT") return null;
     throw new Error(
       `${file} could not be read: ${error instanceof Error ? error.message : String(error)}`,
+      { cause: error },
     );
   }
   let parsed: unknown;
@@ -567,7 +568,7 @@ const resolveRuntimeWorkspaceCandidate = (
       .join("; ");
     throw new Error(`${file} has invalid workspace matching data: ${detail}`);
   }
-  const entries = validated.data.workspaces as RuntimeWorkspaceCandidate[] | undefined;
+  const entries = validated.data.workspaces;
   for (const entry of entries ?? []) {
     const glob = validateWorkspaceGlob(entry.glob);
     if (!glob.ok) throw new Error(`${file} workspace ${entry.name}: ${glob.error}`);
@@ -619,10 +620,7 @@ export const resolveRuntimeWorkspacePolicy = (
       `workspace ${JSON.stringify(candidate.name)} has no profile ${JSON.stringify(profileName)}`,
     );
   const profilePolicy = profile?.[key] as WorkspaceBranchPolicy | WorkspaceCommitPolicy | undefined;
-  const workspacePolicy = candidate[key] as
-    | WorkspaceBranchPolicy
-    | WorkspaceCommitPolicy
-    | undefined;
+  const workspacePolicy = candidate[key];
   return {
     policy: profilePolicy ?? workspacePolicy,
     source: profilePolicy
@@ -700,7 +698,7 @@ export const selectReleaseTrack = (
   requestedTrack?: string,
 ): ReleaseTrackSelection => {
   const tracks = workspace.releaseTracks ?? {};
-  const choices = Object.keys(tracks).sort();
+  const choices = Object.keys(tracks).toSorted();
   if (requestedTrack === undefined) {
     if (choices.length === 0) return { status: "not_configured" };
     if (choices.length > 1) return { status: "choice_required", choices };

package/src/core/youtrack-tools.ts

@@ -84,7 +84,7 @@ export const defaultOperations: YouTrackOperations = {
         issueId,
         markdown,
         workspace_root: workspaceRoot,
-      } as never),
+      }),
     ),
   logTime: async (input) => unwrap(await legacyLogTime(input as never)),
 };