@brainervirus/workit-core 0.5.6 → 0.6.1

package/src/core/config.ts

@@ -1,4 +1,12 @@
-import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import {
+  copyFileSync,
+  cpSync,
+  existsSync,
+  mkdirSync,
+  readFileSync,
+  readdirSync,
+  writeFileSync,
+} from "node:fs";
 import os from "node:os";
 import path from "node:path";
 
@@ -12,16 +20,69 @@ export type ToolkitConfig = {
 };
 
 export const PRESETS: Record<BranchPreset, { allowed: string[]; protected: string[] }> = {
-  gitflow: { allowed: ["feature/*", "bugfix/*", "hotfix/*", "release/*"], protected: ["main", "develop", "master", "prod", "production"] },
+  gitflow: {
+    allowed: ["feature/*", "bugfix/*", "hotfix/*", "release/*"],
+    protected: ["main", "develop", "master", "prod", "production"],
+  },
   "github-flow": { allowed: ["*"], protected: ["main"] },
   "trunk-based": { allowed: ["*"], protected: ["main"] },
   custom: { allowed: [], protected: [] },
 };
 
-export const configDir = (): string =>
-  process.env.WORKFLOW_TOOLKIT_CONFIG
-  ?? process.env.WORKFLOW_TOOLKIT_CONFIG_DIR
-  ?? path.join(process.env.XDG_CONFIG_HOME || path.join(os.homedir(), ".config"), "workflow-toolkit");
+export const resolveConfigDir = (): string =>
+  process.env.WORKFLOW_TOOLKIT_CONFIG ??
+  process.env.WORKFLOW_TOOLKIT_CONFIG_DIR ??
+  path.join(process.env.XDG_CONFIG_HOME || path.join(os.homedir(), ".config"), "workit");
+
+// One-time lazy migration from the legacy ~/.config/workflow-toolkit dir.
+// migratedDir remembers the resolved dir already checked: configDir() is on
+// hot paths, so subsequent calls are one string compare. Re-checking per
+// unique dir also keeps tests with swapped env working.
+// ponytail: cache keyed by dir value — an env override explicitly set to the
+// default path caches before migration could trigger; only matters if that
+// env is cleared mid-process (next unique dir value re-checks).
+let migratedDir: string | null = null;
+// A mid-loop copy failure leaves the new dir half-populated; keep retrying
+// until a full pass succeeds instead of silently skipping the failed entry.
+let migrationFailed = false;
+
+export const ensureConfigDir = (dir: string = resolveConfigDir()): string => {
+  if (migratedDir === dir) return dir;
+  if (process.env.WORKFLOW_TOOLKIT_CONFIG || process.env.WORKFLOW_TOOLKIT_CONFIG_DIR) {
+    migratedDir = dir;
+    return dir;
+  }
+  const legacy = path.join(
+    process.env.XDG_CONFIG_HOME || path.join(os.homedir(), ".config"),
+    "workflow-toolkit",
+  );
+  if (!existsSync(legacy)) {
+    migratedDir = dir;
+    return dir;
+  }
+  if (!migrationFailed && existsSync(dir)) {
+    migratedDir = dir;
+    return dir;
+  }
+  migrationFailed = false;
+  mkdirSync(dir, { recursive: true });
+  for (const entry of readdirSync(legacy, { withFileTypes: true })) {
+    const src = path.join(legacy, entry.name);
+    const dest = path.join(dir, entry.name);
+    if (existsSync(dest)) continue;
+    try {
+      if (entry.isDirectory()) cpSync(src, dest, { recursive: true });
+      else if (entry.isFile()) copyFileSync(src, dest);
+    } catch (err) {
+      migrationFailed = true;
+      console.warn(`[workit] config migration: failed to copy ${src}: ${(err as Error).message}`);
+    }
+  }
+  if (!migrationFailed) migratedDir = dir;
+  return dir;
+};
+
+export const configDir = (): string => ensureConfigDir();
 
 export const LOCALE_RE = /^[a-z]{2,3}(-[A-Z]{2})?$/;
 
@@ -29,11 +90,19 @@ const DEFAULTS: ToolkitConfig = {
   locale: "en",
   localeOptions: ["en", "es-CL", "es-MX", "es-AR", "pt-BR"],
   timezone: "America/Santiago",
-  branchPolicy: { preset: "gitflow", allowed: [...PRESETS.gitflow.allowed], protected: [...PRESETS.gitflow.protected] },
+  branchPolicy: {
+    preset: "gitflow",
+    allowed: [...PRESETS.gitflow.allowed],
+    protected: [...PRESETS.gitflow.protected],
+  },
 };
 
 const readSafe = (p: string): string | null => {
-  try { return readFileSync(p, "utf8"); } catch { return null; }
+  try {
+    return readFileSync(p, "utf8");
+  } catch {
+    return null;
+  }
 };
 
 export const readConfig = (): ToolkitConfig => {
@@ -41,18 +110,26 @@ export const readConfig = (): ToolkitConfig => {
   if (!raw) return DEFAULTS;
   try {
     const parsed = JSON.parse(raw) as Partial<ToolkitConfig>;
-    const locale = LOCALE_RE.test(String(parsed.locale ?? "")) ? parsed.locale as string : DEFAULTS.locale;
+    const locale = LOCALE_RE.test(String(parsed.locale ?? ""))
+      ? (parsed.locale as string)
+      : DEFAULTS.locale;
     const preset = (parsed.branchPolicy?.preset ?? "gitflow") as BranchPreset;
     const presetOk = Object.hasOwn(PRESETS, preset) ? preset : "gitflow";
     const presetDefs = PRESETS[presetOk];
     return {
       locale,
-      localeOptions: Array.isArray(parsed.localeOptions) ? parsed.localeOptions : DEFAULTS.localeOptions,
+      localeOptions: Array.isArray(parsed.localeOptions)
+        ? parsed.localeOptions
+        : DEFAULTS.localeOptions,
       timezone: parsed.timezone ?? DEFAULTS.timezone,
       branchPolicy: {
         preset: presetOk,
-        allowed: Array.isArray(parsed.branchPolicy?.allowed) ? parsed.branchPolicy.allowed : presetDefs.allowed,
-        protected: Array.isArray(parsed.branchPolicy?.protected) ? parsed.branchPolicy.protected : presetDefs.protected,
+        allowed: Array.isArray(parsed.branchPolicy?.allowed)
+          ? parsed.branchPolicy.allowed
+          : presetDefs.allowed,
+        protected: Array.isArray(parsed.branchPolicy?.protected)
+          ? parsed.branchPolicy.protected
+          : presetDefs.protected,
       },
     };
   } catch {
@@ -66,8 +143,11 @@ export const writeConfig = (config: ToolkitConfig): void => {
   writeFileSync(path.join(dir, "config.json"), JSON.stringify(config, null, 2) + "\n", "utf8");
 };
 
-export const resolveBranchPolicy = (config: ToolkitConfig): { allowed: RegExp[]; protected: Set<string> } => {
-  const allowed = config.branchPolicy.allowed.map((p) =>
-    new RegExp(`^${p.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, ".*")}$`, "i"));
+export const resolveBranchPolicy = (
+  config: ToolkitConfig,
+): { allowed: RegExp[]; protected: Set<string> } => {
+  const allowed = config.branchPolicy.allowed.map(
+    (p) => new RegExp(`^${p.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, ".*")}$`, "i"),
+  );
   return { allowed, protected: new Set(config.branchPolicy.protected.map((p) => p.toLowerCase())) };
 };

package/src/core/detector.ts

@@ -5,8 +5,7 @@ import { parseTasksFromPlan } from "./docs-validate";
 
 export type Detection = { choices: string[]; pattern: "alpha" | "numeric" } | null;
 
-export const detectConfigGapError = (text: string): boolean =>
-  text.includes(CONFIG_GAP_MARKER);
+export const detectConfigGapError = (text: string): boolean => text.includes(CONFIG_GAP_MARKER);
 
 // Enforcement-rail detectors: case-insensitive word-boundary heuristics.
 // Conservative bias (D-03): require 1+ signal word AND 0 evidence words;
@@ -86,20 +85,27 @@ export const detectInstructionOption = (questions: unknown): boolean => {
 // Labeled blocks are stripped first so their plain closing fence (```) can't match.
 export const detectRawDocDelivery = (text: string): boolean =>
   /^```\s*$/m.test(text.replace(/```\S[^\n]*\r?\n[\s\S]*?```/g, "")) &&
-  (text.includes("# Spec") || text.includes("# Plan") ||
-    text.includes("**Spec:**") || text.includes("**Branch:**"));
+  (text.includes("# Spec") ||
+    text.includes("# Plan") ||
+    text.includes("**Spec:**") ||
+    text.includes("**Branch:**"));
 
 // Interrogative gate: a literal question mark OR explicit interrogative phrases.
 // Plain "I want to confirm..." or "the script which runs" must NOT match.
-const INTERROGATIVE = /[?¿]|which\s+one|choose\s+(?:one|between|among)|do\s+you\s+(?:want|prefer)|want\s+me\s+to/i;
+const INTERROGATIVE =
+  /[?¿]|which\s+one|choose\s+(?:one|between|among)|do\s+you\s+(?:want|prefer)|want\s+me\s+to/i;
 
 export const detectProseChoices = (text: string): Detection => {
   if (!INTERROGATIVE.test(text)) return null;
 
-  const lines = text.split("\n").map((l) => l.trim()).filter(Boolean);
+  const lines = text
+    .split("\n")
+    .map((l) => l.trim())
+    .filter(Boolean);
 
-  const alphaAll = [...text.matchAll(/([a-dA-D])[.)]\s+([^\n]*?)(?=\s+[a-dA-D][.)]\s|$)/g)]
-    .map((m) => ({ letter: m[1].toLowerCase(), choice: m[2].trim() }));
+  const alphaAll = [...text.matchAll(/([a-dA-D])[.)]\s+([^\n]*?)(?=\s+[a-dA-D][.)]\s|$)/g)].map(
+    (m) => ({ letter: m[1].toLowerCase(), choice: m[2].trim() }),
+  );
   const alphaLines = lines
     .map((l) => /^([a-dA-D])[.)]\s+(.+)$/.exec(l))
     .filter((m): m is RegExpExecArray => Boolean(m))
@@ -114,8 +120,10 @@ export const detectProseChoices = (text: string): Detection => {
     }
   }
 
-  const numericAll = [...text.matchAll(/(\d+)[.)]\s+([^\n]*?)(?=\s+\d+[.)]\s|$)/g)]
-    .map((m) => ({ num: Number(m[1]), choice: m[2].trim() }));
+  const numericAll = [...text.matchAll(/(\d+)[.)]\s+([^\n]*?)(?=\s+\d+[.)]\s|$)/g)].map((m) => ({
+    num: Number(m[1]),
+    choice: m[2].trim(),
+  }));
   const numericLines = lines
     .map((l) => /^(\d+)[.)]\s+(.+)$/.exec(l))
     .filter((m): m is RegExpExecArray => Boolean(m))
@@ -137,7 +145,10 @@ const stripFences = (text: string): string => {
   const out: string[] = [];
   let inFence = false;
   for (const line of lines) {
-    if (line.startsWith("```")) { inFence = !inFence; continue; }
+    if (line.startsWith("```")) {
+      inFence = !inFence;
+      continue;
+    }
     if (!inFence) out.push(line);
   }
   return out.join("\n");

package/src/core/docs-repo.ts

@@ -1,11 +1,10 @@
 import { existsSync, mkdirSync, readFileSync, writeFileSync, readdirSync } from "node:fs";
 import { execFileSync } from "node:child_process";
-import os from "node:os";
 import path from "node:path";
+import { configDir } from "./config";
 
 const configPath = () =>
-  process.env.WORKFLOW_DOCS_REPO_CONFIG
-  ?? path.join(os.homedir(), ".config", "workflow-toolkit", "docs-repo.json");
+  process.env.WORKFLOW_DOCS_REPO_CONFIG ?? path.join(configDir(), "docs-repo.json");
 
 export const readDocsRepoConfig = (): { path: string } | null => {
   try {
@@ -25,7 +24,8 @@ export const writeDocsRepoConfig = (docsPath: string): void => {
 export const docsRepoPath = (): string | null => readDocsRepoConfig()?.path ?? null;
 
 export const validateDocsRepo = (docsPath: string): { ok: true } | { ok: false; error: string } => {
-  if (!existsSync(docsPath)) return { ok: false, error: `docs repo path does not exist: ${docsPath}` };
+  if (!existsSync(docsPath))
+    return { ok: false, error: `docs repo path does not exist: ${docsPath}` };
   try {
     execFileSync("git", ["-C", docsPath, "rev-parse", "--is-inside-work-tree"], { stdio: "pipe" });
   } catch {
@@ -49,7 +49,10 @@ export const linkDocsRepo = (
 
 export const listSpecs = (
   workspaceRoot: string,
-): { docs_repo: string | null; specs: { slug: string; spec: string; promoted: boolean; target: string | null }[] } => {
+): {
+  docs_repo: string | null;
+  specs: { slug: string; spec: string; promoted: boolean; target: string | null }[];
+} => {
   const repoPath = docsRepoPath();
   const specs: { slug: string; spec: string; promoted: boolean; target: string | null }[] = [];
   const docsDir = path.join(workspaceRoot, "docs");
@@ -63,7 +66,9 @@ export const listSpecs = (
       if (repoPath) {
         const featuresDir = path.join(repoPath, "features");
         if (existsSync(featuresDir)) {
-          const match = readdirSync(featuresDir).find((d) => new RegExp(`^20\\d{2}-\\d{2}-${slug}$`).test(d));
+          const match = readdirSync(featuresDir).find((d) =>
+            new RegExp(`^20\\d{2}-\\d{2}-${slug}$`).test(d),
+          );
           if (match) {
             promoted = true;
             target = path.join(repoPath, "features", match);
@@ -84,13 +89,20 @@ const monthPrefix = () => {
 };
 
 const readSafe = (p: string): string | null => {
-  try { return readFileSync(p, "utf8"); } catch { return null; }
+  try {
+    return readFileSync(p, "utf8");
+  } catch {
+    return null;
+  }
 };
 
 const specSummary = (specText: string): string => {
-  const contextMatch = specText.match(/## Context\n\n([\s\S]*?)(?=\n## |\Z)/);
+  const contextMatch = specText.match(/## Context\n\n([\s\S]*?)(?=\n## |Z)/);
   if (!contextMatch) return "";
-  const first = contextMatch[1].trim().split("\n").find((l) => l.trim() && !l.startsWith("<!--"));
+  const first = contextMatch[1]
+    .trim()
+    .split("\n")
+    .find((l) => l.trim() && !l.startsWith("<!--"));
   return (first ?? "").trim();
 };
 
@@ -105,7 +117,8 @@ export const promoteSpec = (
   workspaceRoot: string,
   slug: string,
   opts: { confirmed: boolean; force?: boolean },
-): { ok: true; target_dir: string; files: string[]; index_updated: boolean }
+):
+  | { ok: true; target_dir: string; files: string[]; index_updated: boolean }
   | { ok: false; error: string; findings?: unknown[] } => {
   if (!opts.confirmed) return { ok: false, error: "confirmed: true required" };
   if (!SLUG_RE.test(slug)) return { ok: false, error: `invalid slug: ${JSON.stringify(slug)}` };
@@ -121,14 +134,22 @@ export const promoteSpec = (
 
   const planText = readSafe(path.join(workspaceRoot, planRel));
   if (planText !== null) {
-    const validated = docsValidate({ spec_path: specRel, plan_path: planRel, workspace_root: workspaceRoot });
+    const validated = docsValidate({
+      spec_path: specRel,
+      plan_path: planRel,
+      workspace_root: workspaceRoot,
+    });
     if (validated.ok === false) return { ok: false, error: validated.error };
   }
 
   const findings = qualitySpec(specText);
   const hardFindings = findings.filter((f) => f.severity === "hard");
   if (hardFindings.length > 0 && !opts.force) {
-    return { ok: false, error: "spec has hard quality findings; pass force: true to override", findings };
+    return {
+      ok: false,
+      error: "spec has hard quality findings; pass force: true to override",
+      findings,
+    };
   }
 
   // SDD working state must be gitignored before promotion
@@ -136,9 +157,21 @@ export const promoteSpec = (
     const sddDir = path.join(workspaceRoot, "docs", slug, "sdd");
     if (existsSync(sddDir)) {
       try {
-        execFileSync("git", ["-C", workspaceRoot, "check-ignore", path.posix.join("docs", slug, "sdd", "progress.md")], { stdio: "pipe" });
+        execFileSync(
+          "git",
+          [
+            "-C",
+            workspaceRoot,
+            "check-ignore",
+            path.posix.join("docs", slug, "sdd", "progress.md"),
+          ],
+          { stdio: "pipe" },
+        );
       } catch {
-        return { ok: false, error: `docs/${slug}/sdd/ is not gitignored — add 'docs/*/sdd/' to .gitignore or pass force: true` };
+        return {
+          ok: false,
+          error: `docs/${slug}/sdd/ is not gitignored — add 'docs/*/sdd/' to .gitignore or pass force: true`,
+        };
       }
     }
   }
@@ -179,7 +212,9 @@ ${planText !== null ? "| [plan.md](./plan.md) | Plan de implementación |\n" : "
   files.push("README.md");
 
   const indexPath = path.join(repoPath, "features", "README.md");
-  const indexText = readSafe(indexPath) ?? `# Features\n\nEspecificaciones y planes por feature.\n\n## Features documentadas\n\n| Feature | Repos afectados | Estado |\n| --- | --- | --- |\n`;
+  const indexText =
+    readSafe(indexPath) ??
+    `# Features\n\nEspecificaciones y planes por feature.\n\n## Features documentadas\n\n| Feature | Repos afectados | Estado |\n| --- | --- | --- |\n`;
   const row = `| [${slug}](./${prefix}-${slug}/) | ${specRepos(specText)} | Spec en revisión |`;
   const rowRe = new RegExp(`^\\| \\[${slug}\\]\\([^)]*\\) \\|.*$`, "m");
   let newIndex: string;