@brainervirus/workit-core 0.11.0 → 1.0.0

package/src/core/sdd.ts

@@ -1,353 +0,0 @@
-import {
-  appendFileSync,
-  existsSync,
-  mkdirSync,
-  readFileSync,
-  statSync,
-  writeFileSync,
-} from "node:fs";
-import { execFileSync } from "node:child_process";
-import path from "node:path";
-import { parseTasksFromPlan } from "./docs-validate";
-import { docsValidate } from "./docs-validate";
-import { readFlowState } from "./flow-state";
-import { resolveCanonicalLayout, resolveDocsPath } from "./docs-layout";
-
-const posix = (p: string) => p.split(path.sep).join("/");
-
-/** OpenCode todowrite payload. SDD ledger is persistence, not a UI substitute. */
-export function todosFromTasks(
-  tasks: { id: number | string; title: string }[],
-  completedTaskIds: (number | string)[] = [],
-) {
-  const done = new Set((completedTaskIds ?? []).map((id) => Number(id)));
-  const todos = (tasks ?? []).map((t) => {
-    const id = Number(t.id);
-    return {
-      id: `task-${id}`,
-      content: `Task ${id}: ${t.title ?? ""}`.trim(),
-      status: done.has(id) ? "completed" : "pending",
-    };
-  });
-  const firstPending = todos.find((t) => t.status === "pending");
-  if (firstPending) firstPending.status = "in_progress";
-  return todos;
-}
-
-/** SDD ledger completeness facts shared by lifecycle migration, completion,
- *  and active-plan detection (Task 2). */
-export type LedgerCompletion = {
-  /** True only when progress.md contains at least one `Task N:` record. */
-  started: boolean;
-  /** True only when every canonical plan task id appears completed. */
-  complete: boolean;
-  required: number[];
-  completed: number[];
-  missing: number[];
-};
-
-/**
- * Read the canonical `docs/<slug>/sdd/progress.md` ledger and the plan's
- * `### Task N:` headings. Fail-closed: a missing or unreadable ledger yields
- * `started: false`, and a missing/unreadable plan yields an empty `required`
- * set (never a partial trust of a stale ledger). `complete` requires a
- * non-empty required set fully covered by completed task ids, so an empty plan
- * can never read as "done".
- */
-export function ledgerCompletion(root: string, slug: string): LedgerCompletion {
-  let started = false;
-  const completed: number[] = [];
-  const absProgress = path.join(root, "docs", slug, "sdd", "progress.md");
-  if (existsSync(absProgress)) {
-    try {
-      for (const line of readFileSync(absProgress, "utf8").split("\n")) {
-        const match = /^Task\s+(\d+):/i.exec(line);
-        if (match) {
-          started = true;
-          if (/^Task\s+\d+:\s*complete\b/i.test(line)) completed.push(Number(match[1]));
-        }
-      }
-    } catch {
-      // unreadable ledger: started stays false (fail-closed)
-    }
-  }
-  const required: number[] = [];
-  try {
-    const absPlan = path.join(root, "docs", slug, "plan.md");
-    if (existsSync(absPlan)) {
-      for (const task of parseTasksFromPlan(readFileSync(absPlan, "utf8"))) required.push(task.id);
-    }
-  } catch {
-    // unreadable/missing plan: required stays empty (fail-closed)
-  }
-  const completedSet = new Set(completed);
-  const missing = required.filter((id) => !completedSet.has(id));
-  return {
-    started,
-    complete: required.length > 0 && missing.length === 0,
-    required,
-    completed,
-    missing,
-  };
-}
-
-export function sddContext({
-  slug,
-  plan_path,
-  workspace_root,
-}: {
-  slug?: string;
-  plan_path?: string;
-  workspace_root: string;
-}) {
-  // One shared contained path contract (DC-01, DC-02): slug and/or plan_path
-  // resolve to a canonical layout or the call fails before anything is read.
-  const resolved = resolveCanonicalLayout({ workspace_root, slug, plan_path });
-  if (!resolved.ok) return { error: resolved.error };
-  const cwd = resolved.layout.workspace;
-  const resolvedSlug = resolved.layout.slug;
-  if (!resolvedSlug) return { error: "slug or plan_path required" };
-
-  const sdd_dir = path.posix.join("docs", resolvedSlug, "sdd");
-  const progress_path = path.posix.join(sdd_dir, "progress.md");
-  const manifest_path = path.posix.join(sdd_dir, "manifest.json");
-
-  let progress_lines: string[] = [];
-  let completed_task_ids: number[] = [];
-  const absProgress = path.join(resolved.layout.sdd, "progress.md");
-  if (existsSync(absProgress)) {
-    progress_lines = readFileSync(absProgress, "utf8")
-      .split("\n")
-      .map((ln) => ln.trim())
-      .filter(Boolean);
-    const pat = /^Task\s+(\d+):\s+complete\b/i;
-    completed_task_ids = progress_lines
-      .map((ln) => pat.exec(ln)?.[1])
-      .filter(Boolean)
-      .map(Number);
-  }
-
-  let manifest: Record<string, unknown> = {};
-  const absManifest = path.join(resolved.layout.sdd, "manifest.json");
-  if (existsSync(absManifest)) {
-    try {
-      manifest = JSON.parse(readFileSync(absManifest, "utf8"));
-    } catch {
-      manifest = {};
-    }
-  }
-
-  const legacy_path = path.join(cwd, ".superpowers/sdd");
-  const legacy_exists = existsSync(legacy_path);
-
-  let todos: { id: string; content: string; status: string }[] = [];
-  let task_count = 0;
-  if (plan_path) {
-    const planText = readFileSync(resolved.layout.plan, "utf8");
-    const specMatch = planText.match(/^\*\*Spec:\*\*\s*(?:`([^`]+)`|(\S+))/m);
-    const spec_path = specMatch?.[1] ?? specMatch?.[2] ?? "";
-    if (spec_path) {
-      const validated = docsValidate({
-        spec_path,
-        plan_path: path.relative(cwd, resolved.layout.plan),
-        workspace_root: cwd,
-      });
-      if (validated.ok === false)
-        return { ok: false, errors: validated.errors, error: validated.error };
-    }
-    const tasks = parseTasksFromPlan(planText);
-    if (tasks.length > 0) {
-      task_count = tasks.length;
-      todos = todosFromTasks(tasks, completed_task_ids);
-    }
-  }
-
-  const flow = readFlowState(cwd, resolvedSlug);
-
-  return {
-    slug: resolvedSlug,
-    sdd_dir,
-    progress_path,
-    manifest_path,
-    progress_lines,
-    completed_task_ids,
-    manifest,
-    created: existsSync(path.join(cwd, sdd_dir)),
-    forbidden_legacy_path: ".superpowers/sdd",
-    legacy_sdd_exists: legacy_exists,
-    warning: legacy_exists
-      ? "Ignore .superpowers/sdd — use sdd_dir from this tool only"
-      : undefined,
-    todos,
-    task_count,
-    flow: { spec: flow.spec, plan: flow.plan, menu: flow.menu },
-    todowrite_required: true,
-    todowrite_hint:
-      "REQUIRED: Call OpenCode todowrite with todos from this result so the native task list shows progress. Before each task set status in_progress; after workit_sdd_append_progress set it completed.",
-  };
-}
-
-export function sddTaskBrief({
-  sdd_dir,
-  task_id,
-  section_text,
-  workspace_root,
-}: {
-  sdd_dir: string;
-  task_id: number;
-  section_text: string;
-  workspace_root: string;
-}) {
-  const contained = resolveDocsPath({ workspace_root, path: sdd_dir });
-  if (!contained.ok) return { error: contained.error };
-  const dir = contained.path;
-  mkdirSync(dir, { recursive: true });
-  const out = path.join(dir, `task-${task_id}-brief.md`);
-  writeFileSync(out, `# Task ${task_id} brief\n\n${section_text}\n`, "utf8");
-  const rel = posix(path.relative(contained.base, out));
-  return { brief_path: rel, task_id };
-}
-
-export function sddReviewPackage({
-  sdd_dir,
-  base_sha,
-  head_sha,
-  workspace_root,
-}: {
-  sdd_dir: string;
-  base_sha: string;
-  head_sha: string;
-  workspace_root: string;
-}) {
-  const contained = resolveDocsPath({ workspace_root, path: sdd_dir });
-  if (!contained.ok) return { error: contained.error };
-  // Empty-range guard (Phase 2): a review package over `base..head` where the
-  // endpoints collapse to nothing is a contract error, not an artifact. Reject
-  // BEFORE any diff file is created or written (Task 1's RED evidence watches
-  // the guard, and the adapters only surface this core error — never a copy).
-  if (base_sha === head_sha) {
-    return {
-      error: `empty commit range (base_sha ${base_sha} === head_sha ${head_sha}): nothing to review`,
-      code: "empty_commit_range",
-    };
-  }
-  const dir = contained.path;
-  const base7 = base_sha.slice(0, 7);
-  const head7 = head_sha.slice(0, 7);
-  const diffPath = path.join(dir, `review-${base7}..${head7}.diff`);
-  try {
-    const diff = execFileSync("git", ["diff", base_sha, head_sha], {
-      cwd: contained.base,
-      encoding: "utf8",
-      // AR-14: a failed diff (missing shas, non-repo fixture) must stay in the
-      // captured error, never in the suite output.
-      stdio: ["pipe", "pipe", "pipe"],
-    });
-    // Distinct shas that still diff to nothing are an empty range too (the
-    // "or a diff that is empty" clause): no artifact is written for it, and
-    // the sdd/ dir is created only once a real diff survives (an empty-range
-    // rejection must leave no directory behind).
-    if (diff.trim() === "") {
-      return {
-        error: `empty commit range (${base_sha}..${head_sha}): diff is empty, nothing to review`,
-        code: "empty_commit_range",
-      };
-    }
-    mkdirSync(dir, { recursive: true });
-    writeFileSync(diffPath, diff, "utf8");
-    const rel = posix(path.relative(contained.base, diffPath));
-    return { diff_path: rel, base_sha, head_sha, base7, head7 };
-  } catch (error) {
-    return { error: error instanceof Error ? error.message : "git diff failed" };
-  }
-}
-
-const PROGRESS_RE = /^Task\s+\d+:\s+complete\s+\(commits\s+([0-9a-f]{7,40})\.\.([0-9a-f]{7,40}),/i;
-
-export function sddAppendProgress({
-  progress_path,
-  line,
-  workspace_root,
-}: {
-  progress_path: string;
-  line: string;
-  workspace_root: string;
-}) {
-  const contained = resolveDocsPath({ workspace_root, path: progress_path });
-  if (!contained.ok) return { error: contained.error };
-  const path_ = contained.path;
-  const trimmed = line.trim();
-  const match = PROGRESS_RE.exec(trimmed);
-  // A regex alone cannot compare two groups: reject identical base/head shas
-  // after the format matches so `5db04ae..bd0a810` still passes while
-  // `abcdef0123456789..abcdef0123456789` is rejected (Phase 2).
-  if (!match || match[1].toLowerCase() === match[2].toLowerCase()) {
-    return { error: "invalid progress line format" };
-  }
-  if (existsSync(path_) && statSync(path_).isDirectory()) {
-    return { error: `progress path is a directory: ${progress_path}` };
-  }
-  mkdirSync(path.dirname(path_), { recursive: true });
-  appendFileSync(path_, trimmed + "\n", "utf8");
-  const rel = posix(path.relative(contained.base, path_));
-  return { ok: true, line: trimmed, progress_path: rel };
-}
-
-export type AdvisoryResult =
-  | { ok: true; advisory: string; advisories_path: string }
-  | { error: string; code: string };
-
-export function sddAppendAdvisory({
-  advisories_path,
-  task_id,
-  text,
-  workspace_root,
-}: {
-  advisories_path: string;
-  task_id: unknown;
-  text: unknown;
-  workspace_root: string;
-}): AdvisoryResult {
-  if (typeof task_id !== "number" || !Number.isSafeInteger(task_id) || task_id <= 0) {
-    return { error: "task_id must be a positive safe integer", code: "advisory_task_invalid" };
-  }
-  if (typeof text !== "string") {
-    return {
-      error: "advisory text must be a string of 1-1000 characters after normalization",
-      code: "advisory_text_invalid",
-    };
-  }
-  if (text.includes("\r") || text.includes("\n")) {
-    return {
-      error: "advisory text must be a single line (no CR/LF)",
-      code: "advisory_text_invalid",
-    };
-  }
-  const collapsed = text.trim().replace(/[ \t]+/g, " ");
-  if (collapsed.length === 0 || collapsed.length > 1000) {
-    return {
-      error: "advisory text must be 1-1000 characters after trim and horizontal-space collapse",
-      code: "advisory_text_invalid",
-    };
-  }
-  if (!/^docs\/[^/]+\/sdd\/advisories\.md$/.test(advisories_path)) {
-    return {
-      error: `advisories_path must be docs/<slug>/sdd/advisories.md: ${advisories_path}`,
-      code: "advisory_path_invalid",
-    };
-  }
-  const contained = resolveDocsPath({ workspace_root, path: advisories_path });
-  if (!contained.ok) return { error: contained.error, code: "advisory_path_invalid" };
-  const abs = contained.path;
-  if (existsSync(abs) && statSync(abs).isDirectory()) {
-    return {
-      error: `advisory target is a directory: ${advisories_path}`,
-      code: "advisory_target_invalid",
-    };
-  }
-  mkdirSync(path.dirname(abs), { recursive: true });
-  const line = `- Task ${task_id}: ${collapsed}\n`;
-  appendFileSync(abs, line, "utf8");
-  const rel = posix(path.relative(contained.base, abs));
-  return { ok: true, advisory: collapsed, advisories_path: rel };
-}

package/src/state.ts

@@ -1,22 +0,0 @@
-export type WorkflowState = { spec: string; plan: string; sdd: string };
-
-export class WorkflowStateStore {
-  #sessions = new Map<string, WorkflowState>();
-
-  constructor() {}
-
-  set(sessionID: string, state: WorkflowState) {
-    this.#sessions.set(sessionID, { spec: state.spec, plan: state.plan, sdd: state.sdd });
-  }
-
-  get(sessionID: string) {
-    return this.#sessions.get(sessionID);
-  }
-
-  compactionContext(sessionID: string) {
-    const value = this.get(sessionID);
-    return value
-      ? `Active workflow:\nSpec: ${value.spec}\nPlan: ${value.plan}\nSDD: ${value.sdd}`
-      : null;
-  }
-}

package/templates/superpowers-doc-contract.md

@@ -1,75 +0,0 @@
-# Superpowers document contract
-
-Use OpenCode's native `question` for every bounded user choice. Give concise choices and allow a custom answer; if the tool is unavailable, ask one concise plain-text question. Use `skill` to load workflow and Superpowers skills, `todowrite` for task state, and `task` for delegated work (OpenCode) or the host-native equivalent — on Cursor, Subagent-driven dispatches Cursor-native subagents with a task `delegation_token`, Inline runs single-agent in the current session.
-
-## Tracked document layout
-
-| Document | Path |
-| --- | --- |
-| Spec | `docs/<slug>/spec.md` |
-| Plan | `docs/<slug>/plan.md` |
-| SDD state | `docs/<slug>/sdd/` |
-
-An optional human mirror may live at `docs/specs/<same-basename>.md`; when present, keep its branch identical.
-
-Specs require:
-
-```markdown
-**Branch:** `feature/<slug>`
-```
-
-Plans require:
-
-```markdown
-**Spec:** `docs/<slug>/spec.md`
-**Branch:** `feature/<slug>`
-```
-
-`bugfix/<slug>` is also valid. Never use `main`, `develop`, `master`, or `prod`. Use plain backtick paths. Top-level headings are exactly `### Task N: Title`; steps use `- [ ] **Step N:** ...`; task headings never appear inside fences.
-
-Before writing **Branch:** into a new spec or plan, call `workit_docs_branch` and write the returned `branch` verbatim. When `action` is `keep`, use the current feature/bugfix branch. When `action` is `create_from_develop` or `create_from_base`, create the branch only through `workit_branch_setup`; it uses the configured workspace/global target branch.
-
-## Execution and handoff
-
-- Implementation uses `wk-implement` and subagent-driven development, with native `todowrite` and `task`.
-- Commits use `wk-commit` after its native `question` confirmation.
-- Continuation uses `wk-handoff`, whose `workit_handoff_session` creates and seeds the OpenCode session automatically.
-- Never use worktrees. Resolve the declared branch with `workit_resolve_branch`, preview dirty-tree stash choices with `question`, and apply an approved in-place checkout through `workit_branch_setup` with `confirmed: true` (grounded in the recorded NativeChoiceEvidence).
-- Flow-tool confirmations are never agent-typed booleans and never caller-supplied evidence objects: on OpenCode the plugin records the user's native-`question` answer as a host-observed one-use receipt (`attested: true`, `callID`, `selectedLabel`, `recordedAt`) consumed by `workit_spec_approve` / `workit_plan_approve` / `workit_plan_menu` — no evidence argument exists, and delegated worker status comes from host session parentage (`parentID`), never a caller `role` field. On Cursor, confirmations are policy-only (`attested: false`), Subagent-driven execution is supported through the one-time `coordinator_lease` and per-task `delegation_token` minted by `workit_delegate` (fail-closed validation; no `parentID` identity exists on Cursor), and Inline runs single-agent in the current session.
-- Keep all SDD state under the gitignored `docs/<slug>/sdd/`; use `workit_sdd_context` and the registered `workit_sdd_*` tools.
-- After implementation, use `question` before an approved stash reapply through `workit_branch_setup` with `confirmed: true`.
-
-## YouTrack content
-
-Chat follows the user's language. YouTrack task comments are Spanish (`es-CL`) and use `workit_youtrack_draft` followed by reviewed `workit_youtrack_post` with `confirmed: true`. Preserve the user's paragraph voice; do not inject commits, file paths, or robotic bullet reports.
-
-## Final self-check
-
-Before handoff, call `workit_docs_validate` on the linked spec/plan pair. Hard-fail on any error; never offer execution when validation fails.
-
-Before handoff, verify the saved spec path, plan path, declared branch, top-level task numbering, and workflow-managed SDD directory through the registered read-only workflow tools. Report structured failures; never infer success.
-
-## Post-plan execution choice
-
-After saving a plan, call `workit_docs_validate` on the spec/plan pair. On failure, stop and fix docs — do not offer execution.
-
-On success, use native `question` / Cursor `AskQuestion` with exactly these options (no stay, no A/B/C prose duplicate):
-
-1. Subagent-driven → load `wk-implement`
-2. Inline → execute in this session
-3. Handoff → load `wk-handoff` (new session only)
-4. Review spec first
-5. Review plan first
-6. Change model first
-
-`Change model first` is display-only deferral: it ends the turn without calling `workit_plan_menu` and re-presents the menu on the next turn. Every other choice must call `workit_plan_menu` immediately after the answer and before any skill, branch question, mutation, or handoff.
-
-Never emit Superpowers text beginning “Two execution options”.
-
-A handoff destination session (the seeded contract carries `<workflow-handoff-destination>true</workflow-handoff-destination>`) presents exactly five choices — Subagent-driven, Inline, Review spec first, Review plan first, Change model first — and never re-offers the originating handoff option.
-
-- Specs/plans must follow `templates/spec-template.md` / `templates/plan-template.md` (mandated diagrams, tables, CA-XX).
-
-## Doc delivery
-
-When delivering a spec or plan, use a clickable markdown link (\`[spec.md](docs/<slug>/spec.md)\`) and a 3-5 bullet summary of the content (Context, Goals, key decisions, status). Never reference docs with backtick-only paths.

package/vendor/superpowers/skills/brainstorming/SKILL.md

@@ -1,159 +0,0 @@
----
-name: brainstorming
-description: "You MUST use this before any creative work - creating features, building components, adding functionality, or modifying behavior. Explores user intent, requirements and design before implementation."
----
-
-# Brainstorming Ideas Into Designs
-
-Help turn ideas into fully formed designs and specs through natural collaborative dialogue.
-
-Start by understanding the current project context, then ask questions one at a time to refine the idea. Once you understand what you're building, present the design and get user approval.
-
-<HARD-GATE>
-Do NOT invoke any implementation skill, write any code, scaffold any project, or take any implementation action until you have presented a design and the user has approved it. This applies to EVERY project regardless of perceived simplicity.
-</HARD-GATE>
-
-## Anti-Pattern: "This Is Too Simple To Need A Design"
-
-Every project goes through this process. A todo list, a single-function utility, a config change — all of them. "Simple" projects are where unexamined assumptions cause the most wasted work. The design can be short (a few sentences for truly simple projects), but you MUST present it and get approval.
-
-## Checklist
-
-You MUST create a task for each of these items and complete them in order:
-
-1. **Explore project context** — check files, docs, recent commits
-2. **Offer the visual companion just-in-time** — NOT upfront. The first time a question would genuinely be clearer shown than described, offer it then (its own message); on approval its browser tab opens for you. If no visual question ever arises, never offer it. See the Visual Companion section below.
-3. **Ask clarifying questions** — one at a time, understand purpose/constraints/success criteria
-4. **Propose 2-3 approaches** — with trade-offs and your recommendation
-5. **Present design** — in sections scaled to their complexity, get user approval after each section
-6. **Write design doc** — save to `docs/<slug>/spec.md` and commit
-7. **Spec self-review** — quick inline check for placeholders, contradictions, ambiguity, scope (see below)
-8. **User reviews written spec** — ask user to review the spec file before proceeding
-9. **Transition to implementation** — invoke writing-plans skill to create implementation plan
-
-## Process Flow
-
-```dot
-digraph brainstorming {
-    "Explore project context" [shape=box];
-    "Ask clarifying questions" [shape=box];
-    "Propose 2-3 approaches" [shape=box];
-    "Present design sections" [shape=box];
-    "User approves design?" [shape=diamond];
-    "Write design doc" [shape=box];
-    "Spec self-review\n(fix inline)" [shape=box];
-    "User reviews spec?" [shape=diamond];
-    "Invoke writing-plans skill" [shape=doublecircle];
-
-    "Explore project context" -> "Ask clarifying questions";
-    "Ask clarifying questions" -> "Propose 2-3 approaches";
-    "Propose 2-3 approaches" -> "Present design sections";
-    "Present design sections" -> "User approves design?";
-    "User approves design?" -> "Present design sections" [label="no, revise"];
-    "User approves design?" -> "Write design doc" [label="yes"];
-    "Write design doc" -> "Spec self-review\n(fix inline)";
-    "Spec self-review\n(fix inline)" -> "User reviews spec?";
-    "User reviews spec?" -> "Write design doc" [label="changes requested"];
-    "User reviews spec?" -> "Invoke writing-plans skill" [label="approved"];
-}
-```
-
-**The terminal state is invoking writing-plans.** Do NOT invoke frontend-design, mcp-builder, or any other implementation skill. The ONLY skill you invoke after brainstorming is writing-plans.
-
-## The Process
-
-**Understanding the idea:**
-
-- Check out the current project state first (files, docs, recent commits)
-- Before asking detailed questions, assess scope: if the request describes multiple independent subsystems (e.g., "build a platform with chat, file storage, billing, and analytics"), flag this immediately. Don't spend questions refining details of a project that needs to be decomposed first.
-- If the project is too large for a single spec, help the user decompose into sub-projects: what are the independent pieces, how do they relate, what order should they be built? Then brainstorm the first sub-project through the normal design flow. Each sub-project gets its own spec → plan → implementation cycle.
-- For appropriately-scoped projects, ask questions one at a time to refine the idea
-- Prefer multiple choice questions when possible, but open-ended is fine too
-- Only one question per message - if a topic needs more exploration, break it into multiple questions
-- Focus on understanding: purpose, constraints, success criteria
-
-**Exploring approaches:**
-
-- Propose 2-3 different approaches with trade-offs
-- Present options conversationally with your recommendation and reasoning
-- Lead with your recommended option and explain why
-
-**Presenting the design:**
-
-- Once you believe you understand what you're building, present the design
-- Scale each section to its complexity: a few sentences if straightforward, up to 200-300 words if nuanced
-- Ask after each section whether it looks right so far
-- Cover: architecture, components, data flow, error handling, testing
-- Be ready to go back and clarify if something doesn't make sense
-
-**Design for isolation and clarity:**
-
-- Break the system into smaller units that each have one clear purpose, communicate through well-defined interfaces, and can be understood and tested independently
-- For each unit, you should be able to answer: what does it do, how do you use it, and what does it depend on?
-- Can someone understand what a unit does without reading its internals? Can you change the internals without breaking consumers? If not, the boundaries need work.
-- Smaller, well-bounded units are also easier for you to work with - you reason better about code you can hold in context at once, and your edits are more reliable when files are focused. When a file grows large, that's often a signal that it's doing too much.
-
-**Working in existing codebases:**
-
-- Explore the current structure before proposing changes. Follow existing patterns.
-- Where existing code has problems that affect the work (e.g., a file that's grown too large, unclear boundaries, tangled responsibilities), include targeted improvements as part of the design - the way a good developer improves code they're working in.
-- Don't propose unrelated refactoring. Stay focused on what serves the current goal.
-
-## After the Design
-
-**Documentation:**
-
-- Write the validated design (spec) to `docs/<slug>/spec.md`
-  - (User preferences for spec location override this default)
-- Use elements-of-style:writing-clearly-and-concisely skill if available
-- Commit the design document to git
-
-**Spec Self-Review:**
-After writing the spec document, look at it with fresh eyes:
-
-1. **Placeholder scan:** Any "TBD", "TODO", incomplete sections, or vague requirements? Fix them.
-2. **Internal consistency:** Do any sections contradict each other? Does the architecture match the feature descriptions?
-3. **Scope check:** Is this focused enough for a single implementation plan, or does it need decomposition?
-4. **Ambiguity check:** Could any requirement be interpreted two different ways? If so, pick one and make it explicit.
-
-Fix any issues inline. No need to re-review — just fix and move on.
-
-**User Review Gate:**
-After the spec review loop passes, ask the user to review the written spec before proceeding:
-
-> "Spec written and committed to `<path>`. Please review it and let me know if you want to make any changes before we start writing out the implementation plan."
-
-Wait for the user's response. If they request changes, make them and re-run the spec review loop. Only proceed once the user approves.
-
-**Implementation:**
-
-- Invoke the writing-plans skill to create a detailed implementation plan
-- Do NOT invoke any other skill. writing-plans is the next step.
-
-## Key Principles
-
-- **One question at a time** - Don't overwhelm with multiple questions
-- **Multiple choice preferred** - Easier to answer than open-ended when possible
-- **YAGNI ruthlessly** - Remove unnecessary features from all designs
-- **Explore alternatives** - Always propose 2-3 approaches before settling
-- **Incremental validation** - Present design, get approval before moving on
-- **Be flexible** - Go back and clarify when something doesn't make sense
-
-## Visual Companion
-
-A browser-based companion for showing mockups, diagrams, and visual options during brainstorming. Available as a tool — not a mode. Accepting the companion means it's available for questions that benefit from visual treatment; it does NOT mean every question goes through the browser.
-
-**Offering the companion (just-in-time):** Do NOT offer it upfront. Wait until a question would genuinely be clearer shown than told — a real mockup / layout / diagram question, not merely a UI *topic*. The first time that happens, offer it then, as its own message:
-> "This next part might be easier if I show you — I can put together mockups, diagrams, and comparisons in a browser tab as we go. It's still new and can be token-intensive. Want me to? I'll open it for you."
-
-**This offer MUST be its own message.** Only the offer — no clarifying question, summary, or other content. Wait for the user's response. If they accept, start the server with `--open` so their browser opens to the first screen automatically. If they decline, continue text-only and don't offer again unless they raise it.
-
-**Per-question decision:** Even after the user accepts, decide FOR EACH QUESTION whether to use the browser or the terminal. The test: **would the user understand this better by seeing it than reading it?**
-
-- **Use the browser** for content that IS visual — mockups, wireframes, layout comparisons, architecture diagrams, side-by-side visual designs
-- **Use the terminal** for content that is text — requirements questions, conceptual choices, tradeoff lists, A/B/C/D text options, scope decisions
-
-A question about a UI topic is not automatically a visual question. "What does personality mean in this context?" is a conceptual question — use the terminal. "Which wizard layout works better?" is a visual question — use the browser.
-
-If they agree to the companion, read the detailed guide before proceeding:
-`skills/brainstorming/visual-companion.md`