@bpmn-io/properties-panel 3.40.4 → 3.40.6

package/dist/index.js

@@ -572,10 +572,10 @@ function useDescriptionContext(id, element) {
 function useDebounce(callback, debounceFn) {
   const debouncedCallback = hooks.useCallback(debounceFn(callback), [callback, debounceFn]);
 
-  // make sure previous call is not stalled
+  // flush pending calls before unmount the debounced function
   hooks.useEffect(() => {
     return () => {
-      debouncedCallback.cancel?.();
+      debouncedCallback.flush?.();
     };
   }, [debouncedCallback]);
   return debouncedCallback;
@@ -1992,6 +1992,7 @@ const FeelEditor = compat.forwardRef((props, ref) => {
     value,
     onInput,
     onKeyDown: onKeyDownProp = noop$4,
+    onBlur = noop$4,
     onFeelToggle = noop$4,
     onLint = noop$4,
     onOpenPopup = noop$4,
@@ -2015,6 +2016,9 @@ const FeelEditor = compat.forwardRef((props, ref) => {
     onInput(newValue);
     setLocalValue(newValue);
   });
+  const handleBlur = useStaticCallback(() => {
+    onBlur();
+  });
   hooks.useEffect(() => {
     let editor;
 
@@ -2041,13 +2045,16 @@ const FeelEditor = compat.forwardRef((props, ref) => {
       onKeyDown: onKeyDown,
       onLint: onLint,
       placeholder: placeholder,
+      readOnly: disabled,
       tooltipContainer: tooltipContainer,
       value: localValue,
       variables,
       builtins,
       dialect,
       parserDialect,
-      extensions: [...(enableGutters ? [view.lineNumbers()] : []), view.EditorView.lineWrapping],
+      extensions: [...(enableGutters ? [view.lineNumbers()] : []), view.EditorView.lineWrapping, view.EditorView.domEventHandlers({
+        blur: handleBlur
+      })],
       contentAttributes
     });
     setEditor(editor);
@@ -2516,19 +2523,23 @@ function FeelTextfield(props) {
    * @type { import('min-dash').DebouncedFunction }
    */
   const handleInput = useDebounce(onInput, debounce);
+  const setAndCommitValue = newValue => {
+    // cancel any pending debounced value
+    handleInput.cancel?.();
+    setLocalValue(newValue);
+    onInput(newValue);
+  };
   const handleFeelToggle = useStaticCallback(() => {
     if (feel === 'required') {
       return;
     }
     if (!feelActive) {
-      setLocalValue('=' + localValue);
-      handleInput('=' + localValue);
+      setAndCommitValue('=' + localValue);
     } else {
-      setLocalValue(feelOnlyValue);
-      handleInput(feelOnlyValue);
+      setAndCommitValue(feelOnlyValue);
     }
   });
-  const handleLocalInput = (newValue, useDebounce = true) => {
+  const handleInputChange = newValue => {
     if (feelActive) {
       newValue = '=' + newValue;
     }
@@ -2536,28 +2547,32 @@ function FeelTextfield(props) {
       return;
     }
     setLocalValue(newValue);
-    if (useDebounce) {
-      handleInput(newValue);
-    } else {
-      onInput(newValue);
-    }
+    handleInput(newValue);
     if (!feelActive && minDash.isString(newValue) && newValue.startsWith('=')) {
       // focus is behind `=` sign that will be removed
       setFocus(-1);
     }
   };
-  const handleOnBlur = e => {
-    handleInput.cancel?.();
+  const handleOptionalInputOnBlur = e => {
     if (e.target.type === 'checkbox') {
-      onInput(e.target.checked);
+      setAndCommitValue(e.target.checked);
     } else {
       const trimmedValue = e.target.value.trim();
-      handleLocalInput(trimmedValue, false);
+      if (trimmedValue !== localValue) {
+        // Trim changed the value — commit trimmed
+        setAndCommitValue(trimmedValue);
+      } else {
+        // Value unchanged — flush any pending debounce
+        handleInput.flush?.();
+      }
     }
     if (onBlur) {
       onBlur(e);
     }
   };
+  const handleFeelEditorOnBlur = () => {
+    handleInput.flush?.();
+  };
   const handleOnKeyDown = e => {
     if (isCmdWithChar(e)) {
       handleInput.flush?.();
@@ -2577,7 +2592,7 @@ function FeelTextfield(props) {
       entryId: id,
       hostLanguage,
       label,
-      onInput: handleLocalInput,
+      onInput: handleInputChange,
       singleLine,
       sourceElement: editorRef.current,
       tooltipContainer,
@@ -2643,8 +2658,7 @@ function FeelTextfield(props) {
       if (isFieldEmpty || isAllSelected) {
         const textData = event.clipboardData.getData('text');
         const trimmedValue = textData.trim();
-        setLocalValue(trimmedValue);
-        handleInput(trimmedValue);
+        setAndCommitValue(trimmedValue);
         if (!feelActive && minDash.isString(trimmedValue) && trimmedValue.startsWith('=')) {
           setFocus(trimmedValue.length - 1);
         }
@@ -2688,7 +2702,8 @@ function FeelTextfield(props) {
         onClick: handleFeelToggle
       }), feelActive ? jsxRuntime.jsx(FeelEditor, {
         name: id,
-        onInput: handleLocalInput,
+        onInput: handleInputChange,
+        onBlur: handleFeelEditorOnBlur,
         onKeyDown: handleOnKeyDown,
         contentAttributes: {
           'id': prefixId$5(id),
@@ -2711,9 +2726,9 @@ function FeelTextfield(props) {
       }) : jsxRuntime.jsx(OptionalComponent, {
         ...props,
         popupOpen: isPopupOpen,
-        onInput: handleLocalInput,
+        onInput: handleInputChange,
         onKeyDown: handleOnKeyDown,
-        onBlur: handleOnBlur,
+        onBlur: handleOptionalInputOnBlur,
         contentAttributes: {
           'id': prefixId$5(id),
           'aria-label': label