@boyingliu01/xp-gate 0.7.0 → 0.8.0

package/lib/ui-detector.ts

@@ -1,4 +1,4 @@
-import { execSync } from 'child_process';
+import { spawnSync } from 'child_process';
 import { readFileSync, existsSync } from 'fs';
 import { join } from 'path';
 
@@ -45,11 +45,11 @@ export function isExcluded(filePath: string, exclusions: string[]): boolean {
 }
 
 function matchGlob(filePath: string, pattern: string): boolean {
-  // Convert simplified glob to regex
+  // Escape literal dots first, then replace placeholders with regex
   const regex = pattern
+    .replace(/\./g, '\\.')
     .replace(/_STARSTAR_/g, '.*')
-    .replace(/_STAR_/g, '[^/]*')
-    .replace(/\./g, '\\.');
+    .replace(/_STAR_/g, '[^/]*');
   const re = new RegExp(`^${regex}$`);
   return re.test(filePath);
 }
@@ -75,6 +75,19 @@ function getFullExclusions(repoRoot?: string): string[] {
   return [...UI_GATE_DEFAULT_EXCLUSIONS, ...loadUiGateIgnore(repoRoot)];
 }
 
+function runGitDiff(baseBranch: string): string {
+  const result = spawnSync(
+    'git',
+    ['diff', '--name-only', `${baseBranch}..HEAD`],
+    { stdio: ['pipe', 'pipe', 'pipe'], shell: false, encoding: 'utf8' }
+  );
+  if (result.status !== 0) {
+    const stderr = String(result.stderr ?? '').trim();
+    throw new Error(stderr || `git diff exited with status ${result.status}`);
+  }
+  return String(result.stdout ?? '').trim();
+}
+
 export function detectUiSprint(baseBranch: string = 'main'): UiDetectionResult {
   try {
     const files = getChangedFiles(baseBranch);
@@ -88,18 +101,11 @@ export function detectUiSprint(baseBranch: string = 'main'): UiDetectionResult {
 }
 
 export function getChangedFiles(baseBranch: string): string[] {
-  const diffOutput = execSync(`git diff --name-only ${baseBranch}..HEAD`, {
-    encoding: 'utf8',
-    stdio: ['pipe', 'pipe', 'pipe'],
-  }).trim();
-
-  if (diffOutput === '') {
-    return [];
-  }
-
+  const diffOutput = runGitDiff(baseBranch);
+  if (diffOutput === '') return [];
   return diffOutput
     .split('\n')
-    .filter((f) => f.length > 0)
+    .filter((f: string) => f.length > 0)
     .map(parseRenamedFile);
 }
 

package/lib/ui-review.ts

@@ -5,7 +5,7 @@ import { collectUiMatches, parseRenamedFile } from './ui-detector';
 
 const RESULT_FILE = '.ui-gate-result.json';
 
-interface UiReviewResult {
+export interface UiReviewResult {
   commit: string;
   verdict: string;
   expires: string;
@@ -14,96 +14,101 @@ interface UiReviewResult {
   ui_changes_detected: string[];
 }
 
-function main(): void {
-   
-  console.log('═══ xp-gate ui-review ═══');
-   
-  console.log('');
-
-  // Get staged + modified files
+export function getChangedFilesForReview(): string[] {
   let files = '';
   try {
     files = execSync('git diff --cached --name-only && git diff --name-only', { encoding: 'utf8' }).trim();
   } catch {
-     
     console.log('⚠️ No git repo or no changes. Running in current directory.');
   }
 
-  const fileList = files
+  const fileList = parseFileList(files);
+  if (fileList.length > 0) {
+    return fileList;
+  }
+
+  console.log('No files staged or modified. Checking all tracked files.');
+  return getFallbackFileList();
+}
+
+export function parseFileList(files: string): string[] {
+  return files
     .split('\n')
     .map(parseRenamedFile)
     .filter(f => f.length > 0);
+}
 
-  if (fileList.length === 0) {
-     
-    console.log('No files staged or modified. Checking all tracked files.');
-    try {
-      files = execSync('git ls-files', { encoding: 'utf8' }).trim();
-    } catch {
-      files = execSync('find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git', { encoding: 'utf8' }).trim();
-    }
-    fileList.push(...files.split('\n').filter(f => f.length > 0));
+export function getFallbackFileList(): string[] {
+  try {
+    return parseFileList(execSync('git ls-files', { encoding: 'utf8' }).trim());
+  } catch {
+    const output = execSync(
+      'find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git',
+      { encoding: 'utf8' },
+    ).trim();
+    return parseFileList(output);
   }
+}
+
+export function buildUiReviewResult(matchedFiles: string[], now: Date = new Date()): UiReviewResult {
+  const commit = getCurrentCommit();
+  const expires = new Date(now.getTime() + 24 * 60 * 60 * 1000).toISOString();
+
+  return {
+    commit,
+    verdict: 'APPROVED',
+    expires,
+    design_review: 'APPROVED',
+    browser_qa: 'APPROVED',
+    ui_changes_detected: matchedFiles,
+  };
+}
+
+export function writeUiReviewResult(result: UiReviewResult, repoRoot: string = process.cwd()): void {
+  writeFileSync(join(repoRoot, RESULT_FILE), JSON.stringify(result, null, 2) + '\n', 'utf8');
+}
+
+function getCurrentCommit(): string {
+  return execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
+}
+
+export function main(): void {
+  console.log('═══ xp-gate ui-review ═══');
+  console.log('');
 
+  const fileList = getChangedFilesForReview();
   const result = collectUiMatches(fileList);
 
   if (!result.isUiSprint) {
-     
     console.log('ℹ️ No UI changes detected in staged/modified files.');
-     
     console.log('  Nothing to review. Exiting.');
     process.exit(0);
   }
 
-   
   console.log(`🎨 UI changes detected (${result.matchedFiles.length} files):`);
   result.matchedFiles.forEach(f => console.log(`  - ${f}`));
-   
   console.log('');
 
-   
   console.log('Next steps required before push:');
-   
   console.log('  1. Run /design-review in your AI agent session');
-   
   console.log('  2. Run /qa or /qa-only in your AI agent session');
-   
   console.log('  3. Ensure you have .delphi-config.json configured for Delphi review');
-   
   console.log('');
 
-  const commit = execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
-  const expires = new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString();
+  const uiResult = buildUiReviewResult(result.matchedFiles);
+  writeUiReviewResult(uiResult);
 
-  const uiResult: UiReviewResult = {
-    commit,
-    verdict: 'APPROVED',
-    expires,
-    design_review: 'APPROVED',
-    browser_qa: 'APPROVED',
-    ui_changes_detected: result.matchedFiles,
-  };
-
-  writeFileSync(join(process.cwd(), RESULT_FILE), JSON.stringify(uiResult, null, 2) + '\n', 'utf8');
-
-   
   console.log(`✅ Generated ${RESULT_FILE} with APPROVED verdict (template)`);
-   
-  console.log(`   Commit: ${commit}`);
-   
-  console.log(`   Expires: ${expires}`);
-   
+  console.log(`   Commit: ${uiResult.commit}`);
+  console.log(`   Expires: ${uiResult.expires}`);
   console.log('');
-   
   console.log('⚠️  REVIEW THIS FILE before push:');
-   
   console.log('   - Ensure design_review and browser_qa are actually APPROVED');
-   
   console.log('   - Edit verdict to REJECTED if issues found');
-   
   console.log('');
-   
   console.log('Then: git push (pre-push will validate this file)');
 }
 
-main();
+if (require.main === module) {
+  main();
+}

package/lib/uninstall.js

@@ -1,16 +1,15 @@
 const fs = require('fs');
 const path = require('path');
-const os = require('os');
 const crypto = require('crypto');
+const {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+} = require('./shared-paths.js');
 
-// Cross-platform home directory resolution
-const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
-
-const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
-const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
-const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
-const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
-const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
 const BACKUP_DIR = path.join(CONFIG_DIR, '.uninstall-backup');
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/xp-gate",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "description": "AI-driven development workflow: 6 quality gates + Delphi review + Sprint Flow",
   "bin": {
     "xp-gate": "./bin/xp-gate.js"

package/plugins/claude-code/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.7.0",
+  "version": "0.8.0",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Claude Code. Includes 6 quality gates, Sprint Flow, and Delphi multi-expert review.",
   "author": {