@boyingliu01/xp-gate 0.7.0 → 0.7.1

package/lib/init.js

@@ -1,18 +1,15 @@
 const fs = require('fs');
 const path = require('path');
-const os = require('os');
 const crypto = require('crypto');
-const { checkDeps } = require('./detect-deps.js');
-const { checkBash } = require('./detect-deps.js');
-
-// Cross-platform home directory resolution with os.homedir() fallback
-const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
-
-const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
-const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
-const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
-const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
-const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
+const { checkDeps, checkBash, autoInstallDeps, detectPlatform } = require('./detect-deps.js');
+const {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+} = require('./shared-paths.js');
 
 function copyHooks(srcDir, destDir) {
   ['pre-commit', 'pre-push'].forEach(hook => {
@@ -54,6 +51,35 @@ function logDeps(depCheck) {
   }
 }
 
+/**
+ * Detect which AI agent platform is in use and check/auto-install deps.
+ * @param {string} platform - 'opencode' | 'claude-code' | 'qoder'
+ */
+async function checkAndInstallDeps(platform) {
+  const depCheck = await checkDeps(platform);
+  if (depCheck.ok) {
+    logDeps(depCheck);
+    return depCheck;
+  }
+
+  // Auto-install missing deps
+  console.log(`Checking dependencies (platform: ${platform})...`);
+  const installResult = await autoInstallDeps(platform);
+  if (installResult.ok) {
+    console.log('Dependencies: OK (auto-installed)\n');
+    return { ok: true };
+  }
+
+  // Auto-install failed — report and continue with warning
+  logDeps(depCheck);
+  if (installResult.errors) {
+    for (const err of installResult.errors) {
+      console.warn(`  Auto-install failed for ${err.name}: ${err.message}`);
+    }
+  }
+  return depCheck;
+}
+
 function printUsage() {
   console.log('Choose installation mode:');
   console.log('  1) Global  — all git projects use the same hooks (recommended)');
@@ -228,7 +254,10 @@ async function init(args) {
     console.warn(`  ${bashCheck.message}\n`);
   }
 
-  logDeps(await checkDeps());
+  // Detect platform and check/auto-install dependencies
+  const platform = detectPlatform();
+  console.log(`Platform: ${platform}\n`);
+  await checkAndInstallDeps(platform);
 
   const installMode = args.includes('--global') ? 'global' :
                       args.includes('--core-only') ? 'local' :

package/lib/install-skill.js

@@ -1,25 +1,14 @@
 const fs = require('fs');
 const path = require('path');
-const os = require('os');
 const https = require('https');
 const http = require('http');
 const { execSync } = require('child_process');
-const { checkDeps } = require('./detect-deps.js');
+const { checkDeps, detectPlatform } = require('./detect-deps.js');
 const { downloadFromGitHub } = require('./download-skill.js');
 const { rollback } = require('./rollback.js');
+const { HOME_DIR, CONFIG_DIR } = require('./shared-paths.js');
 
-// Cross-platform home directory resolution
-const HOME = process.env.HOME || process.env.USERPROFILE || os.homedir();
-
-const CONFIG_DIR = path.join(HOME, '.config', 'xp-gate');
-const SKILLS_DIR = path.join(HOME, '.config', 'opencode', 'skills');
-const QODER_SKILLS_DIR = path.join(HOME, '.qoder', 'skills');
-
-// Platform-specific skill directories
-const PLATFORM_SKILLS_DIRS = {
-  opencode: SKILLS_DIR,
-  qoder: QODER_SKILLS_DIR,
-};
+const SKILLS_DIR = path.join(HOME_DIR, '.config', 'opencode', 'skills');
 
 const SKILLS_REGISTRY = {
   'sprint-flow': { repo: 'boyingliu01/xp-gate', path: 'skills/sprint-flow' },
@@ -29,23 +18,21 @@ const SKILLS_REGISTRY = {
 };
 
 async function installSkill(name, options = {}) {
-  const { offline = false, verbose = false, force = false, platform = 'opencode' } = options;
-
-  // Qoder platform has no superpowers/gstack dependency
-  if (platform !== 'qoder') {
-    const depCheck = await checkDeps();
-    if (!depCheck.ok) {
-      if (depCheck.missing) {
-        console.error(`Error: ${depCheck.missing} is required but not installed`);
-        console.error('Please install superpowers and gstack first');
-        console.error('See: https://github.com/boyingliu01/superpowers');
-        return 1;
-      }
-      if (depCheck.versionMismatch) {
-        console.error(`Error: ${depCheck.versionMismatch.name} version too old`);
-        console.error(`Need: ${depCheck.versionMismatch.required}, Found: ${depCheck.versionMismatch.found}`);
-        return 1;
-      }
+  const { offline = false, verbose = false, force = false } = options;
+  
+  const platform = detectPlatform();
+  const depCheck = await checkDeps(platform);
+  if (!depCheck.ok) {
+    if (depCheck.missing) {
+      console.error(`Error: ${depCheck.missing} is required but not installed`);
+      console.error('Please install superpowers and gstack first');
+      console.error('See: https://github.com/boyingliu01/superpowers');
+      return 1;
+    }
+    if (depCheck.versionMismatch) {
+      console.error(`Error: ${depCheck.versionMismatch.name} version too old`);
+      console.error(`Need: ${depCheck.versionMismatch.required}, Found: ${depCheck.versionMismatch.found}`);
+      return 1;
     }
   }
   
@@ -56,8 +43,7 @@ async function installSkill(name, options = {}) {
     return 1;
   }
   
-  const targetSkillsDir = PLATFORM_SKILLS_DIRS[platform] || SKILLS_DIR;
-  const targetDir = path.join(targetSkillsDir, name);
+  const targetDir = path.join(SKILLS_DIR, name);
   if (fs.existsSync(targetDir) && !force) {
     console.error(`Error: ${name} is already installed`);
     console.error('Use --force to overwrite');
@@ -155,21 +141,7 @@ async function downloadFile(url, dest, verbose) {
   });
 }
 
-function copyDirRecursive(src, dest) {
-  fs.mkdirSync(dest, { recursive: true });
-  const entries = fs.readdirSync(src, { withFileTypes: true });
-  
-  for (const entry of entries) {
-    const srcPath = path.join(src, entry.name);
-    const destPath = path.join(dest, entry.name);
-    
-    if (entry.isDirectory()) {
-      copyDirRecursive(srcPath, destPath);
-    } else {
-      fs.copyFileSync(srcPath, destPath);
-    }
-  }
-}
+const { copyDirRecursive } = require('./shared-utils');
 
 function ensureConfigDir() {
   fs.mkdirSync(CONFIG_DIR, { recursive: true });

package/lib/rollback.js

@@ -1,6 +1,7 @@
 const fs = require('fs');
 const path = require('path');
 const os = require('os');
+const { copyDirRecursive } = require('./shared-utils');
 
 // Cross-platform home directory resolution
 const HOME = process.env.HOME || process.env.USERPROFILE || os.homedir();
@@ -51,22 +52,6 @@ async function createBackup(installId, skillName) {
   return backupDir;
 }
 
-function copyDirRecursive(src, dest) {
-  fs.mkdirSync(dest, { recursive: true });
-  const entries = fs.readdirSync(src, { withFileTypes: true });
-  
-  for (const entry of entries) {
-    const srcPath = path.join(src, entry.name);
-    const destPath = path.join(dest, entry.name);
-    
-    if (entry.isDirectory()) {
-      copyDirRecursive(srcPath, destPath);
-    } else {
-      fs.copyFileSync(srcPath, destPath);
-    }
-  }
-}
-
 function cleanupBackup(installId) {
   const backupDir = path.join(BACKUP_DIR, installId);
   

package/lib/shared-paths.js

@@ -0,0 +1,30 @@
+/**
+ * Shared filesystem path constants used across CLI modules.
+ * Cross-platform home directory resolution with os.homedir() fallback.
+ *
+ * @intent Eliminate duplicate path constants in init.js / uninstall.js / detect-deps.js
+ * @covers Issue #107 — duplicate code between init.js and uninstall.js
+ */
+const path = require('path');
+const os = require('os');
+
+/**
+ * Resolve the user's home directory cross-platform.
+ * Fallback chain: HOME → USERPROFILE → os.homedir()
+ */
+const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
+
+const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
+const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
+const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
+const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
+const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
+
+module.exports = {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+};

package/lib/shared-utils.js

@@ -0,0 +1,25 @@
+/**
+ * Pure utility functions shared by CLI modules.
+ * No module-level state — safe for tests that mock fs/path/os.
+ */
+const fs = require('fs');
+
+/**
+ * Recursively copy a directory.
+ * Pure function: only uses fs/path params, no global config.
+ */
+function copyDirRecursive(src, dest) {
+  fs.mkdirSync(dest, { recursive: true });
+  const entries = fs.readdirSync(src, { withFileTypes: true });
+  for (const entry of entries) {
+    const srcPath = require('path').join(src, entry.name);
+    const destPath = require('path').join(dest, entry.name);
+    if (entry.isDirectory()) {
+      copyDirRecursive(srcPath, destPath);
+    } else {
+      fs.copyFileSync(srcPath, destPath);
+    }
+  }
+}
+
+module.exports = { copyDirRecursive };

package/lib/ui-detector.ts

@@ -45,11 +45,11 @@ export function isExcluded(filePath: string, exclusions: string[]): boolean {
 }
 
 function matchGlob(filePath: string, pattern: string): boolean {
-  // Convert simplified glob to regex
+  // Escape literal dots first, then replace placeholders with regex
   const regex = pattern
+    .replace(/\./g, '\\.')
     .replace(/_STARSTAR_/g, '.*')
-    .replace(/_STAR_/g, '[^/]*')
-    .replace(/\./g, '\\.');
+    .replace(/_STAR_/g, '[^/]*');
   const re = new RegExp(`^${regex}$`);
   return re.test(filePath);
 }

package/lib/ui-review.ts

@@ -5,7 +5,7 @@ import { collectUiMatches, parseRenamedFile } from './ui-detector';
 
 const RESULT_FILE = '.ui-gate-result.json';
 
-interface UiReviewResult {
+export interface UiReviewResult {
   commit: string;
   verdict: string;
   expires: string;
@@ -14,96 +14,101 @@ interface UiReviewResult {
   ui_changes_detected: string[];
 }
 
-function main(): void {
-   
-  console.log('═══ xp-gate ui-review ═══');
-   
-  console.log('');
-
-  // Get staged + modified files
+export function getChangedFilesForReview(): string[] {
   let files = '';
   try {
     files = execSync('git diff --cached --name-only && git diff --name-only', { encoding: 'utf8' }).trim();
   } catch {
-     
     console.log('⚠️ No git repo or no changes. Running in current directory.');
   }
 
-  const fileList = files
+  const fileList = parseFileList(files);
+  if (fileList.length > 0) {
+    return fileList;
+  }
+
+  console.log('No files staged or modified. Checking all tracked files.');
+  return getFallbackFileList();
+}
+
+export function parseFileList(files: string): string[] {
+  return files
     .split('\n')
     .map(parseRenamedFile)
     .filter(f => f.length > 0);
+}
 
-  if (fileList.length === 0) {
-     
-    console.log('No files staged or modified. Checking all tracked files.');
-    try {
-      files = execSync('git ls-files', { encoding: 'utf8' }).trim();
-    } catch {
-      files = execSync('find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git', { encoding: 'utf8' }).trim();
-    }
-    fileList.push(...files.split('\n').filter(f => f.length > 0));
+export function getFallbackFileList(): string[] {
+  try {
+    return parseFileList(execSync('git ls-files', { encoding: 'utf8' }).trim());
+  } catch {
+    const output = execSync(
+      'find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git',
+      { encoding: 'utf8' },
+    ).trim();
+    return parseFileList(output);
   }
+}
+
+export function buildUiReviewResult(matchedFiles: string[], now: Date = new Date()): UiReviewResult {
+  const commit = getCurrentCommit();
+  const expires = new Date(now.getTime() + 24 * 60 * 60 * 1000).toISOString();
+
+  return {
+    commit,
+    verdict: 'APPROVED',
+    expires,
+    design_review: 'APPROVED',
+    browser_qa: 'APPROVED',
+    ui_changes_detected: matchedFiles,
+  };
+}
+
+export function writeUiReviewResult(result: UiReviewResult, repoRoot: string = process.cwd()): void {
+  writeFileSync(join(repoRoot, RESULT_FILE), JSON.stringify(result, null, 2) + '\n', 'utf8');
+}
+
+function getCurrentCommit(): string {
+  return execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
+}
+
+export function main(): void {
+  console.log('═══ xp-gate ui-review ═══');
+  console.log('');
 
+  const fileList = getChangedFilesForReview();
   const result = collectUiMatches(fileList);
 
   if (!result.isUiSprint) {
-     
     console.log('ℹ️ No UI changes detected in staged/modified files.');
-     
     console.log('  Nothing to review. Exiting.');
     process.exit(0);
   }
 
-   
   console.log(`🎨 UI changes detected (${result.matchedFiles.length} files):`);
   result.matchedFiles.forEach(f => console.log(`  - ${f}`));
-   
   console.log('');
 
-   
   console.log('Next steps required before push:');
-   
   console.log('  1. Run /design-review in your AI agent session');
-   
   console.log('  2. Run /qa or /qa-only in your AI agent session');
-   
   console.log('  3. Ensure you have .delphi-config.json configured for Delphi review');
-   
   console.log('');
 
-  const commit = execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
-  const expires = new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString();
+  const uiResult = buildUiReviewResult(result.matchedFiles);
+  writeUiReviewResult(uiResult);
 
-  const uiResult: UiReviewResult = {
-    commit,
-    verdict: 'APPROVED',
-    expires,
-    design_review: 'APPROVED',
-    browser_qa: 'APPROVED',
-    ui_changes_detected: result.matchedFiles,
-  };
-
-  writeFileSync(join(process.cwd(), RESULT_FILE), JSON.stringify(uiResult, null, 2) + '\n', 'utf8');
-
-   
   console.log(`✅ Generated ${RESULT_FILE} with APPROVED verdict (template)`);
-   
-  console.log(`   Commit: ${commit}`);
-   
-  console.log(`   Expires: ${expires}`);
-   
+  console.log(`   Commit: ${uiResult.commit}`);
+  console.log(`   Expires: ${uiResult.expires}`);
   console.log('');
-   
   console.log('⚠️  REVIEW THIS FILE before push:');
-   
   console.log('   - Ensure design_review and browser_qa are actually APPROVED');
-   
   console.log('   - Edit verdict to REJECTED if issues found');
-   
   console.log('');
-   
   console.log('Then: git push (pre-push will validate this file)');
 }
 
-main();
+if (require.main === module) {
+  main();
+}

package/lib/uninstall.js

@@ -1,16 +1,15 @@
 const fs = require('fs');
 const path = require('path');
-const os = require('os');
 const crypto = require('crypto');
+const {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+} = require('./shared-paths.js');
 
-// Cross-platform home directory resolution
-const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
-
-const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
-const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
-const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
-const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
-const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
 const BACKUP_DIR = path.join(CONFIG_DIR, '.uninstall-backup');
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/xp-gate",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "AI-driven development workflow: 6 quality gates + Delphi review + Sprint Flow",
   "bin": {
     "xp-gate": "./bin/xp-gate.js"

package/plugins/claude-code/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Claude Code. Includes 6 quality gates, Sprint Flow, and Delphi multi-expert review.",
   "author": {