@boyingliu01/xp-gate 0.6.0 → 0.6.2

package/lib/shared-paths.js

@@ -0,0 +1,30 @@
+/**
+ * Shared filesystem path constants used across CLI modules.
+ * Cross-platform home directory resolution with os.homedir() fallback.
+ *
+ * @intent Eliminate duplicate path constants in init.js / uninstall.js / detect-deps.js
+ * @covers Issue #107 — duplicate code between init.js and uninstall.js
+ */
+const path = require('path');
+const os = require('os');
+
+/**
+ * Resolve the user's home directory cross-platform.
+ * Fallback chain: HOME → USERPROFILE → os.homedir()
+ */
+const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
+
+const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
+const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
+const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
+const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
+const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
+
+module.exports = {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+};

package/lib/shared-utils.js

@@ -0,0 +1,25 @@
+/**
+ * Pure utility functions shared by CLI modules.
+ * No module-level state — safe for tests that mock fs/path/os.
+ */
+const fs = require('fs');
+
+/**
+ * Recursively copy a directory.
+ * Pure function: only uses fs/path params, no global config.
+ */
+function copyDirRecursive(src, dest) {
+  fs.mkdirSync(dest, { recursive: true });
+  const entries = fs.readdirSync(src, { withFileTypes: true });
+  for (const entry of entries) {
+    const srcPath = require('path').join(src, entry.name);
+    const destPath = require('path').join(dest, entry.name);
+    if (entry.isDirectory()) {
+      copyDirRecursive(srcPath, destPath);
+    } else {
+      fs.copyFileSync(srcPath, destPath);
+    }
+  }
+}
+
+module.exports = { copyDirRecursive };

package/lib/ui-review.ts

@@ -5,7 +5,7 @@ import { collectUiMatches, parseRenamedFile } from './ui-detector';
 
 const RESULT_FILE = '.ui-gate-result.json';
 
-interface UiReviewResult {
+export interface UiReviewResult {
   commit: string;
   verdict: string;
   expires: string;
@@ -14,96 +14,101 @@ interface UiReviewResult {
   ui_changes_detected: string[];
 }
 
-function main(): void {
-   
-  console.log('═══ xp-gate ui-review ═══');
-   
-  console.log('');
-
-  // Get staged + modified files
+export function getChangedFilesForReview(): string[] {
   let files = '';
   try {
     files = execSync('git diff --cached --name-only && git diff --name-only', { encoding: 'utf8' }).trim();
   } catch {
-     
     console.log('⚠️ No git repo or no changes. Running in current directory.');
   }
 
-  const fileList = files
+  const fileList = parseFileList(files);
+  if (fileList.length > 0) {
+    return fileList;
+  }
+
+  console.log('No files staged or modified. Checking all tracked files.');
+  return getFallbackFileList();
+}
+
+export function parseFileList(files: string): string[] {
+  return files
     .split('\n')
     .map(parseRenamedFile)
     .filter(f => f.length > 0);
+}
 
-  if (fileList.length === 0) {
-     
-    console.log('No files staged or modified. Checking all tracked files.');
-    try {
-      files = execSync('git ls-files', { encoding: 'utf8' }).trim();
-    } catch {
-      files = execSync('find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git', { encoding: 'utf8' }).trim();
-    }
-    fileList.push(...files.split('\n').filter(f => f.length > 0));
+export function getFallbackFileList(): string[] {
+  try {
+    return parseFileList(execSync('git ls-files', { encoding: 'utf8' }).trim());
+  } catch {
+    const output = execSync(
+      'find . -maxdepth 3 -type f -name "*.ts" -o -name "*.html" -o -name "*.css" -o -name "*.scss" -o -name "*.tsx" -o -name "*.vue" -o -name "*.svelte" 2>/dev/null | grep -v node_modules | grep -v .git',
+      { encoding: 'utf8' },
+    ).trim();
+    return parseFileList(output);
   }
+}
+
+export function buildUiReviewResult(matchedFiles: string[], now: Date = new Date()): UiReviewResult {
+  const commit = getCurrentCommit();
+  const expires = new Date(now.getTime() + 24 * 60 * 60 * 1000).toISOString();
+
+  return {
+    commit,
+    verdict: 'APPROVED',
+    expires,
+    design_review: 'APPROVED',
+    browser_qa: 'APPROVED',
+    ui_changes_detected: matchedFiles,
+  };
+}
+
+export function writeUiReviewResult(result: UiReviewResult, repoRoot: string = process.cwd()): void {
+  writeFileSync(join(repoRoot, RESULT_FILE), JSON.stringify(result, null, 2) + '\n', 'utf8');
+}
+
+function getCurrentCommit(): string {
+  return execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
+}
+
+export function main(): void {
+  console.log('═══ xp-gate ui-review ═══');
+  console.log('');
 
+  const fileList = getChangedFilesForReview();
   const result = collectUiMatches(fileList);
 
   if (!result.isUiSprint) {
-     
     console.log('ℹ️ No UI changes detected in staged/modified files.');
-     
     console.log('  Nothing to review. Exiting.');
     process.exit(0);
   }
 
-   
   console.log(`🎨 UI changes detected (${result.matchedFiles.length} files):`);
   result.matchedFiles.forEach(f => console.log(`  - ${f}`));
-   
   console.log('');
 
-   
   console.log('Next steps required before push:');
-   
   console.log('  1. Run /design-review in your AI agent session');
-   
   console.log('  2. Run /qa or /qa-only in your AI agent session');
-   
   console.log('  3. Ensure you have .delphi-config.json configured for Delphi review');
-   
   console.log('');
 
-  const commit = execSync('git rev-parse HEAD 2>/dev/null || echo "no-commit"', { encoding: 'utf8' }).trim();
-  const expires = new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString();
+  const uiResult = buildUiReviewResult(result.matchedFiles);
+  writeUiReviewResult(uiResult);
 
-  const uiResult: UiReviewResult = {
-    commit,
-    verdict: 'APPROVED',
-    expires,
-    design_review: 'APPROVED',
-    browser_qa: 'APPROVED',
-    ui_changes_detected: result.matchedFiles,
-  };
-
-  writeFileSync(join(process.cwd(), RESULT_FILE), JSON.stringify(uiResult, null, 2) + '\n', 'utf8');
-
-   
   console.log(`✅ Generated ${RESULT_FILE} with APPROVED verdict (template)`);
-   
-  console.log(`   Commit: ${commit}`);
-   
-  console.log(`   Expires: ${expires}`);
-   
+  console.log(`   Commit: ${uiResult.commit}`);
+  console.log(`   Expires: ${uiResult.expires}`);
   console.log('');
-   
   console.log('⚠️  REVIEW THIS FILE before push:');
-   
   console.log('   - Ensure design_review and browser_qa are actually APPROVED');
-   
   console.log('   - Edit verdict to REJECTED if issues found');
-   
   console.log('');
-   
   console.log('Then: git push (pre-push will validate this file)');
 }
 
-main();
+if (require.main === module) {
+  main();
+}

package/lib/uninstall.js

@@ -1,16 +1,15 @@
 const fs = require('fs');
 const path = require('path');
-const os = require('os');
 const crypto = require('crypto');
+const {
+  HOME_DIR,
+  CONFIG_DIR,
+  CONFIG_FILE,
+  TEMPLATE_DIR,
+  GLOBAL_HOOKS_DIR,
+  GLOBAL_ADAPTERS_DIR,
+} = require('./shared-paths.js');
 
-// Cross-platform home directory resolution
-const HOME_DIR = process.env.HOME || process.env.USERPROFILE || os.homedir();
-
-const CONFIG_DIR = path.join(HOME_DIR, '.config', 'xp-gate');
-const CONFIG_FILE = path.join(CONFIG_DIR, 'xp-gate.json');
-const TEMPLATE_DIR = path.join(HOME_DIR, '.config', 'opencode', 'git-hooks-template');
-const GLOBAL_HOOKS_DIR = path.join(CONFIG_DIR, 'hooks');
-const GLOBAL_ADAPTERS_DIR = path.join(CONFIG_DIR, 'adapters');
 const BACKUP_DIR = path.join(CONFIG_DIR, '.uninstall-backup');
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/xp-gate",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "AI-driven development workflow: 6 quality gates + Delphi review + Sprint Flow",
   "bin": {
     "xp-gate": "./bin/xp-gate.js"

package/plugins/claude-code/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Claude Code. Includes 6 quality gates, Sprint Flow, and Delphi multi-expert review.",
   "author": {

package/skills/delphi-review/SKILL.md

@@ -1,10 +1,23 @@
 ---
 name: delphi-review
-description: "Delphi consensus review: multi-round anonymous expert review until unanimous APPROVAL. Supports design/code-walkthrough modes. 2-3 experts from different providers. MANDATORY before implementation, design, or architecture decisions. Trigger: 'review this design', '评审这个需求', 'design review', '多专家评审', 'consensus review', 'code walkthrough', 'push review', or any request for multi-expert review of requirements, design docs, architecture, or PRs."
+description: "Use when asked to review a design, plan, or architecture; before implementation starts; or when multi-expert consensus is needed. Triggers: 'review this design', '评审这个需求', 'design review', '多专家评审', 'consensus review', 'code walkthrough', 'push review', 'architecture review', 'PR review', or any request for multi-expert evaluation of requirements, design docs, or PRs."
 ---
 
 # Delphi Consensus Review
 
+## Scope
+
+**In Scope:**
+- Multi-round anonymous expert consensus review (design + code-walkthrough modes)
+- 2-3 experts from different providers with statistical consensus (>= 91%)
+- Structured verdict: APPROVED / PASS_WITH_CAVEATS / REQUEST_CHANGES
+- Domestic models only (no Anthropic/OpenAI/Google)
+
+**Out of Scope:**
+- Does NOT implement code changes (review only, implementation is separate)
+- Does NOT replace testing or CI/CD verification
+- Does NOT handle deployment or release decisions
+
 ## 核心原则
 
 **Delphi 方法只有一个目的：得到所有专家一致认可的可行方案。**
@@ -14,7 +27,7 @@ description: "Delphi consensus review: multi-round anonymous expert review until
 1. **匿名性** — Round 1 专家互不知道对方意见
 2. **迭代** — 多轮直到共识，不是固定轮数
 3. **受控反馈** — 每轮看到其他专家意见
-4. **统计共识** — >=95% 一致才算共识
+4. **统计共识** — >=91% 一致才算共识
 
 ### 质量优先
 
@@ -82,24 +95,24 @@ description: "Delphi consensus review: multi-round anonymous expert review until
 
 | 阈值 | 说明 |
 |------|------|
-| **>=95%** | 推荐默认 |
+| **>=91%** | 推荐默认 |
 | 100% | 完全一致（更严格） |
 
 ---
 
-## 完整流程
+## Delphi 评审执行过程
 
 ```
 Phase 0: 准备 → Round 1: 匿名独立评审 → 共识检查
     │
-    ├─ 一致 + >=95% + APPROVED → ✅ 完成
+    ├─ 一致 + >=91% + APPROVED → ✅ 完成
     │
-    └─ 不一致 或 <95% 或 REQUEST_CHANGES
+    └─ 不一致 或 <91% 或 REQUEST_CHANGES
           │
           ▼
        Round 2: 交换意见 → 共识检查
           │
-          ├─ 一致 + >=95% + APPROVED → ✅ 完成
+          ├─ 一致 + >=91% + APPROVED → ✅ 完成
           │
           └─ 仍分歧 或 REQUEST_CHANGES
                 │
@@ -202,14 +215,96 @@ Phase 0: 准备 → Round 1: 匿名独立评审 → 共识检查
 
 ---
 
+## Triggers
+
+This skill activates on any request for multi-expert review. Common triggers:
+
+**English:**
+- "review this design"
+- "design review"
+- "architecture review"
+- "consensus review"
+- "code walkthrough"
+- "push review"
+- "multi-expert review"
+- "PR review"
+
+**Chinese:**
+- "评审这个需求"
+- "多专家评审"
+- "设计评审"
+- "架构评审"
+- "代码走查"
+
+**Related commands:**
+- `/delphi-review` - Design review mode
+- `/delphi-review --mode code-walkthrough` - Pre-push code walkthrough
+
+---
+
+## Workflow Steps
+
+1. **Determine mode** - Design review (default) or code-walkthrough (--mode code-walkthrough)
+2. **Dispatch anonymous experts** - 2-3 experts from ≥2 different domestic model providers
+3. **Collect Round 1 independent reviews** - Anonymous, no cross-expert bias
+4. **Synthesize feedback** - Measure consensus, identify disagreements
+5. **Run Round 2+ until consensus** - Exchange opinions, iterate until ≥91% agreement
+6. **Block on unresolved Critical/Major** - Zero-tolerance: all Critical/Major must be resolved
+7. **Emit verdict** - APPROVED (with specification.yaml) or REQUEST_CHANGES (fix + re-review)
+
+**Consensus threshold:** ≥91% (project standard for Delphi review approval)
+**Model policy:** Domestic models only (DeepSeek, Qwen, Kimi, GLM, MiniMax). Foreign models (Anthropic/OpenAI/Google) forbidden.
+
+---
+
+## Scope
+
+**IN Scope:**
+- Design document review (requirements, architecture, PRDs)
+- Pre-implementation planning review
+- Code walkthrough (git push validation, max 20 files/500 LOC)
+- Multi-expert consensus building
+- Specification extraction (design → specification.yaml)
+
+**OUT Scope:**
+- Single-expert review (use `/review` instead)
+- Post-implementation review (use `/requesting-code-review`)
+- Security audit (use `/security-research` or `/cso`)
+- Performance benchmarking (use `/benchmark`)
+
+---
+
+## Examples
+
+**Example 1: Design review**
+```bash
+/delphi-review
+```
+→ 3 experts review design doc → consensus report + specification.yaml
+
+**Example 2: Code walkthrough**
+```bash
+/delphi-review --mode code-walkthrough
+```
+→ Pre-push validation → .code-walkthrough-result.json
+
+**Example 3: Chinese trigger**
+```
+User: 评审这个需求文档
+→ Auto-detects delphi-review trigger → dispatches experts
+```
+
+---
+
 ## Output Format (MANDATORY)
-Every review round output MUST follow this exact JSON structure:
+
+Every review round output MUST follow this exact JSON structure for design mode:
 
 ```json
 {
   "expert_id": "A|B|C",
   "round": 1,
-  "mode": "design|code-walkthrough",
+  "mode": "design",
   "verdict": "APPROVED|REQUEST_CHANGES|REJECTED",
   "confidence": 9,
   "critical_issues": ["..."],
@@ -218,11 +313,14 @@ Every review round output MUST follow this exact JSON structure:
   "consensus_report": {
     "agreed_items": ["..."],
     "disagreed_items": ["..."],
-    "final_verdict": "APPROVED|REQUEST_CHANGES"
+    "final_verdict": "APPROVED|REQUEST_CHANGES",
+    "consensus_ratio": 0.95
   }
 }
 ```
 
+**For code-walkthrough mode**, output follows `.code-walkthrough-result.json` schema (see `references/code-walkthrough.md`).
+
 **Anti-patterns mapping to assertions:**
 - `Round 1 → 生成报告 → "评审完成"` → Output MUST NOT have `verdict: APPROVED` if `critical_issues` exist.
 - `只处理 Critical，忽略 Major` → Output MUST include `major_concerns` array, even if empty.
@@ -242,7 +340,7 @@ Every review round output MUST follow this exact JSON structure:
 - [ ] Round 2+ 完成（交换意见 / 最终立场）
 
 **CRITICAL — 共识验证:**
-- [ ] 问题共识比例 >=95%
+- [ ] 问题共识比例 >=91%
 - [ ] 所有 Critical Issues 已解决
 - [ ] 所有 Major Concerns 已处理
 
@@ -324,7 +422,7 @@ Every review round output MUST follow this exact JSON structure:
 | 只处理 Critical，忽略 Major | 零容忍：Critical/Major 全部必须处理，不可跳过或降级 |
 | 单专家自评 | 至少 2 位不同 provider 的专家 |
 | 用户说"时间紧急"就跳过 | 评审是投资不是开销，跳过后期返工成本更高 |
-| "专家几乎一致"就通过 | "几乎" = 不一致，继续到 >=95% |
+| "专家几乎一致"就通过 | "几乎" = 不一致，继续到 >=91% |
 | 使用 Anthropic/GPT/Gemini 等国外昂贵模型 | 必须使用国产开源模型（DeepSeek, Qwen, Kimi, GLM, MiniMax） |
 | 三个专家使用同一厂家模型 | 必须来自至少 2 家不同厂家 |
 
@@ -339,7 +437,7 @@ Every review round output MUST follow this exact JSON structure:
 | "这只是小变更" | 所有变更都需要评审 |
 | "Round 1 就够了" | 不够，必须多轮直到共识 |
 | "生成报告就完成了" | APPROVED 才算完成 |
-| "2/3 同意就是共识" | 还要检查问题共识比例 >=95% |
+| "2/3 同意就是共识" | 还要检查问题共识比例 >=91% |
 
 ---
 
@@ -347,25 +445,10 @@ Every review round output MUST follow this exact JSON structure:
 
 **Delphi 评审完成的唯一标准：**
 1. ✅ 所有专家裁决 APPROVED
-2. ✅ 问题共识 >=95%
+2. ✅ 问题共识 >=91%
 3. ✅ 所有 Critical Issues 已修复验证
 4. ✅ 所有 Major Concerns 已处理
 5. ✅ 共识报告已生成
 6. ✅ 用户已确认
 
 **缺少任何一项 = 未完成**
-## Output Format (MANDATORY)
-Every delphi review round MUST output valid JSON:
-```json
-{
-  "skill_name": "delphi-review",
-  "mode": "design|code-walkthrough",
-  "phase": "Round 1|Round 2|Round 3|Consensus",
-  "expert_id": "A|B|C",
-  "verdict": "APPROVED|REQUEST_CHANGES|REJECTED",
-  "confidence": 8,
-  "issues": [{"id": "string", "severity": "critical|major|minor", "description": "string"}],
-  "consensus_report": {"status": "pending|consensus|disagreement"}
-}
-```
-**Eval assertions check for:** `verdict` enum values, `confidence` range, `issues` structure, `consensus_report.status`.