@boyingliu01/xp-gate 0.36.0 → 0.36.1

package/lib/__tests__/principles-csharp-coverage.test.js

@@ -0,0 +1,227 @@
+/**
+ * @test REQ-758 `xp-gate principles <dir>` must reach every file the engine has an adapter for
+ * @intent `principles.js` keeps its own literal `SOURCE_EXTENSIONS` because the file must
+ *         stay loadable by plain Node with no transpile step. Its own comment said the
+ *         list "Must match `getAdapterForFile`'s adapterMap" — and it did not.
+ *         `analyzer.ts` registered `.cs` and `.csx` since #717, but this walk never
+ *         offered those files to the checker, so a directory of C# sources reported
+ *         `Files checked: 0`, which reads exactly like "no violations".
+ *
+ *         How the expected set is derived matters more than the assertion, because two
+ *         weaker designs both shipped a guard that could pass while the defect lived:
+ *
+ *         1. A regex over analyzer.ts. Measured: changing `'.ts'` to `".ts"` — cosmetic,
+ *            same semantics — dropped the parsed set from 21 to 20 and the test still
+ *            passed. A guard that weakens under a legal refactor is the same "covered
+ *            but cannot block" shape as the bug.
+ *         2. A hand-written candidate list probed through `getAdapterForFile`. Measured:
+ *            adding `.fs` to BOTH adapterMap and the walk left every test green, because
+ *            the candidate list simply did not contain `.fs`.
+ *
+ *         So: parse `adapterMap` with the TypeScript compiler API (syntax-aware — key
+ *         quoting, comments and line breaks do not change the result; verified against
+ *         three cosmetic refactors), and separately confirm through `getAdapterForFile`
+ *         that each such extension is genuinely analysable. No hand-maintained list
+ *         bounds the expectation, so an extension added to the analyzer alone fails here
+ *         by name.
+ * @covers AC-758-01, AC-758-02, AC-758-03, AC-758-04, AC-758-05
+ */
+const ts = require('typescript');
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
+const { pathToFileURL } = require('url');
+
+const { collectSourceFiles } = require('../principles');
+
+const REPO_ROOT = path.resolve(__dirname, '..', '..', '..', '..');
+const ANALYZER = path.join(REPO_ROOT, 'src', 'principles', 'analyzer.ts');
+
+let TMP;
+let getAdapterForFile;
+
+beforeAll(async () => {
+  TMP = fs.mkdtempSync(path.join(os.tmpdir(), 'principles-csharp-'));
+  const mod = await import(pathToFileURL(ANALYZER).href);
+  getAdapterForFile = mod.getAdapterForFile;
+});
+
+afterAll(() => {
+  fs.rmSync(TMP, { recursive: true, force: true });
+});
+
+/**
+ * Write a file inside the temp tree.
+ * @param {string} rel - path relative to TMP
+ * @param {string} content - file body
+ */
+function touch(rel, content) {
+  const abs = path.join(TMP, rel);
+  try {
+    fs.mkdirSync(path.dirname(abs), { recursive: true });
+    fs.writeFileSync(abs, content);
+  } catch (err) {
+    const msg = err instanceof Error ? err.message : String(err);
+    throw new Error(`fixture setup failed writing ${rel}: ${msg}`);
+  }
+}
+
+/**
+ * Keys of the `adapterMap` object literal in a TypeScript source string.
+ *
+ * Uses the compiler API rather than a regex so that formatting is irrelevant: quoted
+ * any way, reordered, commented or reformatted, the key set is the same. Throws when
+ * the map cannot be found at all — a silently empty result would make every assertion
+ * below pass vacuously.
+ *
+ * @param {string} source - TypeScript source text
+ * @returns {string[]} extensions including the leading dot
+ */
+function adapterMapKeys(source) {
+  const sf = ts.createSourceFile('analyzer.ts', source, ts.ScriptTarget.Latest, true);
+  const keys = [];
+  /**
+   * @param {import('typescript').Node} node
+   */
+  function visit(node) {
+    if (
+      ts.isVariableDeclaration(node) &&
+      node.name.getText(sf) === 'adapterMap' &&
+      node.initializer &&
+      ts.isObjectLiteralExpression(node.initializer)
+    ) {
+      for (const prop of node.initializer.properties) {
+        if (
+          (ts.isPropertyAssignment(prop) || ts.isShorthandPropertyAssignment(prop)) &&
+          prop.name &&
+          ts.isStringLiteralLike(prop.name)
+        ) {
+          keys.push(prop.name.text);
+          continue;
+        }
+        // A spread or a computed key would make this extraction return FEWER extensions
+        // than the map really holds: the derived expectation shrinks, every assertion
+        // still passes, and the guard quietly stops covering what it claims to cover.
+        // That is the exact failure shape this file was written to prevent, so fail
+        // loudly instead of under-reporting.
+        if (ts.isSpreadAssignment(prop) || ts.isComputedPropertyName(prop.name)) {
+          throw new Error(
+            'adapterMap contains a spread or computed key, so this guard cannot derive ' +
+              'the full extension set from it. Extend adapterMapKeys() rather than ' +
+              'letting it silently under-report.',
+          );
+        }
+      }
+    }
+    ts.forEachChild(node, visit);
+  }
+  visit(sf);
+  if (keys.length === 0) {
+    throw new Error('adapterMap not found (or holds no string keys) in analyzer.ts');
+  }
+  return keys;
+}
+
+describe('principles walk covers every language the engine has an adapter for', () => {
+  test('AC-758-01: a .cs file in the target directory is offered to the checker', () => {
+    touch('cs-only/Program.cs', 'namespace Aot { class P { static void Main() {} } }\n');
+
+    const found = collectSourceFiles(path.join(TMP, 'cs-only'));
+
+    expect(found.map(f => path.basename(f))).toContain('Program.cs');
+  });
+
+  test('AC-758-02: every extension in adapterMap is collected by the walk', () => {
+    const expected = adapterMapKeys(fs.readFileSync(ANALYZER, 'utf8'));
+
+    // The C# entries are what this file exists for; assert them explicitly so a
+    // regression names the extension rather than just shrinking a count.
+    expect(expected).toContain('.cs');
+    expect(expected).toContain('.csx');
+
+    for (const ext of expected) {
+      touch(`all-ext/file${ext}`, '// fixture\n');
+    }
+
+    const names = new Set(
+      collectSourceFiles(path.join(TMP, 'all-ext')).map(f => path.basename(f)),
+    );
+
+    const missing = expected
+      .filter(ext => !names.has(`file${ext}`))
+      .map(ext => `${ext} is registered in adapterMap but the walk never collected file${ext}`);
+
+    expect(missing).toEqual([]);
+  });
+
+  test('AC-758-04: each adapterMap extension is genuinely analysable, not just listed', () => {
+    // adapterMap could name an extension whose adapter is broken. Confirm through the
+    // real entry point that a file with that extension produces an adapter at all.
+    //
+    // The function is asserted to BE a function first. Without that, a broken dynamic
+    // import (interop change, undefined export) would make every probe throw a
+    // TypeError, the catch below would swallow each one, `notAnalysable` would stay
+    // empty, and this test would report success while asserting nothing. A guard that
+    // goes green when its own instrument is missing is the defect class this file is
+    // about.
+    expect(typeof getAdapterForFile).toBe('function');
+
+    const expected = adapterMapKeys(fs.readFileSync(ANALYZER, 'utf8'));
+    const notAnalysable = [];
+    let answered = 0;
+    for (const ext of expected) {
+      touch(path.join('analysable', `probe${ext}`), '// fixture\n');
+      const abs = path.join(TMP, 'analysable', `probe${ext}`);
+      try {
+        const adapter = getAdapterForFile(abs);
+        answered += 1;
+        if (adapter === null) notAnalysable.push(ext);
+      } catch (err) {
+        // Adapters read their file in the constructor, so content the adapter rejects
+        // still proves registration. Anything else (a TypeError from a missing
+        // function) must not be mistaken for that, so the error type is checked.
+        const name = err && err.constructor ? err.constructor.name : '';
+        if (name === 'TypeError') throw err;
+        if (!/Could not read file|ENOENT|parse/i.test(String(err && err.message))) throw err;
+        answered += 1;
+      }
+    }
+    // Every extension must have produced a real answer, otherwise the loop above
+    // proved nothing.
+    expect(answered).toBe(expected.length);
+    expect(notAnalysable).toEqual([]);
+  });
+
+  test('AC-758-03: a directory of ONLY C# sources is not reported as empty', () => {
+    touch('only-cs/Alpha.cs', 'class A {}\n');
+    touch('only-cs/sub/Beta.cs', 'class B {}\n');
+
+    const found = collectSourceFiles(path.join(TMP, 'only-cs'));
+
+    expect(found.length).toBe(2);
+    expect(found.map(f => path.basename(f)).sort()).toEqual(['Alpha.cs', 'Beta.cs']);
+  });
+
+  test('AC-758-05: .cs files survive upper/lower case variants, end to end', () => {
+    // Both halves of the claim in the acceptance criterion, because either one alone
+    // leaves the original symptom reachable:
+    //  - the WALK must collect `Program.CS`, and
+    //  - `getAdapterForFile` must accept it, since it lowercases the extension before
+    //    lookup. If that normalisation regressed while the walk still collected the
+    //    file, the adapter would be null, the file would be skipped, and a directory of
+    //    all-uppercase C# would once again report Files checked: 0.
+    touch('mixed-case/Upper.CS', 'class U {}\n');
+    touch('mixed-case/Mixed.Cs', 'class M {}\n');
+
+    const collected = collectSourceFiles(path.join(TMP, 'mixed-case'));
+    const names = collected.map(f => path.basename(f));
+
+    expect(names.sort()).toEqual(['Mixed.Cs', 'Upper.CS']);
+
+    // The end-to-end half: every file the walk collected must also resolve to an
+    // adapter, so "collected" cannot silently degrade into "collected then dropped".
+    for (const file of collected) {
+      expect(getAdapterForFile(file)).not.toBeNull();
+    }
+  });
+});

package/lib/mattpocock-license-verdict.json

@@ -2,6 +2,6 @@
   "verdict": "PASS",
   "license_type": "MIT",
   "sha256": "0e7ac423bf2c6e223b7c5b156f8cf72da49d748e56a1641402c31f22ad07dbb5",
-  "checked_at": "2026-11-05T12:23:08.769Z",
+  "checked_at": "2026-11-05T16:16:15.014Z",
   "source": "network"
 }

package/lib/principles.js

@@ -209,10 +209,18 @@ function findPrinciplesEntry() {
 // Extensions the principles engine has an adapter for. Kept as a literal rather
 // than imported from src/principles/analyzer.ts because this file must stay
 // loadable by plain Node with no transpile step (the package ships zero runtime
-// dependencies and no build). Must match `getAdapterForFile`'s adapterMap.
+// dependencies and no build). Must match `getAdapterForFile`'s adapterMap —
+// `__tests__/principles-csharp-coverage.test.js` now derives the expected set
+// from that adapterMap and fails when the two drift, because "kept in sync by
+// comment" did not survive contact with #717.
+//
+// `.cs`/`.csx` were the gap: analyzer.ts registered CSharpAdapter, this walk
+// never offered the files, so `xp-gate principles <csharp-dir>` reported
+// "Files checked: 0" — indistinguishable from "no violations".
 const SOURCE_EXTENSIONS = new Set([
   '.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs',
   '.py', '.go', '.java', '.kt', '.kts',
+  '.cs', '.csx',
   '.dart', '.swift', '.cpp', '.cc', '.cxx', '.c', '.h', '.hpp',
   '.m', '.mm',
 ]);

package/mock-policy/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Mock layering policy enforcement — Gate M3 of pre-push hook. Ensures integration tests use real implementations for internal dependencies, mock external dependencies, and annotate pending mocks with removal plans. Combines project scope scanning, mock decision engine, and per-file validation into a single pipeline.

package/mutation/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **Gate M** (incremental mutation testing) + **Gate M2** helpers (test-layer detection used by `src/mock-policy/`). Pre-push quality gate. TypeScript-only; uses Stryker.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/xp-gate",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "description": "AI-driven development workflow: 6 quality gates + Delphi review + Sprint Flow",
   "bin": {
     "xp-gate": "bin/xp-gate.js"

package/plugins/claude-code/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Claude Code. Includes 12 pre-commit gates (Gate 0-11), 8 pre-push gates, Sprint Flow (6 phases), and Delphi multi-expert review (>=90% consensus).",
   "author": {

package/plugins/claude-code/skills/delphi-review/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/claude-code/skills/sprint-flow/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/claude-code/skills/test-specification-alignment/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/plugins/dsh/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/dsh-plugin-xp-gate",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "description": "XP-Gate deterministic quality gates + AI workflow skills as a DeepSeek Harness (DSH) native plugin: gate-check / gate-principles / gate-arch tools + 12 SKILL.md skills",
   "type": "module",
   "main": "./lib/index.js",

package/plugins/dsh/skills/delphi-review/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/dsh/skills/sprint-flow/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/dsh/skills/test-specification-alignment/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/plugins/opencode/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/opencode-plugin",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "type": "module",
   "main": "index.ts",
   "description": "XP-Gate quality gates + AI workflow skills for OpenCode",

package/plugins/opencode/skills/delphi-review/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/opencode/skills/sprint-flow/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/opencode/skills/test-specification-alignment/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/plugins/qoder/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Qoder. Includes 12 pre-commit gates (Gate 0-11), 8 pre-push gates, Sprint Flow (6 phases), and Delphi multi-expert review (>=90% consensus).",
   "author": {

package/plugins/qoder/skills/delphi-review/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/qoder/skills/sprint-flow/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/qoder/skills/test-specification-alignment/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/principles/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Clean Code & SOLID principles checker — **Gate 4** of pre-commit. 14 rules × 9 language adapters, SARIF 2.1.0 output. Houses the **Boy Scout Rule** enforcement engine (Gate 6) and warning-baseline storage.

package/skills/delphi-review/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/skills/sprint-flow/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/skills/test-specification-alignment/AGENTS.md

@@ -3,7 +3,7 @@
 **Generated:** 2026-11-04
 **Commit:** eb2097b0
 **Branch:** sprint/2026-11-03-02
-**Version:** 0.36.0.0
+**Version:** 0.36.1.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.