@boyingliu01/xp-gate 0.35.19 → 0.35.20

package/plugins/dsh/src/delphi-version-footer.test.ts

@@ -0,0 +1,42 @@
+import { describe, it, expect } from "vitest"
+import { readFileSync } from "node:fs"
+import { resolve } from "node:path"
+import { fileURLToPath } from "node:url"
+
+import { formatPluginFooter, pluginVersion } from "./index.js"
+
+/**
+ * @test REQ-709
+ * @intent `delphi-review` 的输出里没有任何版本信息，于是"修复没生效"与"修复没做"
+ *         无法区分。本 issue 的发现过程就是代价：对一份设计连续评审 4 次全部
+ *         只拿到票型、拿不到意见正文，据此判定设计有实质缺陷并两次重写；改用
+ *         源码渠道拿到真实意见后，第 2 轮就达成 100% 共识——那 4 次"不通过"
+ *         里至少有一部分是我本来就没错，但**无法区分"错"与"没通过"**。
+ *
+ *         这类缺陷在本仓库已有先例：#451（hook 漂移，doctor --sync-hooks 解决）、
+ *         #681（skill 内容漂移）。共同形状是「运行的东西与你以为在运行的东西
+ *         不一致，且没有任何机制告诉你」。一行版本号就能消掉一整类排查。
+ *
+ *         断言必须能失败：如果 footer 里只是硬编码一个字符串，版本升级后它就
+ *         开始撒谎——所以测试把它与 package.json 的真实 version 对齐。
+ * @covers AC-709-01, AC-709-02
+ */
+
+const PKG_ROOT = resolve(fileURLToPath(new URL("..", import.meta.url)))
+const PKG_VERSION = (JSON.parse(readFileSync(resolve(PKG_ROOT, "package.json"), "utf8")) as { version: string }).version
+
+describe("delphi 输出暴露插件版本 (#709)", () => {
+  it("AC-709-01: the version comes from package.json, not a hardcoded literal", () => {
+    // If this ever drifts, the footer is lying about which code is running —
+    // which is the whole defect this guards against.
+    expect(pluginVersion()).toBe(PKG_VERSION)
+  })
+
+  it("AC-709-02: the footer names the plugin version so a stale load is visible", () => {
+    const footer = formatPluginFooter("whalecloud", "A, B, C")
+    expect(footer).toContain(`plugin: ${PKG_VERSION}`)
+    // The pre-existing fields must survive: this is an addition, not a rewrite.
+    expect(footer).toContain("Provider: whalecloud")
+    expect(footer).toContain("Seats: A, B, C")
+  })
+})

package/plugins/dsh/src/index.ts

@@ -1,4 +1,5 @@
 import { writeFile } from "node:fs/promises"
+import { createRequire } from "node:module"
 import { join } from "node:path"
 import { fileURLToPath } from "node:url"
 
@@ -328,6 +329,42 @@ export function findPlaceholderName(value: string): string | undefined {
   return envStyle ? envStyle[1] : undefined
 }
 
+/**
+ * The running plugin's version, read from its own package.json (#709).
+ *
+ * Delphi's tool result used to carry no version at all, which made "the fix did
+ * not take effect" indistinguishable from "the fix was never made". That cost a
+ * real investigation: four design reviews returned verdicts without a single
+ * line of expert reasoning, the design was rewritten twice on the assumption it
+ * must be wrong, and the same reviews reached 100% consensus on round two once
+ * the reasoning was readable. Nothing was wrong with the design.
+ *
+ * Read rather than injected so dev runs and packed installs report the same
+ * thing, and so a stale load is visible as an old number instead of silence.
+ * Falls back to "unknown" rather than throwing: a version banner must never be
+ * the reason a review fails to start.
+ */
+export function pluginVersion(): string {
+  try {
+    const require_ = createRequire(import.meta.url)
+    const pkg = require_("../package.json") as { version?: string }
+    return typeof pkg.version === "string" && pkg.version !== "" ? pkg.version : "unknown"
+  } catch {
+    return "unknown"
+  }
+}
+
+/**
+ * The provider/seats banner that closes every Delphi tool result (#709).
+ *
+ * Extracted from the inline template so the version claim has exactly one
+ * definition — and so it can be asserted against package.json instead of being
+ * pinned to a literal that silently starts lying at the next release.
+ */
+export function formatPluginFooter(provider: string, described: string): string {
+  return `Provider: ${provider} | plugin: ${pluginVersion()}\nSeats: ${described}`
+}
+
 async function runDelphiReview(subject: string, request: ReviewRequest): Promise<string> {
   const { addressed, cwd, resolveApiKey, signal, writeEvidence } = request
   try {
@@ -336,7 +373,7 @@ async function runDelphiReview(subject: string, request: ReviewRequest): Promise
     const suffix = writeEvidence && cfg !== undefined
       ? await writeWalkthroughEvidence(cwd, cfg, outcome)
       : ""
-    return `${formatOutcome(outcome)}\n\nProvider: ${provider}\nSeats: ${described}${suffix}`
+    return `${formatOutcome(outcome)}\n\n${formatPluginFooter(provider, described)}${suffix}`
   } catch (e) {
     // Config problems are the common failure; report them as guidance
     // rather than a stack trace.

package/plugins/opencode/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boyingliu01/opencode-plugin",
-  "version": "0.35.19",
+  "version": "0.35.20",
   "type": "module",
   "main": "index.ts",
   "description": "XP-Gate quality gates + AI workflow skills for OpenCode",

package/plugins/opencode/skills/delphi-review/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/DELPHI-REVIEW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/opencode/skills/sprint-flow/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/SPRINT-FLOW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/opencode/skills/test-specification-alignment/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/TEST-SPECIFICATION-ALIGNMENT KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/plugins/qoder/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "xp-gate",
-  "version": "0.35.19",
+  "version": "0.35.20",
   "displayName": "XP-Gate",
   "description": "Extreme Programming quality gates + AI workflow skills for Qoder. Includes 12 pre-commit gates (Gate 0-11), 8 pre-push gates, Sprint Flow (6 phases), and Delphi multi-expert review (>=90% consensus).",
   "author": {

package/plugins/qoder/skills/delphi-review/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/DELPHI-REVIEW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/plugins/qoder/skills/sprint-flow/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/SPRINT-FLOW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/plugins/qoder/skills/test-specification-alignment/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/TEST-SPECIFICATION-ALIGNMENT KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.

package/principles/AGENTS.md

@@ -1,9 +1,9 @@
 # PRINCIPLES CHECKER MODULE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Clean Code & SOLID principles checker — **Gate 4** of pre-commit. 14 rules × 9 language adapters, SARIF 2.1.0 output. Houses the **Boy Scout Rule** enforcement engine (Gate 6) and warning-baseline storage.

package/skills/delphi-review/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/DELPHI-REVIEW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, exactly 3 experts with distinct executable model IDs). Supports design, requirements, and code-walkthrough modes.

package/skills/sprint-flow/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/SPRINT-FLOW KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/skills/test-specification-alignment/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/TEST-SPECIFICATION-ALIGNMENT KNOWLEDGE BASE
 
-**Generated:** 2026-11-01
-**Commit:** effea31d
+**Generated:** 2026-11-02
+**Commit:** 60545e49
 **Branch:** main
-**Version:** 0.35.19.0
+**Version:** 0.35.20.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.