@boyingliu01/xp-gate 0.26.0 → 0.27.1

package/principles/rules/__tests__/clean-code/many-exports.test.ts

@@ -111,14 +111,13 @@ describe('manyExportsRule', () => {
     expect(violations).toHaveLength(0);
   });
 
-  it('returns empty violations when adapter throws (catch branch)', () => {
+  it('propagates adapter errors (no empty catch, #392)', () => {
     const adapter: never = {
       ...baseAdapter,
       extractExports: () => {
         throw new Error('boom');
       },
     } as never;
-    const violations = manyExportsRule.check('file.ts', adapter);
-    expect(violations).toHaveLength(0);
+    expect(() => manyExportsRule.check('file.ts', adapter)).toThrow('boom');
   });
 });

package/principles/rules/__tests__/clean-code/missing-error-handling.test.ts

@@ -134,15 +134,13 @@ async function fetchUser(id: string) {
     expect(missingErrorHandlingRule.severity).toBe('warning');
   });
 
-  it('should return empty array when adapter.extractFunctions throws', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThrowing = {
       ...mockAdapter,
       extractFunctions: () => { throw new Error('Parse error'); }
     };
     
-    const violations = missingErrorHandlingRule.check('test.ts', mockAdapterThrowing as never);
-    
-    expect(violations).toEqual([]);
+    expect(() => missingErrorHandlingRule.check('test.ts', mockAdapterThrowing as never)).toThrow('Parse error');
   });
 
   it('should detect multiple IO operations in one function', () => {

package/principles/rules/__tests__/clean-code/too-many-params.test.ts

@@ -47,14 +47,12 @@ describe('too-many-params.ts - Too Many Parameters Rule', () => {
     expect(tooManyParamsRule.severity).toBe('info');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractFunctions: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = tooManyParamsRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => tooManyParamsRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 });

package/principles/rules/__tests__/clean-code/unused-imports.test.ts

@@ -79,15 +79,15 @@ describe('unused-imports.ts - Unused Imports Rule', () => {
     expect(violations).toEqual([]);
   });
 
-  it('should return empty array when adapter throws', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThrowing = {
       ...mockAdapter,
+      // Violate the adapter contract: `imports` must be an array. With the old
+      // empty catch this was swallowed; now it must bubble up to the analyzer.
       imports: () => { throw new Error('Parse error'); }
     };
     
-    const violations = unusedImportsRule.check('test.ts', mockAdapterThrowing as never);
-    
-    expect(violations).toEqual([]);
+    expect(() => unusedImportsRule.check('test.ts', mockAdapterThrowing as never)).toThrow();
   });
 
   it('should handle namespace imports', () => {

package/principles/rules/__tests__/solid/dip.test.ts

@@ -82,15 +82,13 @@ class DateService {
     expect(dipRule.severity).toBe('warning');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractClasses: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = dipRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => dipRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 
   it('should exclude built-in types (Date, Map, Set, etc.)', () => {

package/principles/rules/__tests__/solid/isp.test.ts

@@ -47,14 +47,12 @@ describe('isp.ts - Interface Segregation Principle Rule', () => {
     expect(ispRule.severity).toBe('info');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractInterfaces: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = ispRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => ispRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 });

package/principles/rules/__tests__/solid/lsp.test.ts

@@ -49,15 +49,13 @@ class DerivedRepo extends BaseRepo {
     expect(lspRule.severity).toBe('info');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractClasses: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = lspRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => lspRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 
   /**

package/principles/rules/__tests__/solid/ocp.test.ts

@@ -56,14 +56,12 @@ class DerivedClass extends BaseClass {
     expect(ocpRule.severity).toBe('info');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractClasses: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = ocpRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => ocpRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 });

package/principles/rules/__tests__/solid/srp.test.ts

@@ -76,14 +76,12 @@ describe('srp.ts - Single Responsibility Principle Rule', () => {
     expect(srpRule.severity).toBe('warning');
   });
 
-  it('should return empty violations when adapter throws error', () => {
+  it('should propagate adapter errors (no empty catch, #392)', () => {
     const mockAdapterThatThrows = {
       ...mockAdapter,
       extractClasses: () => { throw new Error('Adapter failed'); }
     };
     
-    const violations = srpRule.check('test.ts', mockAdapterThatThrows as never);
-    
-    expect(violations.length).toBe(0);
+    expect(() => srpRule.check('test.ts', mockAdapterThatThrows as never)).toThrow('Adapter failed');
   });
 });

package/principles/rules/clean-code/code-duplication.ts

@@ -11,20 +11,18 @@ export const codeDuplicationRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['code-duplication'];
     
-    try {
-      const typedAdapter = adapter as { duplicationPercentage?: number };
-      const duplicationPercentage = typedAdapter.duplicationPercentage;
-      
-      if (duplicationPercentage && duplicationPercentage > (settings.threshold ?? 0)) {
-        violations.push({
-          file,
-          line: 1,
-          ruleId: 'clean-code.code-duplication',
-          message: `Code duplication detected: ${duplicationPercentage}% (threshold: ${settings.threshold}%). Consider refactoring duplicated code.`,
-          severity: (settings.severity as Severity) ?? 'warning'
-        });
-      }
-    } catch { }
+    const typedAdapter = adapter as { duplicationPercentage?: number };
+    const duplicationPercentage = typedAdapter.duplicationPercentage;
+    
+    if (duplicationPercentage && duplicationPercentage > (settings.threshold ?? 0)) {
+      violations.push({
+        file,
+        line: 1,
+        ruleId: 'clean-code.code-duplication',
+        message: `Code duplication detected: ${duplicationPercentage}% (threshold: ${settings.threshold}%). Consider refactoring duplicated code.`,
+        severity: (settings.severity as Severity) ?? 'warning'
+      });
+    }
     
     return violations;
   }

package/principles/rules/clean-code/deep-nesting.ts

@@ -11,27 +11,25 @@ export const deepNestingRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['deep-nesting'];
     
-    try {
-      interface TypedAdapter {
-        extractFunctions?: () => Array<{name?: string, nestingDepth?: number, startLine?: number, line?: number}> | undefined;
-      }
-      const typedAdapter = adapter as TypedAdapter;
-      const functions = typedAdapter.extractFunctions?.() || [];
-      
-      for (const func of functions) {
-        if (func.nestingDepth && func.nestingDepth > (settings.threshold ?? 0)) {
-          violations.push({
-            file,
-            line: func.startLine ?? func.line ?? 1,
-            ruleId: 'clean-code.deep-nesting',
-            message: `Function "${func.name}" has deep nesting: ${func.nestingDepth} levels (maximum: ${
-              settings.threshold
-            })`,
-            severity: (settings.severity as Severity) ?? 'warning'
-          });
-        }
+    interface TypedAdapter {
+      extractFunctions?: () => Array<{name?: string, nestingDepth?: number, startLine?: number, line?: number}> | undefined;
+    }
+    const typedAdapter = adapter as TypedAdapter;
+    const functions = typedAdapter.extractFunctions?.() || [];
+    
+    for (const func of functions) {
+      if (func.nestingDepth && func.nestingDepth > (settings.threshold ?? 0)) {
+        violations.push({
+          file,
+          line: func.startLine ?? func.line ?? 1,
+          ruleId: 'clean-code.deep-nesting',
+          message: `Function "${func.name}" has deep nesting: ${func.nestingDepth} levels (maximum: ${
+            settings.threshold
+          })`,
+          severity: (settings.severity as Severity) ?? 'warning'
+        });
       }
-    } catch { }
+    }
     
     return violations;
   }

package/principles/rules/clean-code/god-class.ts

@@ -11,43 +11,41 @@ export const godClassRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['god-class'];
     
-    try {
-      interface ClassObject {
-        code?: string;
-        line: number;
-        name: string;
-      }
-      
-      interface TypedAdapter {
-        extractClasses?: () => ClassObject[] | undefined;
-      }
-      
-      const typedAdapter = adapter as TypedAdapter;
-      const classes = typedAdapter.extractClasses?.() || [];
+    interface ClassObject {
+      code?: string;
+      line: number;
+      name: string;
+    }
+    
+    interface TypedAdapter {
+      extractClasses?: () => ClassObject[] | undefined;
+    }
+    
+    const typedAdapter = adapter as TypedAdapter;
+    const classes = typedAdapter.extractClasses?.() || [];
+    
+    for (const cls of classes) {
+      const methodMatches = cls.code?.match(/(get|set)\s+\w+\s*\(|\w+\s*\([^)]*\)\s*{/g) || [];
       
-      for (const cls of classes) {
-        const methodMatches = cls.code?.match(/(get|set)\s+\w+\s*\(|\w+\s*\([^)]*\)\s*{/g) || [];
-        
-        const methodCount = methodMatches.filter((m: string) => {
-          if (m.startsWith('get ') || m.startsWith('set ')) {
-            return false;
-          }
-          return true;
-        }).length;
-        
-        if (methodCount > (settings.threshold ?? 0)) {
-          violations.push({
-            file,
-            line: cls.line,
-            ruleId: 'clean-code.god-class',
-            message: `Class "${cls.name}" has too many methods: ${methodCount} (maximum: ${
-              settings.threshold
-            })`,
-            severity: (settings.severity as Severity) ?? 'warning'
-          });
+      const methodCount = methodMatches.filter((m: string) => {
+        if (m.startsWith('get ') || m.startsWith('set ')) {
+          return false;
         }
+        return true;
+      }).length;
+      
+      if (methodCount > (settings.threshold ?? 0)) {
+        violations.push({
+          file,
+          line: cls.line,
+          ruleId: 'clean-code.god-class',
+          message: `Class "${cls.name}" has too many methods: ${methodCount} (maximum: ${
+            settings.threshold
+          })`,
+          severity: (settings.severity as Severity) ?? 'warning'
+        });
       }
-    } catch { }
+    }
     
     return violations;
   }

package/principles/rules/clean-code/large-file.ts

@@ -15,23 +15,21 @@ export const largeFileRule: Rule = {
     const settings = getActiveConfig().rules['clean-code']['large-file'];
     const threshold = settings.threshold ?? 500;
 
-    try {
-      interface TypedAdapter {
-        countLines?: (file: string) => number | undefined;
-      }
-      const typedAdapter = adapter as TypedAdapter;
-      const lineCount = typedAdapter.countLines?.(file) ?? 0;
+    interface TypedAdapter {
+      countLines?: (file: string) => number | undefined;
+    }
+    const typedAdapter = adapter as TypedAdapter;
+    const lineCount = typedAdapter.countLines?.(file) ?? 0;
 
-      if (lineCount > threshold) {
-        violations.push({
-          file,
-          line: 1,
-          ruleId: 'clean-code.large-file',
-          message: `File is too large: ${lineCount} lines (maximum: ${threshold})`,
-          severity: (settings.severity as Severity) ?? 'warning'
-        });
-      }
-    } catch { }
+    if (lineCount > threshold) {
+      violations.push({
+        file,
+        line: 1,
+        ruleId: 'clean-code.large-file',
+        message: `File is too large: ${lineCount} lines (maximum: ${threshold})`,
+        severity: (settings.severity as Severity) ?? 'warning'
+      });
+    }
 
     return violations;
   }

package/principles/rules/clean-code/long-function.ts

@@ -11,36 +11,34 @@ export const longFunctionRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['long-function'];
     
-    try {
-      interface FunctionObj {
-        name: string;
-        startLine: number;
-        length: number;
-      }
-      
-      interface TypedAdapter {
-        extractFunctions?: () => FunctionObj[] | undefined;
-      }
-      
-      const typedAdapter = adapter as TypedAdapter;
-      const functions = typedAdapter.extractFunctions?.() || [];
+    interface FunctionObj {
+      name: string;
+      startLine: number;
+      length: number;
+    }
+    
+    interface TypedAdapter {
+      extractFunctions?: () => FunctionObj[] | undefined;
+    }
+    
+    const typedAdapter = adapter as TypedAdapter;
+    const functions = typedAdapter.extractFunctions?.() || [];
+    
+    for (const func of functions) {
+      const { name, startLine, length } = func;
       
-      for (const func of functions) {
-        const { name, startLine, length } = func;
-        
-        if (length > (settings.threshold ?? 0)) {
-          violations.push({
-            file,
-            line: startLine ?? 1,
-            ruleId: 'clean-code.long-function',
-            message: `Function "${name}" is too long: ${length} lines (maximum: ${
-              settings.threshold
-            })`,
-            severity: (settings.severity as Severity) ?? 'warning'
-          });
-        }
+      if (length > (settings.threshold ?? 0)) {
+        violations.push({
+          file,
+          line: startLine ?? 1,
+          ruleId: 'clean-code.long-function',
+          message: `Function "${name}" is too long: ${length} lines (maximum: ${
+            settings.threshold
+          })`,
+          severity: (settings.severity as Severity) ?? 'warning'
+        });
       }
-    } catch { }
+    }
     
     return violations;
   }

package/principles/rules/clean-code/magic-numbers.ts

@@ -15,48 +15,49 @@ export const magicNumbersRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['magic-numbers'];
     
+    // #392-#4: rules must not swallow their own errors. The outer try/catch was
+    // removed so a genuine rule bug bubbles up to analyzer.runRuleOnFile() and
+    // surfaces as a gate error. The inner try/catch below is kept deliberately:
+    // an adapter that cannot extract AST data is a legitimate "no data" case.
+    interface NumberObject {
+      value: number;
+      line: number;
+    }
+    
+    interface TypedAdapter {
+      parseAST?: () => unknown | undefined;
+      extract?: () => NumberObject[] | undefined;
+    }
+    
+    const typedAdapter = adapter as TypedAdapter;
+    
+    let magicNumbers: NumberObject[] = [];
+    
     try {
-      interface NumberObject {
-        value: number;
-        line: number;
-      }
-      
-      interface TypedAdapter {
-        parseAST?: () => unknown | undefined;
-        extract?: () => NumberObject[] | undefined;
-      }
-      
-      const typedAdapter = adapter as TypedAdapter;
-      
-      let magicNumbers: NumberObject[] = [];
-      
-      try {
-        if (typeof typedAdapter.extract !== 'undefined') {
-          const literals = typedAdapter.extract?.();
-          if (literals && Array.isArray(literals)) {
-            magicNumbers = literals;
-          }
+      if (typeof typedAdapter.extract !== 'undefined') {
+        const literals = typedAdapter.extract?.();
+        if (literals && Array.isArray(literals)) {
+          magicNumbers = literals;
         }
-      } catch { }
-      
-      const excludedNumbers = settings.exclude ?? DEFAULT_EXCLUDED_NUMBERS;
-      const filteredNumbers = magicNumbers.filter(numObj => {
-        const numValue = numObj.value;
-        return !excludedNumbers.includes(numValue);
-      });
-      
-      filteredNumbers.forEach(numObj => {
-        violations.push({
-          file,
-          line: numObj.line,
-          ruleId: 'clean-code.magic-numbers',
-          message: `Potential magic number detected: ${numObj.value}. Consider using a named constant instead.`,
-          severity: (settings.severity as Severity) ?? 'info'
-        });
-      });
-      
+      }
     } catch { }
     
+    const excludedNumbers = settings.exclude ?? DEFAULT_EXCLUDED_NUMBERS;
+    const filteredNumbers = magicNumbers.filter(numObj => {
+      const numValue = numObj.value;
+      return !excludedNumbers.includes(numValue);
+    });
+    
+    filteredNumbers.forEach(numObj => {
+      violations.push({
+        file,
+        line: numObj.line,
+        ruleId: 'clean-code.magic-numbers',
+        message: `Potential magic number detected: ${numObj.value}. Consider using a named constant instead.`,
+        severity: (settings.severity as Severity) ?? 'info'
+      });
+    });
+    
     return violations;
   }
 };

package/principles/rules/clean-code/many-exports.ts

@@ -11,29 +11,27 @@ export const manyExportsRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['many-exports'];
 
-    try {
-      interface ExportObj {
-        line: number;
-      }
-      
-      interface TypedAdapter {
-        extractExports?: () => ExportObj[] | undefined;
-      }
-      
-      const typedAdapter = adapter as TypedAdapter;
-      const exports = typedAdapter.extractExports ? typedAdapter.extractExports() : [];
-      const threshold = settings.threshold ?? 10;
-      
-      if (exports && exports.length > threshold) {
-        violations.push({
-          file,
-          line: exports[0]?.line || 1,
-          ruleId: 'clean-code.many-exports',
-          message: `Module has too many exports: ${exports.length} (maximum: ${threshold}). Consider splitting into focused sub-modules.`,
-          severity: (settings.severity as Severity) ?? 'warning'
-        });
-      }
-    } catch { }
+    interface ExportObj {
+      line: number;
+    }
+    
+    interface TypedAdapter {
+      extractExports?: () => ExportObj[] | undefined;
+    }
+    
+    const typedAdapter = adapter as TypedAdapter;
+    const exports = typedAdapter.extractExports ? typedAdapter.extractExports() : [];
+    const threshold = settings.threshold ?? 10;
+    
+    if (exports && exports.length > threshold) {
+      violations.push({
+        file,
+        line: exports[0]?.line || 1,
+        ruleId: 'clean-code.many-exports',
+        message: `Module has too many exports: ${exports.length} (maximum: ${threshold}). Consider splitting into focused sub-modules.`,
+        severity: (settings.severity as Severity) ?? 'warning'
+      });
+    }
     
     return violations;
   }

package/principles/rules/clean-code/missing-error-handling.ts

@@ -11,22 +11,20 @@ export const missingErrorHandlingRule: Rule = {
     // Read the ACTIVE config per invocation; a module-load snapshot was #457.
     const settings = getActiveConfig().rules['clean-code']['missing-error-handling'];
     
-    try {
-      const typedAdapter = adapter as { extractFunctions?: () => Array<{name?: string; startLine?: number; line?: number; ioOperations?: string[]; hasTryCatch?: boolean;}> | undefined };
-      const functions = typedAdapter.extractFunctions?.() || [];
-      
-      for (const func of functions) {
-        if (func.ioOperations && func.ioOperations.length > 0 && !func.hasTryCatch) {
-          violations.push({
-            file,
-            line: func.startLine ?? func.line ?? 1,
-            ruleId: 'clean-code.missing-error-handling',
-            message: `Function "${func.name}" has IO operations (${func.ioOperations.join(', ')}) without error handling`,
-            severity: (settings.severity as Severity) ?? 'warning'
-          });
-        }
+    const typedAdapter = adapter as { extractFunctions?: () => Array<{name?: string; startLine?: number; line?: number; ioOperations?: string[]; hasTryCatch?: boolean;}> | undefined };
+    const functions = typedAdapter.extractFunctions?.() || [];
+    
+    for (const func of functions) {
+      if (func.ioOperations && func.ioOperations.length > 0 && !func.hasTryCatch) {
+        violations.push({
+          file,
+          line: func.startLine ?? func.line ?? 1,
+          ruleId: 'clean-code.missing-error-handling',
+          message: `Function "${func.name}" has IO operations (${func.ioOperations.join(', ')}) without error handling`,
+          severity: (settings.severity as Severity) ?? 'warning'
+        });
       }
-    } catch { }
+    }
     
     return violations;
   }