@boyingliu01/xp-gate 0.20.0 → 0.20.2

package/build-integrity/__tests__/import-resolver.test.ts

@@ -12,6 +12,10 @@ import path from 'path';
 import os from 'os';
 import { extractImports, resolveImportPath, runImportCheck } from '../gate-10';
 
+// Named timeout for the runImportCheck calls that assert verdicts; keeps the
+// Boy Scout magic-number count from growing with each new test case.
+const IMPORT_CHECK_TIMEOUT_MS = 30000;
+
 /**
  * ─── extractImports ────────────────────────────────────────────────────────────
  */
@@ -321,6 +325,61 @@ describe('runImportCheck', () => {
     expect(result.violations[0].reason).toMatch(/not found|does not exist|missing/i);
   });
 
+  it('passes when projectRoot spelling differs in drive case/slashes (Windows, #508)', async () => {
+    // git rev-parse --show-toplevel reports "D:/repo" while path.resolve of a
+    // repo-relative changed file inherits process.cwd()'s "d:\repo" drive case.
+    // The case-sensitive startsWith judged every import as boundary-escaping,
+    // blocking any TS-bearing push. The same root spelled the other way must
+    // pass on Windows; drive letters do not exist on POSIX so skip there.
+    if (process.platform !== 'win32') return;
+
+    let fooFile: string;
+    try {
+      const srcDir = path.join(tmpDir, 'src');
+      await fs.mkdir(srcDir);
+
+      const barFile = path.join(srcDir, 'bar.ts');
+      await fs.writeFile(barFile, 'export const x = 1;');
+
+      fooFile = path.join(srcDir, 'foo.ts');
+      await fs.writeFile(fooFile, `import { x } from './bar';\nconsole.log(x);\n`);
+    } catch (error) {
+      throw new Error(`Fixture setup failed: ${error}`);
+    }
+
+    const altRoot = tmpDir.replace(/\\/g, '/').replace(/^[a-zA-Z]:/, (m) => m.toLowerCase());
+    expect(altRoot).not.toBe(tmpDir);
+
+    const result = await runImportCheck([fooFile], altRoot, IMPORT_CHECK_TIMEOUT_MS);
+    expect(result.status).toBe('pass');
+    expect(result.violations).toEqual([]);
+  });
+
+  it('still fails a true boundary escape after case normalization (#508 follow-up)', async () => {
+    // Normalization must only absorb case/spelling differences, never widen the
+    // boundary: an import that genuinely leaves the project root keeps failing
+    // even when the root is spelled with a different drive-letter case.
+    if (process.platform !== 'win32') return;
+
+    let badFile: string;
+    try {
+      const nestedDir = path.join(tmpDir, 'pkg', 'dist', 'sub');
+      await fs.mkdir(nestedDir, { recursive: true });
+
+      badFile = path.join(nestedDir, 'file.ts');
+      await fs.writeFile(badFile, `import { x } from '../../../../outside';\n`);
+    } catch (error) {
+      throw new Error(`Fixture setup failed: ${error}`);
+    }
+
+    const altRoot = tmpDir.replace(/\\/g, '/').replace(/^[a-zA-Z]:/, (m) => m.toLowerCase());
+
+    const result = await runImportCheck([badFile], altRoot, IMPORT_CHECK_TIMEOUT_MS);
+    expect(result.status).toBe('fail');
+    expect(result.violations.length).toBeGreaterThan(0);
+    expect(result.violations[0].reason).toMatch(/escapes|outside|boundary/i);
+  });
+
   it('skips YAML files containing JavaScript-like require text', async () => {
     const workflowDir = path.join(tmpDir, '.github', 'workflows');
     await fs.mkdir(workflowDir, { recursive: true });

package/build-integrity/gate-10.ts

@@ -307,6 +307,8 @@ export async function runImportCheck(
 
     const fsSync = fsNative;
 
+  const normalizedRoot = path.resolve(projectRoot);
+
   for (const file of changedFiles) {
     if (!isSupportedModuleFile(file)) continue;
 
@@ -327,14 +329,27 @@ export async function runImportCheck(
       continue;
     }
 
+    // Windows paths are case-insensitive but the two sides of the boundary
+    // comparison get their case from different sources: path.resolve of a
+    // repo-relative file inherits process.cwd()'s drive-letter case (often
+    // lowercase), while projectRoot comes from `git rev-parse --show-toplevel`
+    // (uppercase drive). A case-sensitive startsWith then judged EVERY import
+    // as escaping the boundary — pre-push Gate 10 blocked any TS-bearing push
+    // from a shell whose drive-letter case disagreed with git's (#508).
+    const normalizeForBoundary = (p: string): string => {
+      const resolved = path.resolve(p);
+      return process.platform === 'win32' ? resolved.toLowerCase() : resolved;
+    };
+    const boundaryRoot = normalizeForBoundary(normalizedRoot);
+
     const imports = extractImports(content);
 
     for (const imp of imports) {
       const rawResolved = path.resolve(path.dirname(file), imp.path);
-      const normalizedRoot = path.resolve(projectRoot);
+      const boundaryTarget = normalizeForBoundary(rawResolved);
 
       const escapesBoundary =
-        !rawResolved.startsWith(normalizedRoot + path.sep) && rawResolved !== normalizedRoot;
+        !boundaryTarget.startsWith(boundaryRoot + path.sep) && boundaryTarget !== boundaryRoot;
 
       if (escapesBoundary) {
         violations.push({

package/gate-3.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 # ============================================================================
 # GATE 3: Cyclomatic Complexity Check
 # Uses lizard - checks cyclomatic complexity of changed source files
@@ -17,7 +18,45 @@ elif [ "$PROJECT_LANG" = "powershell" ]; then
   GATE_3_STATUS="SKIP"
   
 else
-  CCN_THRESHOLD=5
+  # S2 (#507): three-level CCN threshold override --
+  # .xp-gate/ccn-threshold (positive integer) > XP_GATE_CCN_THRESHOLD > 5.
+  # Invalid values WARN on stderr and fall back to the default; the resolved
+  # value reaches the gate-3 audit record via the --detail argument below.
+  # Implemented with bash builtins only (no tr/grep spawns): every process
+  # spawn is expensive on Windows under AV filter drivers.
+  resolve_ccn_threshold() {
+    local default=5 val
+    if [ -f ".xp-gate/ccn-threshold" ]; then
+      val=$(<".xp-gate/ccn-threshold")
+      val="${val//[[:space:]]/}"
+      case "$val" in
+        ''|*[!0-9]*|0)
+          echo "WARN - invalid .xp-gate/ccn-threshold value '${val}' (expected a positive integer), falling back to ${default}" >&2
+          ;;
+        *)
+          echo "$val"
+          return 0
+          ;;
+      esac
+      echo "$default"
+      return 0
+    fi
+    val=${XP_GATE_CCN_THRESHOLD:-}
+    if [ -n "$val" ]; then
+      case "$val" in
+        ''|*[!0-9]*|0)
+          echo "WARN - invalid XP_GATE_CCN_THRESHOLD value '${val}' (expected a positive integer), falling back to ${default}" >&2
+          ;;
+        *)
+          echo "$val"
+          return 0
+          ;;
+      esac
+    fi
+    echo "$default"
+  }
+
+  CCN_THRESHOLD=$(resolve_ccn_threshold)
   
   # Check lizard availability
   LIZARD_CMD=""
@@ -37,7 +76,16 @@ else
       echo "Checking complexity for source files..."
       
       # Run lizard with CCN threshold
-      CC_OUTPUT=$($LIZARD_PATH -C $CCN_THRESHOLD $CC_FILES 2>&1 || true)
+      # One path per line, into an array. Unquoted $CC_FILES relied on word
+      # splitting, which also splits any path containing a space -- handing
+      # lizard two bogus paths and checking neither (#457 defect class, same
+      # fix as gate-4's PRINCIPLES_ARGS). Quoting the scalar would instead
+      # collapse the list into one argument. An array does both.
+      CC_FILES_ARGS=()
+      while IFS= read -r _cc_file; do
+        [ -n "$_cc_file" ] && CC_FILES_ARGS+=("$_cc_file")
+      done <<< "$CC_FILES"
+      CC_OUTPUT=$("$LIZARD_PATH" -C "$CCN_THRESHOLD" ${CC_FILES_ARGS[@]+"${CC_FILES_ARGS[@]}"} 2>&1 || true)
       
       # Parse warning count from the summary table: "Warning cnt   8"
       # Use anchored grep to avoid matching lizard table headers (e.g. "Rt" column)
@@ -65,4 +113,4 @@ else
     GATE_3_STATUS="WARN"
   fi
 fi
-record_gate_audit "gate-3" "complexity" "$GATE_3_STATUS" "${CC_WARNINGS:-0}" "$GATE_3_START"
+record_gate_audit "gate-3" "complexity" "$GATE_3_STATUS" "${CC_WARNINGS:-0}" "$GATE_3_START" "ccn_threshold=${CCN_THRESHOLD:-5}"

package/gate-4.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 # ============================================================================
 # GATE 4: Principles Checker (Clean Code + SOLID)
 # Reuses existing principles checker logic
@@ -23,6 +24,31 @@ if ! declare -F run_tsx >/dev/null 2>&1; then
   }
 fi
 
+# Java rule coverage annotation (#507 S4, AC-507-04-02). The normative matrix
+# lives in docs/java-principles-coverage.md; these constants mirror it. Before
+# #507 the Java adapter fed rules only {name,type,line,code}, so the 12 rules
+# reading structured metrics silently saw `undefined` and a Java commit got a
+# green "checked" with zero effective coverage. 12/15 now fire; the three
+# inert ones are rule-side gaps documented in the coverage doc -- they must
+# NOT be announced as covered.
+JAVA_COVERAGE_EFFECTIVE=12
+JAVA_COVERAGE_TOTAL=15
+JAVA_COVERAGE_INERT="lsp, many-exports, code-duplication"
+
+# Print the coverage annotation when (and only when) the staged file list
+# contains Java sources. Non-Java commits keep the original output byte for
+# byte. Pure shell builtins: no subprocess per file.
+java_coverage_note() {
+  local _f _has_java=""
+  for _f in "$@"; do
+    case "$_f" in
+      *.java|*.Java|*.JAVA) _has_java=1; break ;;
+    esac
+  done
+  [ -n "$_has_java" ] || return 0
+  echo "ℹ️  Java rule coverage: $JAVA_COVERAGE_EFFECTIVE/$JAVA_COVERAGE_TOTAL rules effective (inert on Java: $JAVA_COVERAGE_INERT -- see docs/java-principles-coverage.md)"
+}
+
  2>&1 echo ""
  2>&1 echo "→ Gate 4: Principles checker (Clean Code + SOLID)..."
 GATE_4_START=$(gate_start_ms)
@@ -72,7 +98,12 @@ else
     
     if [ -n "$PRINCIPLES_DIR" ]; then
       echo "Checking Clean Code + SOLID principles..."
-      
+
+      # AC-507-04-02: say what a Java commit is actually covered for, instead
+      # of implying a full 15-rule check (#507). Printed before the run so it
+      # appears on both the PASS and the FAIL path.
+      java_coverage_note ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"}
+
       if command -v npx > /dev/null 2>&1 || [ -f "$PRINCIPLES_BASE/node_modules/tsx/dist/cli.mjs" ]; then
         # Run principles checker and store results.
         #

package/gate-8.sh

@@ -1,11 +1,14 @@
 # ============================================================================
-# GATE 8: Secret Scanning (gitleaks)
-# Detects secrets (API keys, passwords, tokens) in staged files
-# Tool: gitleaks -- https://github.com/gitleaks/gitleaks
+# GATE 8: Secret Scanning (gitleaks + detect-secrets)
+# Detects secrets (API keys, passwords, tokens) in staged files.
+# Tools:
+#   gitleaks        -- primary, fail-closed (missing or non-0/1 exit => BLOCK, #499)
+#   detect-secrets  -- secondary, baseline-diff: only blocks on secrets NOT in
+#                      .secrets.baseline; silently does nothing when unavailable
 # ============================================================================
 
  2>&1 echo ""
- 2>&1 echo "→ Gate 8: Secret scanning (gitleaks)..."
+ 2>&1 echo "→ Gate 8: Secret scanning (gitleaks + detect-secrets)..."
 GATE_8_START=$(gate_start_ms)
 
 # Gitleaks availability check
@@ -16,85 +19,124 @@ elif [ -f "$HOME/.local/bin/gitleaks" ]; then
   GITLEAKS_CMD="$HOME/.local/bin/gitleaks"
 fi
 
-if [ -n "$GITLEAKS_CMD" ]; then
-  GITLEAKS_CONFIG=""
-  if [ -f ".gitleaks.toml" ]; then
-    # gitleaks is a native binary and may not understand MSYS paths, so pass an
-    # absolute path in the host's own format when we can derive one (#449).
-    if command -v cygpath >/dev/null 2>&1; then
-      GITLEAKS_CONFIG="--config=$(cygpath -w "$(pwd)/.gitleaks.toml")"
-    else
-      GITLEAKS_CONFIG="--config=$(pwd)/.gitleaks.toml"
-    fi
+if [ -z "$GITLEAKS_CMD" ]; then
+  # fail-closed (#499): an uninstalled gitleaks used to SKIP the gate, so any
+  # contributor without it shipped commits with zero secret protection and no
+  # signal. A security gate that cannot run must not report success.
+  echo "     ❌ BLOCKED - gitleaks not installed (fail-closed, #499)."
+  echo "   Secret scanning is mandatory before commit. Install gitleaks then retry:"
+  echo "     macOS:   brew install gitleaks"
+  echo "     Windows: winget install gitleaks"
+  echo "     Linux:   scripts/install-gitleaks.sh  (or https://github.com/gitleaks/gitleaks)"
+  exit 1
+fi
+
+GITLEAKS_CONFIG=""
+if [ -f ".gitleaks.toml" ]; then
+  # gitleaks is a native binary and may not understand MSYS paths, so pass an
+  # absolute path in the host's own format when we can derive one (#449).
+  if command -v cygpath >/dev/null 2>&1; then
+    GITLEAKS_CONFIG="--config=$(cygpath -w "$(pwd)/.gitleaks.toml")"
+  else
+    GITLEAKS_CONFIG="--config=$(pwd)/.gitleaks.toml"
   fi
+fi
 
-  # Scan the INDEX, not history. gitleaks 8.x `git --pre-commit` walks committed
-  # revisions and reports "0 commits scanned" on a pre-commit run -- so a staged
-  # secret was never seen and Gate 8 always passed. `git --staged` scans
-  # `git diff --cached`, which is exactly the pre-commit payload (#449).
-  GITLEAKS_REPORT="${TMPDIR:-/tmp}/gitleaks-report.json"
-  rm -f "$GITLEAKS_REPORT"
-  GITLEAKS_OUTPUT=$($GITLEAKS_CMD git --staged --redact --no-banner $GITLEAKS_CONFIG --report-format=json --report-path="$GITLEAKS_REPORT" 2>&1)
-  GITLEAKS_EXIT=$?
+# Scan the INDEX, not history. gitleaks 8.x `git --pre-commit` walks committed
+# revisions and reports "0 commits scanned" on a pre-commit run -- so a staged
+# secret was never seen and Gate 8 always passed. `git --staged` scans
+# `git diff --cached`, which is exactly the pre-commit payload (#449).
+GITLEAKS_REPORT="${TMPDIR:-/tmp}/gitleaks-report.json"
+rm -f "$GITLEAKS_REPORT"
+GITLEAKS_OUTPUT=$($GITLEAKS_CMD git --staged --redact --no-banner $GITLEAKS_CONFIG --report-format=json --report-path="$GITLEAKS_REPORT" 2>&1)
+GITLEAKS_EXIT=$?
 
-  if [ "$GITLEAKS_EXIT" -eq 0 ]; then
-    # Decide SKIP from the REPORT ARTIFACT, not from log wording. Parsing stdout
-    # meant a gitleaks message change would silently turn a no-evidence run into
-    # a PASS -- the same fail-open class this gate just fixed (#449).
-    # The report exists and is a JSON array of findings; `[]` == clean scan.
-    GITLEAKS_FINDINGS="?"
-    if [ -f "$GITLEAKS_REPORT" ]; then
-      # A report that is not shaped like a JSON array is no evidence: leave the
-      # '?' sentinel so the gate reports SKIP, never a PASS it cannot support
-      # (the fail-closed-on-the-claim rule #449 established).
-      if grep -q '^\[' "$GITLEAKS_REPORT" 2>/dev/null; then
-        # Count occurrences, not matching lines: `grep -c` prints its own zero AND
-        # exits 1 on a clean report, so the old `|| echo 0` handed the verdict table
-        # $'0\n0' -- no branch matched and a clean scan was BLOCKED as if it leaked
-        # (#493). wc -l emits exactly one value, and `|| true` keeps the assignment
-        # errexit/pipefail-safe (#489).
-        GITLEAKS_FINDINGS=$(grep -o '"RuleID"' "$GITLEAKS_REPORT" 2>/dev/null | wc -l | tr -d '[:space:]') || true
-      fi
+if [ "$GITLEAKS_EXIT" -eq 0 ]; then
+  # Decide SKIP from the REPORT ARTIFACT, not from log wording. Parsing stdout
+  # meant a gitleaks message change would silently turn a no-evidence run into
+  # a PASS -- the same fail-open class this gate just fixed (#449).
+  # The report exists and is a JSON array of findings; `[]` == clean scan.
+  GITLEAKS_FINDINGS="?"
+  if [ -f "$GITLEAKS_REPORT" ]; then
+    # A report that is not shaped like a JSON array is no evidence: leave the
+    # '?' sentinel so the gate reports SKIP, never a PASS it cannot support
+    # (the fail-closed-on-the-claim rule #449 established).
+    if grep -q '^\[' "$GITLEAKS_REPORT" 2>/dev/null; then
+      # Count occurrences, not matching lines: `grep -c` prints its own zero AND
+      # exits 1 on a clean report, so the old `|| echo 0` handed the verdict table
+      # $'0\n0' -- no branch matched and a clean scan was BLOCKED as if it leaked
+      # (#493). wc -l emits exactly one value, and `|| true` keeps the assignment
+      # errexit/pipefail-safe (#489).
+      GITLEAKS_FINDINGS=$(grep -o '"RuleID"' "$GITLEAKS_REPORT" 2>/dev/null | wc -l | tr -d '[:space:]') || true
     fi
+  fi
 
-    if [ "$GITLEAKS_FINDINGS" = "0" ]; then
-      echo "     ✅ PASSED - No secrets detected."
-      GATE_8_STATUS="PASS"
-    elif [ "$GITLEAKS_FINDINGS" = "?" ]; then
-      # Exit 0 but no readable report: we have no evidence the scan happened.
-      # Fail closed on the *claim*: report SKIP, never PASS.
-      echo "     ⚠️  gitleaks exited 0 but produced no readable report"
-      echo "     ⏭️  SKIPPED - secret scanning produced no evidence (not a pass)"
-      GATE_8_STATUS="SKIP"
-    else
-      echo "     ❌ BLOCKED - gitleaks reported $GITLEAKS_FINDINGS finding(s)"
-      echo "$GITLEAKS_OUTPUT"
-      echo ""
-      echo "Remediation: remove the secret, or allowlist a false positive in .gitleaks.toml."
-      exit 1
-    fi
-  elif [ "$GITLEAKS_EXIT" -eq 1 ]; then
-    # Secrets found — output details
+  if [ "$GITLEAKS_FINDINGS" = "0" ]; then
+    echo "     ✅ PASSED - No secrets detected."
+    GATE_8_STATUS="PASS"
+  elif [ "$GITLEAKS_FINDINGS" = "?" ]; then
+    # Exit 0 but no readable report: we have no evidence the scan happened.
+    # Fail closed on the *claim*: report SKIP, never PASS.
+    echo "     ⚠️  gitleaks exited 0 but produced no readable report"
+    echo "     ⏭️  SKIPPED - secret scanning produced no evidence (not a pass)"
+    GATE_8_STATUS="SKIP"
+  else
+    echo "     ❌ BLOCKED - gitleaks reported $GITLEAKS_FINDINGS finding(s)"
     echo "$GITLEAKS_OUTPUT"
     echo ""
-    echo "❌ BLOCKED - Secrets detected in staged files."
-    echo ""
-    echo "Remediation options:"
-    echo "  1. Remove the secret and use environment variables instead"
-    echo "  2. Add a false positive to .gitleaks.toml allowlist"
-    echo "  3. Use git secret or vault for sensitive data"
-    echo ""
-    echo "See: https://github.com/gitleaks/gitleaks"
+    echo "Remediation: remove the secret, or allowlist a false positive in .gitleaks.toml."
     exit 1
+  fi
+elif [ "$GITLEAKS_EXIT" -eq 1 ]; then
+  # Secrets found — output details
+  echo "$GITLEAKS_OUTPUT"
+  echo ""
+  echo "     ❌ BLOCKED - Secrets detected in staged files."
+  echo ""
+  echo "Remediation options:"
+  echo "  1. Remove the secret and use environment variables instead"
+  echo "  2. Add a false positive to .gitleaks.toml allowlist"
+  echo "  3. Use git secret or vault for sensitive data"
+  echo ""
+  echo "See: https://github.com/gitleaks/gitleaks"
+  exit 1
+else
+  # fail-closed (#499): a non-0/1 exit (config error, crash) used to SKIP, which
+  # let a broken scanner wave every commit through without any scan.
+  echo "     ❌ BLOCKED - gitleaks exited with code $GITLEAKS_EXIT (fail-closed, #499)."
+  echo "$GITLEAKS_OUTPUT"
+  echo "   Secret scanning could not complete; fix the gitleaks error above and retry."
+  exit 1
+fi
+
+# ---- detect-secrets（次要防线，基线比对）----
+# detect-secrets-hook comes from the project's Python dev extra; it blocks only
+# on secrets NOT yet registered in .secrets.baseline, so test-fixture dummy keys
+# recorded in the baseline never trip it.
+#
+# The file list is piped NUL-delimited STRAIGHT into xargs -0 — never through a
+# command substitution. `var=$(cmd -z)` strips every NUL byte (bash cannot hold
+# NULs in a variable), which concatenated all filenames into one giant
+# nonexistent path and would have BLOCKED every commit once a project shipped
+# both detect-secrets-hook and .secrets.baseline. The pipeline lives inside an
+# if-condition (errexit-exempt); a non-zero hook exit lands in the else branch.
+if command -v detect-secrets-hook >/dev/null 2>&1 && [ -f ".secrets.baseline" ]; then
+  DS_TMP="$(dirname "$(mktemp -u)")/ds-output.$$"
+  if git diff --cached --name-only --diff-filter=ACM -z \
+      | xargs -0 detect-secrets-hook --baseline .secrets.baseline > "$DS_TMP" 2>&1; then
+    echo "     ✅ detect-secrets PASSED - no new secrets beyond baseline."
   else
-    echo "     ⚠️  gitleaks exited with code $GITLEAKS_EXIT - skipping gate"
-    echo "     ✅ Secret Scanning (SKIP, gitleaks error)"
-    GATE_8_STATUS="SKIP"
+    cat "$DS_TMP"
+    echo ""
+    echo "     ❌ BLOCKED - detect-secrets found secrets not in .secrets.baseline."
+    echo "   If these are false positives, regenerate the baseline (cross-platform):"
+    echo "     detect-secrets scan --update .secrets.baseline && git add .secrets.baseline"
+    rm -f "$DS_TMP"
+    exit 1
   fi
+  rm -f "$DS_TMP"
 else
-  echo "     ℹ️  gitleaks not installed — secret scanning unavailable"
-  echo "     Install: brew install gitleaks (macOS) | winget install gitleaks (Windows) | scripts/install-gitleaks.sh (Linux)"
-  echo "     ⏭️  SKIPPED - Secret scanning (gitleaks not installed)"
-  GATE_8_STATUS="SKIP"
+  echo "     ⚠️  detect-secrets-hook unavailable (install: pip install -e \".[dev]\") — gitleaks only."
 fi
+
 record_gate_audit "gate-8" "secret-scanning" "$GATE_8_STATUS" "0" "$GATE_8_START"

package/hooks/gate-3.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 # ============================================================================
 # GATE 3: Cyclomatic Complexity Check
 # Uses lizard - checks cyclomatic complexity of changed source files
@@ -17,7 +18,45 @@ elif [ "$PROJECT_LANG" = "powershell" ]; then
   GATE_3_STATUS="SKIP"
   
 else
-  CCN_THRESHOLD=5
+  # S2 (#507): three-level CCN threshold override --
+  # .xp-gate/ccn-threshold (positive integer) > XP_GATE_CCN_THRESHOLD > 5.
+  # Invalid values WARN on stderr and fall back to the default; the resolved
+  # value reaches the gate-3 audit record via the --detail argument below.
+  # Implemented with bash builtins only (no tr/grep spawns): every process
+  # spawn is expensive on Windows under AV filter drivers.
+  resolve_ccn_threshold() {
+    local default=5 val
+    if [ -f ".xp-gate/ccn-threshold" ]; then
+      val=$(<".xp-gate/ccn-threshold")
+      val="${val//[[:space:]]/}"
+      case "$val" in
+        ''|*[!0-9]*|0)
+          echo "WARN - invalid .xp-gate/ccn-threshold value '${val}' (expected a positive integer), falling back to ${default}" >&2
+          ;;
+        *)
+          echo "$val"
+          return 0
+          ;;
+      esac
+      echo "$default"
+      return 0
+    fi
+    val=${XP_GATE_CCN_THRESHOLD:-}
+    if [ -n "$val" ]; then
+      case "$val" in
+        ''|*[!0-9]*|0)
+          echo "WARN - invalid XP_GATE_CCN_THRESHOLD value '${val}' (expected a positive integer), falling back to ${default}" >&2
+          ;;
+        *)
+          echo "$val"
+          return 0
+          ;;
+      esac
+    fi
+    echo "$default"
+  }
+
+  CCN_THRESHOLD=$(resolve_ccn_threshold)
   
   # Check lizard availability
   LIZARD_CMD=""
@@ -37,7 +76,16 @@ else
       echo "Checking complexity for source files..."
       
       # Run lizard with CCN threshold
-      CC_OUTPUT=$($LIZARD_PATH -C $CCN_THRESHOLD $CC_FILES 2>&1 || true)
+      # One path per line, into an array. Unquoted $CC_FILES relied on word
+      # splitting, which also splits any path containing a space -- handing
+      # lizard two bogus paths and checking neither (#457 defect class, same
+      # fix as gate-4's PRINCIPLES_ARGS). Quoting the scalar would instead
+      # collapse the list into one argument. An array does both.
+      CC_FILES_ARGS=()
+      while IFS= read -r _cc_file; do
+        [ -n "$_cc_file" ] && CC_FILES_ARGS+=("$_cc_file")
+      done <<< "$CC_FILES"
+      CC_OUTPUT=$("$LIZARD_PATH" -C "$CCN_THRESHOLD" ${CC_FILES_ARGS[@]+"${CC_FILES_ARGS[@]}"} 2>&1 || true)
       
       # Parse warning count from the summary table: "Warning cnt   8"
       # Use anchored grep to avoid matching lizard table headers (e.g. "Rt" column)
@@ -65,4 +113,4 @@ else
     GATE_3_STATUS="WARN"
   fi
 fi
-record_gate_audit "gate-3" "complexity" "$GATE_3_STATUS" "${CC_WARNINGS:-0}" "$GATE_3_START"
+record_gate_audit "gate-3" "complexity" "$GATE_3_STATUS" "${CC_WARNINGS:-0}" "$GATE_3_START" "ccn_threshold=${CCN_THRESHOLD:-5}"

package/hooks/gate-4.sh

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 # ============================================================================
 # GATE 4: Principles Checker (Clean Code + SOLID)
 # Reuses existing principles checker logic
@@ -23,6 +24,31 @@ if ! declare -F run_tsx >/dev/null 2>&1; then
   }
 fi
 
+# Java rule coverage annotation (#507 S4, AC-507-04-02). The normative matrix
+# lives in docs/java-principles-coverage.md; these constants mirror it. Before
+# #507 the Java adapter fed rules only {name,type,line,code}, so the 12 rules
+# reading structured metrics silently saw `undefined` and a Java commit got a
+# green "checked" with zero effective coverage. 12/15 now fire; the three
+# inert ones are rule-side gaps documented in the coverage doc -- they must
+# NOT be announced as covered.
+JAVA_COVERAGE_EFFECTIVE=12
+JAVA_COVERAGE_TOTAL=15
+JAVA_COVERAGE_INERT="lsp, many-exports, code-duplication"
+
+# Print the coverage annotation when (and only when) the staged file list
+# contains Java sources. Non-Java commits keep the original output byte for
+# byte. Pure shell builtins: no subprocess per file.
+java_coverage_note() {
+  local _f _has_java=""
+  for _f in "$@"; do
+    case "$_f" in
+      *.java|*.Java|*.JAVA) _has_java=1; break ;;
+    esac
+  done
+  [ -n "$_has_java" ] || return 0
+  echo "ℹ️  Java rule coverage: $JAVA_COVERAGE_EFFECTIVE/$JAVA_COVERAGE_TOTAL rules effective (inert on Java: $JAVA_COVERAGE_INERT -- see docs/java-principles-coverage.md)"
+}
+
  2>&1 echo ""
  2>&1 echo "→ Gate 4: Principles checker (Clean Code + SOLID)..."
 GATE_4_START=$(gate_start_ms)
@@ -72,7 +98,12 @@ else
     
     if [ -n "$PRINCIPLES_DIR" ]; then
       echo "Checking Clean Code + SOLID principles..."
-      
+
+      # AC-507-04-02: say what a Java commit is actually covered for, instead
+      # of implying a full 15-rule check (#507). Printed before the run so it
+      # appears on both the PASS and the FAIL path.
+      java_coverage_note ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"}
+
       if command -v npx > /dev/null 2>&1 || [ -f "$PRINCIPLES_BASE/node_modules/tsx/dist/cli.mjs" ]; then
         # Run principles checker and store results.
         #