@boyingliu01/xp-gate 0.19.2 → 0.20.0

package/adapters/gate-4.sh

@@ -16,29 +16,97 @@ if [ "$PROJECT_LANG" = "documentation-only" ]; then
 else
   # Get source files to check against principles
   PRINCIPLES_FILES=$(echo "$CHANGED_FILES" | grep -E '\.(ts|tsx|js|jsx|py|go|java|kt|dart|swift|cpp|c|hpp|h|m|mm)$' || true)
+
+  # One path per line, into an array. Passing $PRINCIPLES_FILES unquoted relies on
+  # word splitting to turn the list into separate argv entries, which also splits
+  # any path containing a space -- handing the checker two bogus paths and checking
+  # neither. Quoting it would instead collapse the list into one argument. An array
+  # is the only form that does both. Same defect class as the --config fix (#457).
+  PRINCIPLES_ARGS=()
+  while IFS= read -r _principles_file; do
+    [ -n "$_principles_file" ] && PRINCIPLES_ARGS+=("$_principles_file")
+  done <<< "$PRINCIPLES_FILES"
   
   if [ -n "$PRINCIPLES_FILES" ]; then
-    # Check for principles checker in installed modules first, then project src/
+    # Same anchoring as githooks/gate-4.sh: CHANGED_FILES paths are repo-root relative
+    # and the checker resolves them against its own working directory, so both the
+    # probes and the invocation run from the repo root. Resolving them against the
+    # hook's CWD lost the checker in single-language subdir mode (#478).
+    PRINCIPLES_BASE="${PROJECT_ROOT:-$(pwd)}"
+
     PRINCIPLES_DIR=""
-    if [ -d ".xp-gate/modules/principles" ]; then
-      PRINCIPLES_DIR=".xp-gate/modules/principles"
-    elif [ -f "src/principles/index.ts" ]; then
-      PRINCIPLES_DIR="src/principles"
-    elif [ -d "$HOME/.config/xp-gate/modules/principles" ]; then
-      PRINCIPLES_DIR="$HOME/.config/xp-gate/modules/principles"
-    fi
+    for _principles_candidate in \
+      "$PRINCIPLES_BASE/.xp-gate/modules/principles" \
+      "$PRINCIPLES_BASE/src/principles" \
+      "$(pwd)/.xp-gate/modules/principles" \
+      "$(pwd)/src/principles" \
+      "$HOME/.config/xp-gate/modules/principles"; do
+      if [ -f "$_principles_candidate/index.ts" ]; then
+        PRINCIPLES_DIR="$_principles_candidate"
+        break
+      fi
+    done
     
     if [ -n "$PRINCIPLES_DIR" ]; then
       echo "Checking Clean Code + SOLID principles..."
       
       if command -v npx > /dev/null 2>&1; then
-        # Run principles checker and store results
-        if npx tsx $PRINCIPLES_DIR/index.ts --files $PRINCIPLES_FILES --format json > /tmp/principles-output.json 2>/dev/null; then
-          # Check severity levels
-          ERROR_COUNT=$(grep -c '"severity":"error"' /tmp/principles-output.json 2>/dev/null || true)
+        # Run principles checker and store results.
+        #
+        # Do NOT wrap this in `if ...; then`: the checker's exit codes are
+        # deliberately distinct (0 clean, 1 ERROR-severity findings, >=2 tool
+        # failure), and an `if` collapses 1 and 2 into "failed". That sent real
+        # error-severity findings down the crash branch, which SKIPs and prints
+        # PASSED -- releasing exactly the most serious violations.
+        # The trailing `|| PRINCIPLES_EXIT=$?` captures the exit status without
+        # letting a non-zero return abort the hook under `set -e`. pre-commit itself
+        # runs with only `set -o pipefail` (no `set -e`, pinned by
+        # scripts/__tests__/gate-5-runner-error.test.ts AC-454-08), but this module is
+        # also sourced by consumer hooks that may set it, and a bare call followed by
+        # `PRINCIPLES_EXIT=$?` never reaches the assignment under `set -e`. `|| true`
+        # would erase the status -- which is exactly the distinction this gate depends
+        # on.
+        PRINCIPLES_EXIT=0
+        # Keep stderr: it carries the checker's configuration warnings -- a rejected
+        # threshold or an out-of-vocabulary severity says so here and nowhere else.
+        # Sending it to /dev/null made an exit-2 SKIP undiagnosable and hid every
+        # .principlesrc typo (Delphi walkthrough MC-03). Captured to a file so a clean
+        # run stays quiet, then replayed only when the checker had a problem.
+        # `cd || exit 2`: a base we cannot enter means the checker never ran, which is
+        # this module's tool-failure code. Falling through would return the exit status
+        # of the failed cd (1), and 1 asserts "I examined files and found errors" -- an
+        # empty report at 1 reads as a clean pass.
+        #
+        # The report is a PER-INVOCATION mktemp, not a shared `/tmp/principles-output.json`:
+        # two commits racing on one machine (two worktrees, a hook and a CI job) overwrote
+        # each other's report before it was counted, so a run with ERROR findings could
+        # read a clean report and PASS (#457). PRINCIPLES_JSON is exported so a caller can
+        # point a harness at the same file.
+        PRINCIPLES_STDERR=$(mktemp)
+        PRINCIPLES_JSON=$(mktemp)
+        export PRINCIPLES_JSON
+        ( cd "$PRINCIPLES_BASE" 2>/dev/null || exit 2
+          npx tsx "$PRINCIPLES_DIR/index.ts" --files ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"} --format json ) > "$PRINCIPLES_JSON" 2>"$PRINCIPLES_STDERR" || PRINCIPLES_EXIT=$?
+
+        if [ -s "$PRINCIPLES_STDERR" ]; then
+          sed 's/^/     /' "$PRINCIPLES_STDERR"
+        fi
+        rm -f "$PRINCIPLES_STDERR"
+
+        if [ "$PRINCIPLES_EXIT" -ge 2 ]; then
+          echo "⚠️  Warning: Principles checker execution failed"
+          echo "⏭️  SKIPPED - Principles check (execution issue)"
+          GATE_4_STATUS="SKIP"
+          rm -f "$PRINCIPLES_JSON"
+        else
+          # Check severity levels. The reporter emits JSON.stringify(out, null, 2),
+          # i.e. `"severity": "warning"` WITH a space; tolerate any whitespace so a
+          # future minified format cannot silently zero these counts again (#444).
+          ERROR_COUNT=$(grep -cE '"severity"[[:space:]]*:[[:space:]]*"error"' "$PRINCIPLES_JSON" 2>/dev/null || true)
           ERROR_COUNT=${ERROR_COUNT:-0}
-          WARNING_COUNT=$(grep -c '"severity":"warning"' /tmp/principles-output.json 2>/dev/null || true)
+          WARNING_COUNT=$(grep -cE '"severity"[[:space:]]*:[[:space:]]*"warning"' "$PRINCIPLES_JSON" 2>/dev/null || true)
           WARNING_COUNT=${WARNING_COUNT:-0}
+          rm -f "$PRINCIPLES_JSON"
           
           if [ "$ERROR_COUNT" -gt 0 ]; then
             echo ""
@@ -47,7 +115,8 @@ else
             echo "  - error-handling violations"
             echo "  - SOLID principle violations"
             echo "  - architectural violations"
-            npx tsx $PRINCIPLES_DIR/index.ts --files $PRINCIPLES_FILES --format console
+            ( cd "$PRINCIPLES_BASE" 2>/dev/null || exit 2
+              npx tsx "$PRINCIPLES_DIR/index.ts" --files ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"} --format console )
             GATE_4_STATUS="FAIL"
             exit 1
           fi
@@ -57,10 +126,6 @@ else
           if [ "$WARNING_COUNT" -gt 0 ]; then
             echo "ℹ️  $WARNING_COUNT warnings found (will be handled by Boy Scout Rule)."
           fi
-        else
-          echo "⚠️  Warning: Principles checker execution failed"
-          echo "⏭️  SKIPPED - Principles check (execution issue)"
-          GATE_4_STATUS="SKIP"
         fi
       else
         echo "ℹ️  npx not available - skipping principles check"

package/adapters/gate-8.sh

@@ -19,16 +19,60 @@ fi
 if [ -n "$GITLEAKS_CMD" ]; then
   GITLEAKS_CONFIG=""
   if [ -f ".gitleaks.toml" ]; then
-    GITLEAKS_CONFIG="--config=.gitleaks.toml"
+    # gitleaks is a native binary and may not understand MSYS paths, so pass an
+    # absolute path in the host's own format when we can derive one (#449).
+    if command -v cygpath >/dev/null 2>&1; then
+      GITLEAKS_CONFIG="--config=$(cygpath -w "$(pwd)/.gitleaks.toml")"
+    else
+      GITLEAKS_CONFIG="--config=$(pwd)/.gitleaks.toml"
+    fi
   fi
 
-  # Run gitleaks on staged changes only (pre-commit mode for speed)
-  GITLEAKS_OUTPUT=$($GITLEAKS_CMD git --pre-commit --redact --no-banner $GITLEAKS_CONFIG --report-format=json --report-path=/tmp/gitleaks-report.json 2>&1)
+  # Scan the INDEX, not history. gitleaks 8.x `git --pre-commit` walks committed
+  # revisions and reports "0 commits scanned" on a pre-commit run -- so a staged
+  # secret was never seen and Gate 8 always passed. `git --staged` scans
+  # `git diff --cached`, which is exactly the pre-commit payload (#449).
+  GITLEAKS_REPORT="${TMPDIR:-/tmp}/gitleaks-report.json"
+  rm -f "$GITLEAKS_REPORT"
+  GITLEAKS_OUTPUT=$($GITLEAKS_CMD git --staged --redact --no-banner $GITLEAKS_CONFIG --report-format=json --report-path="$GITLEAKS_REPORT" 2>&1)
   GITLEAKS_EXIT=$?
 
   if [ "$GITLEAKS_EXIT" -eq 0 ]; then
-    echo "     ✅ PASSED - No secrets detected."
-    GATE_8_STATUS="PASS"
+    # Decide SKIP from the REPORT ARTIFACT, not from log wording. Parsing stdout
+    # meant a gitleaks message change would silently turn a no-evidence run into
+    # a PASS -- the same fail-open class this gate just fixed (#449).
+    # The report exists and is a JSON array of findings; `[]` == clean scan.
+    GITLEAKS_FINDINGS="?"
+    if [ -f "$GITLEAKS_REPORT" ]; then
+      # A report that is not shaped like a JSON array is no evidence: leave the
+      # '?' sentinel so the gate reports SKIP, never a PASS it cannot support
+      # (the fail-closed-on-the-claim rule #449 established).
+      if grep -q '^\[' "$GITLEAKS_REPORT" 2>/dev/null; then
+        # Count occurrences, not matching lines: `grep -c` prints its own zero AND
+        # exits 1 on a clean report, so the old `|| echo 0` handed the verdict table
+        # $'0\n0' -- no branch matched and a clean scan was BLOCKED as if it leaked
+        # (#493). wc -l emits exactly one value, and `|| true` keeps the assignment
+        # errexit/pipefail-safe (#489).
+        GITLEAKS_FINDINGS=$(grep -o '"RuleID"' "$GITLEAKS_REPORT" 2>/dev/null | wc -l | tr -d '[:space:]') || true
+      fi
+    fi
+
+    if [ "$GITLEAKS_FINDINGS" = "0" ]; then
+      echo "     ✅ PASSED - No secrets detected."
+      GATE_8_STATUS="PASS"
+    elif [ "$GITLEAKS_FINDINGS" = "?" ]; then
+      # Exit 0 but no readable report: we have no evidence the scan happened.
+      # Fail closed on the *claim*: report SKIP, never PASS.
+      echo "     ⚠️  gitleaks exited 0 but produced no readable report"
+      echo "     ⏭️  SKIPPED - secret scanning produced no evidence (not a pass)"
+      GATE_8_STATUS="SKIP"
+    else
+      echo "     ❌ BLOCKED - gitleaks reported $GITLEAKS_FINDINGS finding(s)"
+      echo "$GITLEAKS_OUTPUT"
+      echo ""
+      echo "Remediation: remove the secret, or allowlist a false positive in .gitleaks.toml."
+      exit 1
+    fi
   elif [ "$GITLEAKS_EXIT" -eq 1 ]; then
     # Secrets found — output details
     echo "$GITLEAKS_OUTPUT"

package/adapters/iac.sh

@@ -124,7 +124,7 @@ run_static_analysis() {
 
     # Print captured output then check for failures
     cat "$checkov_log"
-    local failed_count=$(grep -c "FAILED for resource" "$checkov_log" 2>/dev/null || echo 0)
+    local failed_count=$(grep -c "FAILED for resource" "$checkov_log" 2>/dev/null || true)
     rm -f "$checkov_log"
 
     if [ "$failed_count" -gt 0 ]; then

package/adapters/typescript.sh

@@ -3,70 +3,25 @@
 # TypeScript adapter for quality gates
 
 run_static_analysis() {
-  if ! command -v npx >/dev/null 2>&1; then
-    echo "npx not available, skipping TypeScript static analysis"
-    return 0
-  fi
-
-  local HAS_ERRORS=0
-  local TSC_VERSION
-
-  echo "Running TypeScript static analysis..."
-  npx tsc --noEmit
-  TSC_EXIT=$?
-  if [ $TSC_EXIT -ne 0 ]; then
-    HAS_ERRORS=1
+  # The type-check decision is shared with pre-commit's Gate 1 (#436): a project's
+  # own checker (typecheck script, or GATE_TS_TYPECHECK_CMD) is used when declared,
+  # otherwise the pre-#436 `npx tsc --noEmit` path. This adapter's contract predates
+  # that split, so it keeps reporting only 0 (clean/skipped) or 1 (type errors).
+  local lib_dir
+  lib_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../lib" 2>/dev/null && pwd)"
+  if [ -n "$lib_dir" ] && [ -f "$lib_dir/typecheck.sh" ]; then
+    # shellcheck source=/dev/null
+    source "$lib_dir/typecheck.sh"
   fi
 
-  # Also check test files if tsconfig.json exists (see Issue #293).
-  # Many projects exclude __tests__/ from tsconfig.json, so test file type
-  # errors silently accumulate. We detect this and run a second tsc pass.
-  local HAS_TESTS=false
-  if [ -d "src/__tests__" ] || [ -d "src/tests" ] || [ -d "tests" ] || [ -d "__tests__" ]; then
-    HAS_TESTS=true
-  fi
-
-  if [ "$HAS_TESTS" = true ] && [ -f "tsconfig.json" ]; then
-    # Check if tsconfig.json already includes test files
-    if npx tsc --noEmit --listFiles 2>/dev/null | grep -qE '__tests__/|\.test\.ts|\.spec\.ts'; then
-      : # Test files already checked — no additional pass needed
-    elif [ -f "tsconfig.tests.json" ]; then
-      echo "Checking test files with tsconfig.tests.json..."
-      npx tsc --noEmit --project tsconfig.tests.json
-      TSC_TEST_EXIT=$?
-      if [ $TSC_TEST_EXIT -ne 0 ]; then
-        HAS_ERRORS=1
-      fi
-    else
-      # Generate a temp tsconfig that includes test files for the additional pass
-      local TSC_TEST_EXIT=0
-      echo "Checking test files for type errors (generating temp tsconfig)..."
-      npx tsc --noEmit 2>/dev/null
-      # Create temp tsconfig extending the original but with test files included
-      local TEMP_TSCONFIG=".tsconfig.withtests.json"
-      if [ ! -f "$TEMP_TSCONFIG" ]; then
-        node -e "
-          const cfg = JSON.parse(require('fs').readFileSync('tsconfig.json','utf8'));
-          delete cfg.exclude;
-          cfg.include = cfg.include || ['src/**/*'];
-          cfg.include.push('src/**/__tests__/**','src/**/*.test.ts','src/**/*.spec.ts');
-          require('fs').writeFileSync('$TEMP_TSCONFIG', JSON.stringify(cfg, null, 2));
-        " 2>/dev/null
-        npx tsc --noEmit --project "$TEMP_TSCONFIG"
-        TSC_TEST_EXIT=$?
-        rm -f "$TEMP_TSCONFIG"
-      fi
-      if [ $TSC_TEST_EXIT -ne 0 ]; then
-        echo ""
-        echo "❌ BLOCKED - TYPE ERRORS in test files"
-        echo "Your project's tsconfig.json excludes test files from type checking."
-        echo "Fix the type errors above or add a tsconfig.tests.json to customise test file checking."
-        HAS_ERRORS=1
-      fi
-    fi
+  if ! command -v run_typescript_typecheck >/dev/null 2>&1; then
+    echo "typecheck.sh not resolvable, skipping TypeScript static analysis"
+    return 0
   fi
 
-  return $HAS_ERRORS
+  run_typescript_typecheck
+  [ $? -eq 1 ] && return 1
+  return 0
 }
 
 run_lint() {

package/bin/xp-gate.js

@@ -6,6 +6,7 @@ const { updateSkill } = require('../lib/update-skill.js');
 const { uninstallSkill } = require('../lib/uninstall-skill.js');
 const { uninstall } = require('../lib/uninstall.js');
 const { doctor } = require('../lib/doctor.js');
+const { parseSkillFlags, SKILL_FLAGS_BY_COMMAND } = require('../lib/shared-utils.js');
 const { checkDeps } = require('../lib/detect-deps.js');
 const { migrate } = require('../lib/migrate.js');
 const { handleBaseline } = require('../lib/baseline.js');
@@ -80,18 +81,18 @@ const COMMANDS = {
     usage: 'xp-gate setup-global'
   },
   'install-skill': {
-    description: 'Install a xp-gate skill from GitHub',
+    description: 'Install a xp-gate skill from the package bundle',
     run: subargs => {
       const name = subargs[0];
       if (!name) {
         console.error('Error: Skill name required');
-        console.error('Usage: xp-gate install-skill <name>[@<version>]');
+        console.error('Usage: xp-gate install-skill <name> [--verbose] [--force]');
         process.exit(1);
       }
-      const options = parseOptions(subargs.slice(1));
+      const options = parseOptions(subargs.slice(1), 'install-skill');
       installSkill(name, options).then(code => process.exit(code));
     },
-    usage: 'xp-gate install-skill <name>[@<version>] [--offline] [--verbose] [--force]'
+    usage: 'xp-gate install-skill <name> [--verbose] [--force]'
   },
   'update-skill': {
     description: 'Update installed skill(s)',
@@ -101,12 +102,12 @@ const COMMANDS = {
       let name, options;
       if (allFlagIndex !== -1) {
         // Remove --all from args before parsing, name is undefined
-        options = parseOptions([...subargs.slice(0, allFlagIndex), ...subargs.slice(allFlagIndex + 1)]);
+        options = parseOptions([...subargs.slice(0, allFlagIndex), ...subargs.slice(allFlagIndex + 1)], 'update-skill');
         options.all = true;
         name = undefined;  // explicit: no single name when --all is used
       } else {
         name = subargs[0];
-        options = parseOptions(subargs.slice(1));
+        options = parseOptions(subargs.slice(1), 'update-skill');
       }
       updateSkill(name, options).then(code => process.exit(code));
     },
@@ -121,7 +122,7 @@ const COMMANDS = {
         console.error('Usage: xp-gate uninstall-skill <name>');
         process.exit(1);
       }
-      const options = parseOptions(subargs.slice(1));
+      const options = parseOptions(subargs.slice(1), 'uninstall-skill');
       uninstallSkill(name, options).then(code => process.exit(code));
     },
     usage: 'xp-gate uninstall-skill <name> [--force]'
@@ -139,7 +140,7 @@ const COMMANDS = {
   'doctor': {
     description: 'Diagnose xp-gate installation health',
     run: subargs => doctor(subargs).then(code => process.exit(code)),
-    usage: 'xp-gate doctor [--fix]'
+    usage: 'xp-gate doctor [--fix [--install-tools] | --sync-hooks [--force]] | --json | --format json  (the two machine-readable modes print one JSON document and refuse --fix/--sync-hooks)'
   },
   'ui-review': {
     description: 'Run UI review for non-sprint developers (generates .ui-gate-result.json)',
@@ -487,14 +488,12 @@ function printStatsTable(stats) {
   console.log('└──────────────────┴────────┴────────┴────────────┘');
 }
 
-function parseOptions(args) {
-  const options = { offline: false, verbose: false, force: false, all: false, check: false };
-  for (const arg of args) {
-    if (arg === '--offline') options.offline = true;
-    if (arg === '--verbose') options.verbose = true;
-    if (arg === '--force') options.force = true;
-    if (arg === '--all') options.all = true;
-    if (arg === '--check') options.check = true;
+function parseOptions(args, command) {
+  const { options, unknown } = parseSkillFlags(args, command);
+  if (unknown.length > 0) {
+    console.error(`Unknown argument(s) for ${command}: ${unknown.join(', ')}`);
+    console.error(`Supported flags: ${(SKILL_FLAGS_BY_COMMAND[command] || []).join(', ') || '(none)'}`);
+    process.exit(1);
   }
   return options;
 }

package/gate-10.sh

@@ -33,15 +33,39 @@ else
     echo "     ⏭️  SKIPPED - SAST (no supported language files changed)"
     GATE_10_STATUS="SKIP"
   else
+    # One path per line into an array. Quoting the newline-joined list would hand
+    # semgrep ONE argument containing newlines -> "Invalid scanning root" once
+    # >=2 files are staged (#490). Same defect class as the Gate 4 --files fix
+    # (#457): an array is the only form that keeps spaces intact AND splits files.
+    #
+    # Each element gets a ./ prefix: a tracked path may legitimately start with
+    # '-' (`git add -- ./-o.ts`), and bare in argv that element reads as an option
+    # and rewrites the scan it was meant to constrain. ./ is a path to every
+    # argument parser.
+    #
+    # The unquoted heredoc below expands $SEMGREP_FILES once, then feeds literal
+    # lines to `read`; bash never rescans the result for separators. Its correct
+    # reading rests on one property of the producer above, not of the loop:
+    # `git diff --cached --name-only` terminates paths with LF and quotes control
+    # characters (a CR in a name arrives as the four bytes \215, never as a bare
+    # CR), so one line is exactly one path. Asserted for spaces and a leading '-'
+    # by AC-490-04.
+    SEMGREP_ARGS=()
+    while IFS= read -r _semgrep_file; do
+      [ -n "$_semgrep_file" ] && SEMGREP_ARGS+=("./$_semgrep_file")
+    done <<EOF
+$SEMGREP_FILES
+EOF
+
     # Run semgrep with JSON output
     # --config=p/security-audit: explicit security ruleset
     # --json: machine-readable output
     # --disable-version-check: skip network call
-    SEMGREP_OUTPUT=$("$SEMGREP_CMD" scan --config=p/security-audit --json --disable-version-check "$SEMGREP_FILES" 2>&1)
+    SEMGREP_OUTPUT=$("$SEMGREP_CMD" scan --config=p/security-audit --json --disable-version-check "${SEMGREP_ARGS[@]}" 2>&1)
     SEMGREP_EXIT=$?
 
     if [ "$SEMGREP_EXIT" -eq 0 ]; then
-      echo "     ✅ PASSED - No security vulnerabilities found."
+      echo "     ✅ PASSED - No security vulnerabilities found (files scanned: ${#SEMGREP_ARGS[@]})."
       GATE_10_STATUS="PASS"
     elif [ "$SEMGREP_EXIT" -eq 1 ]; then
       # Findings detected - parse JSON to categorize
@@ -96,7 +120,16 @@ console.log('  ['+severity+'] '+ruleId);console.log('  '+path+':'+line+' → '+m
       fi
     else
       # semgrep runtime error (timeout, config error, etc.)
+      #
+      # SEMGREP_OUTPUT is captured above and was never shown here, so an intermittent
+      # ruleset-fetch failure looked identical to a broken install: the gate printed
+      # "runtime error" and kept the reason to itself (#475). The verdict stays SKIP --
+      # an operational failure must not block the commit, and must not be called a pass.
       echo "     ⚠️  semgrep exited with code ${SEMGREP_EXIT} — skipping gate"
+      if [ -n "$SEMGREP_OUTPUT" ]; then
+        echo "     ── what semgrep reported ──"
+        printf '%s\n' "$SEMGREP_OUTPUT" | tail -10 | sed 's/^/     /'
+      fi
       echo "     ⏭️  SKIPPED - SAST (semgrep runtime error)"
       GATE_10_STATUS="SKIP"
     fi

package/gate-4.sh

@@ -3,6 +3,26 @@
 # Reuses existing principles checker logic
 # ============================================================================
 
+# Run a TypeScript entrypoint under tsx without routing arguments through the
+# npx shim: Windows cmd.exe caps command lines at 8191 chars and long staged
+# file lists overflow it, turning a healthy run into a false BLOCK. Prefer the
+# repo-local tsx CLI driven by node directly; keep npx as fallback for consumer
+# repos relying on a global install. Defined here as well so this module also
+# works when sourced outside pre-commit.
+if ! declare -F run_tsx >/dev/null 2>&1; then
+  run_tsx() {
+    local _root="${PROJECT_ROOT:-$(pwd)}" _timeout=()
+    if [ -n "${RUN_TSX_TIMEOUT:-}" ]; then
+      _timeout=(timeout "$RUN_TSX_TIMEOUT")
+    fi
+    if [ -f "$_root/node_modules/tsx/dist/cli.mjs" ] && command -v node >/dev/null 2>&1; then
+      "${_timeout[@]}" node "$_root/node_modules/tsx/dist/cli.mjs" "$@"
+    else
+      "${_timeout[@]}" npx tsx "$@"
+    fi
+  }
+fi
+
  2>&1 echo ""
  2>&1 echo "→ Gate 4: Principles checker (Clean Code + SOLID)..."
 GATE_4_START=$(gate_start_ms)
@@ -16,29 +36,101 @@ if [ "$PROJECT_LANG" = "documentation-only" ]; then
 else
   # Get source files to check against principles
   PRINCIPLES_FILES=$(echo "$CHANGED_FILES" | grep -E '\.(ts|tsx|js|jsx|py|go|java|kt|dart|swift|cpp|c|hpp|h|m|mm)$' || true)
+
+  # One path per line, into an array. Passing $PRINCIPLES_FILES unquoted relies on
+  # word splitting to turn the list into separate argv entries, which also splits
+  # any path containing a space -- handing the checker two bogus paths and checking
+  # neither. Quoting it would instead collapse the list into one argument. An array
+  # is the only form that does both. Same defect class as the --config fix (#457).
+  PRINCIPLES_ARGS=()
+  while IFS= read -r _principles_file; do
+    [ -n "$_principles_file" ] && PRINCIPLES_ARGS+=("$_principles_file")
+  done <<< "$PRINCIPLES_FILES"
   
   if [ -n "$PRINCIPLES_FILES" ]; then
-    # Check for principles checker in installed modules first, then project src/
+    # The checker resolves every path it is given -- and every path in CHANGED_FILES
+    # comes from `git diff`, so it is repo-root relative -- against its own working
+    # directory. Resolving against the hook's CWD broke in single-language subdir
+    # mode, where pre-commit has already cd'd into $PROJECT_SUBDIR: web/src/a.ts was
+    # looked up as web/web/src/a.ts, the probes below missed the checker that was
+    # installed one level up, and a working gate degraded to SKIPPED (#478).
+    # Everything this gate reads is therefore anchored at the repo root.
+    PRINCIPLES_BASE="${PROJECT_ROOT:-$(pwd)}"
+
     PRINCIPLES_DIR=""
-    if [ -d ".xp-gate/modules/principles" ]; then
-      PRINCIPLES_DIR=".xp-gate/modules/principles"
-    elif [ -f "src/principles/index.ts" ]; then
-      PRINCIPLES_DIR="src/principles"
-    elif [ -d "$HOME/.config/xp-gate/modules/principles" ]; then
-      PRINCIPLES_DIR="$HOME/.config/xp-gate/modules/principles"
-    fi
+    for _principles_candidate in \
+      "$PRINCIPLES_BASE/.xp-gate/modules/principles" \
+      "$PRINCIPLES_BASE/src/principles" \
+      "$(pwd)/.xp-gate/modules/principles" \
+      "$(pwd)/src/principles" \
+      "$HOME/.config/xp-gate/modules/principles"; do
+      if [ -f "$_principles_candidate/index.ts" ]; then
+        PRINCIPLES_DIR="$_principles_candidate"
+        break
+      fi
+    done
     
     if [ -n "$PRINCIPLES_DIR" ]; then
       echo "Checking Clean Code + SOLID principles..."
       
-      if command -v npx > /dev/null 2>&1; then
-        # Run principles checker and store results
-        if npx tsx $PRINCIPLES_DIR/index.ts --files $PRINCIPLES_FILES --format json > /tmp/principles-output.json 2>/dev/null; then
-          # Check severity levels
-          ERROR_COUNT=$(grep -c '"severity":"error"' /tmp/principles-output.json 2>/dev/null || true)
+      if command -v npx > /dev/null 2>&1 || [ -f "$PRINCIPLES_BASE/node_modules/tsx/dist/cli.mjs" ]; then
+        # Run principles checker and store results.
+        #
+        # Do NOT wrap this in `if ...; then`: the checker's exit codes are
+        # deliberately distinct (0 clean, 1 ERROR-severity findings, >=2 tool
+        # failure), and an `if` collapses 1 and 2 into "failed". That sent real
+        # error-severity findings down the crash branch, which SKIPs and prints
+        # PASSED -- releasing exactly the most serious violations.
+        # The trailing `|| PRINCIPLES_EXIT=$?` captures the exit status without
+        # letting a non-zero return abort the hook under `set -e`. pre-commit itself
+        # runs with only `set -o pipefail` (no `set -e`, pinned by
+        # scripts/__tests__/gate-5-runner-error.test.ts AC-454-08), but this module is
+        # also sourced by consumer hooks that may set it, and a bare call followed by
+        # `PRINCIPLES_EXIT=$?` never reaches the assignment under `set -e`. `|| true`
+        # would erase the status -- which is exactly the distinction this gate depends
+        # on.
+        PRINCIPLES_EXIT=0
+        # Keep stderr: it carries the checker's configuration warnings -- a rejected
+        # threshold or an out-of-vocabulary severity says so here and nowhere else.
+        # Sending it to /dev/null made an exit-2 SKIP undiagnosable and hid every
+        # .principlesrc typo (Delphi walkthrough MC-03). Captured to a file so a clean
+        # run stays quiet, then replayed only when the checker had a problem.
+        #
+        # `cd || exit 2`: a base we cannot enter means the checker never ran, which is
+        # this module's tool-failure code. Falling through would return the exit status
+        # of the failed cd (1), and 1 asserts "I examined files and found errors" -- an
+        # empty report at 1 reads as a clean pass.
+        #
+        # The report is a PER-INVOCATION mktemp, not a shared `/tmp/principles-output.json`:
+        # two commits racing on one machine (two worktrees, a hook and a CI job) overwrote
+        # each other's report before it was counted, so a run with ERROR findings could
+        # read a clean report and PASS (#457). PRINCIPLES_JSON is exported so a caller can
+        # point a harness at the same file.
+        PRINCIPLES_STDERR=$(mktemp)
+        PRINCIPLES_JSON=$(mktemp)
+        export PRINCIPLES_JSON
+        ( cd "$PRINCIPLES_BASE" 2>/dev/null || exit 2
+          run_tsx "$PRINCIPLES_DIR/index.ts" --files ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"} --format json ) > "$PRINCIPLES_JSON" 2>"$PRINCIPLES_STDERR" || PRINCIPLES_EXIT=$?
+
+        if [ -s "$PRINCIPLES_STDERR" ]; then
+          sed 's/^/     /' "$PRINCIPLES_STDERR"
+        fi
+        rm -f "$PRINCIPLES_STDERR"
+
+        if [ "$PRINCIPLES_EXIT" -ge 2 ]; then
+          echo "⚠️  Warning: Principles checker execution failed"
+          echo "⏭️  SKIPPED - Principles check (execution issue)"
+          GATE_4_STATUS="SKIP"
+          rm -f "$PRINCIPLES_JSON"
+        else
+          # Check severity levels. The reporter emits JSON.stringify(out, null, 2),
+          # i.e. `"severity": "warning"` WITH a space; tolerate any whitespace so a
+          # future minified format cannot silently zero these counts again (#444).
+          ERROR_COUNT=$(grep -cE '"severity"[[:space:]]*:[[:space:]]*"error"' "$PRINCIPLES_JSON" 2>/dev/null || true)
           ERROR_COUNT=${ERROR_COUNT:-0}
-          WARNING_COUNT=$(grep -c '"severity":"warning"' /tmp/principles-output.json 2>/dev/null || true)
+          WARNING_COUNT=$(grep -cE '"severity"[[:space:]]*:[[:space:]]*"warning"' "$PRINCIPLES_JSON" 2>/dev/null || true)
           WARNING_COUNT=${WARNING_COUNT:-0}
+          rm -f "$PRINCIPLES_JSON"
           
           if [ "$ERROR_COUNT" -gt 0 ]; then
             echo ""
@@ -47,7 +139,8 @@ else
             echo "  - error-handling violations"
             echo "  - SOLID principle violations"
             echo "  - architectural violations"
-            npx tsx $PRINCIPLES_DIR/index.ts --files $PRINCIPLES_FILES --format console
+            ( cd "$PRINCIPLES_BASE" 2>/dev/null || exit 2
+              run_tsx "$PRINCIPLES_DIR/index.ts" --files ${PRINCIPLES_ARGS[@]+"${PRINCIPLES_ARGS[@]}"} --format console )
             GATE_4_STATUS="FAIL"
             exit 1
           fi
@@ -57,14 +150,10 @@ else
           if [ "$WARNING_COUNT" -gt 0 ]; then
             echo "ℹ️  $WARNING_COUNT warnings found (will be handled by Boy Scout Rule)."
           fi
-        else
-          echo "⚠️  Warning: Principles checker execution failed"
-          echo "⏭️  SKIPPED - Principles check (execution issue)"
-          GATE_4_STATUS="SKIP"
         fi
       else
-        echo "ℹ️  npx not available - skipping principles check"
-        echo "⏭️  SKIPPED - Principles check (no Node.js/npx)"
+        echo "ℹ️  npx/tsx not available - skipping principles check"
+        echo "⏭️  SKIPPED - Principles check (no Node.js/tsx)"
         GATE_4_STATUS="SKIP"
       fi
     else