@boyingliu01/xp-gate 0.14.30 → 0.15.0

package/scripts/__tests__/sync-package-content.test.js

@@ -377,34 +377,35 @@ describe('sync-package-content subprocess invocation', () => {
     'to-issues',
   ];
 
-  function cleanupPackageDirectories() {
-    // Clean up if they exist
-    ['skills', 'plugins', 'adapters'].forEach(dir => {
-      const fullPath = path.join(PKG_ROOT, dir);
-      if (fs.existsSync(fullPath)) {
-        fs.rmSync(fullPath, { recursive: true, force: true });
-      }
+  /**
+   * afterAll: Ensure package directories are restored after all tests.
+   * Prevents race condition where other test files (e.g. doctor.test.js)
+   * read from src/npm-package/adapters/ while sync tests temporarily delete it.
+   */
+  afterAll(() => {
+    const syncScript = path.join(WORKTREE_PATH, 'src', 'npm-package', 'scripts', 'sync-package-content.js');
+    spawnSync(process.execPath, [syncScript], {
+      cwd: WORKTREE_PATH,
+      stdio: 'pipe',
     });
-  }
-
-  function restorePackageDirectories() {
-    // Restore from backup if they existed before test
-    // Since we just tested them being empty, just ensure they exist after sync
-  }
+  });
 
   it('sync-package-content.js copies skills from repo to package', () => {
     const syncScript = path.join(WORKTREE_PATH, 'src', 'npm-package', 'scripts', 'sync-package-content.js');
     const nodeExe = process.execPath;
 
-    // Ensure skills directory is empty first
-    cleanupPackageDirectories();
-
-    // Run sync as subprocess
+    // Run sync as subprocess (overwrites existing files — no need to delete first)
     const result = spawnSync(nodeExe, [syncScript], {
       cwd: WORKTREE_PATH,
       stdio: 'pipe',
+      timeout: 15000,
     });
 
+    if (result.status !== 0) {
+      console.error('sync stderr:', result.stderr?.toString() || '(empty)');
+      console.error('sync stdout:', result.stdout?.toString() || '(empty)');
+    }
+
     expect(result.status).toBe(0, 'sync script should exit with status 0');
 
     // Verify skills were copied from repo to package
@@ -432,8 +433,14 @@ describe('sync-package-content subprocess invocation', () => {
     const result = spawnSync(nodeExe, [syncScript], {
       cwd: WORKTREE_PATH,
       stdio: 'pipe',
+      timeout: 15000,
     });
 
+    if (result.status !== 0) {
+      console.error('sync stderr:', result.stderr?.toString() || '(empty)');
+      console.error('sync stdout:', result.stdout?.toString() || '(empty)');
+    }
+
     expect(result.status).toBe(0, 'sync script should exit with status 0');
 
     // Verify plugin manifests were copied
@@ -454,8 +461,14 @@ describe('sync-package-content subprocess invocation', () => {
     const result = spawnSync(nodeExe, [syncScript], {
       cwd: WORKTREE_PATH,
       stdio: 'pipe',
+      timeout: 15000,
     });
 
+    if (result.status !== 0) {
+      console.error('sync stderr:', result.stderr?.toString() || '(empty)');
+      console.error('sync stdout:', result.stdout?.toString() || '(empty)');
+    }
+
     expect(result.status).toBe(0, 'sync script should exit with status 0');
 
     // Verify adapters directory exists and has files
@@ -480,8 +493,14 @@ describe('sync-package-content subprocess invocation', () => {
     const result = spawnSync(nodeExe, [syncScript], {
       cwd: WORKTREE_PATH,
       stdio: 'pipe',
+      timeout: 15000,
     });
 
+    if (result.status !== 0) {
+      console.error('sync stderr:', result.stderr?.toString() || '(empty)');
+      console.error('sync stdout:', result.stdout?.toString() || '(empty)');
+    }
+
     expect(result.status).toBe(0, 'sync script should exit with status 0');
 
     // Verify package.json dependencies remained empty

package/scripts/sync-package-content.js

@@ -64,7 +64,7 @@ function copyDir(src, dest) {
 
 function syncSkills() {
   const destRoot = path.join(PKG_ROOT, 'skills');
-  rmrf(destRoot);
+  // In-place copy (no rmrf) to avoid race condition with parallel test readers.
   fs.mkdirSync(destRoot, { recursive: true });
   let copied = 0;
   for (const name of CORE_SKILLS) {
@@ -80,7 +80,7 @@ function syncSkills() {
 
 function injectCanonicalSkills(pluginDest) {
   const skillsDest = path.join(pluginDest, 'skills');
-  rmrf(skillsDest);
+  // In-place copy (no rmrf) to avoid race condition with parallel test readers.
   fs.mkdirSync(skillsDest, { recursive: true });
   for (const name of CORE_SKILLS) {
     const src = path.join(REPO_ROOT, 'skills', name);
@@ -97,7 +97,7 @@ function injectCanonicalSkills(pluginDest) {
 
 function syncPlugins() {
   const destRoot = path.join(PKG_ROOT, 'plugins');
-  rmrf(destRoot);
+  // In-place copy (no rmrf) to avoid race condition with parallel test readers.
   fs.mkdirSync(destRoot, { recursive: true });
   let copied = 0;
   for (const name of PLUGINS) {
@@ -139,7 +139,8 @@ function syncAdapters() {
     console.error(`[sync] SKIP adapters (missing): ${srcRoot}`);
     return 0;
   }
-  rmrf(destRoot);
+  // In-place copy (no rmrf) to avoid race condition where parallel tests
+  // (e.g. doctor.test.js) read from destRoot during the delete-recreate window.
   fs.mkdirSync(destRoot, { recursive: true });
   const entries = fs.readdirSync(srcRoot, { withFileTypes: true });
   let copied = 0;

package/skills/delphi-review/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/DELPHI-REVIEW KNOWLEDGE BASE
 
-**Generated:** 2026-07-22
-**Commit:** a465b02
+**Generated:** 2026-07-23
+**Commit:** 1d581aa
 **Branch:** main
-**Version:** 0.14.30.0
+**Version:** 0.15.0.0
 
 ## OVERVIEW
 Delphi Consensus Review — multi-round anonymous expert review (≥90% threshold, 3 experts from ≥2 providers, domestic models only). Supports design + code-walkthrough modes.

package/skills/sprint-flow/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/SPRINT-FLOW KNOWLEDGE BASE
 
-**Generated:** 2026-07-22
-**Commit:** a465b02
+**Generated:** 2026-07-23
+**Commit:** 1d581aa
 **Branch:** main
-**Version:** 0.14.30.0
+**Version:** 0.15.0.0
 
 ## OVERVIEW
 **6-phase** development pipeline (v2.0 compact redesign, Issue #290): PREP → DESIGN → BUILD → VERIFY → SHIP → CLOSE. Phase 3/6 BUILD default build mode is **ralph-loop** (REQ-level iteration, 40-67% token savings vs parallel). HARD-GATE between DESIGN (2/6) and BUILD (3/6): design must pass Delphi review (≥90% consensus) before any coding.

package/skills/sprint-flow/SKILL.md

@@ -269,6 +269,7 @@ next_phase_context: [key info for next phase]
 | Clean up CLOSE without backing up sprint-state first | `.sprint-state/` is inside worktree; it's lost on worktree removal. CLOSE step 1 MUST back up to repo-tracked path first |
 | Keep adding random changes after verification failures | Max 3 fix cycles; if still failing, BLOCK and request user decision |
 | Enter next phase without generating Phase Summary | Every phase MUST write `.sprint-state/phase-outputs/phase-{N}-summary.md` and pass transition gate |
+| Complete implementation change without running verification | After every file edit/refactor/feature, MUST run `npm test` + `npm run lint` + `npx tsc --noEmit` and record the structured verification event (see `phase-3-build.md` §In-Session Verification) |
 
 ---
 

package/skills/sprint-flow/references/phase-3-build.md

@@ -144,6 +144,77 @@ This enforcement is instructional (LLM follows SKILL.md instructions), not progr
 
 ---
 
+## In-Session Verification (MANDATORY — v0.14.31+)
+
+**Purpose**: Ensure every implementation change is immediately verified and recorded, enabling Better Loop Harness (and other observability tools) to capture normalized change→validation event pairs.
+
+**Problem it solves**: Without explicit in-session verification, Agents may edit files and move on without running tests or linters. This creates unverified changes that are invisible to post-hoc review tools, breaking the traceability chain between "what changed" and "was it validated".
+
+### Mandatory Verification Protocol
+
+After **every** implementation change (file edit, refactor, new feature, bug fix), the Agent MUST execute the following sequence BEFORE claiming the change is complete:
+
+1. **Run tests**: `npm test` or `npx vitest run` (or project-specific test command)
+2. **Run linter**: `npm run lint` or `npx eslint .` (or project-specific lint command)
+3. **Type-check** (TypeScript projects): `npx tsc --noEmit`
+4. **Record the result**: Append a structured verification event (see format below)
+
+### Verification Event Format
+
+Each verification event MUST be recorded as a structured JSON object. Agents should output this to stdout or append to `.sprint-state/phase-outputs/verification-events.jsonl`:
+
+```json
+{
+  "timestamp": "2026-07-22T10:30:00Z",
+  "change": {
+    "type": "edit|refactor|feature|bugfix",
+    "files": ["src/lib/auth.ts", "src/lib/auth.test.ts"],
+    "description": "Implement validateToken() for expired token handling"
+  },
+  "verification": {
+    "tests": { "command": "npx vitest run src/lib/auth.test.ts", "status": "pass|fail", "summary": "4 passed, 0 failed" },
+    "lint": { "command": "npm run lint", "status": "pass|fail|warn", "summary": "0 errors, 2 warnings" },
+    "typecheck": { "command": "npx tsc --noEmit", "status": "pass|fail|skip", "summary": "No type errors" }
+  },
+  "outcome": "verified|failed|partial",
+  "req": "REQ-003"
+}
+```
+
+### Integration with ralph-loop
+
+When using ralph-loop mode (default BUILD strategy), each REQ iteration MUST include verification as the final step before marking the REQ complete:
+
+```
+ralph-loop iteration:
+  1. [TDD-RED] Write failing test
+  2. [TDD-GREEN] Implement minimal code to pass
+  3. [TDD-REFACTOR] Clean up while keeping tests green
+  4. [VERIFY] Run tests + lint + typecheck ← MANDATORY
+  5. [RECORD] Append verification event ← MANDATORY
+  6. Mark REQ complete and continue to next
+```
+
+### Anti-Patterns
+
+| ❌ Error | ✅ Correct |
+|----------|----------|
+| Edit file → claim done → move to next task | Edit file → run tests + lint → record result → claim done |
+| "Tests should pass" (assertion without evidence) | "Tests passed: 4 passed, 0 failed (npx vitest run)" |
+| Run tests only at end of entire BUILD phase | Run tests after every individual change/REQ |
+| Skip type-check because "I didn't touch types" | Always run `tsc --noEmit` on TypeScript projects |
+
+### Harness Integration
+
+Better Loop Harness captures change and verification events by inspecting session history. The structured verification events above serve as the canonical signal that:
+- A change occurred (the `change` field)
+- The change was validated (the `verification` field)
+- The outcome is attributable (the `outcome` field ties result to specific change)
+
+Without these events, the Harness can only infer changes from file diffs and has no verification signal, resulting in lower "改动验证" (Change Verification) dimension scores.
+
+---
+
 ## TDD 强制执行
 
 ### Gate 5a-BLOCK: 新增文件测试强制

package/skills/test-specification-alignment/AGENTS.md

@@ -1,9 +1,9 @@
 # SKILLS/TEST-SPECIFICATION-ALIGNMENT KNOWLEDGE BASE
 
-**Generated:** 2026-07-22
-**Commit:** a465b02
+**Generated:** 2026-07-23
+**Commit:** 1d581aa
 **Branch:** main
-**Version:** 0.14.30.0
+**Version:** 0.15.0.0
 
 ## OVERVIEW
 Test-Specification Alignment Engine — two-stage validation ensuring tests accurately reflect requirements and design specs.