@boyingliu01/xp-gate 0.12.10 → 0.12.12

package/adapters/typescript.sh

@@ -3,25 +3,102 @@
 # TypeScript adapter for quality gates
 
 run_static_analysis() {
-  if command -v npx >/dev/null 2>&1; then
-    echo "Running TypeScript static analysis..."
-    npx tsc --noEmit
-    return $?
-  else
+  if ! command -v npx >/dev/null 2>&1; then
     echo "npx not available, skipping TypeScript static analysis"
     return 0
   fi
+
+  local HAS_ERRORS=0
+  local TSC_VERSION
+
+  echo "Running TypeScript static analysis..."
+  npx tsc --noEmit
+  TSC_EXIT=$?
+  if [ $TSC_EXIT -ne 0 ]; then
+    HAS_ERRORS=1
+  fi
+
+  # Also check test files if tsconfig.json exists (see Issue #293).
+  # Many projects exclude __tests__/ from tsconfig.json, so test file type
+  # errors silently accumulate. We detect this and run a second tsc pass.
+  local HAS_TESTS=false
+  if [ -d "src/__tests__" ] || [ -d "src/tests" ] || [ -d "tests" ] || [ -d "__tests__" ]; then
+    HAS_TESTS=true
+  fi
+
+  if [ "$HAS_TESTS" = true ] && [ -f "tsconfig.json" ]; then
+    # Check if tsconfig.json already includes test files
+    if npx tsc --noEmit --listFiles 2>/dev/null | grep -qE '__tests__/|\.test\.ts|\.spec\.ts'; then
+      : # Test files already checked — no additional pass needed
+    elif [ -f "tsconfig.tests.json" ]; then
+      echo "Checking test files with tsconfig.tests.json..."
+      npx tsc --noEmit --project tsconfig.tests.json
+      TSC_TEST_EXIT=$?
+      if [ $TSC_TEST_EXIT -ne 0 ]; then
+        HAS_ERRORS=1
+      fi
+    else
+      # Generate a temp tsconfig that includes test files for the additional pass
+      local TSC_TEST_EXIT=0
+      echo "Checking test files for type errors (generating temp tsconfig)..."
+      npx tsc --noEmit 2>/dev/null
+      # Create temp tsconfig extending the original but with test files included
+      local TEMP_TSCONFIG=".tsconfig.withtests.json"
+      if [ ! -f "$TEMP_TSCONFIG" ]; then
+        node -e "
+          const cfg = JSON.parse(require('fs').readFileSync('tsconfig.json','utf8'));
+          delete cfg.exclude;
+          cfg.include = cfg.include || ['src/**/*'];
+          cfg.include.push('src/**/__tests__/**','src/**/*.test.ts','src/**/*.spec.ts');
+          require('fs').writeFileSync('$TEMP_TSCONFIG', JSON.stringify(cfg, null, 2));
+        " 2>/dev/null
+        npx tsc --noEmit --project "$TEMP_TSCONFIG"
+        TSC_TEST_EXIT=$?
+        rm -f "$TEMP_TSCONFIG"
+      fi
+      if [ $TSC_TEST_EXIT -ne 0 ]; then
+        echo ""
+        echo "❌ BLOCKED - TYPE ERRORS in test files"
+        echo "Your project's tsconfig.json excludes test files from type checking."
+        echo "Fix the type errors above or add a tsconfig.tests.json to customise test file checking."
+        HAS_ERRORS=1
+      fi
+    fi
+  fi
+
+  return $HAS_ERRORS
 }
 
 run_lint() {
-  if command -v npx >/dev/null 2>&1; then
-    echo "Running TypeScript linting..."
-    npx eslint . --ext .ts,.tsx
-    return $?
-  else
+  if ! command -v npx >/dev/null 2>&1; then
     echo "npx not available, skipping TypeScript linting"
     return 0
   fi
+
+  # Prefer Biome if biome.json/biome.jsonc exists (covers lint + format in one pass)
+  if [ -f "biome.json" ] || [ -f "biome.jsonc" ]; then
+    echo "Running Biome linting..."
+    npx biome check . --no-errors-on-unmatched 2>&1 | head -50
+    local EXIT_CODE=$?
+    if [ $EXIT_CODE -ne 0 ]; then
+      echo ""
+      echo "❌ Biome check failed"
+      echo "Run 'npx biome check --write .' to auto-fix."
+      return $EXIT_CODE
+    fi
+    echo "✅ PASSED - Biome check."
+    return 0
+  fi
+
+  # Fall back to ESLint if no Biome config exists
+  if [ -f ".eslintrc.json" ] || [ -f ".eslintrc.js" ] || [ -f ".eslintrc.cjs" ] || [ -f "eslint.config.js" ]; then
+    echo "Running ESLint linting..."
+    npx eslint . --ext .ts,.tsx
+    return $?
+  fi
+
+  echo "ℹ️  No linter config found (biome.json or eslint config). Skipping lint."
+  return 0
 }
 
 run_tests() {

package/gate-3.sh

@@ -30,7 +30,7 @@ else
   if [ -n "$LIZARD_CMD" ]; then
     LIZARD_PATH=$(eval echo "$LIZARD_CMD")
     
-    # Get changed source files for complexity check
+    # Get changed source files for complexity check (includes test files)
     CC_FILES=$(echo "$CHANGED_FILES" | grep -E '\.(ts|tsx|js|jsx|py|go|java|swift|cpp|c|hpp|h|m|mm|kt)$' || true)
     
     if [ -n "$CC_FILES" ]; then

package/hooks/adapter-common.sh

@@ -192,26 +192,21 @@ detect_iac_project() {
 
 # Stryker 9.x config files (new format, takes priority)
 detect_mutation_testable() {
-  if [ -f "stryker.config.mjs" ] || [ -f "stryker.config.js" ] || \
-     [ -f "stryker.config.cjs" ] || [ -f "stryker.config.json" ]; then
-    if [ -f "package.json" ] && grep -qE '"@stryker-mutator[^"]*"' package.json 2>/dev/null; then
-      return 0
-    fi
-    if command -v npx >/dev/null 2>&1 && npx --no-install stryker --version >/dev/null 2>&1; then
-      return 0
-    fi
+  # Check if @stryker-mutator/core is installed — no config file required.
+  # The StrykerRunner passes --mutate via CLI flags, so stryker can run
+  # without any config file present.
+  if [ -f "package.json" ] && grep -qE '"@stryker-mutator[^"]*"' package.json 2>/dev/null; then
+    return 0
   fi
-
-  # Legacy Stryker config files (backwards compatibility)
-  if [ -f "stryker.conf.json" ] || [ -f "stryker.prepush.conf.json" ]; then
-    if [ -f "package.json" ] && grep -qE '"@stryker-mutator[^"]*"' package.json 2>/dev/null; then
-      return 0
-    fi
-    if command -v npx >/dev/null 2>&1 && npx --no-install stryker --version >/dev/null 2>&1; then
-      return 0
-    fi
+  if command -v npx >/dev/null 2>&1 && npx --no-install stryker --version >/dev/null 2>&1; then
+    return 0
+  fi
+  # Legacy config files (backwards compatibility — deprecated)
+  if [ -f "stryker.conf.json" ] || [ -f "stryker.prepush.conf.json" ] || \
+     [ -f "stryker.config.mjs" ] || [ -f "stryker.config.js" ] || \
+     [ -f "stryker.config.cjs" ] || [ -f "stryker.config.json" ]; then
+    return 0
   fi
-
   return 1
 }
 # Detect if a Python project has mutmut installed and configured

package/hooks/pre-commit

@@ -608,6 +608,44 @@ if [ "$PROJECT_LANG" = "documentation-only" ]; then
           exit 1
         fi
         echo "✅ PASSED - TypeScript static analysis."
+        
+        # Also check test files if they exist (Issue #293)
+        # Many projects exclude __tests__/ from tsconfig.json, so test file type
+        # errors silently accumulate.
+        if [ -d "src/__tests__" ] || [ -d "src/tests" ] || [ -d "tests" ] || [ -d "__tests__" ]; then
+          HAS_TESTS_IN_TSC=false
+          if npx tsc --noEmit --skipLibCheck --listFiles 2>/dev/null | grep -qE '__tests__/|\.test\.ts|\.spec\.ts'; then
+            HAS_TESTS_IN_TSC=true
+          fi
+          if [ "$HAS_TESTS_IN_TSC" = false ]; then
+            TSC_TEST_EXIT=0
+            if [ -f "tsconfig.tests.json" ]; then
+              echo "Checking test files with tsconfig.tests.json..."
+              npx tsc --noEmit --project tsconfig.tests.json 2>&1 | head -30
+              TSC_TEST_EXIT=$?
+            else
+              echo "Checking test files for type errors..."
+              TEMP_TSCONFIG=".tsconfig.withtests.json"
+              node -e "
+                const cfg = JSON.parse(require('fs').readFileSync('tsconfig.json','utf8'));
+                delete cfg.exclude;
+                cfg.include = cfg.include || ['src/**/*'];
+                cfg.include.push('src/**/__tests__/**','src/**/*.test.ts','src/**/*.spec.ts');
+                require('fs').writeFileSync('$TEMP_TSCONFIG', JSON.stringify(cfg, null, 2));
+              " 2>/dev/null
+              npx tsc --noEmit --project "$TEMP_TSCONFIG" --skipLibCheck 2>&1 | head -30
+              TSC_TEST_EXIT=$?
+              rm -f "$TEMP_TSCONFIG"
+            fi
+            if [ $TSC_TEST_EXIT -ne 0 ]; then
+              echo ""
+              echo "❌ BLOCKED - TYPE ERRORS in test files"
+              echo "Your project's tsconfig.json excludes test files from type checking."
+              echo "Add a tsconfig.tests.json to customise test file checking."
+              exit 1
+            fi
+          fi
+        fi
       else
         echo "ℹ️  SKIP - tsconfig.json not found (no TypeScript project config)"
       fi
@@ -679,8 +717,20 @@ if [ "$PROJECT_LANG" = "documentation-only" ]; then
       fi
     fi
 
-    # ── Biome config detection ──
-    if ! [ -f "biome.json" ] && ! [ -f "biome.jsonc" ]; then
+    # ── Biome lint/format check ──
+    if [ -f "biome.json" ] || [ -f "biome.jsonc" ]; then
+      echo "Running Biome lint/format check..."
+      if ! npx biome check --staged . 2>/dev/null; then
+        npx biome check . 2>&1 | head -50
+        echo ""
+        echo "❌ BLOCKED - Biome check failed"
+        echo "Fix the errors above before committing."
+        echo "Tip: Run 'npx biome check --write .' to auto-fix formatting and safe lint issues."
+        echo "     Run 'npx biome check --write --unsafe .' to also fix unsafe lint issues."
+        exit 1
+      fi
+      echo "✅ PASSED - Biome check."
+    else
       if [ -f "package.json" ] && command -v node &> /dev/null; then
         HAS_BIOME=$(node -e "try{const p=JSON.parse(require('fs').readFileSync('package.json','utf8'));const d=p.devDependencies||{};const deps=p.dependencies||{};console.log((d['@biomejs/biome']||deps['@biomejs/biome'])?'yes':'no')}catch{console.log('no')}") && true
         if [ "$HAS_BIOME" = "yes" ]; then
@@ -1221,13 +1271,6 @@ else
         fi
       done
 
-      if [ "$TEST_FOUND" = false ] && [ "$ext" = "py" ]; then
-        module_name="${filename//-/_}"
-        if grep -rq "import $module_name\|from $module_name import" tests/ 2>/dev/null; then
-          TEST_FOUND=true
-        fi
-      fi
-
       if [ "$TEST_FOUND" = false ]; then
         echo "⚠️  TEST PAIRING WARNING: Source file without corresponding test: $src_file"
         echo "   Expected patterns for .${ext}: ${patterns[0]}, ${patterns[1]:-...}"
@@ -1299,28 +1342,117 @@ else
     done
   fi
 
-  # Run tests + coverage in a single pass (optimization: avoids running vitest twice)
-  # For TypeScript with test:coverage script, use coverage-enabled run directly.
-  # For other languages, fall back to the adapter's run_tests + run_coverage pair.
+  # ============================================================================
+  # Smart test selection (Issue #286): only run tests affected by changed files.
+  # Reuses CHANGED_TEST_FILES already computed in Gate 5b (line 1244).
+  # Full run fallback: >20 changed test files, or vitest not found.
+  # ============================================================================
   echo "Running tests..."
   
   # Route to appropriate test runner via adapter
   ADAPTER_FILE=$(resolve_adapter_path "$PROJECT_LANG")
   if [ "${PROJECT_LANG}" != "unknown" ] && [ -n "$ADAPTER_FILE" ]; then
     if source "$ADAPTER_FILE" 2>/dev/null; then
-      # TypeScript: single vitest run --coverage (combines tests + coverage)
+      # TypeScript: vitest with smart test selection
       if [ "$PROJECT_LANG" = "typescript" ] && [ -f "package.json" ]; then
         if npx vitest --version >/dev/null 2>&1; then
-          echo "Running TypeScript tests with coverage..."
-          TESTS_OUTPUT=$(npx vitest run --coverage 2>&1)
-          TESTS_EXIT_CODE=$?
-          echo "$TESTS_OUTPUT" | head -60
-          if [ "$TESTS_EXIT_CODE" -ne 0 ]; then
-            echo ""
-            echo "❌ BLOCKED - Tests FAILED"
-            exit 1
+          # Count changed test files to decide strategy
+          CHANGED_TEST_FILE_COUNT=$(echo "$CHANGED_TEST_FILES" | grep -c '.' || echo "0")
+          
+          # Also get changed source files (non-test) for related-test lookup
+          CHANGED_SRC_FILES=$(git diff --cached --name-only --diff-filter=ACM | grep -E '\.(ts|tsx|js|jsx)$' | grep -v '\.test\.' | grep -v '\.spec\.' | grep -v '__tests__' | grep -v '\.d\.ts$' | grep -v '__snapshots__' || true)
+          CHANGED_SRC_COUNT=$(echo "$CHANGED_SRC_FILES" | grep -c '.' || echo "0")
+          
+          # Decide strategy
+          if [ "$CHANGED_TEST_FILE_COUNT" -gt 20 ] 2>/dev/null; then
+            # Too many test files changed → full run
+            echo "Too many test files changed ($CHANGED_TEST_FILE_COUNT), running full test suite..."
+            TESTS_OUTPUT=$(npx vitest run --coverage 2>&1)
+            TESTS_EXIT_CODE=$?
+            echo "$TESTS_OUTPUT" | head -60
+            if [ "$TESTS_EXIT_CODE" -ne 0 ]; then
+              echo ""
+              echo "❌ BLOCKED - Tests FAILED"
+              exit 1
+            else
+              echo "✅ PASSED - Full test suite passed (with coverage)."
+            fi
+          elif [ "$CHANGED_TEST_FILE_COUNT" -gt 0 ] 2>/dev/null; then
+            # Run only changed test files with coverage
+            SMART_TARGETS=$(echo "$CHANGED_TEST_FILES" | tr '\n' ' ')
+            echo "Running ${CHANGED_TEST_FILE_COUNT} changed test file(s) with coverage..."
+            echo "   Target(s): $(echo "$CHANGED_TEST_FILES" | tr '\n' ' ')"
+            TESTS_OUTPUT=$(npx vitest run --coverage $SMART_TARGETS 2>&1)
+            TESTS_EXIT_CODE=$?
+            echo "$TESTS_OUTPUT" | head -60
+            if [ "$TESTS_EXIT_CODE" -ne 0 ]; then
+              echo ""
+              echo "❌ BLOCKED - Tests FAILED in changed test files"
+              exit 1
+            else
+              echo "✅ PASSED - Changed test files passed (with coverage)."
+            fi
+          elif [ "$CHANGED_SRC_COUNT" -gt 0 ] 2>/dev/null; then
+            # Source files changed but no test files → find related tests or run full
+            echo "Source file(s) changed, finding related tests..."
+            RELATED_TESTS=""
+            for src_file in $CHANGED_SRC_FILES; do
+              base="${src_file%.*}"
+              filename="${base##*/}"
+              dir="$(dirname "$src_file")"
+              ext="${src_file##*.}"
+              # Try common test file patterns
+              for pattern in \
+                "${base}.test.${ext}" \
+                "${base}.spec.${ext}" \
+                "${dir}/__tests__/${filename}.test.${ext}" \
+                "${dir}/__tests__/${filename}.spec.${ext}" \
+                "tests/${filename}.test.${ext}" \
+                "tests/${filename}.spec.${ext}"; do
+                if [ -f "$pattern" ]; then
+                  RELATED_TESTS="${RELATED_TESTS}${pattern} "
+                fi
+              done
+              # Glob fallback for __tests__ dir patterns
+              if [ -d "${dir}/__tests__" ]; then
+                found_glob=$(find "${dir}/__tests__" -maxdepth 1 -name "${filename}.test.*" -o -name "${filename}.spec.*" 2>/dev/null | tr '\n' ' ')
+                if [ -n "$found_glob" ]; then
+                  for f in $found_glob; do
+                    case " $RELATED_TESTS " in *" $f "*) ;; *) RELATED_TESTS="${RELATED_TESTS}${f} " ;; esac
+                  done
+                fi
+              fi
+            done
+            if [ -n "$RELATED_TESTS" ]; then
+              echo "   Found related test(s): $(echo "$RELATED_TESTS" | tr '\n' ' ')"
+              TESTS_OUTPUT=$(npx vitest run --coverage $RELATED_TESTS 2>&1)
+              TESTS_EXIT_CODE=$?
+              echo "$TESTS_OUTPUT" | head -60
+              if [ "$TESTS_EXIT_CODE" -ne 0 ]; then
+                echo ""
+                echo "❌ BLOCKED - Tests FAILED in related test files"
+                exit 1
+              else
+                echo "✅ PASSED - Related test files passed (with coverage)."
+              fi
+            else
+              # No related tests found → full run is safest
+              echo "   No related test files found, running full test suite..."
+              TESTS_OUTPUT=$(npx vitest run --coverage 2>&1)
+              TESTS_EXIT_CODE=$?
+              echo "$TESTS_OUTPUT" | head -60
+              if [ "$TESTS_EXIT_CODE" -ne 0 ]; then
+                echo ""
+                echo "❌ BLOCKED - Tests FAILED"
+                exit 1
+              else
+                echo "✅ PASSED - Full test suite passed (with coverage)."
+              fi
+            fi
           else
-            echo "✅ PASSED - Unit tests passed (with coverage)."
+            # No test files AND no source files changed → skip
+            echo "✅ PASSED - No test or source files changed, skipping test run."
+            TESTS_EXIT_CODE=0
           fi
         else
           # Fallback: run_tests without coverage
@@ -1360,11 +1492,18 @@ else
     if source "$ADAPTER_FILE" 2>/dev/null; then
       case "$PROJECT_LANG" in
         "typescript")
-          # Coverage already collected in the test section above (optimized single vitest run --coverage).
-          # The --coverage flag produces coverage/coverage-summary.json which the unconditional
-          # stage-2 enforcement reads. No need to run vitest again here.
-          echo "TypeScript coverage already collected during test run."
-          COV_EXIT=0
+          # Coverage collected during the test section above.
+          # Smart selection (Issue #286): only runs changed/related tests with --coverage,
+          # producing coverage/coverage-summary.json for the tested subset.
+          # Stage 2 enforcement reads global coverage from the subset run.
+          # If no tests were run (TESTS_EXIT_CODE=0 skip path), warn instead of blocking.
+          if [ -f "coverage/coverage-summary.json" ]; then
+            echo "TypeScript coverage collected during test run."
+            COV_EXIT=0
+          else
+            echo "ℹ️  No coverage data produced — test run was skipped (no TS changes)."
+            COV_EXIT=0
+          fi
           ;;
         "python")
           if command -v pytest &> /dev/null && command -v coverage &> /dev/null; then