@boxxy/closeout 0.2.3 → 0.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@boxxy/closeout",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "boxxy's phase kinds: the input, the close-out parser and the settle rule of triage, design, build and review",
   "homepage": "https://github.com/zgeoff/boxxy/tree/main/modules/closeout#readme",
   "bugs": "https://github.com/zgeoff/boxxy/issues",
@@ -30,14 +30,14 @@
     "typecheck": "tsrs --noEmit"
   },
   "dependencies": {
-    "@boxxy/model": "0.2.3",
+    "@boxxy/model": "0.2.4",
     "tiny-invariant": "1.3.3",
     "ts-pattern": "5.9.2",
     "zod": "4.6.7"
   },
   "devDependencies": {
-    "@boxxy/planning": "0.2.3",
-    "@boxxy/rules": "0.2.3",
+    "@boxxy/planning": "0.2.4",
+    "@boxxy/rules": "0.2.4",
     "@faker-js/faker": "10.6.0"
   },
   "peerDependencies": {

package/src/phases/build.ts

@@ -1,4 +1,5 @@
 import type {
+  AttemptRow,
   BuildCloseOut,
   BuildInput,
   CloseOutContext,
@@ -15,6 +16,8 @@ import {
   definePhase,
   storedReviewCloseOutSchema,
   toJSONValue,
+  verifyCloseOutSchema,
+  verifyInputSchema,
 } from '@boxxy/model';
 import { match } from 'ts-pattern';
 import type { z } from 'zod';
@@ -64,21 +67,43 @@ function buildBuildInput(ctx: PhaseInputContext): BuildInput {
   return {
     acceptance: buildCriterionTexts(ctx.item),
     design: findLatestDesign(ctx.history),
-    sentBack: findReviewSentBack(ctx),
+    sentBack: findSentBack(ctx.history),
     pullRequest: findPullRequestLink(ctx.pullRequests),
   };
 }
 
-// Only a latest review that asked for changes sends the build its findings: a build after a
-// passed review, sent back by the owner, gets none.
-function findReviewSentBack(ctx: PhaseInputContext): SentBack | null {
-  const reading = findLatestCloseOut(ctx.history, 'review', storedReviewCloseOutSchema)?.reading;
+// The latest grading of the work decides the send-back: a review that asked for changes sends
+// its findings, and a failed verify sends its features. A build after a passed review or a
+// verified verify, sent back by the owner, gets none.
+function findSentBack(history: readonly AttemptRow[]): SentBack | null {
+  const graded = history.findLast(
+    (row) => (row.phase === 'review' || row.phase === 'verify') && row.state === 'succeeded',
+  );
+
+  if (graded?.phase === 'verify') {
+    return findVerifySentBack(graded);
+  }
+
+  const reading = findLatestCloseOut(history, 'review', storedReviewCloseOutSchema)?.reading;
 
   return reading?.status === 'blocked' && reading.why === 'open-findings'
     ? { from: 'review', head: reading.head, open: reading.open, answerHint: reading.answerHint }
     : null;
 }
 
+function findVerifySentBack(verify: AttemptRow): SentBack | null {
+  const closeOut = verifyCloseOutSchema.safeParse(verify.closeOut);
+  const input = verifyInputSchema.safeParse(verify.input);
+
+  return closeOut.success && closeOut.data.result.kind === 'failed'
+    ? {
+        from: 'verify',
+        head: input.success ? input.data.head : null,
+        features: closeOut.data.result.features,
+      }
+    : null;
+}
+
 function collectBuildProblems(closeOut: BuildCloseOut, ctx: CloseOutContext): CloseOutProblem[] {
   const acceptance = new Set(ctx.item.acceptance.map((criterion) => criterion.id));
   const own = new Set(ctx.evidence.map((row) => row.factId));