@botlearn-course/daemon 0.0.20-beta.1 → 0.0.20-beta.2

package/dist/workspace-snapshot-staging.js

@@ -1,6 +1,7 @@
 import { createHash, randomUUID } from "node:crypto";
-import { chmodSync, closeSync, constants, fstatSync, fsyncSync, lstatSync, mkdirSync, openSync, readdirSync, readSync, realpathSync, rmSync, writeSync, } from "node:fs";
+import { chmodSync, closeSync, constants, existsSync, fstatSync, fsyncSync, lstatSync, mkdirSync, openSync, readdirSync, readSync, realpathSync, rmSync, writeSync, } from "node:fs";
 import path from "node:path";
+import { isWorkspaceQuiescenceProof, } from "./runtime-quiescence.js";
 import { defaultCaseFold, validateWorkspaceEntrySet, WORKSPACE_ENTRY_SET_SCHEMA, } from "./workspace-entry-set.js";
 const UUID = /^[0-9a-f]{8}-[0-9a-f]{4}-[1-8][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i;
 const EXCLUDED_NAMES = new Set(["node_modules"]);
@@ -107,30 +108,52 @@ function fsyncDirectory(directory) {
         closeSync(handle);
     }
 }
+function descriptorPath(handle, fallback) {
+    if (existsSync("/proc/self/fd")) {
+        const value = path.join("/proc/self/fd", String(handle));
+        if (!existsSync(value))
+            fail("workspace_snapshot_fd_traversal_unavailable");
+        return value;
+    }
+    // Darwin has no procfs open-file path that supports relative child lookup. It is used
+    // only by local tests/BYOA; managed durable sandboxes are Linux and fail closed above.
+    return fallback;
+}
 function stageOnce(options, paths) {
     const stagingDirectory = path.join(paths.checkpointRoot, randomUUID());
     mkdirSync(stagingDirectory, { mode: 0o700 });
     chmodSync(stagingDirectory, 0o700);
     try {
-        const rootStats = lstatSync(paths.workspace, { bigint: true });
-        if (!rootStats.isDirectory())
+        const rootHandle = openSync(paths.workspace, constants.O_RDONLY | constants.O_DIRECTORY | constants.O_NOFOLLOW);
+        const rootStats = fstatSync(rootHandle, { bigint: true });
+        if (!rootStats.isDirectory()) {
+            closeSync(rootHandle);
             fail("workspace_snapshot_root_invalid");
+        }
         const entries = [];
         const files = [];
         let fileCount = 0;
         let totalBytes = 0;
-        function walk(sourceDirectory, destinationDirectory, segments) {
-            const directoryBefore = lstatSync(sourceDirectory, { bigint: true });
+        let estimatedEntrySetBytes = Buffer.byteLength('{"schemaVersion":"agent-workspace-entry-set/1","entries":[]}', "utf8");
+        function appendEntry(entry) {
+            estimatedEntrySetBytes += Buffer.byteLength(JSON.stringify(entry), "utf8") + 1;
+            if (estimatedEntrySetBytes > options.limits.maxEntrySetBytes) {
+                fail("workspace_snapshot_limit_exceeded");
+            }
+            entries.push(entry);
+        }
+        function walk(sourceHandle, sourceFallback, destinationDirectory, segments) {
+            const directoryBefore = fstatSync(sourceHandle, { bigint: true });
             assertSourceNode(directoryBefore, {
                 rootDevice: rootStats.dev,
                 expected: "directory",
             });
+            const sourceDirectory = descriptorPath(sourceHandle, sourceFallback);
             const children = readdirSync(sourceDirectory, {
-                withFileTypes: true,
                 encoding: "buffer",
-            }).sort((left, right) => Buffer.compare(left.name, right.name));
+            }).sort((left, right) => Buffer.compare(left, right));
             for (const child of children) {
-                const name = decodeName(child.name);
+                const name = decodeName(child);
                 if (excludedName(name))
                     continue;
                 const relativeSegments = [...segments, name];
@@ -145,13 +168,21 @@ function stageOnce(options, paths) {
                     fail("workspace_snapshot_unsupported_file_type");
                 if (stats.isDirectory()) {
                     assertSourceNode(stats, { rootDevice: rootStats.dev, expected: "directory" });
+                    const childHandle = openSync(source, constants.O_RDONLY | constants.O_DIRECTORY | constants.O_NOFOLLOW);
+                    const openedDirectory = fstatSync(childHandle, { bigint: true });
+                    if (!sameIdentity(stats, openedDirectory)) {
+                        closeSync(childHandle);
+                        fail("workspace_snapshot_source_changed", true);
+                    }
                     mkdirSync(destination, { mode: 0o700 });
                     chmodSync(destination, 0o700);
-                    entries.push({ type: "directory", path: relativePath, mode: "0700" });
-                    if (entries.length > options.limits.maxEntrySetBytes) {
-                        fail("workspace_snapshot_limit_exceeded");
+                    appendEntry({ type: "directory", path: relativePath, mode: "0700" });
+                    try {
+                        walk(childHandle, source, destination, relativeSegments);
+                    }
+                    finally {
+                        closeSync(childHandle);
                     }
-                    walk(source, destination, relativeSegments);
                     continue;
                 }
                 const copied = copyStableFile(source, destination, {
@@ -163,7 +194,7 @@ function stageOnce(options, paths) {
                 if (fileCount > options.limits.maxFileCount ||
                     totalBytes > options.limits.maxTotalBytes)
                     fail("workspace_snapshot_limit_exceeded");
-                entries.push({
+                appendEntry({
                     type: "file",
                     path: relativePath,
                     mode: copied.mode,
@@ -176,17 +207,19 @@ function stageOnce(options, paths) {
                     sizeBytes: copied.sizeBytes,
                     sha256: copied.sha256,
                 });
-                if (entries.length > options.limits.maxEntrySetBytes) {
-                    fail("workspace_snapshot_limit_exceeded");
-                }
             }
-            const directoryAfter = lstatSync(sourceDirectory, { bigint: true });
+            const directoryAfter = fstatSync(sourceHandle, { bigint: true });
             if (!sameIdentity(directoryBefore, directoryAfter)) {
                 fail("workspace_snapshot_source_changed", true);
             }
             fsyncDirectory(destinationDirectory);
         }
-        walk(paths.workspace, stagingDirectory, []);
+        try {
+            walk(rootHandle, paths.workspace, stagingDirectory, []);
+        }
+        finally {
+            closeSync(rootHandle);
+        }
         entries.sort((left, right) => Buffer.compare(Buffer.from(left.path, "utf8"), Buffer.from(right.path, "utf8")));
         files.sort((left, right) => Buffer.compare(Buffer.from(left.path, "utf8"), Buffer.from(right.path, "utf8")));
         const entrySet = validateWorkspaceEntrySet({ schemaVersion: WORKSPACE_ENTRY_SET_SCHEMA, entries }, options.limits);
@@ -200,7 +233,8 @@ function stageOnce(options, paths) {
 export function stageWorkspaceSnapshot(options) {
     if (!UUID.test(options.checkpointId))
         fail("workspace_snapshot_checkpoint_invalid");
-    if (options.quiescenceProof.proofVersion !== "workspace-quiescence-proof/1" ||
+    if (!isWorkspaceQuiescenceProof(options.quiescenceProof) ||
+        options.quiescenceProof.proofVersion !== "workspace-quiescence-proof/1" ||
         !UUID.test(options.quiescenceProof.sandboxId) ||
         !UUID.test(options.quiescenceProof.runtimeSessionId) ||
         options.quiescenceProof.checkpointId !== options.checkpointId ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botlearn-course/daemon",
-  "version": "0.0.20-beta.1",
+  "version": "0.0.20-beta.2",
   "description": "Lightweight BotLearn Course daemon: run course tasks on your own machine with your own agent runtime (BYOA).",
   "type": "module",
   "bin": {