@botcord/daemon 0.2.44 → 0.2.45

package/dist/gateway/runtimes/openclaw-acp.js

@@ -280,6 +280,13 @@ export class OpenclawAcpAdapter {
             if (capped) {
                 log.warn("openclaw-acp.assistant-text-capped", { sessionId: acpSessionId });
             }
+            if (!finalText) {
+                const stopReason = pickStopReason(promptResult);
+                const warningTail = handle.nonJsonStdoutTail.slice(-8).join("\n").trim();
+                const detail = warningTail ? `; stdout: ${truncateDetail(warningTail, 1000)}` : "";
+                const reason = stopReason ? `prompt stopped: ${stopReason}` : "empty assistant response";
+                return failResult(acpSessionId, `openclaw-acp: ${reason}${detail}`);
+            }
             return {
                 text: finalText,
                 newSessionId: acpSessionId,
@@ -359,6 +366,7 @@ export class OpenclawAcpAdapter {
             subscribers: new Map(),
             nextId: 1,
             buffer: "",
+            nonJsonStdoutTail: [],
             initialized: false,
             inFlight: 0,
             closed: false,
@@ -431,6 +439,10 @@ function onStdoutChunk(handle, chunk) {
             msg = JSON.parse(line);
         }
         catch (err) {
+            handle.nonJsonStdoutTail.push(line.slice(0, 500));
+            if (handle.nonJsonStdoutTail.length > 20) {
+                handle.nonJsonStdoutTail.splice(0, handle.nonJsonStdoutTail.length - 20);
+            }
             log.warn("openclaw-acp.parse-error", {
                 error: err instanceof Error ? err.message : String(err),
                 line: line.slice(0, 200),
@@ -744,6 +756,15 @@ function pickFinalText(result) {
         return r.message;
     return undefined;
 }
+function pickStopReason(result) {
+    if (!result || typeof result !== "object")
+        return undefined;
+    const v = result.stopReason;
+    return typeof v === "string" && v.length > 0 ? v : undefined;
+}
+function truncateDetail(text, max) {
+    return text.length <= max ? text : `${text.slice(0, max)}…`;
+}
 function looksLikeReasoningLeak(text) {
     const t = text.trim();
     if (!t)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botcord/daemon",
-  "version": "0.2.44",
+  "version": "0.2.45",
   "description": "BotCord local daemon — bridges Hub inbox push to local Claude Code / Codex / Gemini CLIs",
   "type": "module",
   "bin": {

package/src/__tests__/openclaw-acp.test.ts

@@ -162,6 +162,46 @@ describe("OpenclawAcpAdapter.run", () => {
     expect(spawnFn.mock.calls[0][1]).toEqual(["acp", "--url", "ws://127.0.0.1:1"]);
   });
 
+  it("returns an error instead of empty text when OpenClaw emits warnings and no assistant text", async () => {
+    const child = new FakeChild();
+    const adapter = new OpenclawAcpAdapter({ spawnFn: makeSpawn(child) });
+    const gateway: ResolvedOpenclawGateway = {
+      name: "local",
+      url: "ws://127.0.0.1:1",
+      openclawAgent: "main",
+    };
+
+    child.stdin.on("data", (chunk: Buffer) => {
+      for (const line of chunk.toString("utf8").split("\n").filter(Boolean)) {
+        const frame = JSON.parse(line);
+        if (frame.method === "initialize") {
+          child.stdout.write("◇  Config warnings ─────────────────────╮\n");
+          child.stdout.write("│  - models.providers.foo.apiKey: Missing env var FOO_API_KEY │\n");
+          child.stdout.write(JSON.stringify({ jsonrpc: "2.0", id: frame.id, result: { protocolVersion: 1 } }) + "\n");
+        } else if (frame.method === "session/new") {
+          child.stdout.write(JSON.stringify({ jsonrpc: "2.0", id: frame.id, result: { sessionId: "sid-warn" } }) + "\n");
+        } else if (frame.method === "session/prompt") {
+          child.stdout.write(JSON.stringify({ jsonrpc: "2.0", id: frame.id, result: { stopReason: "error" } }) + "\n");
+        }
+      }
+    });
+
+    const res = await adapter.run({
+      text: "hi",
+      sessionId: null,
+      cwd: "/tmp",
+      accountId: "ag_alice",
+      signal: new AbortController().signal,
+      trustLevel: "owner",
+      gateway,
+    });
+
+    expect(res.text).toBe("");
+    expect(res.newSessionId).toBe("sid-warn");
+    expect(res.error).toContain("prompt stopped: error");
+    expect(res.error).toContain("Missing env var FOO_API_KEY");
+  });
+
   it("streams only final text when OpenClaw sends reasoning before a final block", async () => {
     const child = new FakeChild();
     const adapter = new OpenclawAcpAdapter({ spawnFn: makeSpawn(child) });

package/src/gateway/runtimes/openclaw-acp.ts

@@ -37,6 +37,7 @@ interface AcpProcessHandle {
   subscribers: Map<string, (note: AcpNotification) => void>;
   nextId: number;
   buffer: string;
+  nonJsonStdoutTail: string[];
   initialized: boolean;
   initializePromise?: Promise<void>;
   idleTimer?: NodeJS.Timeout;
@@ -355,6 +356,14 @@ export class OpenclawAcpAdapter implements RuntimeAdapter {
         log.warn("openclaw-acp.assistant-text-capped", { sessionId: acpSessionId });
       }
 
+      if (!finalText) {
+        const stopReason = pickStopReason(promptResult);
+        const warningTail = handle.nonJsonStdoutTail.slice(-8).join("\n").trim();
+        const detail = warningTail ? `; stdout: ${truncateDetail(warningTail, 1000)}` : "";
+        const reason = stopReason ? `prompt stopped: ${stopReason}` : "empty assistant response";
+        return failResult(acpSessionId, `openclaw-acp: ${reason}${detail}`);
+      }
+
       return {
         text: finalText,
         newSessionId: acpSessionId,
@@ -447,6 +456,7 @@ export class OpenclawAcpAdapter implements RuntimeAdapter {
       subscribers: new Map(),
       nextId: 1,
       buffer: "",
+      nonJsonStdoutTail: [],
       initialized: false,
       inFlight: 0,
       closed: false,
@@ -533,6 +543,10 @@ function onStdoutChunk(handle: AcpProcessHandle, chunk: string): void {
     try {
       msg = JSON.parse(line);
     } catch (err) {
+      handle.nonJsonStdoutTail.push(line.slice(0, 500));
+      if (handle.nonJsonStdoutTail.length > 20) {
+        handle.nonJsonStdoutTail.splice(0, handle.nonJsonStdoutTail.length - 20);
+      }
       log.warn("openclaw-acp.parse-error", {
         error: err instanceof Error ? err.message : String(err),
         line: line.slice(0, 200),
@@ -847,6 +861,16 @@ function pickFinalText(result: unknown): string | undefined {
   return undefined;
 }
 
+function pickStopReason(result: unknown): string | undefined {
+  if (!result || typeof result !== "object") return undefined;
+  const v = (result as Record<string, unknown>).stopReason;
+  return typeof v === "string" && v.length > 0 ? v : undefined;
+}
+
+function truncateDetail(text: string, max: number): string {
+  return text.length <= max ? text : `${text.slice(0, max)}…`;
+}
+
 function looksLikeReasoningLeak(text: string): boolean {
   const t = text.trim();
   if (!t) return false;