@botbuddy/cli 1.9.0 → 1.9.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "description": "BotBuddy — Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/botbuddy-release-repair.json

@@ -0,0 +1 @@
+{"schema_version":1,"source_version":"1.9.0","source_identity":"70b96a360d9dd5bd637dc6378a4cae6542cb0a508990f28d26c842946e6fb694"}

package/src/test-lane.mjs

@@ -26,12 +26,19 @@ import { callToolJson } from "./api.mjs";
 export const EXIT_TEST = Object.freeze({ ...EXIT, TIMEOUT: 2 });
 export const WAITS_URL = "https://app.bot-buddy.ai/waits";
 const KNOWN_RUNNERS = new Set(["playwright", "generic"]);
+// BOT-1549: mirror of the DB enum public.test_lane_kind (BOT-1547) and
+// supabase/functions/_shared/test-adapters.ts LANE_KINDS. A lane declares its
+// kind in .botbuddy/lanes.json; an unknown value (config or --lane-kind) is a
+// hard, named failure — never a guessed default (gate 9).
+export const LANE_KINDS = Object.freeze(["smoke", "regression", "diagnostics", "e2e", "unit", "integration", "other"]);
+const LANE_KIND_SET = new Set(LANE_KINDS);
 
 export function parseTestArgs(argv, { env = process.env } = {}) {
   const opts = {
     sessionId: env.BOTBUDDY_SESSION_ID ?? null,
     environment: "local",
     ticket: null, pr: null, repo: null,
+    laneKind: null,
     wait: false, json: false,
   };
   const errors = [];
@@ -49,6 +56,7 @@ export function parseTestArgs(argv, { env = process.env } = {}) {
       case "--ticket": opts.ticket = value(flag, i); i++; break;
       case "--pr": { const raw = value(flag, i); i++; opts.pr = raw == null ? null : Number(raw); if (raw != null && !Number.isInteger(opts.pr)) errors.push("--pr must be an integer"); break; }
       case "--repo": opts.repo = value(flag, i); i++; break;
+      case "--lane-kind": opts.laneKind = value(flag, i); i++; break;
       case "--wait": opts.wait = true; break;
       case "--json": opts.json = true; break;
       default:
@@ -88,7 +96,12 @@ export function resolveLane(laneName, { cwd = process.cwd(), readFileImpl = read
   const lane = lanes[laneName];
   if (!Array.isArray(lane.command) || lane.command.length === 0) return { ok: false, error: "invalid", path, root, detail: `lane "${laneName}" has no command` };
   if (!KNOWN_RUNNERS.has(lane.runner)) return { ok: false, error: "invalid", path, root, detail: `lane "${laneName}" runner must be playwright|generic` };
-  return { ok: true, appSlug: config.app_slug ?? null, lane, path, root };
+  // BOT-1549: an optional per-lane `kind` must be a known lane_kind — a bad
+  // value is rejected here, never coerced or defaulted (gate 9).
+  if (lane.kind != null && !LANE_KIND_SET.has(lane.kind)) {
+    return { ok: false, error: "invalid", path, root, detail: `lane "${laneName}" lane_kind must be one of ${LANE_KINDS.join("|")} (got "${lane.kind}")` };
+  }
+  return { ok: true, appSlug: config.app_slug ?? null, lane, laneKind: lane.kind ?? null, path, root };
 }
 
 // Best-effort git/gh context. Every field falls back to null — never fabricated
@@ -151,8 +164,18 @@ export async function launchTestLane(argv, {
     if (resolved.error === "missing") process.stderr.write(`botbuddy test: no lane config — create ${resolved.path}\n`);
     else if (resolved.error === "unknown") process.stderr.write(`botbuddy test: unknown lane "${laneName}". Available: ${resolved.available.join(", ") || "(none)"}\n`);
     else process.stderr.write(`botbuddy test: invalid lane config (${resolved.detail}) at ${resolved.path}\n`);
-    return { exitCode: EXIT_TEST.INVALID, line: JSON.stringify({ outcome: "rejected", error: resolved.error, path: resolved.path }) };
+    return { exitCode: EXIT_TEST.INVALID, line: JSON.stringify({ outcome: "rejected", error: resolved.error, path: resolved.path, detail: resolved.detail }) };
+  }
+
+  // BOT-1549: resolve the effective lane kind — a --lane-kind flag overrides
+  // the lane's config kind for this run. An invalid flag value is rejected
+  // before any run is created (gate 9), mirroring the config-side check.
+  if (opts.laneKind != null && !LANE_KIND_SET.has(opts.laneKind)) {
+    const detail = `invalid lane_kind: --lane-kind must be one of ${LANE_KINDS.join("|")} (got "${opts.laneKind}")`;
+    process.stderr.write(`botbuddy test: ${detail}\n`);
+    return { exitCode: EXIT_TEST.INVALID, line: JSON.stringify({ outcome: "rejected", error: "invalid", detail }) };
   }
+  const laneKind = opts.laneKind ?? resolved.laneKind ?? null;
 
   const git = gitInfo({ cwd, ticket: opts.ticket, pr: opts.pr, repo: opts.repo });
   const sha7 = (git.sha ?? "").slice(0, 7) || "nosha";
@@ -167,6 +190,8 @@ export async function launchTestLane(argv, {
     commit_sha: git.sha ?? undefined, branch_name: git.branch ?? undefined,
     pr_number: git.prNumber ?? undefined, pr_url: git.prUrl ?? undefined,
     source_kind: "cli-lane", source_id: laneRunId,
+    // BOT-1549: stamp the resolved lane kind on the run; absent ⇒ omitted (NULL).
+    lane_kind: laneKind ?? undefined,
   };
   const created = await call("create_test_run", createArgs);
   const testRunId = created?.ok && !created.isError ? created.data?.id ?? null : null;
@@ -183,6 +208,15 @@ export async function launchTestLane(argv, {
 
   // Step 3: launch the lane under the durable worker, telemetry env in the child.
   const childEnv = { BOTBUDDY_LANE: laneName };
+  // BOT-1549: carry the lane kind to the child so uploaded executions
+  // (test-ingest / playwright-upload) can stamp lane_kind too. ALWAYS set the
+  // key: runWorker spawns the child with `{ ...process.env, ...child_env }`
+  // (run.mjs), so a bare `if (laneKind)` would let a stale BOTBUDDY_LANE_KIND
+  // already in the environment leak into the child even though this run's
+  // lane_kind is NULL — making child-uploaded executions disagree with their
+  // run (Codex P2). Setting "" when there is no effective kind deterministically
+  // clears any inherited value; empty ⇒ unset by parseLaneKind's contract.
+  childEnv.BOTBUDDY_LANE_KIND = laneKind ?? "";
   if (testRunId) { childEnv.BOTBUDDY_TEST_RUN_ID = testRunId; childEnv.BOTBUDDY_TEST_RUN_EVENTS = eventsPath; }
   const testRun = testRunId
     ? { test_run_id: testRunId, events_path: eventsPath, lane: laneName, runner: resolved.lane.runner, git_sha: git.sha ?? null, branch: git.branch ?? null }
@@ -248,7 +282,7 @@ function laneList(cwd) {
 }
 
 function testHelp() {
-  console.log(`botbuddy test <lane> [--session-id <uuid>] [--environment local] [--ticket <KEY>] [--pr <n>] [--repo <owner/repo>] [--wait] [--json] [-- <extra args>]
+  console.log(`botbuddy test <lane> [--session-id <uuid>] [--environment local] [--ticket <KEY>] [--pr <n>] [--repo <owner/repo>] [--lane-kind <${LANE_KINDS.join("|")}>] [--wait] [--json] [-- <extra args>]
 botbuddy test list      List the lanes configured in .botbuddy/lanes.json
 botbuddy test help      Show this help