@botbuddy/cli 1.8.8 → 1.9.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.8.8",
+  "version": "1.9.0",
   "description": "BotBuddy — Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/wait-core.mjs

@@ -611,6 +611,63 @@ export function foldFeedLag(degraded, lagging) {
   return degraded;
 }
 
+// ---------------------------------------------------------------------------
+// BOT-1539 — arm-time outstanding-review notice.
+//
+// `pr-review` / `pr-state` are edge-triggered: they wake only on a review event
+// delivered AFTER arm. When the relay reports (via `pr_review_snapshot` on the
+// register receipt) that a PR ALREADY has an outstanding review, warn the
+// operator on stderr so a silent park isn't mistaken for "no review yet". The
+// existing review will NOT re-wake this wait.
+// ---------------------------------------------------------------------------
+
+// Compact, human relative age (e.g. "27m ago", "3h ago", "2d ago"). Returns
+// null when the timestamp is absent or unparseable, so callers can omit the
+// phrase entirely.
+function relativeAge(iso, now) {
+  if (!iso) return null;
+  const then = Date.parse(iso);
+  if (!Number.isFinite(then)) return null;
+  const secs = Math.max(0, Math.round((now - then) / 1000));
+  if (secs < 60) return `${secs}s ago`;
+  const mins = Math.round(secs / 60);
+  if (mins < 60) return `${mins}m ago`;
+  const hours = Math.round(mins / 60);
+  if (hours < 48) return `${hours}h ago`;
+  return `${Math.round(hours / 24)}d ago`;
+}
+
+/**
+ * Build one stderr warning line per OUTSTANDING pr-review snapshot entry.
+ * Clean (not-outstanding) entries and empty/absent input yield no lines.
+ *
+ * @param {Array<{repo:string,pr:number,unresolved_threads:number,review_decision:string,pr_updated_at:string|null,existing_review_outstanding:boolean}>|null|undefined} snapshot
+ * @param {number} [now] epoch ms, for deterministic age formatting
+ * @returns {string[]}
+ */
+export function formatPrReviewSnapshotWarnings(snapshot, now = Date.now()) {
+  if (!Array.isArray(snapshot)) return [];
+  const lines = [];
+  for (const e of snapshot) {
+    if (!e || e.existing_review_outstanding !== true) continue;
+    const threads = typeof e.unresolved_threads === "number" ? e.unresolved_threads : 0;
+    const parts = [`pr-review armed: ${e.repo}#${e.pr} already has a review outstanding`];
+    if (threads > 0) {
+      parts.push(`${threads} unresolved review thread${threads === 1 ? "" : "s"}`);
+    }
+    if (e.review_decision && e.review_decision !== "unknown") {
+      parts.push(`review_decision=${e.review_decision}`);
+    }
+    const age = relativeAge(e.pr_updated_at, now);
+    if (age) parts.push(`last update ${age}`);
+    lines.push(
+      `${parts.join(" · ")}. This wait fires only on the NEXT review event; ` +
+      `the existing review will not re-wake it.`,
+    );
+  }
+  return lines;
+}
+
 // ---------------------------------------------------------------------------
 // Matching — does a spine signal frame satisfy a condition?
 // ---------------------------------------------------------------------------

package/src/wait.mjs

@@ -13,7 +13,7 @@
 // Usage:  botbuddy wait [--any] <condition>... [options]
 // Run     botbuddy wait --help for the condition grammar.
 
-import { EXIT, parseConditions, parseSseFrames, runWaitLoop, normalizeSince, truncateReceipt } from "./wait-core.mjs";
+import { EXIT, parseConditions, parseSseFrames, runWaitLoop, normalizeSince, truncateReceipt, formatPrReviewSnapshotWarnings } from "./wait-core.mjs";
 import { resolveAgentProfile, withPrincipalReceipt } from "./wait-profile.mjs";
 import { VERSION } from "./version.mjs";
 import { fileURLToPath } from "node:url";
@@ -52,7 +52,12 @@ CONDITIONS  (TYPE:key=val,key=val — repeat for several; --any wakes on the fir
                                       flip sets payload.mergeable_changed (no new condition).
   pr-review:repo=<owner/repo>[,pr=<n>]
                                       a new review comment, or a thread resolved/re-opened
-                                      (payload carries the unresolved-thread count)
+                                      (payload carries the unresolved-thread count).
+                                      Edge-triggered: it wakes only on review activity AFTER
+                                      arm. If the PR ALREADY has an outstanding review at arm,
+                                      bb-wait prints a one-line stderr notice (unresolved count,
+                                      review_decision, age) so a silent park isn't mistaken for
+                                      "no review yet" — the existing review will not re-wake it.
   test-run:id=<run_id>                a test run reaching a terminal status (owner-scoped)
   lease:id=<lease_id>                 a batch stack lease (BOT-1218) leaving the queue /
                                       becoming active — the zero-poll wake for a parked
@@ -334,6 +339,10 @@ async function registerWait(opts, conditions, deadlineIso) {
     // echoes session_agent_id only when it overrode the profile agent).
     sessionId: body.session_id ?? null,
     sessionAgentId: body.session_agent_id ?? null,
+    // BOT-1539: arm-time snapshot of already-outstanding code review for any
+    // pr-review/pr-state target. Report-only — surfaced on stderr so a silent
+    // edge-triggered park isn't mistaken for "no review yet".
+    prReviewSnapshot: Array.isArray(body.pr_review_snapshot) ? body.pr_review_snapshot : null,
   };
 }
 
@@ -618,6 +627,12 @@ export async function runWait(argv) {
       registeredAgentId = reg.agentId;
       registeredSessionAgentId = reg.sessionAgentId;
       registeredSessionId = reg.sessionId;
+      // BOT-1539: if any pr-review/pr-state target already has an outstanding
+      // review, tell the operator now (stderr, one line per PR). Purely
+      // informational — it does not change arming or exit semantics.
+      for (const line of formatPrReviewSnapshotWarnings(reg.prReviewSnapshot)) {
+        process.stderr.write(`bb-wait: ${line}\n`);
+      }
       // BOT-1184: adopt the server's canonical host for each lock condition so the
       // local matcher builds the same subject_key the availability/claim-grant
       // signals carry (armed under an alias like 'jono-mac', the signal uses the

package/src/botbuddy-release-repair.json

@@ -1 +0,0 @@
-{"schema_version":1,"source_version":"1.8.7","source_identity":"e6b611000678281287808866482334e5a40e265ef3c0328c4e85f53a5bf23cd0"}