@botbuddy/cli 1.63.32 → 1.63.33

package/daemon-release/darwin-arm64.json

@@ -1,7 +1,7 @@
 {
-  "release_version": "1.63.32",
-  "source_commit": "91ea9b88abe8effa478b5dcf15d42e1898afc3e9",
-  "source_sha256": "a7741aa15134ea47f319a63a32ee1d40cf993636e693e679d77534d257f31aa7",
+  "release_version": "1.63.33",
+  "source_commit": "70dd5a394a7180acebe24941d884cec93eb5f1cc",
+  "source_sha256": "16eed9e08035023447c0c964ce608a2a7324a24fdbe21df4de3085fda26f3bfc",
   "target": "darwin-arm64",
-  "sha256": "8f3782ebb257b5676259ae478fe76ae54903e86d9343898cf48c26496ad6e64f"
+  "sha256": "41ea9976bf224497e18148142d93ae53b231e16d814ee0f7d406cc82d5a6d39f"
 }

package/daemon-release/linux-x64.json

@@ -1,7 +1,7 @@
 {
-  "release_version": "1.63.32",
-  "source_commit": "91ea9b88abe8effa478b5dcf15d42e1898afc3e9",
-  "source_sha256": "a7741aa15134ea47f319a63a32ee1d40cf993636e693e679d77534d257f31aa7",
+  "release_version": "1.63.33",
+  "source_commit": "70dd5a394a7180acebe24941d884cec93eb5f1cc",
+  "source_sha256": "16eed9e08035023447c0c964ce608a2a7324a24fdbe21df4de3085fda26f3bfc",
   "target": "linux-x64",
-  "sha256": "404616db3ad3184c701b3330a23b23f3a2636ca5858dbb4e5bdcea93775c6ca3"
+  "sha256": "94e4da81775defe0589d339d1eac3f6885ee529ec4df71aa35809cb6d498c5b3"
 }

package/daemon-release/manifest.json

@@ -1,21 +1,21 @@
 {
   "schema_version": 1,
-  "release_version": "1.63.32",
-  "source_commit": "91ea9b88abe8effa478b5dcf15d42e1898afc3e9",
-  "source_sha256": "a7741aa15134ea47f319a63a32ee1d40cf993636e693e679d77534d257f31aa7",
+  "release_version": "1.63.33",
+  "source_commit": "70dd5a394a7180acebe24941d884cec93eb5f1cc",
+  "source_sha256": "16eed9e08035023447c0c964ce608a2a7324a24fdbe21df4de3085fda26f3bfc",
   "targets": {
     "darwin-arm64": {
       "goos": "darwin",
       "goarch": "arm64",
       "binary": "daemon/bin/darwin-arm64/botbuddy-daemon",
-      "sha256": "8f3782ebb257b5676259ae478fe76ae54903e86d9343898cf48c26496ad6e64f",
+      "sha256": "41ea9976bf224497e18148142d93ae53b231e16d814ee0f7d406cc82d5a6d39f",
       "mode": "0755"
     },
     "linux-x64": {
       "goos": "linux",
       "goarch": "amd64",
       "binary": "daemon/bin/linux-x64/botbuddy-daemon",
-      "sha256": "404616db3ad3184c701b3330a23b23f3a2636ca5858dbb4e5bdcea93775c6ca3",
+      "sha256": "94e4da81775defe0589d339d1eac3f6885ee529ec4df71aa35809cb6d498c5b3",
       "mode": "0755"
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.63.32",
+  "version": "1.63.33",
   "description": "BotBuddy \u2014 Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/update-check.mjs

@@ -13,6 +13,7 @@
 // off to a detached, unref'd `npm install -g` and exits 0.
 
 import { mkdir, readFile, writeFile } from "node:fs/promises";
+import { readFileSync } from "node:fs";
 import { spawn, spawnSync } from "node:child_process";
 import { homedir } from "node:os";
 import { dirname, join } from "node:path";
@@ -22,7 +23,11 @@ import { VERSION } from "./version.mjs";
 export const UPDATE_CHECK_INTERVAL_MS = 24 * 60 * 60 * 1000;
 export const NPM_LATEST_URL = "https://registry.npmjs.org/@botbuddy/cli/latest";
 export const NPM_LATEST_TIMEOUT_MS = 1500;
-export const UPDATE_COMMAND = "npm i -g @botbuddy/cli@latest";
+export const UPDATE_COMMAND = "npm install -g @botbuddy/cli@latest";
+
+export function formatUpdateOffer(current, latest) {
+  return `\nUpdate available\n  Current: v${current}\n  Latest:  v${latest}\n  Run:     bb update\n`;
+}
 
 export function defaultUpdateCheckCachePath(home = homedir()) {
   return join(home, ".botbuddy", "update-check.json");
@@ -106,16 +111,26 @@ export async function maybeWarnStale({
       await writeCache(cachePath, { checkedAt: now(), latest });
     }
     if (typeof latest !== "string" || !isNewerVersion(latest, version)) return { warned: false, latest: latest ?? null };
-    stderr.write(`botbuddy: update available ${version} → ${latest}: ${UPDATE_COMMAND}\n`);
+    stderr.write(formatUpdateOffer(version, latest));
     return { warned: true, latest };
   } catch {
     return { warned: false, latest: null };
   }
 }
 
-// `botbuddy update` — hand off to npm and get out of the way.
-export function cmdUpdate({ version = VERSION, spawnImpl = spawn, probeImpl = spawnSync, log = (line) => console.log(line), platform = process.platform, stderr = process.stderr } = {}) {
-  log(`current: ${version}`);
+export function readInstalledVersion({ npmBin = "npm", shellOpt = {}, probeImpl = spawnSync, readPackage = readFileSync } = {}) {
+  const root = probeImpl(npmBin, ["root", "-g"], { encoding: "utf8", ...shellOpt });
+  if (root?.error || root?.status !== 0) throw new Error(`npm global root lookup failed for ${npmBin}`);
+  const directory = String(root?.stdout ?? "").trim();
+  if (!directory) throw new Error("npm global root lookup returned no directory");
+  const packageJson = JSON.parse(readPackage(join(directory, "@botbuddy", "cli", "package.json"), "utf8"));
+  if (typeof packageJson?.version !== "string" || !parseSemver(packageJson.version)) throw new Error("installed @botbuddy/cli package has no valid version");
+  return packageJson.version;
+}
+
+// `botbuddy update` waits for npm because the terminal result, rather than the
+// child-process launch, is the only trustworthy confirmation an update worked.
+export function cmdUpdate({ version = VERSION, spawnImpl = spawn, probeImpl = spawnSync, readInstalledVersion: installedVersion = readInstalledVersion, log = (line) => console.log(line), platform = process.platform, stderr = process.stderr } = {}) {
   // BOT-1566 (Codex P1/P2): on Windows npm is the `npm.cmd` shim, and Node
   // cannot spawn a .cmd file shell-free (docs) — run it through a shell on
   // win32 (args are all static constants, so no injection surface) and select
@@ -134,34 +149,44 @@ export function cmdUpdate({ version = VERSION, spawnImpl = spawn, probeImpl = sp
     try { stderr.write(`botbuddy update: npm was not found — install Node.js/npm, then retry (looked for ${npmBin})\n`); } catch { /* ignore */ }
     return Promise.resolve(1);
   }
+  log(`BotBuddy CLI update\n  Current: v${version}\n\n$ ${UPDATE_COMMAND}`);
   const child = spawnImpl(npmBin, ["install", "-g", "@botbuddy/cli@latest"], {
     stdio: "inherit",
-    detached: true,
     ...shellOpt,
   });
-  // Node reports a launch failure asynchronously via the `error` event, so we
-  // must NOT announce success until the child has actually spawned (Codex P2).
-  // Race spawn vs error: print + unref only on `spawn`, exit nonzero on `error`.
+  // Node reports a launch failure asynchronously via the `error` event. A
+  // successfully spawned child can still fail its install, so only `close: 0`
+  // plus a readable npm global package metadata record is a success.
   return new Promise((resolve) => {
     if (!child || typeof child.once !== "function") {
-      log("updating in background — re-run botbuddy --version to confirm");
-      if (child && typeof child.unref === "function") child.unref();
-      resolve(0);
+      try { stderr.write("botbuddy update: npm did not return a trackable process\n"); } catch { /* ignore */ }
+      resolve(1);
       return;
     }
     let settled = false;
-    child.once("spawn", () => {
-      if (settled) return;
-      settled = true;
-      if (typeof child.unref === "function") child.unref();
-      log("updating in background — re-run botbuddy --version to confirm");
-      resolve(0);
-    });
     child.once("error", (err) => {
       if (settled) return;
       settled = true;
       try { stderr.write(`botbuddy update: failed to launch npm (${err?.message ?? err})\n`); } catch { /* ignore */ }
       resolve(1);
     });
+    child.once("close", (code, signal) => {
+      if (settled) return;
+      settled = true;
+      if (code !== 0 || signal) {
+        const reason = signal ? `signal ${signal}` : `code ${code ?? "unknown"}`;
+        try { stderr.write(`botbuddy update: npm exited with ${reason}; no update was confirmed\n`); } catch { /* ignore */ }
+        resolve(1);
+        return;
+      }
+      try {
+        const installed = installedVersion({ npmBin, shellOpt });
+        log(`✓ Updated to v${installed}`);
+        resolve(0);
+      } catch (error) {
+        try { stderr.write(`botbuddy update: npm completed but could not verify the installed version (${error?.message ?? error})\n`); } catch { /* ignore */ }
+        resolve(1);
+      }
+    });
   });
 }