@botbuddy/cli 1.62.3 → 1.62.4

package/daemon-release/darwin-arm64.json

@@ -1,7 +1,7 @@
 {
-  "release_version": "1.62.3",
-  "source_commit": "f360d97780f33ea528695c412fe995921def79e4",
-  "source_sha256": "f51d8ebb381b6f6ed5cdcaa820cc37b4b464c87f4f83057336e7db52c57b5d26",
+  "release_version": "1.62.4",
+  "source_commit": "1cc371424a95b39915a3e882a428688bced7386a",
+  "source_sha256": "8d9dd0daf489c418b04d34b57696a6f97a9346d141f9266dda3a74e7ca87d4cf",
   "target": "darwin-arm64",
-  "sha256": "5a19b567b8faf0e956bacaab84b5106cc79809fe0330924b4af1af91ce9c90f3"
+  "sha256": "4ce65712c580403552a1d15f9dce56149dfdf48d121c634a6f5c748cb48e85fd"
 }

package/daemon-release/linux-x64.json

@@ -1,7 +1,7 @@
 {
-  "release_version": "1.62.3",
-  "source_commit": "f360d97780f33ea528695c412fe995921def79e4",
-  "source_sha256": "f51d8ebb381b6f6ed5cdcaa820cc37b4b464c87f4f83057336e7db52c57b5d26",
+  "release_version": "1.62.4",
+  "source_commit": "1cc371424a95b39915a3e882a428688bced7386a",
+  "source_sha256": "8d9dd0daf489c418b04d34b57696a6f97a9346d141f9266dda3a74e7ca87d4cf",
   "target": "linux-x64",
-  "sha256": "89be3a9a5d26a7ba8ef5c7463c174be158ca7567efc0b2b736f3dbcdd50a1a0d"
+  "sha256": "4993e29705d75254afd21fadcbef568faf8650471df1bbcd9a96a6c5d3d2a254"
 }

package/daemon-release/manifest.json

@@ -1,21 +1,21 @@
 {
   "schema_version": 1,
-  "release_version": "1.62.3",
-  "source_commit": "f360d97780f33ea528695c412fe995921def79e4",
-  "source_sha256": "f51d8ebb381b6f6ed5cdcaa820cc37b4b464c87f4f83057336e7db52c57b5d26",
+  "release_version": "1.62.4",
+  "source_commit": "1cc371424a95b39915a3e882a428688bced7386a",
+  "source_sha256": "8d9dd0daf489c418b04d34b57696a6f97a9346d141f9266dda3a74e7ca87d4cf",
   "targets": {
     "darwin-arm64": {
       "goos": "darwin",
       "goarch": "arm64",
       "binary": "daemon/bin/darwin-arm64/botbuddy-daemon",
-      "sha256": "5a19b567b8faf0e956bacaab84b5106cc79809fe0330924b4af1af91ce9c90f3",
+      "sha256": "4ce65712c580403552a1d15f9dce56149dfdf48d121c634a6f5c748cb48e85fd",
       "mode": "0755"
     },
     "linux-x64": {
       "goos": "linux",
       "goarch": "amd64",
       "binary": "daemon/bin/linux-x64/botbuddy-daemon",
-      "sha256": "89be3a9a5d26a7ba8ef5c7463c174be158ca7567efc0b2b736f3dbcdd50a1a0d",
+      "sha256": "4993e29705d75254afd21fadcbef568faf8650471df1bbcd9a96a6c5d3d2a254",
       "mode": "0755"
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.62.3",
+  "version": "1.62.4",
   "description": "BotBuddy \u2014 Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/stack-tunnel.mjs

@@ -22,7 +22,7 @@
 // Dependency-free (Node stdlib only).
 
 import { spawn, spawnSync } from "node:child_process";
-import { connect, createServer } from "node:net";
+import { connect, createServer, isIP } from "node:net";
 
 export const SSH_FORWARD_OPTIONS = Object.freeze([
   "-N", "-T",
@@ -299,7 +299,7 @@ export async function openSshForwards({
  * `GatewayPorts yes` silently binds it on every interface, exposing this machine's
  * callback service to the host's network. The CLI cannot read sshd_config, so after the
  * forward is up it asks the host which address the listener really holds and refuses
- * anything but loopback (fail closed: no lsof, no listener, unreadable → refused).
+ * anything but loopback (fail closed: no inventory, no listener, unreadable → refused).
  */
 export function verifyCallbackLoopback({ sshBin, sshTarget, port, env = process.env, run = spawnSync, label = null }) {
   const what = label ?? `the reverse forward for --callback-port ${port}`;
@@ -307,18 +307,47 @@ export function verifyCallbackLoopback({ sshBin, sshTarget, port, env = process.
     `${what} on ${sshTarget} could not be proven loopback-only (${why}). ` +
       "An sshd with GatewayPorts yes binds -R forwards on every interface; set GatewayPorts no (or clientspecified) on the host, " +
       "or run without --callback-port.", extra);
+  const checkedPort = validPort(port);
+  if (checkedPort == null) throw fail("invalid listener port");
+  // Linux lsof cannot see root-owned sshd sockets from an unprivileged login (BOT-2743).
+  // ss reads the socket table without process visibility; -p is deliberately omitted.
+  // Dispatch on the remote OS in the SAME SSH invocation, with no guessed fallback.
+  const command = `case "$(uname -s)" in Linux) printf 'bb-ss-v1\\n'; ss -H -ltn '( sport = :${checkedPort} )';; ` +
+    `Darwin) lsof -nP -iTCP:${checkedPort} -sTCP:LISTEN -Fn;; ` +
+    "*) printf 'unsupported listener inventory platform\\n' >&2; exit 69;; esac";
   // nosemgrep: javascript.lang.security.detect-child-process.detect-child-process -- fixed argv; target validated; integer port.
   const r = run(sshBin, [
     "-T", "-o", "BatchMode=yes", "-o", "ControlMaster=no", "-o", "ControlPath=none", "--", sshTarget,
-    `lsof -nP -iTCP:${Number(port)} -sTCP:LISTEN -Fn`,
+    command,
   ], { encoding: "utf8", env, timeout: 15_000 });
   if (r.error || r.status !== 0) {
     const tail = String(r.stderr || r.error?.message || "").trim().split("\n").slice(-1)[0];
     // lsof exits 1 with no output when nothing listens.
-    if (r.status === 1 && !String(r.stdout || "").trim()) throw fail(`no listener on the host's port ${port}`, { noListener: true });
-    throw fail(`could not run lsof on the host (exit ${r.status ?? "?"}${tail ? `: ${tail}` : ""})`);
+    if (!r.error && r.status === 1 && !String(r.stdout || "").trim() && !String(r.stderr || "").trim()) {
+      throw fail(`no listener on the host's port ${port}`, { noListener: true });
+    }
+    throw fail(`could not inspect host sockets with ss/lsof (exit ${r.status ?? "?"}${tail ? `: ${tail}` : ""})`);
+  }
+  const output = String(r.stdout || "");
+  let addresses;
+  if (output.startsWith("bb-ss-v1\n")) {
+    addresses = output.slice("bb-ss-v1\n".length).split("\n").filter((line) => line.trim()).map((line) => {
+      // ss -H -ltn: State Recv-Q Send-Q Local-Address:Port Peer-Address:Port.
+      // Reject the whole answer on any bad row: silently skipping a wildcard is unsafe.
+      const fields = line.trim().split(/\s+/);
+      const local = /^(.+):(\d+)$/.exec(fields[3] ?? "");
+      let address = local?.[1];
+      if (address?.startsWith("[") && address.endsWith("]")) address = address.slice(1, -1);
+      const family = isIP(address ?? "");
+      if (fields.length !== 5 || fields[0] !== "LISTEN" || !/^\d+$/.test(fields[1]) || !/^\d+$/.test(fields[2]) ||
+          !local || Number(local[2]) !== checkedPort || (!family && address !== "*")) {
+        throw fail("malformed ss listener inventory");
+      }
+      return `${family === 6 ? `[${address}]` : address}:${checkedPort}`;
+    });
+  } else {
+    addresses = output.split("\n").filter((l) => l.startsWith("n")).map((l) => l.slice(1).trim());
   }
-  const addresses = String(r.stdout || "").split("\n").filter((l) => l.startsWith("n")).map((l) => l.slice(1).trim());
   if (!addresses.length) throw fail(`no listener on the host's port ${port}`, { noListener: true });
   const exposed = addresses.filter((a) => !(a.startsWith("127.") || a.startsWith("[::1]:") || a.startsWith("localhost:")));
   if (exposed.length) throw fail(`the host listens on ${exposed.join(", ")}`, { exposed, listeners: addresses });