@botbuddy/cli 1.5.0 → 1.5.2

package/src/discovery.test.mjs

@@ -1,195 +0,0 @@
-// BOT-876: unit coverage for the CLI's generic call + discovery commands.
-
-import test from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  CallUsageError,
-  discoveryUrlFor,
-  formatDiscovery,
-  parseCallArgs,
-} from "./discovery.mjs";
-
-const SERVER = "https://api.bot-buddy.ai/functions/v1/mcp-server";
-
-// ─── parseCallArgs ──────────────────────────────────────────────
-
-test("call with no arguments yields an empty args object", () => {
-  assert.deepEqual(parseCallArgs(["list_agents"]), {
-    tool: "list_agents",
-    args: {},
-    usedJson: false,
-  });
-});
-
-test("--json supplies the whole arguments object", () => {
-  const { tool, args } = parseCallArgs([
-    "register_agent",
-    "--json",
-    '{"name":"claude-1","type":"claude"}',
-  ]);
-  assert.equal(tool, "register_agent");
-  assert.deepEqual(args, { name: "claude-1", type: "claude" });
-});
-
-test("--json accepts nested structures", () => {
-  const { args } = parseCallArgs([
-    "register_agent",
-    "--json",
-    '{"resources":[{"resource_type":"mcp_server","subtype":"playwright_lane"}]}',
-  ]);
-  assert.deepEqual(args.resources, [
-    { resource_type: "mcp_server", subtype: "playwright_lane" },
-  ]);
-});
-
-test("--key value flags build the arguments object", () => {
-  const { args } = parseCallArgs(["create_task", "--title", "Fix the thing", "--priority", "2"]);
-  assert.deepEqual(args, { title: "Fix the thing", priority: 2 });
-});
-
-test("numeric and boolean flag values are coerced off the command line", () => {
-  // A tool whose schema says `number` would reject the string "2".
-  const { args } = parseCallArgs([
-    "t",
-    "--count", "2",
-    "--ratio", "1.5",
-    "--negative", "-3",
-    "--yes", "true",
-    "--no", "false",
-    "--nothing", "null",
-  ]);
-  assert.deepEqual(args, {
-    count: 2, ratio: 1.5, negative: -3, yes: true, no: false, nothing: null,
-  });
-});
-
-test("values that only look numeric stay strings", () => {
-  const { args } = parseCallArgs([
-    "t",
-    "--ticket", "BOT-876",
-    "--version", "1.2.3",
-    "--hex", "0x10",
-    "--padded", "007",
-  ]);
-  assert.equal(args.ticket, "BOT-876");
-  assert.equal(args.version, "1.2.3");
-  assert.equal(args.hex, "0x10");
-  // "007" is unambiguously numeric; losing the padding is acceptable, but a
-  // leading-zero identifier is common enough to pin the behaviour.
-  assert.equal(args.padded, 7);
-});
-
-test("a valueless flag is a boolean true", () => {
-  const { args } = parseCallArgs(["t", "--force", "--name", "x"]);
-  assert.deepEqual(args, { force: true, name: "x" });
-});
-
-test("a trailing valueless flag is a boolean true", () => {
-  const { args } = parseCallArgs(["t", "--force"]);
-  assert.deepEqual(args, { force: true });
-});
-
-test("flags after --json override the blob", () => {
-  const { args } = parseCallArgs(["t", "--json", '{"name":"a"}', "--name", "b"]);
-  assert.equal(args.name, "b");
-});
-
-test("a missing tool name is a usage error", () => {
-  assert.throws(() => parseCallArgs([]), CallUsageError);
-  assert.throws(() => parseCallArgs(["--json", "{}"]), CallUsageError);
-});
-
-test("malformed --json is reported clearly, not swallowed", () => {
-  assert.throws(() => parseCallArgs(["t", "--json", "{not json}"]), (e) => {
-    assert.ok(e instanceof CallUsageError);
-    assert.match(e.message, /not valid JSON/);
-    return true;
-  });
-});
-
-test("--json must be an object, not an array or scalar", () => {
-  for (const bad of ["[1,2]", '"a string"', "42", "null"]) {
-    assert.throws(() => parseCallArgs(["t", "--json", bad]), CallUsageError, `accepted ${bad}`);
-  }
-});
-
-test("--json with no value is a usage error", () => {
-  assert.throws(() => parseCallArgs(["t", "--json"]), CallUsageError);
-});
-
-test("a bare positional argument is rejected rather than silently ignored", () => {
-  assert.throws(() => parseCallArgs(["t", "oops"]), (e) => {
-    assert.match(e.message, /--key value or --json/);
-    return true;
-  });
-});
-
-// ─── discoveryUrlFor ────────────────────────────────────────────
-
-test("discovery URL is derived from the server URL", () => {
-  assert.equal(discoveryUrlFor(SERVER), `${SERVER}/discovery`);
-  assert.equal(discoveryUrlFor(`${SERVER}/`), `${SERVER}/discovery`);
-});
-
-test("discovery URL encodes a requested tool", () => {
-  assert.equal(discoveryUrlFor(SERVER, "get_totp_code"), `${SERVER}/discovery?tool=get_totp_code`);
-});
-
-// ─── formatDiscovery ────────────────────────────────────────────
-
-const DOC = {
-  tools: [
-    { name: "register_agent", description: "Register an agent. Extra detail here.", inputSchema: { type: "object" } },
-    { name: "list_agents", description: "List all agents", inputSchema: { type: "object" } },
-  ],
-};
-
-test("the index lists every tool, sorted, one line each", () => {
-  const out = formatDiscovery(DOC);
-  const lines = out.split("\n").filter((l) => l.startsWith("  "));
-  assert.equal(lines.length, 2);
-  assert.match(lines[0], /list_agents/);
-  assert.match(lines[1], /register_agent/);
-  assert.match(out, /2 tools available/);
-});
-
-test("the index truncates a description to its first sentence", () => {
-  const out = formatDiscovery(DOC);
-  assert.match(out, /Register an agent\./);
-  assert.doesNotMatch(out, /Extra detail here/);
-});
-
-test("a single tool renders its full schema and an invocation example", () => {
-  const out = formatDiscovery(DOC, { tool: "register_agent" });
-  assert.match(out, /^register_agent/);
-  assert.match(out, /botbuddy call register_agent/);
-  assert.match(out, /"type": "object"/);
-  // register_agent carries no `auth` note → no Auth section.
-  assert.doesNotMatch(out, /Auth:/);
-});
-
-test("a single tool with an agent-identity note renders an Auth section", () => {
-  // BOT-971: the server stamps `auth` on discovery entries for agent-gated
-  // tools; `botbuddy help <tool>` must surface it (matching help({ tool })).
-  const doc = {
-    tools: [{
-      name: "acquire_resources",
-      description: "Batch lock",
-      inputSchema: { type: "object" },
-      auth: "Requires an agent identity — call register_agent first.",
-    }],
-  };
-  const out = formatDiscovery(doc, { tool: "acquire_resources" });
-  assert.match(out, /Auth:/);
-  assert.match(out, /register_agent/);
-});
-
-test("an unknown tool is reported, not rendered empty", () => {
-  assert.match(formatDiscovery(DOC, { tool: "nope" }), /Unknown tool: nope/);
-});
-
-test("a malformed discovery document does not throw", () => {
-  assert.equal(formatDiscovery(null), "No tools found.");
-  assert.equal(formatDiscovery({}), "No tools found.");
-});