@botbuddy/cli 1.45.1 → 1.45.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.45.1",
+  "version": "1.45.3",
   "description": "BotBuddy — Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/agent-doctor.mjs

@@ -77,6 +77,12 @@ export function repairFailureRecovery(code, error = null) {
   if (code === "client_key_unavailable") {
     return "the client key could not be read (locked or failing credential store); unlock it, then run `bb doctor --fix`";
   }
+  // BOT-1787: this is a server-side identity conflict, not an authentication
+  // failure. Preserve the real remedy so a healthy credential is never needlessly
+  // rotated; `bb setup` clears this worktree's cache and re-registers it.
+  if (code === "agent_tenant_immutable") {
+    return "this worktree's agent identity belongs to another tenant; run `bb setup` to register this tenant, then `bb doctor --fix`";
+  }
   // BOT-1750 (Codex R9 P2): `session_mint_unauthorized` means a locally-unexpired
   // client key was revoked/rejected server-side — only a fresh login replaces it, so
   // point at `bb login`, not a binding repair (the binding is valid).

package/src/api.mjs

@@ -445,7 +445,13 @@ export async function callToolJson(toolName, args = {}, { fetchImpl = fetch, sig
   }
   let payload;
   try { payload = await res.json(); } catch { return { ok: false, status: res.status, error: "invalid_json" }; }
-  if (payload.error?.message) return { ok: false, status: res.status, error: payload.error.message };
+  if (payload.error?.message) {
+    // Typed domain errors retain their verdict inside the HTTP-200 JSON-RPC
+    // envelope. Do not infer credential failure from an identity conflict.
+    const code = payload.error.data?.code;
+    return { ok: false, status: res.status, error: payload.error.message,
+      ...(typeof code === "string" && code ? { code } : {}) };
+  }
   const text = payload.result?.content?.map((c) => c.text).filter(Boolean).join("\n") ?? "";
   let data;
   try { data = text ? JSON.parse(text) : {}; } catch { data = { raw: text }; }

package/src/stack.mjs

@@ -320,7 +320,7 @@ export function parseStackArgs(argv) {
       case "--idle-ttl": {
         if (need(a, rest[i + 1])) {
           const n = Number(rest[++i]);
-          if (!Number.isFinite(n) || !Number.isInteger(n) || n <= 0) errors.push("--idle-ttl must be a positive integer number of seconds");
+          if (!Number.isFinite(n) || !Number.isInteger(n) || n < 2) errors.push("--idle-ttl must be an integer of at least 2 seconds so the one-second heartbeat can keep the lease alive");
           else opts.idleTtl = n;
         }
         break;
@@ -1766,6 +1766,20 @@ function readStackIdentity(dir, read = readFileSync) {
  * is best-effort (unreadable config ⇒ treated as isolated, since the parse+provision
  * guards already blocked a same-project subdir at `up`). Never mutates.
  */
+// BOT-1935: every local-exec lease has persisted `connection.botbuddy_docker_target`
+// since CLI 1.5.0, so a TARGETLESS lease activated on/after this instant was provisioned
+// by the Helper, not by a pre-1.5.0 client (prod 069096a4, 2026-09-29). The server names
+// the Helper as `provisioner` only when it holds the Helper's succeeded receipt; this is
+// the diagnosis for the rest. It never authorizes anything: the lease stays fenced.
+export const HELPER_ERA_ACTIVATED_AT = Date.parse("2026-09-01T00:00:00Z");
+
+export function targetlessHelperLeaseRefusal(lease, leaseId) {
+  const activatedAt = Date.parse(lease?.activated_at ?? "");
+  if (lease?.connection?.botbuddy_docker_target || !(activatedAt >= HELPER_ERA_ACTIVATED_AT)) return null;
+  return `this lease was provisioned by the Helper; release it with \`bb stack done ${leaseId}\` (no --local-exec) ` +
+    "from the owning session, or ask the operator; lease and slot remain fenced";
+}
+
 export function localExecTeardownIsNonIsolated(lease, read = readFileSync) {
   const stackPath = lease?.stack_path || ".";
   if (stackPath === ".") return true;
@@ -2580,16 +2594,20 @@ export async function cmdDone(leaseId, opts, {
       // the compatibility contract still pins them there, so keep this path OrbStack-only:
       // a Docker Desktop daemon (newly admitted by the preflight allowlist for MODERN
       // leases) must never authorize teardown of a targetless legacy OrbStack lease.
+      // BOT-1935: a targetless lease activated after the 1.5.0 era is not legacy — the
+      // Helper provisioned it (local-exec has persisted a target since 1.5.0). Same fence,
+      // same exit code; only the diagnosis names the release path that actually works.
+      const helperLeaseRefusal = targetlessHelperLeaseRefusal(current.data, leaseId);
       if (dockerTarget?.validation !== "orbstack") {
         return emitResult(buildReceipt({ command: "done", outcome: "refused", lease_id: leaseId,
-          error: `pre-1.5.0 lease has no persisted Docker target; only an OrbStack daemon may authorize legacy teardown, not ${dockerTarget?.validation || "an unverified engine"}; lease and slot remain fenced`,
+          error: helperLeaseRefusal ?? `pre-1.5.0 lease has no persisted Docker target; only an OrbStack daemon may authorize legacy teardown, not ${dockerTarget?.validation || "an unverified engine"}; lease and slot remain fenced`,
           expected_docker_target: null, observed_docker_target: dockerTarget,
         }), opts, EXIT.LEASE_FAILED);
       }
       const proof = proveLegacyTarget(current.data, dockerTarget, opts);
       if (!proof?.ok) {
         return emitResult(buildReceipt({ command: "done", outcome: "refused", lease_id: leaseId,
-          error: `pre-1.5.0 lease has no persisted Docker target and compatibility proof failed: ${proof?.error || "unknown proof failure"}; lease and slot remain fenced`,
+          error: helperLeaseRefusal ?? `pre-1.5.0 lease has no persisted Docker target and compatibility proof failed: ${proof?.error || "unknown proof failure"}; lease and slot remain fenced`,
           expected_docker_target: null, observed_docker_target: dockerTarget,
         }), opts, EXIT.LEASE_FAILED);
       }