@botbuddy/cli 1.45.0 → 1.45.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@botbuddy/cli",
-  "version": "1.45.0",
+  "version": "1.45.2",
   "description": "BotBuddy — Swarm coordination CLI for multi-agent workflows",
   "type": "module",
   "bin": {

package/src/botbuddy-release-repair.json

@@ -0,0 +1 @@
+{"schema_version":1,"source_version":"1.45.1","source_identity":"2fa051c4d0ee5cb09fda8d9e15c4952af94d701a6a43e98c8831912040cb41f2"}

package/src/stack.mjs

@@ -320,7 +320,7 @@ export function parseStackArgs(argv) {
       case "--idle-ttl": {
         if (need(a, rest[i + 1])) {
           const n = Number(rest[++i]);
-          if (!Number.isFinite(n) || !Number.isInteger(n) || n <= 0) errors.push("--idle-ttl must be a positive integer number of seconds");
+          if (!Number.isFinite(n) || !Number.isInteger(n) || n < 2) errors.push("--idle-ttl must be an integer of at least 2 seconds so the one-second heartbeat can keep the lease alive");
           else opts.idleTtl = n;
         }
         break;
@@ -1766,6 +1766,20 @@ function readStackIdentity(dir, read = readFileSync) {
  * is best-effort (unreadable config ⇒ treated as isolated, since the parse+provision
  * guards already blocked a same-project subdir at `up`). Never mutates.
  */
+// BOT-1935: every local-exec lease has persisted `connection.botbuddy_docker_target`
+// since CLI 1.5.0, so a TARGETLESS lease activated on/after this instant was provisioned
+// by the Helper, not by a pre-1.5.0 client (prod 069096a4, 2026-09-29). The server names
+// the Helper as `provisioner` only when it holds the Helper's succeeded receipt; this is
+// the diagnosis for the rest. It never authorizes anything: the lease stays fenced.
+export const HELPER_ERA_ACTIVATED_AT = Date.parse("2026-09-01T00:00:00Z");
+
+export function targetlessHelperLeaseRefusal(lease, leaseId) {
+  const activatedAt = Date.parse(lease?.activated_at ?? "");
+  if (lease?.connection?.botbuddy_docker_target || !(activatedAt >= HELPER_ERA_ACTIVATED_AT)) return null;
+  return `this lease was provisioned by the Helper; release it with \`bb stack done ${leaseId}\` (no --local-exec) ` +
+    "from the owning session, or ask the operator; lease and slot remain fenced";
+}
+
 export function localExecTeardownIsNonIsolated(lease, read = readFileSync) {
   const stackPath = lease?.stack_path || ".";
   if (stackPath === ".") return true;
@@ -2580,16 +2594,20 @@ export async function cmdDone(leaseId, opts, {
       // the compatibility contract still pins them there, so keep this path OrbStack-only:
       // a Docker Desktop daemon (newly admitted by the preflight allowlist for MODERN
       // leases) must never authorize teardown of a targetless legacy OrbStack lease.
+      // BOT-1935: a targetless lease activated after the 1.5.0 era is not legacy — the
+      // Helper provisioned it (local-exec has persisted a target since 1.5.0). Same fence,
+      // same exit code; only the diagnosis names the release path that actually works.
+      const helperLeaseRefusal = targetlessHelperLeaseRefusal(current.data, leaseId);
       if (dockerTarget?.validation !== "orbstack") {
         return emitResult(buildReceipt({ command: "done", outcome: "refused", lease_id: leaseId,
-          error: `pre-1.5.0 lease has no persisted Docker target; only an OrbStack daemon may authorize legacy teardown, not ${dockerTarget?.validation || "an unverified engine"}; lease and slot remain fenced`,
+          error: helperLeaseRefusal ?? `pre-1.5.0 lease has no persisted Docker target; only an OrbStack daemon may authorize legacy teardown, not ${dockerTarget?.validation || "an unverified engine"}; lease and slot remain fenced`,
           expected_docker_target: null, observed_docker_target: dockerTarget,
         }), opts, EXIT.LEASE_FAILED);
       }
       const proof = proveLegacyTarget(current.data, dockerTarget, opts);
       if (!proof?.ok) {
         return emitResult(buildReceipt({ command: "done", outcome: "refused", lease_id: leaseId,
-          error: `pre-1.5.0 lease has no persisted Docker target and compatibility proof failed: ${proof?.error || "unknown proof failure"}; lease and slot remain fenced`,
+          error: helperLeaseRefusal ?? `pre-1.5.0 lease has no persisted Docker target and compatibility proof failed: ${proof?.error || "unknown proof failure"}; lease and slot remain fenced`,
           expected_docker_target: null, observed_docker_target: dockerTarget,
         }), opts, EXIT.LEASE_FAILED);
       }

package/src/wait-core.mjs

@@ -436,10 +436,13 @@ function prSubjectMatches(subjectKey, params) {
   return subjectKey.startsWith(`${params.repo}#`);
 }
 
-// Does a commit field on a signal payload start with the condition's sha prefix?
-// A missing / non-string field never matches a sha-scoped condition.
+// Does a commit field on a signal payload identify the same commit as the
+// condition's SHA? GitHub may send either side as a 7–40-character prefix, so
+// accept either prefix direction while refusing malformed payload values.
 function shaPrefixMatches(value, sha) {
-  return typeof value === "string" && value.trim().toLowerCase().startsWith(sha);
+  if (typeof value !== "string") return false;
+  const candidate = value.trim().toLowerCase();
+  return /^[0-9a-f]{7,40}$/.test(candidate) && (candidate.startsWith(sha) || sha.startsWith(candidate));
 }
 
 // BOT-1975: optional head scoping for pr-state. pr_state signals carry the PR

package/src/wait.mjs

@@ -78,8 +78,8 @@ CONDITIONS  (TYPE:key=val,key=val — repeat for several; --any wakes on the fir
                                       by the PR read model. Omit pr= to wake on ANY of your PRs
                                       in the repo; or pass pr=<owner/repo#n> in one value. A
                                       conflict/clean flip sets payload.mergeable_changed. The
-                                      payload carries head_ref_oid; sha=<head> (7-40 hex, a
-                                      prefix is fine) wakes only on signals for that head, so a
+                                      payload carries head_ref_oid; sha=<head> (7-40 hex; either
+                                      side may be an abbreviated prefix) wakes only on signals for that head, so a
                                       previous head's check result can't wake you. A push alone
                                       emits nothing — the head rides on the next transition.
   pr-review:repo=<owner/repo>[,pr=<n>][,reviewer=<login>][,sha=<commit>]
@@ -96,7 +96,7 @@ CONDITIONS  (TYPE:key=val,key=val — repeat for several; --any wakes on the fir
                                       existing review will not re-wake it.
                                       reviewer=<login> wakes only on that reviewer (case-
                                       insensitive; a trailing [bot] is ignored). sha=<commit>
-                                      wakes only on verdicts for that commit (submitted reviews
+                                      wakes only on verdicts for that commit (either side may be an abbreviated prefix; submitted reviews
                                       and clean passes carry commit_sha; thread comments do not,
                                       so they never match sha=); the usage-limit decline always
                                       passes sha=. Any other key is refused (exit 4).