@botbuddy/cli 1.4.2 → 1.5.1

package/src/wait.test.mjs

@@ -1,266 +0,0 @@
-import assert from "node:assert/strict";
-import test from "node:test";
-import { execFile, spawn } from "node:child_process";
-import { fileURLToPath } from "node:url";
-import { dirname, join } from "node:path";
-import { promisify } from "node:util";
-import { once } from "node:events";
-import { createServer } from "node:http";
-import { mkdtemp } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { VERSION } from "./version.mjs";
-
-const exec = promisify(execFile);
-const BIN = join(dirname(dirname(fileURLToPath(import.meta.url))), "bin", "botbuddy.mjs");
-const npmEnv = {
-  PATH: process.env.PATH,
-  HOME: process.env.HOME,
-  TMPDIR: process.env.TMPDIR,
-  npm_config_userconfig: "/dev/null",
-  npm_config_globalconfig: join(tmpdir(), "botbuddy-empty-npmrc"),
-};
-
-test("BOT-1344: public CLI exposes the wait command", async () => {
-  const { stdout } = await exec("node", [BIN, "wait", "--help"]);
-  assert.match(stdout, /botbuddy wait/);
-});
-
-test("BOT-1344: local argument failures emit one typed terminal receipt", async () => {
-  for (const [args, error] of [
-    [["--bogus"], "invalid_arguments"],
-    [["timer:duration=1", "--timeout", "0"], "invalid_timeout"],
-    [["timer:duration=1", "--receipt-max-bytes", "300"], "invalid_receipt_max_bytes"],
-  ]) {
-    const result = await exec("node", [BIN, "wait", ...args]).then(
-      ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-      (failure) => ({ code: failure.code, stdout: failure.stdout, stderr: failure.stderr }),
-    );
-    assert.equal(result.code, 4);
-    const lines = result.stdout.trim().split("\n");
-    assert.equal(lines.length, 1, `${error} emits one receipt`);
-    const receipt = JSON.parse(lines[0]);
-    assert.equal(receipt.outcome, "error");
-    assert.equal(receipt.error, error);
-  }
-});
-
-test("BOT-1344: missing wait-option values fail closed with one bounded receipt", async () => {
-  for (const option of ["--url", "--since", "--profile"]) {
-    const result = await exec("node", [BIN, "wait", "timer:duration=1", option]).then(
-      ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-      (failure) => ({ code: failure.code, stdout: failure.stdout, stderr: failure.stderr }),
-    );
-    assert.equal(result.code, 4);
-    const receipt = JSON.parse(result.stdout.trim());
-    assert.equal(receipt.error, "invalid_arguments");
-    assert.equal(receipt.option, option);
-  }
-});
-
-test("BOT-1344: local error receipts honour a valid byte cap", async () => {
-  const longInvalidCondition = `unknown:type=${"x".repeat(2_000)}`;
-  const result = await exec("node", [
-    BIN, "wait", longInvalidCondition, "--receipt-max-bytes", "512",
-  ]).then(
-    ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-    (failure) => ({ code: failure.code, stdout: failure.stdout, stderr: failure.stderr }),
-  );
-  assert.equal(result.code, 4);
-  const line = result.stdout.trim();
-  assert.ok(Buffer.byteLength(line, "utf8") <= 512);
-  const receipt = JSON.parse(line);
-  assert.equal(receipt.error, "invalid_conditions");
-  assert.equal(receipt.errors_truncated, true);
-});
-
-test("BOT-1344: profile recovery is installation-free", async () => {
-  const server = createServer(async (req, res) => {
-    for await (const _chunk of req) {
-      // Drain the registration request before replying.
-    }
-    res.writeHead(401, { "content-type": "application/json" });
-    res.end(JSON.stringify({ error: "unauthorized", detail: "credential revoked" }));
-  });
-  await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve));
-  const { port } = server.address();
-  try {
-    const result = await exec("node", [
-      BIN, "wait", "chat:channel=*", "--profile", "botbuddy-dev", "--token", "test-key",
-      "--url", `http://127.0.0.1:${port}`,
-    ]).then(
-      ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-      (error) => ({ code: error.code, stdout: error.stdout, stderr: error.stderr }),
-    );
-    assert.equal(result.code, 3);
-    assert.equal(
-      JSON.parse(result.stdout.trim()).recovery,
-      "npx --yes @botbuddy/cli@latest profile setup botbuddy-dev",
-    );
-  } finally {
-    await new Promise((resolve) => server.close(resolve));
-  }
-});
-
-test("BOT-1344: client_outdated is a typed receipt with a copy-paste upgrade", async () => {
-  let registration;
-  const server = createServer(async (req, res) => {
-    const chunks = [];
-    for await (const chunk of req) chunks.push(chunk);
-    registration = JSON.parse(Buffer.concat(chunks).toString("utf8"));
-    res.writeHead(426, { "content-type": "application/json" });
-    res.end(JSON.stringify({
-      error: "client_outdated",
-      detail: "upgrade required",
-      minimum_wait_protocol: 2,
-      upgrade_command: "npx --yes @botbuddy/cli@latest wait",
-    }));
-  });
-  await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve));
-  const { port } = server.address();
-  try {
-    const result = await exec("node", [
-      BIN, "wait", "chat:channel=*", "--profile", "botbuddy-dev", "--token", "test-key",
-      "--url", `http://127.0.0.1:${port}`,
-    ]).then(
-      ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-      (error) => ({ code: error.code, stdout: error.stdout, stderr: error.stderr }),
-    );
-    assert.equal(result.code, 4);
-    assert.equal(registration.client_version, VERSION);
-    assert.equal(registration.wait_protocol_version, 1);
-    const receipt = JSON.parse(result.stdout.trim());
-    assert.equal(receipt.error, "client_outdated");
-    assert.equal(receipt.upgrade_command, "npx --yes @botbuddy/cli@latest wait");
-    assert.deepEqual(receipt.client, {
-      package: "@botbuddy/cli", version: VERSION, wait_protocol: 1,
-    });
-  } finally {
-    await new Promise((resolve) => server.close(resolve));
-  }
-});
-
-test("BOT-1344: active-wait cap emits one typed terminal receipt", async () => {
-  const server = createServer(async (req, res) => {
-    for await (const _chunk of req) {
-      // Drain the registration request before replying.
-    }
-    res.writeHead(429, { "content-type": "application/json" });
-    res.end(JSON.stringify({
-      error: "wait_session_cap_exceeded",
-      detail: "too many active waits for this agent",
-    }));
-  });
-  await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve));
-  const { port } = server.address();
-  try {
-    const result = await exec("node", [
-      BIN, "wait", "chat:channel=*", "--profile", "botbuddy-dev", "--token", "test-key",
-      "--url", `http://127.0.0.1:${port}`,
-    ]).then(
-      ({ stdout, stderr }) => ({ code: 0, stdout, stderr }),
-      (error) => ({ code: error.code, stdout: error.stdout, stderr: error.stderr }),
-    );
-    assert.equal(result.code, 4);
-    const lines = result.stdout.trim().split("\n");
-    assert.equal(lines.length, 1, "the public command always emits exactly one receipt");
-    const receipt = JSON.parse(lines[0]);
-    assert.equal(receipt.outcome, "error");
-    assert.equal(receipt.error, "wait_session_cap_exceeded");
-  } finally {
-    await new Promise((resolve) => server.close(resolve));
-  }
-});
-
-test("BOT-1344: receipt cap includes public client metadata", async () => {
-  const cap = 512;
-  const { stdout } = await exec("node", [
-    BIN, "wait", "timer:duration=1", "--receipt-max-bytes", String(cap),
-  ]);
-  const line = stdout.trim();
-  assert.ok(Buffer.byteLength(line, "utf8") <= cap, "client metadata is inside the requested receipt cap");
-  const receipt = JSON.parse(line);
-  assert.deepEqual(receipt.client, {
-    package: "@botbuddy/cli", version: VERSION, wait_protocol: 1,
-  });
-});
-
-test("BOT-1344: packed CLI runs a deterministic wait outside this checkout", async () => {
-  const packageDir = dirname(dirname(fileURLToPath(import.meta.url)));
-  const packedDir = await mkdtemp(join(tmpdir(), "botbuddy-cli-pack-"));
-  const installedDir = await mkdtemp(join(tmpdir(), "botbuddy-cli-install-"));
-  const { stdout: packed } = await exec("npm", ["pack", "--json", "--pack-destination", packedDir], { cwd: packageDir, env: npmEnv });
-  const tarball = join(packedDir, JSON.parse(packed)[0].filename);
-  await exec("npm", ["install", "--ignore-scripts", "--no-audit", "--no-fund", tarball], { cwd: installedDir, env: npmEnv });
-  const { stdout } = await exec("node", [
-    join(installedDir, "node_modules", ".bin", "botbuddy"), "wait", "timer:duration=1",
-  ], { cwd: installedDir });
-  const receipt = JSON.parse(stdout.trim());
-  assert.equal(receipt.outcome, "matched");
-  assert.equal(receipt.client.package, "@botbuddy/cli");
-  assert.equal(receipt.client.wait_protocol, 1);
-  const { stdout: profileEnv } = await exec("node", [
-    join(installedDir, "node_modules", ".bin", "botbuddy"), "profile", "env", "botbuddy-dev",
-  ], { cwd: installedDir });
-  assert.match(profileEnv, /security find-generic-password/);
-});
-
-// BOT-1383: the loopback-login runtime must load from an installed tarball and
-// actually START the RFC 8252 flow (register → print URL → wait), never the old
-// "No authorization code in redirect" early exit. --no-browser keeps it from
-// opening a real browser, and a local mock server stands in for production.
-test("BOT-1383: packed CLI starts loopback login from outside this checkout", async () => {
-  const packageDir = dirname(dirname(fileURLToPath(import.meta.url)));
-  const packedDir = await mkdtemp(join(tmpdir(), "botbuddy-cli-login-pack-"));
-  const installedDir = await mkdtemp(join(tmpdir(), "botbuddy-cli-login-install-"));
-  const fakeHome = await mkdtemp(join(tmpdir(), "botbuddy-cli-login-home-"));
-  const { stdout: packed } = await exec("npm", ["pack", "--json", "--pack-destination", packedDir], { cwd: packageDir, env: npmEnv });
-  const tarball = join(packedDir, JSON.parse(packed)[0].filename);
-  await exec("npm", ["install", "--ignore-scripts", "--no-audit", "--no-fund", tarball], { cwd: installedDir, env: npmEnv });
-  const bin = join(installedDir, "node_modules", ".bin", "botbuddy");
-
-  // login --help loads the new modules and documents the browser behavior.
-  const { stdout: help } = await exec("node", [bin, "login", "--help"], { cwd: installedDir });
-  assert.match(help, /--no-browser/);
-  assert.match(help, /loopback callback/);
-
-  // A local mock authorization server so --no-browser can register a client.
-  const server = createServer((req, res) => {
-    if (req.url.endsWith("/register")) {
-      res.writeHead(201, { "content-type": "application/json" });
-      res.end(JSON.stringify({ client_id: "smoke-client" }));
-      return;
-    }
-    res.writeHead(404).end();
-  });
-  await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve));
-  const { port } = server.address();
-
-  try {
-    const child = spawn("node", [bin, "login", "--no-browser"], {
-      cwd: installedDir,
-      env: {
-        ...process.env,
-        HOME: fakeHome,
-        BOTBUDDY_SERVER_URL: `http://127.0.0.1:${port}/functions/v1/mcp-server`,
-      },
-    });
-    let out = "";
-    child.stdout.on("data", (c) => (out += c));
-    child.stderr.on("data", (c) => (out += c));
-
-    // Wait until it has registered and is listening for the callback, then stop.
-    const deadline = Date.now() + 8000;
-    while (!/Waiting for authorization/.test(out) && Date.now() < deadline) {
-      await new Promise((r) => setTimeout(r, 50));
-    }
-    child.kill("SIGKILL");
-    await once(child, "exit");
-
-    assert.match(out, /127\.0\.0\.1/, "prints the loopback callback host");
-    assert.match(out, /callback/, "prints the callback path");
-    assert.match(out, /Waiting for authorization/, "starts the callback listener");
-    assert.doesNotMatch(out, /No authorization code in redirect/, "old early-exit path is gone");
-  } finally {
-    await new Promise((resolve) => server.close(resolve));
-  }
-});