@botbuddy/cli 1.2.3 → 1.4.1

package/src/stack.test.mjs

@@ -0,0 +1,196 @@
+// BOT-1220 — `botbuddy stack` unit + spawn tests (bb-wait pattern).
+//   * pure helpers: slot derivation, arg parsing, receipt build/truncate, status parse
+//   * --help snapshot (AC-4)
+//   * spawn tests: documented exit codes + exactly ONE JSON-line receipt to stdout (AC-4)
+import test from "node:test";
+import assert from "node:assert/strict";
+import { spawnSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+import { dirname, join } from "node:path";
+import { mkdtempSync, writeFileSync, mkdirSync, realpathSync } from "node:fs";
+import { tmpdir } from "node:os";
+
+import {
+  EXIT, STACK_HELP, STACK_SCHEMA_VERSION, DEFAULT_RECEIPT_MAX_BYTES,
+  deriveSlot, parseStackArgs, buildReceipt, truncateReceipt,
+  parseSupabaseStatus, eventStreamBase, resolveLocalSupabaseUrl, resolveStackPath,
+} from "./stack.mjs";
+
+const BIN = join(dirname(fileURLToPath(import.meta.url)), "..", "bin", "botbuddy.mjs");
+
+// Run the real CLI with a throwaway HOME so no ambient ~/.botbuddy config leaks in.
+function runStack(args, extraEnv = {}) {
+  const home = mkdtempSync(join(tmpdir(), "bb-stack-home-"));
+  return spawnSync("node", [BIN, "stack", ...args], {
+    encoding: "utf8",
+    env: { ...process.env, HOME: home, USERPROFILE: home, ...extraEnv },
+  });
+}
+
+// The single JSON-line receipt discipline: stdout is exactly one line and it parses.
+function soleReceipt(res) {
+  const lines = res.stdout.split("\n").filter((l) => l.trim() !== "");
+  assert.equal(lines.length, 1, `expected exactly one stdout line, got ${lines.length}:\n${res.stdout}`);
+  return JSON.parse(lines[0]);
+}
+
+// ── deriveSlot ───────────────────────────────────────────────────────────────
+test("deriveSlot: explicit --slot wins", () => {
+  assert.equal(deriveSlot({ slot: "56322" }, {}), "56322");
+});
+test("deriveSlot: derives <repo>-<ticket> when both given", () => {
+  assert.equal(deriveSlot({ repo: "botbuddy-web", ticket: "BOT-1220" }, {}), "botbuddy-web-bot-1220");
+});
+test("deriveSlot: BB_STACK_SLOT env fallback", () => {
+  assert.equal(deriveSlot({}, { BB_STACK_SLOT: "56999" }), "56999");
+});
+test('deriveSlot: rejects "default"', () => {
+  assert.throws(() => deriveSlot({ slot: "default" }, {}), /default.*rejected/i);
+});
+test("deriveSlot: throws when undeterminable", () => {
+  assert.throws(() => deriveSlot({}, {}), /cannot determine a stack slot/);
+});
+
+// ── parseStackArgs ───────────────────────────────────────────────────────────
+test("parseStackArgs: up options", () => {
+  const { command, opts, errors } = parseStackArgs([
+    "up", "--slot", "56322", "--host", "mac", "--repo", "botbuddy-web",
+    "--ticket", "BOT-1220", "--stack-path", "infra/local", "--idle-ttl", "600", "--timeout", "120", "--no-wait", "--local-exec",
+  ]);
+  assert.equal(errors.length, 0);
+  assert.equal(command, "up");
+  assert.equal(opts.slot, "56322");
+  assert.equal(opts.host, "mac");
+  assert.equal(opts.stackPath, "infra/local");
+  assert.equal(opts.idleTtl, 600);
+  assert.equal(opts.timeout, 120);
+  assert.equal(opts.noWait, true);
+  assert.equal(opts.localExec, true);
+});
+test("parseStackArgs: rejects absolute and escaping stack paths", () => {
+  assert.ok(parseStackArgs(["up", "--stack-path", "/tmp/stack"]).errors.length > 0);
+  assert.ok(parseStackArgs(["up", "--stack-path", "../stack"]).errors.length > 0);
+  assert.ok(parseStackArgs(["up", "--stack-path", "sub/../../stack"]).errors.length > 0);
+});
+test("resolveStackPath: canonicalizes an in-worktree directory", () => {
+  const root = mkdtempSync(join(tmpdir(), "bb-stack-root-"));
+  mkdirSync(join(root, "stack"));
+  assert.deepEqual(resolveStackPath(root, "stack"), { worktreeRoot: realpathSync(root), stackPath: "stack" });
+});
+test("parseStackArgs: status/touch/done require a lease_id", () => {
+  for (const c of ["status", "touch", "done"]) {
+    const { errors } = parseStackArgs([c]);
+    assert.ok(errors.some((e) => e.includes("lease_id")), `${c} should require lease_id`);
+  }
+  const { leaseId, errors } = parseStackArgs(["status", "abc-123"]);
+  assert.equal(errors.length, 0);
+  assert.equal(leaseId, "abc-123");
+});
+test("parseStackArgs: unknown option is an error", () => {
+  const { errors } = parseStackArgs(["up", "--bogus"]);
+  assert.ok(errors.some((e) => e.includes("--bogus")));
+});
+test("parseStackArgs: --idle-ttl / --timeout must be positive integers", () => {
+  assert.ok(parseStackArgs(["up", "--idle-ttl", "0"]).errors.length > 0);
+  assert.ok(parseStackArgs(["up", "--timeout", "-5"]).errors.length > 0);
+  assert.ok(parseStackArgs(["up", "--idle-ttl", "x"]).errors.length > 0);
+});
+test("parseStackArgs: --stop sets disposition stop (default destroy)", () => {
+  assert.equal(parseStackArgs(["done", "id"]).opts.disposition, "destroy");
+  assert.equal(parseStackArgs(["done", "id", "--stop"]).opts.disposition, "stop");
+});
+
+// ── receipts ─────────────────────────────────────────────────────────────────
+test("buildReceipt: stamps schema_version", () => {
+  assert.equal(buildReceipt({ command: "up" }).schema_version, STACK_SCHEMA_VERSION);
+});
+test("truncateReceipt: in-budget receipt is returned unchanged", () => {
+  const r = buildReceipt({ command: "up", outcome: "active", lease_id: "x", exit_code: 0 });
+  assert.deepEqual(truncateReceipt(r, DEFAULT_RECEIPT_MAX_BYTES), r);
+});
+test("truncateReceipt: collapses the oversized connection block first, keeps lease_id + exit_code", () => {
+  const big = "k".repeat(20000);
+  const r = buildReceipt({ command: "up", outcome: "active", lease_id: "lease-1", exit_code: 0, connection: { service_role_key: big } });
+  const t = truncateReceipt(r, DEFAULT_RECEIPT_MAX_BYTES);
+  assert.ok(Buffer.byteLength(JSON.stringify(t), "utf8") <= DEFAULT_RECEIPT_MAX_BYTES);
+  assert.equal(t.lease_id, "lease-1");
+  assert.equal(t.exit_code, 0);
+  assert.ok(t.connection.connection_truncated || t.truncated);
+});
+
+// ── parseSupabaseStatus ──────────────────────────────────────────────────────
+test("parseSupabaseStatus: JSON form", () => {
+  const conn = parseSupabaseStatus(JSON.stringify({ API_URL: "http://127.0.0.1:56321", DB_URL: "postgresql://x", ANON_KEY: "anon", SERVICE_ROLE_KEY: "svc" }));
+  assert.equal(conn.api_url, "http://127.0.0.1:56321");
+  assert.equal(conn.service_role_key, "svc");
+});
+test("parseSupabaseStatus: plain key/value fallback", () => {
+  const conn = parseSupabaseStatus("API URL: http://127.0.0.1:56321\nanon key: theanon\nservice_role key: thesvc\n");
+  assert.equal(conn.api_url, "http://127.0.0.1:56321");
+  assert.equal(conn.anon_key, "theanon");
+});
+
+// ── eventStreamBase ──────────────────────────────────────────────────────────
+test("eventStreamBase: derives the event-stream URL from the mcp-server URL", () => {
+  assert.equal(eventStreamBase("https://api.bot-buddy.ai/functions/v1/mcp-server"), "https://api.bot-buddy.ai/functions/v1/event-stream");
+  assert.equal(eventStreamBase("http://127.0.0.1:56321/functions/v1/mcp-server/"), "http://127.0.0.1:56321/functions/v1/event-stream");
+});
+
+// ── resolveLocalSupabaseUrl (Codex P1: never bake the prod origin) ───────────
+test("resolveLocalSupabaseUrl: honours an already-local VITE_SUPABASE_URL", () => {
+  assert.equal(resolveLocalSupabaseUrl({ VITE_SUPABASE_URL: "http://127.0.0.1:56321" }), "http://127.0.0.1:56321");
+  assert.equal(resolveLocalSupabaseUrl({ VITE_SUPABASE_URL: "http://localhost:54321" }), "http://localhost:54321");
+});
+test("resolveLocalSupabaseUrl: derives the [api] port from supabase/config.toml", () => {
+  const dir = mkdtempSync(join(tmpdir(), "bb-stack-cfg-"));
+  mkdirSync(join(dir, "supabase"));
+  writeFileSync(join(dir, "supabase", "config.toml"), "[api]\nenabled = true\nport = 56321\n\n[db]\nport = 56322\n");
+  assert.equal(resolveLocalSupabaseUrl({}, dir), "http://127.0.0.1:56321");
+});
+test("resolveLocalSupabaseUrl: ignores a NON-local exported origin (refuses → null)", () => {
+  // A prod VITE_SUPABASE_URL must NOT be trusted, and no config.toml here ⇒ null (caller refuses).
+  const empty = mkdtempSync(join(tmpdir(), "bb-stack-nocfg-"));
+  assert.equal(resolveLocalSupabaseUrl({ VITE_SUPABASE_URL: "https://api.bot-buddy.ai" }, empty), null);
+});
+
+// ── --help snapshot (AC-4) ───────────────────────────────────────────────────
+test("STACK_HELP documents the four subcommands and every exit code", () => {
+  for (const s of ["stack up", "stack status", "stack touch", "stack done", "--local-exec", "--no-wait"]) {
+    assert.ok(STACK_HELP.includes(s), `help missing ${s}`);
+  }
+  for (const s of ["0 ok", "2 park timed out", "3 not authenticated", "4 invalid", "5 backend", "6 lease failed", "7 internal"]) {
+    assert.ok(STACK_HELP.includes(s), `help missing exit-code doc ${s}`);
+  }
+});
+
+// ── spawn tests: exit codes + single-line receipt (bb-wait pattern) ──────────
+test("spawn: `stack help` prints usage and exits 0", () => {
+  const res = runStack(["help"]);
+  assert.equal(res.status, 0);
+  assert.ok(res.stdout.includes("botbuddy stack"));
+});
+test("spawn: invalid slot 'default' → exit 4 with a single JSON-line receipt", () => {
+  const res = runStack(["up", "--slot", "default"]);
+  assert.equal(res.status, EXIT.INVALID);
+  const r = soleReceipt(res);
+  assert.equal(r.schema_version, STACK_SCHEMA_VERSION);
+  assert.equal(r.command, "up");
+  assert.equal(r.outcome, "error");
+  assert.equal(r.exit_code, EXIT.INVALID);
+});
+test("spawn: `stack status` without a lease_id → exit 4", () => {
+  const res = runStack(["status"]);
+  assert.equal(res.status, EXIT.INVALID);
+  soleReceipt(res);
+});
+test("spawn: `stack up` with a valid slot but no auth → exit 3", () => {
+  const res = runStack(["up", "--slot", "56322"]);
+  assert.equal(res.status, EXIT.AUTH);
+  const r = soleReceipt(res);
+  assert.equal(r.exit_code, EXIT.AUTH);
+  assert.equal(r.command, "up");
+});
+test("spawn: unknown subcommand → exit 4", () => {
+  const res = runStack(["frobnicate"]);
+  assert.equal(res.status, EXIT.INVALID);
+});