@boshu2/vibe-check 1.7.0 → 1.8.0

package/.claude/skills/typescript-review.md

@@ -0,0 +1,152 @@
+# TypeScript Code Review Skill
+
+**Trigger:** User asks for TypeScript review, type safety audit, or TS best practices check.
+
+**Purpose:** Systematic TypeScript code review focusing on type safety, patterns, and idiomatic usage.
+
+---
+
+## Review Checklist
+
+### 1. Compiler Configuration (tsconfig.json)
+
+| Setting | Recommended | Why |
+|---------|-------------|-----|
+| `strict` | `true` | Enables all strict checks |
+| `noImplicitAny` | `true` (via strict) | No silent `any` types |
+| `strictNullChecks` | `true` (via strict) | Catch null/undefined errors |
+| `noUncheckedIndexedAccess` | `true` | Arrays return `T \| undefined` |
+| `exactOptionalPropertyTypes` | `true` | Distinguish `undefined` vs missing |
+| `noImplicitReturns` | `true` | All code paths must return |
+| `noFallthroughCasesInSwitch` | `true` | Prevent switch fallthrough bugs |
+
+### 2. Type Safety Issues
+
+**Critical (fix immediately):**
+- [ ] Explicit `any` types
+- [ ] Type assertions without validation (`as Type`)
+- [ ] Non-null assertions (`!`) without checks
+- [ ] `@ts-ignore` or `@ts-expect-error` comments
+- [ ] Missing return types on exported functions
+
+**Warning (improve when possible):**
+- [ ] Implicit `any` in callbacks
+- [ ] Overly broad types (`object`, `{}`, `Function`)
+- [ ] Missing generics where reuse is possible
+- [ ] Type assertions that could be type guards
+
+### 3. Type Design Patterns
+
+**Good patterns to look for:**
+```typescript
+// Discriminated unions
+type Result<T> =
+  | { success: true; data: T }
+  | { success: false; error: string };
+
+// Branded types for IDs
+type UserId = string & { readonly brand: unique symbol };
+
+// Const assertions for literals
+const STATUSES = ['pending', 'active', 'done'] as const;
+type Status = typeof STATUSES[number];
+
+// Type guards
+function isUser(obj: unknown): obj is User {
+  return typeof obj === 'object' && obj !== null && 'id' in obj;
+}
+```
+
+**Anti-patterns to flag:**
+```typescript
+// ❌ Stringly-typed
+function setStatus(status: string) { }
+
+// ✅ Union type
+function setStatus(status: 'pending' | 'active' | 'done') { }
+
+// ❌ Optional chaining hiding bugs
+const name = user?.profile?.name ?? 'Unknown';
+
+// ✅ Explicit null handling
+if (!user || !user.profile) {
+  throw new Error('User profile required');
+}
+const name = user.profile.name;
+```
+
+### 4. Interface vs Type
+
+| Use Interface | Use Type |
+|---------------|----------|
+| Object shapes | Unions, intersections |
+| Extendable contracts | Computed types |
+| Class implementations | Mapped types |
+| Public API | Internal aliases |
+
+### 5. Export Hygiene
+
+- [ ] Are internal types exported unnecessarily?
+- [ ] Is there a central `types.ts` for shared types?
+- [ ] Are re-exports organized (`index.ts` barrels)?
+
+---
+
+## Review Process
+
+1. **Check tsconfig.json** - Verify strict settings
+2. **Run `tsc --noEmit`** - Catch all compiler errors
+3. **Search for anti-patterns:**
+   ```bash
+   grep -r ": any" src/
+   grep -r "as " src/ | grep -v "import"
+   grep -r "@ts-ignore" src/
+   grep -r "!" src/ | grep -v "!=" | grep -v "!=="
+   ```
+4. **Review types.ts** - Check type design
+5. **Sample 3-5 files** - Deep review patterns
+
+---
+
+## Output Format
+
+```markdown
+## TypeScript Review: [Project Name]
+
+### Config Score: X/10
+[tsconfig.json findings]
+
+### Type Safety Score: X/10
+[Anti-pattern counts and examples]
+
+### Type Design Score: X/10
+[Pattern quality assessment]
+
+### Top Issues
+1. [Most critical issue]
+2. [Second issue]
+3. [Third issue]
+
+### Recommendations
+- [ ] [Actionable fix 1]
+- [ ] [Actionable fix 2]
+- [ ] [Actionable fix 3]
+```
+
+---
+
+## Quick Fixes
+
+```bash
+# Find all `any` types
+grep -rn ": any" src/
+
+# Find type assertions
+grep -rn " as [A-Z]" src/
+
+# Find non-null assertions
+grep -rn "\![^=]" src/
+
+# Run strict type check
+npx tsc --noEmit --strict
+```

package/CHANGELOG.md

@@ -7,6 +7,41 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.8.0] - 2025-12-05
+
+### Added
+
+- **Git Forensics** - `vibe-check forensics` command for deep pattern analysis (VIBE-045)
+  - Detects debug spirals ("take N" patterns indicating fix-retry loops)
+  - Detects vague commits (<20 characters)
+  - Detects context amnesia (repeatedly revisiting same scope)
+  - Quality metrics: conventional commit %, descriptive commit %
+  - Recommendations: sweep, maintain, or celebrate
+- **Session Detection** - `vibe-check sessions` command for work session analysis (VIBE-046)
+  - Identifies sessions from commit timestamps (90-minute gap threshold)
+  - Session statistics: avg duration, commits per session, longest/shortest
+  - Proven algorithm from release-engineering retrospective
+- **Brand Assets** - Professional logo and visual identity
+  - SVG logo with spiral-to-checkmark concept
+  - Light and dark mode variants
+  - Tagline: "catch the spiral before it catches you"
+- **Actionable Coaching** - Personalized coaching based on your spiral history
+  - `vibe-check insights` - View your spiral patterns and what works for you
+  - Watch mode shows personalized alerts
+  - Session end shows coaching for spirals hit during the session
+  - All spirals auto-recorded to `~/.vibe-check/spiral-history.ndjson`
+
+### Changed
+
+- **README Redesign** - Modern visual flow inspired by top npm packages
+  - Centered hero section with logo and badges
+  - Progressive disclosure structure
+  - Cleaner section organization with horizontal rules
+  - Scannable tables instead of prose
+- **Security Policy Updated** - Added forensics and sessions to threat model
+
+## [1.7.0] - 2025-12-02
+
 ### Added
 - **Session Integration** - New `vibe-check session` command suite for Claude Code integration
   - `session start` - Capture baseline metrics at session start
@@ -16,11 +51,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Automatic failure pattern detection (Debug Spiral, Context Amnesia, Velocity Crash, Trust Erosion, Flow Disruption)
   - Auto-generated learnings based on metrics and patterns
   - Baseline comparison with last 7 days
-- **Learning System** - New learning and lessons database
-  - `learn` command - Extract patterns from sessions
-  - `lesson` command - Manage synthesized lessons with `--list`, `--stats`, `--apply`, `--dismiss`
-  - Automatic synthesis from pattern + intervention memory
-  - Lessons surface during analyze when relevant spirals detected
+
+### Changed
+- Major cleanup: removed 20 files, -3900 lines of speculative features
+- Removed learning system (zero adoption evidence)
+- Removed advanced gamification (challenges, prestige, leaderboards)
+- Simplified to core value: metrics, coaching, insights
 
 ## [1.6.0] - 2025-11-30
 

package/CLAUDE.md

@@ -140,11 +140,17 @@ src/
 ├── commands/
 │   ├── index.ts        # Command exports
 │   ├── analyze.ts      # Main analyze command
-│   ├── session.ts      # Session start/end/status commands
+│   ├── session.ts      # Session start/end/status + coaching
 │   ├── dashboard.ts    # Visual dashboard command
-│   ├── learn.ts        # Learning extraction command
-│   ├── lesson.ts       # Lessons database command
+│   ├── watch.ts        # Real-time monitoring + coaching
+│   ├── insights.ts     # Spiral patterns + recommendations
+│   ├── timeline.ts     # Session history
 │   └── profile.ts      # Profile/stats command
+├── storage/
+│   ├── spiral-history.ts  # Spiral history NDJSON log
+│   ├── atomic.ts          # Atomic file operations
+│   ├── commit-log.ts      # Commit log storage
+│   └── timeline-store.ts  # Timeline cache
 ├── metrics/
 │   ├── index.ts        # Orchestrates all metrics
 │   ├── velocity.ts     # Iteration velocity
@@ -162,17 +168,8 @@ src/
 │   ├── xp.ts           # XP calculation and levels
 │   ├── streaks.ts      # Daily/weekly streak tracking
 │   ├── achievements.ts # Achievement definitions and checks
-│   ├── pattern-memory.ts # Track spiral triggers over time
-│   ├── intervention-memory.ts # Track what breaks spirals
+│   ├── stats.ts        # Weekly statistics
 │   └── profile.ts      # Profile persistence (.vibe-check/)
-├── learning/
-│   ├── index.ts        # Learning system exports
-│   ├── types.ts        # Learning/lesson types
-│   ├── storage.ts      # Learnings persistence
-│   ├── cadence.ts      # Automatic learning cadence
-│   ├── synthesis.ts    # Lesson synthesis from patterns
-│   ├── surfacing.ts    # Surface lessons during analyze
-│   └── lessons-storage.ts # Lessons database
 ├── sessions/
 │   └── index.ts        # Session tracking and baseline comparison
 ├── calibration/
@@ -197,9 +194,14 @@ dashboard/              # Static HTML dashboard
 ├── app.js              # Dashboard JavaScript
 └── styles.css          # Dashboard styles
 
-.vibe-check/            # Local profile data (per-repo)
+~/.vibe-check/          # Global profile data (in home dir)
 ├── profile.json        # XP, streaks, achievements
+├── spiral-history.ndjson  # Spiral log for coaching
 └── calibration.json    # Calibration samples
+
+.vibe-check/            # Local data (per-repo)
+├── active-session.json # Active session state
+└── timeline.json       # Timeline cache
 ```
 
 ## Commands
@@ -229,29 +231,29 @@ vibe-check level --calibrate 3 # Record calibration sample
 ```bash
 vibe-check session start --level 3   # Start session, capture baseline
 vibe-check session status            # Show active session
-vibe-check session end --format json # End session, get metrics + patterns
+vibe-check session end --format json # End session, get metrics + coaching
 ```
 
-Output includes failure pattern detection for `/session-end` integration:
+Output includes failure pattern detection and personalized coaching:
 ```json
 {
   "metrics": { "trust_pass_rate": 92, "rework_ratio": 11, ... },
   "retro": {
     "failure_patterns_hit": [],
-    "failure_patterns_avoided": ["Debug Spiral", "Context Amnesia"],
-    "learnings": ["Test-first approach prevented spirals"]
+    "failure_patterns_avoided": ["Debug Spiral", "Context Amnesia"]
   }
 }
 ```
 
-### Learning Commands
+### Insights Command (Coaching)
 ```bash
-vibe-check learn               # Extract patterns from sessions
-vibe-check lesson --list       # List synthesized lessons
-vibe-check lesson --stats      # Lesson statistics
-vibe-check lesson --apply <id> # Apply a lesson
+vibe-check insights              # Your spiral patterns + what works
+vibe-check insights --days 90    # Longer history
+vibe-check insights --format json  # Export for analysis
 ```
 
+Shows your spiral history, patterns by frequency, what resolutions worked, and personalized recommendations.
+
 ## The 5 Metrics
 
 | Metric | Measures | Threshold |
@@ -272,3 +274,5 @@ A "debug spiral" is detected when 3+ consecutive fix commits target the same com
 - `SSL_TLS` - Certificate problems
 - `IMAGE_REGISTRY` - Container pull issues
 - `GITOPS_DRIFT` - Sync/reconciliation issues
+
+**Coaching Integration:** Spirals are automatically recorded to `~/.vibe-check/spiral-history.ndjson`. Watch mode and session end show personalized advice based on what's worked before for you.

package/Makefile

@@ -137,19 +137,6 @@ session-end-json:
 session-status:
 	node dist/cli.js session status
 
-# ============================================
-# Learning Commands
-# ============================================
-
-learn:
-	node dist/cli.js learn
-
-lessons:
-	node dist/cli.js lesson --list
-
-lesson-stats:
-	node dist/cli.js lesson --stats
-
 # ============================================
 # Shortcuts
 # ============================================