@bonniernews/eslint-config 1.0.1 → 1.1.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 1.1.0
+
+- Add rule `react/jsx-curly-spacing` to align jsx curly with js curly.
+- Bumped `eslint-plugin-react`, `eslint-plugin-import` and `eslint-plugin-n`.
+- Moved TypeScript restricted syntax to a seperate package `@bonniernews/typescript-rules`.
+- Uses `@bonniernews/typescript-rules` for TypeScript.
+- Added `@bonniernews/typescript-rules/disallow-class-extends` also for non-typescript.
+
+## 1.0.2
+
+- Run tests on all supported node versions
+- Bump `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser`.
+- Use typescript 5.3 for tests
+
 ## 1.0.1
 
 - Loosen react/jsx-max-props-per-line to allow as many props the developer wants on

package/index.js

@@ -19,7 +19,7 @@ const moduleConfig = {
     node: true,
     ...(hasES2022Support ? { es2022: true } : { es6: true }),
   },
-  plugins: [ "eslint-plugin-n", "import" ],
+  plugins: [ "eslint-plugin-n", "import", "@bonniernews/typescript-rules" ],
 };
 
 const commonjsConfig = {
@@ -28,7 +28,7 @@ const commonjsConfig = {
     node: true,
     es6: true,
   },
-  plugins: [ "eslint-plugin-n" ],
+  plugins: [ "eslint-plugin-n", "@bonniernews/typescript-rules" ],
 };
 
 module.exports = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bonniernews/eslint-config",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "ESLint config",
   "main": "index.js",
   "scripts": {
@@ -20,11 +20,11 @@
   ],
   "contributors": [],
   "devDependencies": {
-    "chai": "^4.3.7",
-    "eslint": "^8.19.0",
+    "chai": "^4.3.10",
+    "eslint": "^8.53.0",
     "mocha": "^10.2.0",
     "mocha-cakes-2": "^3.3.0",
-    "typescript": "^5.2.0"
+    "typescript": "^5.3.0"
   },
   "peerDependencies": {
     "eslint": ">=8.3.0",
@@ -40,13 +40,14 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^6.6.0",
-    "@typescript-eslint/parser": "^6.6.0",
+    "@bonniernews/eslint-plugin-typescript-rules": "^0.9.0",
+    "@typescript-eslint/eslint-plugin": "^6.12.0",
+    "@typescript-eslint/parser": "^6.12.0",
     "eslint-plugin-chai-friendly": "^0.7.2",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-n": "^16.0.1",
+    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-n": "^16.3.1",
     "eslint-plugin-no-only-tests": "^3.1.0",
-    "eslint-plugin-react": "^7.32.2"
+    "eslint-plugin-react": "^7.33.2"
   },
   "files": [
     "all.js",

package/react-rules.js

@@ -36,4 +36,5 @@ module.exports = {
   "react/jsx-indent": [ 2, 2 ],
   "react/jsx-tag-spacing": [ 2, { beforeSelfClosing: "always" } ],
   "react/jsx-indent-props": [ 2, 2 ],
+  "react/jsx-curly-spacing": [ "error", { when: "never", children: { when: "always" } } ],
 };

package/rules.js

@@ -236,6 +236,7 @@ module.exports = function getRules(isModuleProject) {
     ...starterAppRules,
     ...(isModuleProject ? importRules : {}),
     // good stuff..
+    "@bonniernews/typescript-rules/disallow-class-extends": "error",
     "no-multiple-empty-lines": [ "error", {
       max: 1,
       maxEOF: 0,

package/typescript-rules.js

@@ -30,32 +30,6 @@ const typescriptEslintRecommended = {
   "@typescript-eslint/triple-slash-reference": "error",
 };
 
-const disallowNonEcmaScriptCompatibleSyntax = {
-  "no-restricted-syntax": [
-    "error",
-    {
-      selector: "ClassDeclaration[abstract=true]",
-      message: "Abstract classes aren't allowed.",
-    },
-    {
-      selector: "PropertyDefinition[accessibility=private]",
-      message: "Private keyword isn't allowed, use native # instead.",
-    },
-    {
-      selector: "MethodDefinition[decorators.length > 0]",
-      message: "Decorators aren't allowed.",
-    },
-    {
-      selector: "TSEnumDeclaration",
-      message: "Don't use enums since it is not a type-level extension of JavaScript. Use Objects instead.",
-    },
-    {
-      selector: "ClassDeclaration[superClass]",
-      message: "Extending other classes via inheritance isn't allowed. Use composition instead.",
-    },
-  ],
-};
-
 const eslitRecommendedTs = {
   "constructor-super": "off", // ts(2335) & ts(2377)
   "getter-return": "off", // ts(2378)
@@ -84,7 +58,8 @@ const importRules = { "import/named": "off" };
 
 module.exports = {
   ...typescriptEslintRecommended,
-  ...disallowNonEcmaScriptCompatibleSyntax,
   ...eslitRecommendedTs,
   ...importRules,
+  "@bonniernews/typescript-rules/disallow-abstract-class": "error",
+  "@bonniernews/typescript-rules/disallow-non-es-compatible": "error",
 };