@bongos/core 1.25.7 → 1.25.9

package/modules/hall-ui/public/style.css

@@ -895,7 +895,7 @@ html[data-theme="dark"] .brand-mark__mark { --mark-ink: #e2e1e4; }
      and the shell’s corner buttons, so the top arc, its notch and the place all step aside. The foot row keeps its three parts in one line and nothing leans: the sprite
      with the count over its word, the one accent button (its name may take two lines; its key is in the sheet), and of
      the key hints only Actions, as its dots (every other hint is a row in its sheet). */
-  html[data-game="on"] #visor { --visor-inset-bottom: 52px; }
+  :root[data-game="on"] { --visor-inset-bottom: 52px; --visor-foot-room: 112px; }
   html[data-game="on"] .visor__place, html[data-game="on"] .visor__progress, html[data-game="on"] .visor__notch, html[data-game="on"] .visor__frame--top, html[data-game="on"] .visor__name { display: none; }
   html[data-game="on"] .visor__foot { grid-template-columns: auto minmax(0, 1fr) auto; column-gap: var(--ds-space-hair); }
   html[data-game="on"] .visor__me, html[data-game="on"] .visor__hints { transform: none; }
@@ -914,7 +914,7 @@ html[data-theme="dark"] .brand-mark__mark { --mark-ink: #e2e1e4; }
   html[data-game="on"] .visor__who, html[data-game="on"] .visor__hint { background: var(--night-plate); box-shadow: none; -webkit-backdrop-filter: none; backdrop-filter: none; }
   html[data-game="on"] .visor__hint--sheet > :not(.visor__dots) { position: absolute; width: 1px; height: 1px; padding: 0; border: 0; overflow: hidden; clip-path: inset(50%); white-space: nowrap; }
   html[data-game="on"] .visor__main .visor__key { display: none; }
-  html[data-game="on"] .visor__sheet { bottom: calc(var(--visor-inset-bottom) + 112px); max-height: 60vh; }
+  html[data-game="on"] .visor__sheet { max-height: 60vh; }
 }
 /* task 1004424 (BV2.PS10): THE FOUNDING MARK. A pill in .rank-badge's grammar (same
    height, type and radius) so it sits beside a rank without competing with it; the

package/modules/hall-ui/public/visor.css

@@ -10,11 +10,15 @@
    the night, and the place, each hint and your credits stand on a small night plate. Colours, sizes and corners
    are the hall tier's tokens; nothing here is typed in. Record: modules/hall-ui/records/visor.md. */
 .visor { display: none; }
+/* where the glass sits, so a scene's pop-up, and a window the glass opens, can keep clear of
+   it (ADR 0399 §2.3). On the root, not the visor, because the options window is not inside
+   it. --visor-foot-room is the foot row's height with the hints wrapped onto a second line. */
+html[data-game="on"] {
+  --visor-arc: 64px; --visor-inset-top: 88px; --visor-inset-bottom: 76px; --visor-foot-room: 100px;
+  --visor-inset-right: max(var(--ds-space-gutter-narrow), var(--helm-inset)); --visor-inset-left: var(--visor-inset-right);
+}
 html[data-game="on"] .visor:not([hidden]) {
   display: block; position: fixed; inset: 0; z-index: 4; pointer-events: none;
-  /* where the glass sits, so a scene's pop-up can keep clear of it (ADR 0399 §2.3) */
-  --visor-arc: 64px; --visor-inset-top: 88px; --visor-inset-bottom: 76px;
-  --visor-inset-right: max(var(--ds-space-gutter-narrow), var(--helm-inset)); --visor-inset-left: var(--visor-inset-right);
   color: var(--ink); font-family: var(--font-body);
 }
 
@@ -187,9 +191,9 @@ html[data-game="on"] .visor:not([hidden]) {
    panel between two strong hairlines, standing over the hints that opened it, clear of the foot
    row even when the hints have wrapped onto a second line. */
 .visor__sheet {
-  position: absolute; right: var(--visor-inset-right); bottom: calc(var(--visor-inset-bottom) + 100px); z-index: 1;
+  position: absolute; right: var(--visor-inset-right); bottom: calc(var(--visor-inset-bottom) + var(--visor-foot-room)); z-index: 1;
   pointer-events: auto; box-sizing: border-box; width: min(18rem, calc(100vw - 2 * var(--ds-space-gutter-narrow)));
-  max-height: calc(100% - var(--visor-inset-top) - var(--visor-inset-bottom) - 100px); overflow-y: auto;
+  max-height: calc(100% - var(--visor-inset-top) - var(--visor-inset-bottom) - var(--visor-foot-room)); overflow-y: auto;
   padding: var(--ds-space-sm); background: var(--bg-card);
   border: 0 solid var(--rule); border-left-width: var(--line-strong); border-right-width: var(--line-strong);
 }
@@ -237,5 +241,29 @@ html[data-game="on"] .visor:not([hidden]) {
 .visor__focus .visor__key { color: var(--ink-soft); background: none; }
 .visor__main--lead[aria-busy="true"] { cursor: progress; background: var(--accent-lift); }
 
+/* A WINDOW THE GLASS OPENS OPENS IN THE GLASS (task 1005253, ADR 0403; owner 2026-11-13). The
+   options window and your profile (shell-game.js openOverlay, .opt-window) and the game menu
+   (openMenu, .game-menu) are reached from the visor, so they never cover it: in game mode each
+   fits between the top arc and the foot row, and the visor is drawn over its scrim, undimmed,
+   as the frame you see it through. While one is up the glass is a picture: nothing on it takes
+   a pointer (the window is modal and keeps the keyboard), the sight leaves the window's middle,
+   and the glass's own pop-ups (the sheet, the scene's pick, your card) step aside. */
+html.visor-on .opt-window, html.visor-on .game-menu {
+  box-sizing: border-box;
+  padding: var(--visor-inset-top) var(--visor-inset-right) calc(var(--visor-inset-bottom) + var(--visor-foot-room)) var(--visor-inset-left);
+}
+html.visor-on .opt-window__box { width: min(1040px, 100%); height: min(720px, 100%); }
+html.visor-on .game-menu__box { max-height: 100%; }
+html.visor-on:is(.opt-window-open, .game-menu-open) .visor:not([hidden]) { z-index: calc(var(--ds-z-modal, 160) + 1); }
+html.visor-on:is(.opt-window-open, .game-menu-open) .visor * { pointer-events: none; }
+html.visor-on:is(.opt-window-open, .game-menu-open) :is(.visor__sight, .visor__sheet, .visor__focus, .visor__card) { visibility: hidden; }
+/* THE GAME MENU IS THE ONE THING IN FOCUS (owner 2026-11-13): the place behind it is frosted
+   (the hall's glass blur, under the glass, so the visor's lines stay sharp), and everything on
+   the glass but its two arcs steps back, so the eye goes to the menu. The arcs stay as the frame
+   the menu is held in. */
+html.visor-on .game-menu { -webkit-backdrop-filter: blur(var(--glass-blur)); backdrop-filter: blur(var(--glass-blur)); }
+html.visor-on .visor > :not(.visor__frame, .visor__notch) { transition: opacity var(--ds-dur-fast) var(--ds-ease); }
+html.visor-on.game-menu-open .visor > :not(.visor__frame, .visor__notch) { opacity: .25; }
+
 /* a phone (640px and narrower): the rules live in style.css’s shared phone block, so the
    visor adds no breakpoint of its own (the design-count ratchet). */

package/modules/hall-ui/records/options-menu.md

@@ -28,6 +28,6 @@ The menu is a Helm screen, written from the hall tier's tokens alone (`settings.
 ## The options window (owner, 2026-11-11: "WoW sizing, an overlay")
 
 - **In game mode the menu opens over the place, not as a page.** The game menu's Options row (task 1005250, `records/game-menu.md`; until then Escape itself), or a click on any link to `/settings` (the profile chip), draws one window (`shell-game.js` `openOverlay`, `window.OTBOptionsOverlay`), built on the shared dialog (`OTBDialog.bind`: Escape, scrim, close button, focus trap and return), with the page behind made `inert` while it is up, holding the menu framed with `?embed=1`; the place stays drawn behind it. Escape, the scrim or the × shuts it; `options-menu.js` `close()` shuts the window when it is in one. A page that cannot draw it falls back to the menu page. A plain visit to `/settings` is the page, as before.
-- **Window sized, see-through.** The window is `min(1040px, …) × min(720px, …)` of glass at 48% of the ground with a light blur, over the shared `--scrim` at a third. Every embedded screen is drawn at `zoom: 0.82` with no ground of its own (`style.css`), and the menu inside it takes smaller words (`settings.css`, `html[data-embed="on"]`); a window-high length divides by the zoom (`--opt-vh`).
+- **Window sized, see-through.** The window is `min(1040px, …) × min(720px, …)` of glass at 48% of the ground with a light blur, over the shared `--scrim` at a third. Every embedded screen is drawn at `zoom: 0.82` with no ground of its own (`style.css`), and the menu inside it takes smaller words (`settings.css`, `html[data-embed="on"]`); a window-high length divides by the zoom (`--opt-vh`). In game mode with the visor up the window fits inside the glass, between the top arc and the foot row, and never covers the visor (task 1005253, `records/visor.md`).
 - **One review palette.** A framed screen docks no artist palette of its own (`craft-mode.js` `applyDocked`); the page around it has one.
 - **Tests:** `tests/hall_options_menu.mjs` ("away from the menu, Escape opens the options as a window…"), `tests/page_notes_panel.mjs` (the frame docks no panel).

package/modules/hall-ui/records/visor.md

@@ -6,6 +6,14 @@ Covers: `visor.js` + `visor.css`, loaded on Home, `/city`, `/goal-map` and `/thi
 
 The visor is the control and the scene is the view: every main call to action in game mode is on the glass (the accent button, the key hints, the Actions sheet), and a scene carries none of its own. A scene that has something to do registers it with `OTBVisor.scene({ actions, keys })`. ADR 0403 §3 lists the scenes that do not keep it yet; the Governor City keeps it since task 1005209 the sky since task 1005210, and Home's gallery since task 1005211 (below).
 
+## A window the glass opens opens in the glass (task 1005253, owner 2026-11-13)
+
+- **The bug.** The options window and your profile window (`shell-game.js` `openOverlay`, `.opt-window`), and the game menu (`openMenu`, `.game-menu`, task 1005250), are reached from the visor, yet they opened as a box over the whole screen and covered the visor itself: the arcs, the place, your credits, the accent button and the hints.
+- **The rule.** A menu or window the visor opens never covers the visor. In game mode (`html.visor-on`) the window fits between the top arc (`--visor-inset-top`) and the foot row (`--visor-inset-bottom` + `--visor-foot-room`), inside the side insets, and the visor is drawn over the window's scrim, undimmed, as the frame it is seen through (`visor.css`). While a window is up the glass is a picture: none of it takes a pointer (the window is modal and keeps the keyboard), the sight leaves the window's middle, and the glass's own pop-ups (the sheet, the scene's pick, your card) step aside. Shut, the glass goes back to z 4.
+- **The game menu is the one thing in focus** (owner, same day: "a frosted glass or blur… so the user focuses specifically on the game menu"). While it is up the place behind it is frosted (`backdrop-filter` with the hall's `--glass-blur`, on `.game-menu`, so it is under the glass and the visor's lines stay sharp), and everything on the glass but its two arcs and the notch fades to a quarter. The options and profile windows are glass of their own and keep the visor whole around them.
+- **The glass's measures are on the root now** (`html[data-game="on"]`, and the phone block's `:root[data-game="on"]`), not on `#visor`, because the window is not inside the visor. The sheet reads `--visor-foot-room` too, so the sheet and a window keep the same clearance over the foot row. Classic mode keeps the centred window.
+- **Tests:** `tests/hall_visor_profile.mjs` ("a window the visor opens sits inside the glass…", at a desk and a phone width).
+
 ## One owner per key (task 1005248, owner 2026-11-12)
 
 - **The bug.** The Artist saw Esc twice: "Options" on the glass, then in the Actions sheet both Close and the Options row said Esc.

package/modules/provisioning/github-setup.js

@@ -134,6 +134,9 @@ function githubChecklist(status, appSlug, facts = {}) {
     // what "is alive" waits for — device flow is optional by design
     connected: approve === 'done' && install === 'done' && signIn === 'done',
     wired_elsewhere: elsewhere,
+    // GitHub sent the founder back from the install page (or they asked for a check) and
+    // the runner has not confirmed it yet: the page shows the step as being checked
+    install_checking: install !== 'done' && !!(facts.installReportedAt || facts.checkRequestedAt),
   };
 }
 

package/modules/public-landing/public/projects.html

@@ -533,7 +533,10 @@ body:has(#view-new:not([hidden])) footer.foot{position:relative;z-index:1;backgr
 .setFact .optional{margin-left:8px;font-family:var(--label-face);font-size:var(--label-size);letter-spacing:var(--label-space);text-transform:uppercase;color:var(--ink-faint);}
 .setFact.done .d{background:color-mix(in srgb,var(--ok) 12%,transparent);color:var(--ok);border-color:var(--ok);}
 .setFact.done .t,.setFact.now .t,.setFact.you .t{color:var(--ink);}
-.setFact.now .d{border:2px solid var(--accent);}
+.setFact.now .d{border:2px solid var(--accent);border-top-color:transparent;animation:factSpin 1s linear infinite;}
+/* a loading wheel is essential, so it turns even with reduced motion (slower, no pulse) */
+@media (prefers-reduced-motion:reduce){.setFact.now .d{animation-duration:2s;}}
+@keyframes factSpin{to{transform:rotate(360deg)}}
 .setFact.you .d{background:color-mix(in srgb,var(--accent) 16%,transparent);border-color:color-mix(in srgb,var(--accent) 60%,transparent);color:var(--ink);}
 .setFact.bad .d{background:color-mix(in srgb,var(--err) 10%,transparent);color:var(--err);border-color:var(--err);}
 .setFact.bad .t{color:var(--err);}
@@ -548,8 +551,7 @@ body:has(#view-new:not([hidden])) footer.foot{position:relative;z-index:1;backgr
 .setFact .acctPick .acctTyped{margin-top:10px;}
 .setFact .acctPick .hint{min-height:0;}
 @media (prefers-reduced-motion:no-preference){
-  .setFact.now .d{animation:factBreathe 1.4s ease-in-out infinite,factSpin 1s linear infinite;border-top-color:transparent;}
-  @keyframes factSpin{to{transform:rotate(360deg)}}
+  .setFact.now .d{animation:factBreathe 1.4s ease-in-out infinite,factSpin 1s linear infinite;}
   .setNow.working::after{content:"";display:inline-block;width:1.2em;text-align:left;animation:workDots 1.4s steps(4,end) infinite;}
   @keyframes workDots{0%{content:""}25%{content:"."}50%{content:".."}75%{content:"..."}}
   @keyframes factBreathe{0%,100%{border-color:var(--accent)}50%{border-color:color-mix(in srgb,var(--accent) 35%,transparent)}}
@@ -6933,6 +6935,7 @@ summary{min-height:24px;padding:3px 0;}
        sentence and carries the action that fixes it, with the app GitHub already made, never a
        second one. live.pickUp is the server's word for what that action does (github-setup.js
        pickUpFor); live.verifying is whether the runner is still checking. */
+    var installOpened = false;   /* this page sent the founder to GitHub's install page */
     var ghTabTrouble = null;   /* 'behind' | 'closed': what this page saw of the GitHub tab it opened */
     var NO_SECOND_APP = 'Nothing is lost, and no second app will be made.';
     function projectName() { return state.name || state.slug || 'your project'; }
@@ -7067,6 +7070,10 @@ summary{min-height:24px;padding:3px 0;}
       /* the runner stopped checking and GitHub never confirmed the install: the link opens the
          SAME app's install page, and the click asks the runner to look again */
       else if (live.pickUp === 'check') { install.state = 'bad'; install.sub = 'GitHub stopped before the app was on ' + (repo || 'your repo') + '.'; install.right = checked; install.act = 'pick-up-link'; install.href = installUrl; }
+      /* the founder came back from GitHub's install page (GitHub reported it, or they pressed
+         the link here): the runner is checking with GitHub, so the step spins until it ticks,
+         and the link stays in case they never finished */
+      else if ((live.setup && live.setup.install_checking) || installOpened) { install.state = 'now'; install.sub = (repo ? repo + '. ' : '') + 'Checking with GitHub. This ticks by itself.'; install.right = checked; install.act = 'install-link'; install.href = installUrl; }
       else { install.state = 'you'; install.right = 'not yet seen'; install.act = 'install-link'; install.href = installUrl; }
 
       var signIn = { key: 'sign_in', title: 'Builders can sign in' };
@@ -7313,6 +7320,7 @@ summary{min-height:24px;padding:3px 0;}
       var ib = $('installBtn'), instRow = gh[1];
       var instHref = instRow && instRow.state !== 'done' && homeUp && (instRow.act === 'install-link' || instRow.act === 'pick-up-link') ? installHrefOf(instRow) : '';
       if (instHref) ib.setAttribute('href', instHref); else ib.removeAttribute('href');
+      if (!ib.getAttribute('data-wired')) { ib.setAttribute('data-wired', '1'); ib.addEventListener('click', function () { installOpened = true; paintFacts(); }); }
       ib.hidden = !instHref;
       paintSetDone(ready, home, gh);
       tipsRun(!ready);

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.25.7",
+  "version": "1.25.9",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.25.7",
+      "version": "1.25.9",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.25.7",
+  "version": "1.25.9",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11753,5 +11753,12 @@
       "id": "1005219",
       "text": "Opening the builders' hall now starts on the Game or Classic choice. Signed out, your pick takes you to sign in and then straight to that menu."
     }
+  ],
+  "1.25.8": [],
+  "1.25.9": [
+    {
+      "id": "1005253",
+      "text": "In game mode, the windows the visor opens (Options, your profile, the game menu) now open inside the visor instead of covering it, and the game menu blurs the place behind it and quiets the visor so it is the one thing in focu"
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.25.7'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.25.9'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/github_one_trip.mjs

@@ -35,7 +35,7 @@ const SCRIPT = HUB.slice(HUB.lastIndexOf('<script>'), HUB.lastIndexOf('</script>
 
 test('each step reads only what the server has seen — the honest "not yet" states included', () => {
   const none = GS.githubChecklist(null, null);
-  assert.deepEqual(none, { approve: 'todo', install: 'todo', sign_in: 'todo', device_flow: 'todo', connected: false, wired_elsewhere: false }, 'never started');
+  assert.deepEqual(none, { approve: 'todo', install: 'todo', sign_in: 'todo', device_flow: 'todo', connected: false, wired_elsewhere: false, install_checking: false }, 'never started');
   assert.equal(GS.githubChecklist('pending', null).approve, 'now', 'waiting for the approval on GitHub');
   for (const s of ['code_received', 'converting']) {
     const c = GS.githubChecklist(s, null);
@@ -327,3 +327,10 @@ test('the device-flow finding lives in the direction doc, and the code points at
   assert.match(doc, /Device flow cannot be switched on for the founder \(spike, task 1004649\)/);
   assert.match(fs.readFileSync(path.join(ROOT, 'modules', 'provisioning', 'github-setup.js'), 'utf8'), /docs\/design\/project-startup-direction\.md/);
 });
+
+test('back from the install page, the install step reads as being checked until GitHub confirms it', () => {
+  const { githubChecklist } = require('../modules/provisioning/github-setup.js');
+  assert.equal(githubChecklist('done', 'kestrel', {}).install_checking, false, 'not reported yet');
+  assert.equal(githubChecklist('done', 'kestrel', { installReportedAt: '2026-10-25T10:00:00Z' }).install_checking, true, 'reported, not yet seen');
+  assert.equal(githubChecklist('done', 'kestrel', { installReportedAt: '2026-10-25T10:00:00Z', installedAt: '2026-10-25T10:01:00Z' }).install_checking, false, 'seen: done');
+});

package/tests/github_sign_in_seen.mjs

@@ -53,7 +53,7 @@ test('the project saying sign-in works ticks sign-in, whatever the attempt row s
 
 test('without that answer, nothing changes: a pending attempt still waits on GitHub', () => {
   const c = gs.githubChecklist('pending', null, {});
-  assert.deepEqual(c, { approve: 'now', install: 'todo', sign_in: 'todo', device_flow: 'todo', connected: false, wired_elsewhere: false });
+  assert.deepEqual(c, { approve: 'now', install: 'todo', sign_in: 'todo', device_flow: 'todo', connected: false, wired_elsewhere: false, install_checking: false });
 });
 
 test('with our app recorded, the answer ticks sign-in and the install keeps its own fact', () => {

package/tests/hall_game_menu.mjs

@@ -93,6 +93,35 @@ test('Escape in a game place opens the game menu, not the options; Escape again
   await ctx.close();
 });
 
+// task 1005253 (owner, 2026-11-13): the menu is in the glass and is the one thing in focus. The
+// place behind it is frosted, the visor stays over it with only its arcs at full strength, and
+// it ends above the foot row.
+test('the game menu is the one thing in focus: the place frosted, the glass quiet but for its arcs', { skip }, async () => {
+  const { ctx, page, errors } = await open();
+  await escape(page);
+  assert.equal(await menuUp(page), true);
+  await page.waitForTimeout(300); // the glass's fade
+  const f = await page.evaluate(() => {
+    const cs = (s) => getComputedStyle(document.querySelector(s));
+    return {
+      blur: cs('.game-menu').backdropFilter,
+      visorOver: Number(cs('#visor').zIndex) > Number(cs('.game-menu').zIndex),
+      foot: Number(cs('.visor__foot').opacity), arc: Number(cs('.visor__frame--top').opacity),
+      clear: document.querySelector('.game-menu__box').getBoundingClientRect().bottom <= document.querySelector('.visor__foot').getBoundingClientRect().top,
+    };
+  });
+  assert.match(f.blur, /^blur\(\d/, 'the place behind is frosted');
+  assert.ok(f.visorOver, 'the glass stays over the menu\'s scrim');
+  assert.ok(f.foot < 0.5, 'the buttons and words on the glass step back');
+  assert.equal(f.arc, 1, 'the arcs hold the menu at full strength');
+  assert.ok(f.clear, 'the menu ends above the foot row');
+  await escape(page);
+  await page.waitForTimeout(300);
+  assert.equal(await page.evaluate(() => Number(getComputedStyle(document.querySelector('.visor__foot')).opacity)), 1, 'shut, the glass is whole again');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
 test('Return to game shuts the menu; Options opens the options window in its place', { skip }, async () => {
   const { ctx, page, errors } = await open();
   await escape(page);

package/tests/hall_visor_profile.mjs

@@ -65,7 +65,7 @@ const SCENE = `<script>
   window.__visorScene = { name: 'test', place: 'Test city', actions: [], keys: [] };
 </script>`;
 const PAGE = (withWindow) => `<!doctype html><html data-theme="dark" data-faces="helm"><head><meta charset="utf-8">
-<link rel="stylesheet" href="/builders/style.css"><link rel="stylesheet" href="/builders/visor.css"></head>
+<link rel="stylesheet" href="/tokens.css"><link rel="stylesheet" href="/builders/style.css"><link rel="stylesheet" href="/builders/visor.css"></head>
 <body>${SCENE}<script src="/builders/hall-dialog.js"></script>${withWindow ? '<script src="/builders/shell-game.js"></script>' : ''}<script src="/builders/visor.js"></script></body></html>`;
 
 async function open({ withWindow = true } = {}) {
@@ -73,6 +73,7 @@ async function open({ withWindow = true } = {}) {
   await ctx.route(ORIGIN + '/**', (route) => {
     const p = new URL(route.request().url()).pathname;
     if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(withWindow) });
+    if (p === '/tokens.css') return route.fulfill({ contentType: 'text/css', body: fs.readFileSync(path.join(ROOT, 'modules/ui-design/public/tokens.css')) }); // the design tokens the hall loads first
     if (p === '/profile') return route.fulfill({ contentType: 'text/html', body: '<!doctype html><title>profile</title><p id="pp">your profile</p><script src="/builders/shell-game.js"></script>' }); // the real page carries the game shell, which hands an Escape up
     const f = path.join(HALL, p.replace(/^\/builders\//, ''));
     if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
@@ -133,6 +134,44 @@ test('clicking you opens your whole profile in the window over the place; Escape
   await ctx.close();
 });
 
+// task 1005253 (owner, 2026-11-13): a window the glass opens opens IN the glass. It never covers
+// the visor: it sits under the top arc and above the foot row, the visor is drawn over its scrim,
+// and while it is up nothing on the glass takes a pointer and the glass's own pop-ups step aside.
+test('a window the visor opens sits inside the glass, and the visor stays drawn around it', { skip }, async () => {
+  for (const viewport of [{ width: 1280, height: 800 }, { width: 390, height: 844 }]) {
+    const { ctx, page, errors } = await open();
+    await page.setViewportSize(viewport);
+    await page.evaluate(() => window.OTBOptionsOverlay.open(''));
+    await page.waitForFunction(() => window.OTBOptionsOverlay.isOpen());
+    const g = await page.evaluate(() => {
+      const r = (s) => document.querySelector(s).getBoundingClientRect();
+      const box = r('.opt-window__box'); const foot = r('.visor__foot'); const main = r('.visor__main');
+      const z = (s) => Number(getComputedStyle(document.querySelector(s)).zIndex);
+      // what is on top at the centre of the accent button: the glass, not the window
+      const hit = document.elementsFromPoint(main.left + main.width / 2, main.top + main.height / 2);
+      return {
+        top: box.top, bottom: box.bottom, footTop: foot.top, place: getComputedStyle(document.documentElement).getPropertyValue('--visor-inset-top').trim(),
+        visorOver: z('#visor') > z('.opt-window'),
+        buttonUnder: hit.some((el) => el.closest && el.closest('.opt-window__box')),
+        mainPointer: getComputedStyle(document.querySelector('.visor__main')).pointerEvents,
+        sight: getComputedStyle(document.querySelector('.visor__sight')).visibility,
+      };
+    });
+    assert.ok(g.bottom <= g.footTop, `${viewport.width}px: the window ends above the foot row (${g.bottom} > ${g.footTop})`);
+    assert.equal(g.top, parseFloat(g.place), `${viewport.width}px: the window starts under the top arc`);
+    assert.ok(g.visorOver, 'the glass is drawn over the window\'s scrim');
+    assert.ok(!g.buttonUnder, 'the window covers none of the foot row');
+    assert.equal(g.mainPointer, 'none', 'the glass is a picture while the window is up');
+    assert.equal(g.sight, 'hidden', 'the sight leaves the window\'s middle');
+    await page.evaluate(() => window.OTBOptionsOverlay.close());
+    await page.waitForFunction(() => !window.OTBOptionsOverlay.isOpen());
+    assert.equal(await page.evaluate(() => getComputedStyle(document.querySelector('#visor')).zIndex), '4', 'shut, the glass goes back under the pop-ups');
+    assert.equal(await page.evaluate(() => getComputedStyle(document.querySelector('.visor__main')).pointerEvents), 'auto');
+    assert.deepEqual(errors, []);
+    await ctx.close();
+  }
+});
+
 test('with no window to draw, you are still a link to your profile', { skip }, async () => {
   const { ctx, page, errors } = await open({ withWindow: false });
   const r = await page.evaluate(() => {